)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a59d9d9f64a017a5620857477ef08e756d7481de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c7b413d_6f7b9866","updated":"2024-10-07 10:34:34.000000000","message":"Hi folks, any review is welcome. Thanks!","commit_id":"fcac078d919a67a1956446fd57356e7b0cbccb78"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"bed1788babb0419185ceed72be17efa6f8ad6c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"781c1556_c6fabbaf","updated":"2024-10-07 11:10:46.000000000","message":"I have somehow missed when people started spreading usage of `Computed` field. I think there is quite a misunderstanding on what that means. It was designed to be used in SDK for those fields that SDK itself calculates based on whichever logic (i.e. for adding location as a project scope or adding re-calculated routing information for server: public_v4, public_v6, etc). This information is not retrieved from the server and is NOT read from the response body. Since this change also does not introduce the test it is not verified.\n\nHowever, I think the bigger issue is that `subports` is not an attribute of the port resource. After digging deeper into the Neutron I see attribute `sub_ports` under trunk_details, but not under the port itself. The change in its current form had absolutely no effect on SDK. There are few options:\n- use Computed attribute as proposed here, but also override _collect_attrs method on the `port` resource to actually populate it. In this case adding of unittest is absolutely inavoidable\n- change OSC to add this \"field\" artificially bypassing SDK change. Sub_ports are more or less the only information underneath trunk_details so instead just serialize it properly. I have, however, another \"problem\" with the fact that you would need to serialize list of dicts which in current CLI form is hardly usable.","commit_id":"fcac078d919a67a1956446fd57356e7b0cbccb78"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dd4b1d263e15310604448f234a9f2a11dd1e06d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e607db5_22ceea6a","updated":"2024-08-26 09:38:12.000000000","message":"Thanks, good idea, makes life better for users","commit_id":"fcac078d919a67a1956446fd57356e7b0cbccb78"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a53743fbcd30766092ef0268dd509a409f40e616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2ba7223_66d942e5","in_reply_to":"781c1556_c6fabbaf","updated":"2024-10-18 08:46:14.000000000","message":"I was trying to avoid the bad formatting for this mixed dict with string and list of strings, just extracting the sub port list. But I can create an ad-hoc formatter for this specific blob.\n\nI\u0027ll push an new PS to store the \"trunk_details\" in the port, that is actually a field published by the Neutron API.\n\nThanks a lot for your feedback, specially for the information provided.","commit_id":"fcac078d919a67a1956446fd57356e7b0cbccb78"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3d9958b230a61fef6a543d0b790ded0cc188415","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1584d8c9_bde3f46b","updated":"2024-11-21 14:08:44.000000000","message":"ping fellow reviewers","commit_id":"886fb80fbfca65821dc78a7634a30fd8ffe74111"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd17c263c9e9c7d1d093bdefdb8891f9cb313204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f323c0fa_92c5ee48","updated":"2024-11-13 11:27:10.000000000","message":"ping fellow reviewers","commit_id":"886fb80fbfca65821dc78a7634a30fd8ffe74111"}]}