)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"6af5c048ec4206f60ff8f5defdf0e1b5e7cc6949","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc3629ff_fafd0bea","updated":"2024-08-31 06:41:55.000000000","message":"I think you have to add test codes for proxy.","commit_id":"2d677ae4fd754fdb42097dacd94469ecea05a76d"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"adc34510ab8d942f0d3e187e9af5f2652c3fc51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6903626b_dd2b43ab","in_reply_to":"dc3629ff_fafd0bea","updated":"2024-09-02 00:32:53.000000000","message":"Thanks for your feedback. I\u0027ve added test codes for the proxy","commit_id":"2d677ae4fd754fdb42097dacd94469ecea05a76d"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"7193fb2b02c21d1e537954df57b2712ebdeb6c67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a5e59c5_489858e2","updated":"2024-08-31 12:47:48.000000000","message":"look good to me:)","commit_id":"5354af3273c57dc05e3305e228e33d1a79405930"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"732da22128270d2dfd30720228978c09b2a7e3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35e36aec_0b0781d1","in_reply_to":"6a5e59c5_489858e2","updated":"2024-09-05 12:11:13.000000000","message":"\u003e Can you comment it like the other functions?\nfor example, \n\n```\n\"\"\"Get a zone\n\n        :param zone: The value can be the ID of a zone\n            or a :class:`~openstack.dns.v2.zone.Zone` instance.\n        :returns: Zone instance.\n        :rtype: :class:`~openstack.dns.v2.zone.Zone`\n        \"\"\"\n```\nfrom fet_zone()","commit_id":"5354af3273c57dc05e3305e228e33d1a79405930"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"adc34510ab8d942f0d3e187e9af5f2652c3fc51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3c9e5607_e38b83e0","updated":"2024-09-02 00:32:53.000000000","message":"Thanks for your feedback. I\u0027ve added test codes for the proxy","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e38e2bbb5d18d508a5e5998aa31ff245352d28d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59654991_75e020a6","updated":"2024-09-12 10:27:43.000000000","message":"You also need to add docs for this as well as a release note. I\u0027d really like to see a functional test in e.g. `openstack/tests/functional/dns/v2/test_tld.py` too.\n\nFor docs, I suggest looking at one of your peers\u0027 patches, like [this one](https://review.opendev.org/c/openstack/openstacksdk/+/927673).","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"37ef551a_525c0da7","in_reply_to":"59654991_75e020a6","updated":"2024-09-22 05:40:06.000000000","message":"Thank you for pointing out the good example. As you suggested, I’ve added the release note and included the functional test as well.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"41e4805a_6c3be289","updated":"2024-09-22 05:40:06.000000000","message":"RECHECK","commit_id":"d371d2113ff6b88380f71e74e94e5207b890b586"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a8321f8ab66e18e699c97dff4576ccabe39f2f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"20d52b6c_edfc4153","updated":"2025-08-19 17:09:40.000000000","message":"Failures are unrelated and will be fixed by https://review.opendev.org/c/openstack/ironic/+/957960","commit_id":"fcdbe2eaeeee43d7faa6e226d0b24a6a706bb466"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7e955e69af6b8da9cc3891a357670770d41f0c72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"336207af_388c3b1e","updated":"2025-09-09 21:04:35.000000000","message":"recheck","commit_id":"fcdbe2eaeeee43d7faa6e226d0b24a6a706bb466"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"766c9236db799e9ea7f75579e0bc1d7a330137ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1ab8ae27_e2d01694","updated":"2025-09-08 12:49:01.000000000","message":"recheck https://review.opendev.org/c/openstack/ironic/+/957960 is merged","commit_id":"fcdbe2eaeeee43d7faa6e226d0b24a6a706bb466"}],"openstack/dns/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                    resource_evaluation_fn\u003dresource_evaluation_fn,"},{"line_number":701,"context_line":"                )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def tlds(self, **query):"},{"line_number":704,"context_line":"        return self._list(_tld.Tld, **query)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def create_tld(self, **attrs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"25f45e75_4b9d5fe1","line":703,"updated":"2024-09-12 10:26:11.000000000","message":"You need to add docstrings here. Also, can you add a `\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d TLDs \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d` separator here?","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                    resource_evaluation_fn\u003dresource_evaluation_fn,"},{"line_number":701,"context_line":"                )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def tlds(self, **query):"},{"line_number":704,"context_line":"        return self._list(_tld.Tld, **query)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def create_tld(self, **attrs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"eab31aac_65762182","line":703,"in_reply_to":"25f45e75_4b9d5fe1","updated":"2024-09-22 05:40:06.000000000","message":"I\u0027ve added the required docstrings and a separator labeled \"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d TLDs \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\" as requested.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                    resource_evaluation_fn\u003dresource_evaluation_fn,"},{"line_number":701,"context_line":"                )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def tlds(self, **query):"},{"line_number":704,"context_line":"        return self._list(_tld.Tld, **query)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def create_tld(self, **attrs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c8e8b3e_f978aa48","line":703,"in_reply_to":"eab31aac_65762182","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17be0dd2_442e60ff","line":716,"updated":"2024-09-12 10:26:11.000000000","message":"What about `find_tld` and `get_tld`? On the resource you have indicated that the resource allows us to fetch an individual resource (`allow_fetch \u003d True`) and the api-ref [agrees](https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#show-tld).","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8c625b1abfbdeae49fbdb8982c17ea40b6a4474f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a2efb6a_f516e437","line":716,"in_reply_to":"17be0dd2_442e60ff","updated":"2024-09-12 10:38:34.000000000","message":"Later: I see someone has added two of these but not find. You might want to collaborate with this person.\n\nhttps://review.opendev.org/c/openstack/openstacksdk/+/927805","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"586a1fd6_e83aca37","line":716,"in_reply_to":"1a2efb6a_f516e437","updated":"2024-09-22 05:40:06.000000000","message":"I have added the `find_tld`, `get_tld`, and `update_tld` functions as requested. I also collaborated with the other contributor as you suggested. Thank you for pointing this out. Apologies for the slight delay due to the collaboration process.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a949ea51_1d33b8d0","line":716,"in_reply_to":"586a1fd6_e83aca37","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"}],"openstack/dns/v2/tld.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from openstack import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Tld(_base.Resource):"},{"line_number":20,"context_line":"    \"\"\"DNS TLD Resource\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resources_key \u003d \"tlds\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7e5046da_87a783ad","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":9},"updated":"2024-09-12 10:26:11.000000000","message":"Can you capitalise this?\n\n```suggestion\nclass TLD(_base.Resource):\n```","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from openstack import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Tld(_base.Resource):"},{"line_number":20,"context_line":"    \"\"\"DNS TLD Resource\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resources_key \u003d \"tlds\""}],"source_content_type":"text/x-python","patch_set":4,"id":"e41a8bb4_64854e52","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":9},"in_reply_to":"7e5046da_87a783ad","updated":"2024-09-22 05:40:06.000000000","message":"As per your suggestion, I’ve capitalized it and applied the same change wherever the class is used.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstack import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Tld(_base.Resource):"},{"line_number":20,"context_line":"    \"\"\"DNS TLD Resource\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resources_key \u003d \"tlds\""}],"source_content_type":"text/x-python","patch_set":4,"id":"25dba2d7_0068280c","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":9},"in_reply_to":"e41a8bb4_64854e52","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    #: *Type: str*"},{"line_number":43,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f67b1f58_139e7b0d","line":45,"updated":"2024-09-12 10:26:11.000000000","message":"Any reason not to include the `created_at` and `updated_at` fields? They\u0027re read-only but there is value in having them, no?","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    #: *Type: str*"},{"line_number":43,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f98e1c00_23975f86","line":45,"in_reply_to":"712e734a_0ce31492","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    #: *Type: str*"},{"line_number":43,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"712e734a_0ce31492","line":45,"in_reply_to":"f67b1f58_139e7b0d","updated":"2024-09-22 05:40:06.000000000","message":"I realize I was mistaken about that. Thank you for pointing it out. As you suggested, I\u0027ve added the `created_at`, `updated_at`, and `links` fields.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""},{"line_number":49,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \"tasks\", action)"},{"line_number":50,"context_line":"        response \u003d session.post(url, json\u003dbody)"},{"line_number":51,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":52,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"27c8cb42_967e39fd","line":52,"range":{"start_line":47,"start_character":0,"end_line":52,"end_character":23},"updated":"2024-09-12 10:26:11.000000000","message":"I don\u0027t think the `/tlds` API supports actions so this shouldn\u0027t be needed? I don\u0027t see any callers either.\n\nIn case you\u0027re curious, \"actions\" are how OpenStack does RPC-style calls for things that don\u0027t fit neatly into a RESTful API. For example, the compute service\u0027s server reboot API is [implemented as an action](https://docs.openstack.org/api-ref/compute/#reboot-server-reboot-action).","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""},{"line_number":49,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \"tasks\", action)"},{"line_number":50,"context_line":"        response \u003d session.post(url, json\u003dbody)"},{"line_number":51,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":52,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"e46fb1d2_29e3468c","line":52,"range":{"start_line":47,"start_character":0,"end_line":52,"end_character":23},"in_reply_to":"27c8cb42_967e39fd","updated":"2024-09-22 05:40:06.000000000","message":"It seems there was a misunderstanding regarding that part. As you pointed out, I’ve removed the unnecessary \"actions\". Thank you for bringing this to my attention, and I appreciate your kind explanation about OpenStack\u0027s \"actions\".","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _action(self, session, action, body):"},{"line_number":48,"context_line":"        \"\"\"Preform actions given the message body.\"\"\""},{"line_number":49,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \"tasks\", action)"},{"line_number":50,"context_line":"        response \u003d session.post(url, json\u003dbody)"},{"line_number":51,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":52,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"645a2780_46f0b71c","line":52,"range":{"start_line":47,"start_character":0,"end_line":52,"end_character":23},"in_reply_to":"e46fb1d2_29e3468c","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"}],"openstack/tests/unit/dns/v2/test_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ae916ff0d56035aced8ae24d53470538d232624","unresolved":true,"context_lines":[{"line_number":329,"context_line":"            tld.Tld,"},{"line_number":330,"context_line":"            True,"},{"line_number":331,"context_line":"            expected_kwargs\u003d{\u0027ignore_missing\u0027: True},"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def test_tlds(self):"},{"line_number":335,"context_line":"        self.verify_list(self.proxy.tlds, tld.Tld)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7b99b93b_6298ebd4","line":332,"updated":"2024-09-12 10:26:11.000000000","message":"You\u0027re missing `test_tld_get` and `test_tld_find` tests.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"cdab5bebfad93105fc5927e692c773fdc9e0474e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            tld.Tld,"},{"line_number":330,"context_line":"            True,"},{"line_number":331,"context_line":"            expected_kwargs\u003d{\u0027ignore_missing\u0027: True},"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def test_tlds(self):"},{"line_number":335,"context_line":"        self.verify_list(self.proxy.tlds, tld.Tld)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa908e73_92cd688b","line":332,"in_reply_to":"2a4ae051_70405dfa","updated":"2024-09-22 10:52:09.000000000","message":"Done","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"},{"author":{"_account_id":37204,"name":"Chanho Jung","display_name":"chanhojung","email":"cksgh1168@gmail.com","username":"chanhojung"},"change_message_id":"8d865482a4e41d270860b06f92b7aa34abac87e6","unresolved":true,"context_lines":[{"line_number":329,"context_line":"            tld.Tld,"},{"line_number":330,"context_line":"            True,"},{"line_number":331,"context_line":"            expected_kwargs\u003d{\u0027ignore_missing\u0027: True},"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def test_tlds(self):"},{"line_number":335,"context_line":"        self.verify_list(self.proxy.tlds, tld.Tld)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a4ae051_70405dfa","line":332,"in_reply_to":"7b99b93b_6298ebd4","updated":"2024-09-22 05:40:06.000000000","message":"Thank you for pointing that out. As you mentioned, I’ve added the `test_tld_get` and `test_tld_find` tests, along with the `test_tld_update` as well.","commit_id":"81043b39a3021431cedfd8a735e010f87045828c"}]}