)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ca815e952fdb6d621eafa4ebdaf5774c547e764e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yanks Yoon \u003cyangsoo.yoon@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-14 07:08:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pass stream value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2d2c7e5f0d7fbf0d4296a5e2a08d18fcdbe2b143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d83b1251_829e7f08","line":7,"updated":"2025-02-14 15:04:36.000000000","message":"Can you add a better description? You should have a short sentence followed by a paragraph below with the \u0027why\u0027 of the change.\n\nSorry, should have mentioned this in last comment.","commit_id":"03fe9fab585fbd4f694eb07ffad2fc0ae5e3944d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea96711a96ebdce2c861a17f00da5046cf6bb141","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yanks Yoon \u003cyangsoo.yoon@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-14 07:08:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pass stream value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2d2c7e5f0d7fbf0d4296a5e2a08d18fcdbe2b143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f33c310f_dc63031c","line":7,"in_reply_to":"d83b1251_829e7f08","updated":"2025-03-28 14:31:51.000000000","message":"Done","commit_id":"03fe9fab585fbd4f694eb07ffad2fc0ae5e3944d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aeaf5076efeb63e4f7f45b72f7711417fff52ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb6b8eda_df65bbc6","updated":"2024-09-24 14:53:59.000000000","message":"-1 because you need to run the linters (`tox -e pep8` or `pre-commit run -a`) to fix style","commit_id":"e23476f338190ee37fd19a9744fabdb3040cebb4"},{"author":{"_account_id":37407,"name":"mixermsk","display_name":"mixermsk","email":"mixermsk@yandex.ru","username":"mixermsk"},"change_message_id":"5a838d1f6644c6da8c9091d9c2e9d65ed7cd2c40","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81ab8e96_3e6e5c54","updated":"2024-10-23 19:26:11.000000000","message":"@stephenfin@redhat.com It looks like the `chunk_size` won\u0027t work without `stream\u003dTrue`, because otherwise `requests.Response.iter_content` will put all the data in memory as a single chunk, which in turn greatly increases the chances for an OOM.","commit_id":"e23476f338190ee37fd19a9744fabdb3040cebb4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3188f0db3c18fb57a81b16427e21e73bbcea355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eec17b3e_7de1114c","updated":"2024-09-24 14:53:35.000000000","message":"We can do this, but tbh if you want this level of control you are better off using the proxy layer altogether. Is there any reason you can\u0027t do that?","commit_id":"e23476f338190ee37fd19a9744fabdb3040cebb4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea96711a96ebdce2c861a17f00da5046cf6bb141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"80effae0_1f3f5b89","updated":"2025-03-28 14:31:51.000000000","message":"lgtm, think all comments were addressed","commit_id":"ec4720d8fcf1154a8e1e5a2b25d716e46331e0a8"}],"openstack/cloud/_image.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9943a7818671fbdcb129a9568f2314e1f659aa8c","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        image \u003d self.image.find_image(name_or_id, ignore_missing\u003dFalse)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        return self.image.download_image("},{"line_number":130,"context_line":"            image, output\u003doutput_file or output_path, chunk_size\u003dchunk_size, stream\u003dstream"},{"line_number":131,"context_line":"        )"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_image_exclude(self, name_or_id, exclude):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0ac9c2e_e4f4e3eb","line":130,"updated":"2025-02-13 15:04:01.000000000","message":"I think you need to change this as the ruff formatter did in the complaint to get pep8 to pass.","commit_id":"758f0dd3b4c848fcf40f05094c11580a945f9d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea96711a96ebdce2c861a17f00da5046cf6bb141","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        image \u003d self.image.find_image(name_or_id, ignore_missing\u003dFalse)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        return self.image.download_image("},{"line_number":130,"context_line":"            image, output\u003doutput_file or output_path, chunk_size\u003dchunk_size, stream\u003dstream"},{"line_number":131,"context_line":"        )"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_image_exclude(self, name_or_id, exclude):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2516413b_d7ab3db3","line":130,"in_reply_to":"b0ac9c2e_e4f4e3eb","updated":"2025-03-28 14:31:51.000000000","message":"Done","commit_id":"758f0dd3b4c848fcf40f05094c11580a945f9d33"}]}
