)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4704283cbb43d075ed64cb8351eed9ceb1e960ca","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ADD DNS Zone Blacklist CRUD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I add DNS Zone CRUD based on the DNS v2 API [1]."},{"line_number":10,"context_line":"[1] https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#blacklists"},{"line_number":11,"context_line":"I also added a list function that is not in the above document but in cli."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"story: 2011219"},{"line_number":14,"context_line":"tasks: 50955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba4315d7_d074dbc2","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":74},"updated":"2024-09-12 09:51:15.000000000","message":"This is a huge nit, but typically when you reference a link with e.g. `[1]` you put that at the end of the commit message, like this:\n\n```suggestion\nAdd support for the DNS Blacklist resource, based on the DNS\nv2 API [1]. We include a list operation which is not documented\nin the api-ref but is exposed by OSC.\n\n[1] https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#blacklists\n```\n\nYou should also try to wrap commit messages bodies at \u003c\u003d 72 characters.","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"278d16eb2ebd65f96c1f90b06945e5dddc8f3736","unresolved":true,"context_lines":[{"line_number":10,"context_line":"v2 API [1]. We include a list operation which is not documented"},{"line_number":11,"context_line":"in the api-ref but is exposed by OSC."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#blacklistsI also added a list function that is not in the above document but in cli."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"story: 2011219"},{"line_number":16,"context_line":"tasks: 50955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ad2afae5_5fc75db5","line":13,"range":{"start_line":13,"start_character":75,"end_line":13,"end_character":149},"updated":"2024-09-13 09:43:37.000000000","message":"Did you mean to keep this bit? I\u0027m guessing not.","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b9d6c50d7920bb9fc4cd5d55790ad6f347d8aacb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"722f018e_5fe3a257","updated":"2024-09-12 09:37:05.000000000","message":"One comment about potentially missing fields. Otherwise, what\u0027s here looks pretty good and just needs to be expanded somewhat. -1 is mainly for that.","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"6f00170fbbae89fe756d2f63493888e88c2a3acb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbe677b2_36b9daf5","updated":"2024-09-11 11:33:46.000000000","message":"you need to update docs about new feature on .rst","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b9d6c50d7920bb9fc4cd5d55790ad6f347d8aacb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"814ad14c_fbb405ba","in_reply_to":"dbe677b2_36b9daf5","updated":"2024-09-12 09:37:05.000000000","message":"Yeah, you need to create `doc/source/user/resources/dns/v2/blacklist.rst` and update `doc/source/user/proxies/dns.rst`. We also need a new release note (you can create those with `reno`) and ideally we should have a new functional test in e.g. `openstack/tests/functional/dns/v2/test_blacklist.py`. For the functional test, you just need to ensure you can add, list, show and delete these resources.","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"278d16eb2ebd65f96c1f90b06945e5dddc8f3736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d1f8ab2_f90ca0a2","updated":"2024-09-13 09:43:37.000000000","message":"Still waiting on a functional test and release note, and the unit test failures are happening because you haven\u0027t added fields to the resource itself, only the unit test. Please do ask questions if you\u0027re struggling with anything. I\u0027ll be happy to explain how to do things.","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"},{"author":{"_account_id":37216,"name":"이현규","display_name":"hyungyulee","email":"dlgusrb3456@naver.com","username":"hyungyulee"},"change_message_id":"cf8d7c50bd46f60302508a466e2cf5d708f5c866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"551e12c0_83ec22cf","in_reply_to":"1d1f8ab2_f90ca0a2","updated":"2024-09-25 14:47:57.000000000","message":"@stephenfin@redhat.com\nSorry for the late response, but I\u0027m not giving up.\n\nI\u0027m modifying the code as Stephenfin said. I added the response factor and modified the rst document.\n\nFunctional test is still in the works.","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"},{"author":{"_account_id":37216,"name":"이현규","display_name":"hyungyulee","email":"dlgusrb3456@naver.com","username":"hyungyulee"},"change_message_id":"2ab4128ceab7753ea1dc0f4850d0ba75c4f5fbf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a532e015_359e5690","in_reply_to":"551e12c0_83ec22cf","updated":"2024-09-25 14:51:14.000000000","message":"If you don\u0027t mind, can I deal with functional test in another patch set? I think it will be a little hard for me to deal with functional test in this patch set.\n\nIf you have to deal with it here, I can deal with it here! Feel free to answer.","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"}],"doc/source/user/proxies/dns.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"278d16eb2ebd65f96c1f90b06945e5dddc8f3736","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  :members: create_zone_share, delete_zone_share, get_zone_share,"},{"line_number":70,"context_line":"            find_zone_share, zone_shares"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Blacklist Operations"},{"line_number":73,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. autoclass:: openstack.dns.v2._proxy.Proxy"},{"line_number":76,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7eb119bd_559ab84c","line":73,"range":{"start_line":72,"start_character":20,"end_line":73,"end_character":21},"updated":"2024-09-13 09:43:37.000000000","message":"```suggestion\nBlacklist Operations\n^^^^^^^^^^^^^^^^^^^^\n```\n\nunderlines should be the same length as the title itself","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"}],"doc/source/user/resources/dns/v2/blacklist.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"278d16eb2ebd65f96c1f90b06945e5dddc8f3736","unresolved":true,"context_lines":[{"line_number":6,"context_line":"The Blacklist Class"},{"line_number":7,"context_line":"-------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``DNS`` class inherits from :class:`~openstack.resource.Resource`."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. autoclass:: openstack.dns.v2.blacklist.Blacklist"},{"line_number":12,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ee4d506f_e5635e91","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":9},"updated":"2024-09-13 09:43:37.000000000","message":"```suggestion\nThe ``Blacklist`` class inherits from :class:`~openstack.resource.Resource`.\n```\n\nNo?","commit_id":"329d57422507ec4ad0af3f043d5d60e6e6e3e14f"}],"openstack/dns/v2/blacklist.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b9d6c50d7920bb9fc4cd5d55790ad6f347d8aacb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    description \u003d resource.Body(\u0027description\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Pattern for this blacklist"},{"line_number":38,"context_line":"    pattern \u003d resource.Body(\u0027pattern\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2cac5be_6d57a3d6","line":38,"updated":"2024-09-12 09:37:05.000000000","message":"The docs say that there are also read-only `created_at` and `updated_at` fields. Do we want to provide these also?\n\nhttps://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#show-blacklist","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"278d16eb2ebd65f96c1f90b06945e5dddc8f3736","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    description \u003d resource.Body(\u0027description\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Pattern for this blacklist"},{"line_number":38,"context_line":"    pattern \u003d resource.Body(\u0027pattern\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"222710ff_cd287360","line":38,"in_reply_to":"d2cac5be_6d57a3d6","updated":"2024-09-13 09:43:37.000000000","message":"This still isn\u0027t addressed.","commit_id":"7dee73ce0ca83fee79372c3f95f6256ad9e2d19e"}]}