)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"f2468afe7d92105a8d38581058b0e61cc7b67c0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c7d3d20c_ce64c1f5","updated":"2024-09-08 07:17:40.000000000","message":"RECHECK","commit_id":"d2b2213807003b910ccae47f4353e8cbb00c5173"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1b015eb5_8a6008c6","updated":"2024-09-12 09:48:15.000000000","message":"I have some very minor nits, mostly to do with docs. If you can fix those I think we\u0027re good 👌","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"3be350fa57523778dfba22ce897b61d7675be3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3878a2ab_d6c5ac2c","updated":"2024-09-12 09:10:47.000000000","message":"lgtm","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"95802767_fbaaa531","updated":"2024-10-05 09:10:34.000000000","message":"RECHECK","commit_id":"e53b1b7606b178d7d66ba0d46357a1c061ef8bb4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db6382844978c8f553bd97fe4992b2907dfbf352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a6bc3b02_c90773d9","updated":"2024-12-17 17:49:14.000000000","message":"Sorry it took so long to get to this. Please do reach out on IRC if things are passing CI and they don\u0027t get attention within a week or two.","commit_id":"e53b1b7606b178d7d66ba0d46357a1c061ef8bb4"}],"doc/source/user/proxies/dns.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  :members: create_zone_share, delete_zone_share, get_zone_share,"},{"line_number":70,"context_line":"            find_zone_share, zone_shares"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Limit Operations"},{"line_number":73,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. autoclass:: openstack.dns.v2._proxy.Proxy"},{"line_number":76,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"833d4ba1_1061d594","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":21},"updated":"2024-09-12 09:48:15.000000000","message":"In rST, it\u0027s best practice to ensure underlines are the same length as the title itself.\n\n```suggestion\nLimit Operations\n^^^^^^^^^^^^^^^^\n```","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  :members: create_zone_share, delete_zone_share, get_zone_share,"},{"line_number":70,"context_line":"            find_zone_share, zone_shares"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Limit Operations"},{"line_number":73,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. autoclass:: openstack.dns.v2._proxy.Proxy"},{"line_number":76,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"d5f5fe95_3ade9cc9","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":21},"in_reply_to":"833d4ba1_1061d594","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"}],"doc/source/user/resources/dns/v2/limit.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":1,"context_line":"openstack.dns.v2.limit"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.dns.v2.limit"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"13ad4e9f_68c71fd0","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":26},"updated":"2024-09-12 09:48:15.000000000","message":"```suggestion\nopenstack.dns.v2.limit\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n```","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.dns.v2.limit"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.dns.v2.limit"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"809ba728_a534c62d","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":26},"in_reply_to":"13ad4e9f_68c71fd0","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.dns.v2.limit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The Limit Class"},{"line_number":7,"context_line":"-------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``DNS`` class inherits from :class:`~openstack.resource.Resource`."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1901d3d1_4787dc30","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":19},"updated":"2024-09-12 09:48:15.000000000","message":"```suggestion\nThe Limit Class\n---------------\n```","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.dns.v2.limit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The Limit Class"},{"line_number":7,"context_line":"-------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``DNS`` class inherits from :class:`~openstack.resource.Resource`."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"84486418_3ae7abe1","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"1901d3d1_4787dc30","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":6,"context_line":"The Limit Class"},{"line_number":7,"context_line":"-------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``DNS`` class inherits from :class:`~openstack.resource.Resource`."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. autoclass:: openstack.dns.v2.limit.Limit"},{"line_number":12,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"8bcb4115_bfef2415","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":9},"updated":"2024-09-12 09:48:15.000000000","message":"```suggestion\nThe ``Limit`` class inherits from :class:`~openstack.resource.Resource`.\n```\n\nRight?","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":6,"context_line":"The Limit Class"},{"line_number":7,"context_line":"-------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``DNS`` class inherits from :class:`~openstack.resource.Resource`."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. autoclass:: openstack.dns.v2.limit.Limit"},{"line_number":12,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"33456605_fdb5efb5","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":9},"in_reply_to":"8bcb4115_bfef2415","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"}],"openstack/dns/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from openstack.dns.v2 import floating_ip as _fip"},{"line_number":15,"context_line":"from openstack.dns.v2 import limit as _limit"},{"line_number":16,"context_line":"from openstack.dns.v2 import recordset as _rs"}],"source_content_type":"text/x-python","patch_set":13,"id":"d8474215_46864a7c","line":13,"updated":"2024-09-12 09:48:15.000000000","message":"you don\u0027t want/need this extra newline","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from openstack.dns.v2 import floating_ip as _fip"},{"line_number":15,"context_line":"from openstack.dns.v2 import limit as _limit"},{"line_number":16,"context_line":"from openstack.dns.v2 import recordset as _rs"}],"source_content_type":"text/x-python","patch_set":13,"id":"36072666_299825e3","line":13,"in_reply_to":"d8474215_46864a7c","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \"zone_import\": _zone_import.ZoneImport,"},{"line_number":32,"context_line":"        \"zone_share\": _zone_share.ZoneShare,"},{"line_number":33,"context_line":"        \"zone_transfer_request\": _zone_transfer.ZoneTransferRequest,"},{"line_number":34,"context_line":"        \"limits\": _limit.Limit,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Zones \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":13,"id":"98ea9a7e_5741aa41","line":34,"updated":"2024-09-12 09:48:15.000000000","message":"Can you place this alphabetically in the list?","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"zone_import\": _zone_import.ZoneImport,"},{"line_number":32,"context_line":"        \"zone_share\": _zone_share.ZoneShare,"},{"line_number":33,"context_line":"        \"zone_transfer_request\": _zone_transfer.ZoneTransferRequest,"},{"line_number":34,"context_line":"        \"limits\": _limit.Limit,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Zones \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":13,"id":"9d9868cb_2e88a82e","line":34,"in_reply_to":"98ea9a7e_5741aa41","updated":"2024-10-05 09:10:34.000000000","message":"Done","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"}],"openstack/dns/v2/limit.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"462e4ddff6e50afbf0b82efaf57f1c2b95749c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"de46e6bc_23265675","updated":"2024-09-12 09:48:15.000000000","message":"Similar APIs exist across multiple services. I note, however, that we seem to diverge on what these should be called. Some services call the object `Limits`, and others call them `Limit`.\n\n```\n❯ find openstack -name \u0027limit.py\u0027\nopenstack/identity/v3/limit.py\nopenstack/shared_file_system/v2/limit.py\n\n❯ find openstack -name \u0027limits.py\u0027\nopenstack/block_storage/v3/limits.py\nopenstack/block_storage/v2/limits.py\nopenstack/compute/v2/limits.py\n```\n\n`Limit` (i.e. what you have done here) probably makes more sense since it\u0027s consistent, but I just wanted to highlight the fact that I had observed this.","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"},{"author":{"_account_id":37209,"name":"Junwoo Park","display_name":"Junwoo Park","email":"junjunjun815@gmail.com","username":"JOOONU"},"change_message_id":"61a1db00c07c033d61624c12532dedcf10a4f0be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6eb0486b_c129db61","in_reply_to":"de46e6bc_23265675","updated":"2024-10-05 09:10:34.000000000","message":"Thank you for the insightful feedback! I noticed the same inconsistency while debugging. Specifically, I saw that the \u0027base_path\u0027 was set to \u0027/limits\u0027, and both \u0027limit\u0027 and \u0027limits\u0027 in the \u0027resource_key\u0027 returned similar results, which led to some deliberation on my end as well. I tried to stay as consistent as possible with the existing code to avoid unnecessary deviations.\n\nI appreciate you pointing this out, and if there are any further adjustments you\u0027d suggest, I\u0027d be happy to hear them!","commit_id":"2568b17573c3f1fb77f1b11317e74410f771bc75"}]}