)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"2888d1a46501c91e92073282ecf0cdfedbb5cd4a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Author:     kyeongnapark \u003cnayapark0814@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-09-05 21:39:28 +0900"},{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-08 00:01:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bca53ac0_4a7a795c","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"updated":"2024-09-09 13:45:20.000000000","message":"RECHECK","commit_id":"afd2b22a2bfac31ac7223d758ff823c3e77ef3de"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     kyeongnapark \u003cnayapark0814@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-09-05 21:39:28 +0900"},{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-08 00:01:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7fc0bcab_be371736","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"916ce953_34919b3b","updated":"2024-09-12 13:31:59.000000000","message":"Done","commit_id":"afd2b22a2bfac31ac7223d758ff823c3e77ef3de"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     kyeongnapark \u003cnayapark0814@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-09-05 21:39:28 +0900"},{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-08 00:01:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba182097_1b3ee3ac","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"bca53ac0_4a7a795c","updated":"2024-09-13 13:46:31.000000000","message":"Done","commit_id":"afd2b22a2bfac31ac7223d758ff823c3e77ef3de"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"362de24bd41883cd06cec5b89393b27d031ca47a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Author:     kyeongnapark \u003cnayapark0814@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-09-05 21:39:28 +0900"},{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-08 00:01:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"916ce953_34919b3b","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"bca53ac0_4a7a795c","updated":"2024-09-12 10:05:48.000000000","message":"You want to place these comments on the patchset itself, not the commit message (but I\u0027m guessing you have figured this out by now)","commit_id":"afd2b22a2bfac31ac7223d758ff823c3e77ef3de"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"362de24bd41883cd06cec5b89393b27d031ca47a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-09 23:51:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"},{"line_number":9,"context_line":"- list zone"},{"line_number":10,"context_line":"- delete zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ad9ba04c_d94ce142","line":7,"updated":"2024-09-12 10:05:48.000000000","message":"You need to have a blank line underneath the commit message summary, otherwise this renders as one giant line (as you can see in the web UI).\n\n```\nShort (ideally \u003c 50 char) summary\n\nDescription here, which should be wrapped at \u003c 72 characters.\n```","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9becd2718375e31e65a4157dd8214be717c61fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-09 23:51:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"},{"line_number":9,"context_line":"- list zone"},{"line_number":10,"context_line":"- delete zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2f21142a_d2519b78","line":7,"in_reply_to":"ad9ba04c_d94ce142","updated":"2024-09-12 13:32:11.000000000","message":"Done","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     박경나 \u003cnayapark0814@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-09 23:51:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":8,"context_line":"- create zone, recordset"},{"line_number":9,"context_line":"- list zone"},{"line_number":10,"context_line":"- delete zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9172c709_3c94c272","line":7,"in_reply_to":"ad9ba04c_d94ce142","updated":"2024-09-13 13:46:31.000000000","message":"I have to put it up here\nI\u0027ll be careful next time!","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"362de24bd41883cd06cec5b89393b27d031ca47a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"- delete zone, recordset"},{"line_number":11,"context_line":"- example connect"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1859170b06311330c954beec7919ade0e76b6c48"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":16,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f9d1f6cd_0cfb4f52","line":13,"updated":"2024-09-12 10:05:48.000000000","message":"I\u0027m guessing you squashed two commit together. This first commit ID is now ignored because Gerrit uses the last `Change-Id` trailer it finds. If you want to fix this, I suggest doing the following since this will practice your `git-rebase` skills.\n\n```\n# sync master to the latest version [*]\ngit checkout master\ngit pull\n\n# download the patch\ngit review -d 928129\n\n# start a rebase\ngit rebase -i master\n\n# on the rebase editor page, change `edit` to `reword` (or just `r`),\n# then save the file.\n\n# this will open this commit message which you should edit to remove\n# everything from this line up\n```\n\nAlternatively, you can avoid rebase and just \"amend\" the commit:\n\n```\n# download the patch\ngit review -d 928129\n\n# amend the commit\ngit commit --amend\n\n# this will open this commit message which you should edit to remove\n# everything from this line up\n```\n\n[*] If the `git-pull` fails, you probably have local patches on your `master` branch. You don\u0027t ever want to work on your `master` branch. When doing work, always check out a new branch. If you have local patches that you want to get rid of, you can reset your master branch to the remote copy like so:\n\n```\ngit reset --hard origin/master\n```","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9becd2718375e31e65a4157dd8214be717c61fa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- delete zone, recordset"},{"line_number":11,"context_line":"- example connect"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1859170b06311330c954beec7919ade0e76b6c48"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":16,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"47c10bf3_9a0b6615","line":13,"in_reply_to":"f9d1f6cd_0cfb4f52","updated":"2024-09-12 13:32:11.000000000","message":"Done","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- delete zone, recordset"},{"line_number":11,"context_line":"- example connect"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1859170b06311330c954beec7919ade0e76b6c48"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add create, delete, find, list and UPDATE example connect code"},{"line_number":16,"context_line":"- create zone, recordset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a77de1a_e5a5c874","line":13,"in_reply_to":"f9d1f6cd_0cfb4f52","updated":"2024-09-13 13:46:31.000000000","message":"Thank you for the detailed guide.","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"2888d1a46501c91e92073282ecf0cdfedbb5cd4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6123e2b7_42fadd48","updated":"2024-09-09 13:45:20.000000000","message":"RECHECK","commit_id":"63fd8aa34ef293e9464e7d262da15d202599608d"},{"author":{"_account_id":35933,"name":"Baek Seung Ju","display_name":"Becker","email":"halucinor0@gmail.com","username":"halucinor","status":"developer"},"change_message_id":"d73e273b0e5de4618d40a9d42ececdb3523c2152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ac5e87b9_d70bbec7","updated":"2024-09-09 14:17:03.000000000","message":"RECHECK","commit_id":"63fd8aa34ef293e9464e7d262da15d202599608d"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"cc858ca6797478b2f40f3166f96758493cd242c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2a6034f_762cebb9","updated":"2024-09-09 13:50:10.000000000","message":"RECHECK","commit_id":"63fd8aa34ef293e9464e7d262da15d202599608d"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"e0384c54d2d96e4795043ba1e2ca8582426a0c98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2d7ff217_6cb80c16","updated":"2024-09-12 09:13:40.000000000","message":"lgtm","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7c658080_2d11cce1","updated":"2024-09-12 13:31:59.000000000","message":"Thanks. This is better but still needs some work. Please mark comments as \"done\" when you\u0027ve seen/fixed them 🙏","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"596cc5ad_1deee98c","in_reply_to":"7c658080_2d11cce1","updated":"2024-09-13 13:46:31.000000000","message":"Done","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"310914fc185f4305474671d870bfcba630ffab75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1ee1e26e_36ee1cb8","updated":"2024-09-13 09:40:29.000000000","message":"Also, please mark comments as \"done\" when you\u0027ve addressed them 🙏","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"18392685_ddaf4bf6","in_reply_to":"1ee1e26e_36ee1cb8","updated":"2024-09-13 13:46:31.000000000","message":"done !","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"dc5de878_6e1c6c99","updated":"2024-09-13 13:46:31.000000000","message":"RECHECK","commit_id":"697e59eb59801ebef3e0f4188971744124493928"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"9d414de79784ce037a6120cfbc0695009ce04b09","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0d3def07_0d8898eb","updated":"2024-09-25 15:52:15.000000000","message":"RECHECK","commit_id":"fee0293c32138d24c273015ea0db838e24ab9e02"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"35e6a316b8fc45292a284124400fd10d45d88214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"54127112_a7fdc2d8","updated":"2024-09-25 13:30:22.000000000","message":"RECHECK","commit_id":"fee0293c32138d24c273015ea0db838e24ab9e02"},{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"84a09f1bc9366260bac7294aa9775bb7c6a5eab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7bc78d61_ed04c1f2","updated":"2024-09-25 15:45:44.000000000","message":"RECHECK","commit_id":"fee0293c32138d24c273015ea0db838e24ab9e02"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"f1ddf5a5e40eb72c5fbbda65d344b4a97e91bcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9207f6a8_965f9509","updated":"2024-09-25 14:56:45.000000000","message":"RECHECK","commit_id":"fee0293c32138d24c273015ea0db838e24ab9e02"}],"doc/source/user/guides/dns.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"362de24bd41883cd06cec5b89393b27d031ca47a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"**Recordsets** allow for the centralized management of"},{"line_number":29,"context_line":"various DNS records within a Zone,"},{"line_number":30,"context_line":"helping to define how a domain responds to different types of DNS queries."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. literalinclude:: ../examples/dns/list.py"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a5ad2c5d_8e6a6991","line":29,"updated":"2024-09-12 10:05:48.000000000","message":"nit: The wrapping on this is rather odd. Any reason you didn\u0027t just wrap at \u003c\u003d 79 characters? This is a nit so you don\u0027t need to fix this, but I\u0027m just curious.","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"**Recordsets** allow for the centralized management of"},{"line_number":29,"context_line":"various DNS records within a Zone,"},{"line_number":30,"context_line":"helping to define how a domain responds to different types of DNS queries."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. literalinclude:: ../examples/dns/list.py"}],"source_content_type":"text/x-rst","patch_set":7,"id":"296690a2_04b8b54c","line":29,"in_reply_to":"a5ad2c5d_8e6a6991","updated":"2024-09-12 13:31:59.000000000","message":"Done","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"**Recordsets** allow for the centralized management of"},{"line_number":29,"context_line":"various DNS records within a Zone,"},{"line_number":30,"context_line":"helping to define how a domain responds to different types of DNS queries."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. literalinclude:: ../examples/dns/list.py"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8189b569_06989e8e","line":29,"in_reply_to":"a5ad2c5d_8e6a6991","updated":"2024-09-13 13:46:31.000000000","message":"I didn\u0027t know I did this weird spacing because I was splitting through the screen ㅜ_ㅜ I fixed it!","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"}],"examples/connect.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"362de24bd41883cd06cec5b89393b27d031ca47a","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"EXAMPLE_IMAGE_NAME \u003d \u0027openstacksdk-example-public-image\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"ZONE \u003d {"},{"line_number":69,"context_line":"    \"name\": \"test.com.\","},{"line_number":70,"context_line":"    \"email\": \"test@example.com\","},{"line_number":71,"context_line":"    \"ttl\": 3600,"},{"line_number":72,"context_line":"    \"description\": \"test description\","},{"line_number":73,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RECORDSET \u003d {"},{"line_number":77,"context_line":"    \"name\": \"test.com.\","},{"line_number":78,"context_line":"    \"type\": \"A\","},{"line_number":79,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":80,"context_line":"    \"ttl\": 3600,"},{"line_number":81,"context_line":"    \"description\": \"test description\","},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def create_connection_from_config():"},{"line_number":86,"context_line":"    return openstack.connect(cloud\u003dTEST_CLOUD)"}],"source_content_type":"text/x-python","patch_set":7,"id":"075b06e7_ca220437","line":83,"range":{"start_line":68,"start_character":0,"end_line":83,"end_character":1},"updated":"2024-09-12 10:05:48.000000000","message":"Don\u0027t define these here. Instead, define them in the file where they will be used.","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"EXAMPLE_IMAGE_NAME \u003d \u0027openstacksdk-example-public-image\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"ZONE \u003d {"},{"line_number":69,"context_line":"    \"name\": \"test.com.\","},{"line_number":70,"context_line":"    \"email\": \"test@example.com\","},{"line_number":71,"context_line":"    \"ttl\": 3600,"},{"line_number":72,"context_line":"    \"description\": \"test description\","},{"line_number":73,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RECORDSET \u003d {"},{"line_number":77,"context_line":"    \"name\": \"test.com.\","},{"line_number":78,"context_line":"    \"type\": \"A\","},{"line_number":79,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":80,"context_line":"    \"ttl\": 3600,"},{"line_number":81,"context_line":"    \"description\": \"test description\","},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def create_connection_from_config():"},{"line_number":86,"context_line":"    return openstack.connect(cloud\u003dTEST_CLOUD)"}],"source_content_type":"text/x-python","patch_set":7,"id":"82dac7db_d388fb55","line":83,"range":{"start_line":68,"start_character":0,"end_line":83,"end_character":1},"in_reply_to":"075b06e7_ca220437","updated":"2024-09-12 13:31:59.000000000","message":"Done","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"EXAMPLE_IMAGE_NAME \u003d \u0027openstacksdk-example-public-image\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"ZONE \u003d {"},{"line_number":69,"context_line":"    \"name\": \"test.com.\","},{"line_number":70,"context_line":"    \"email\": \"test@example.com\","},{"line_number":71,"context_line":"    \"ttl\": 3600,"},{"line_number":72,"context_line":"    \"description\": \"test description\","},{"line_number":73,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RECORDSET \u003d {"},{"line_number":77,"context_line":"    \"name\": \"test.com.\","},{"line_number":78,"context_line":"    \"type\": \"A\","},{"line_number":79,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":80,"context_line":"    \"ttl\": 3600,"},{"line_number":81,"context_line":"    \"description\": \"test description\","},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def create_connection_from_config():"},{"line_number":86,"context_line":"    return openstack.connect(cloud\u003dTEST_CLOUD)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c5de218c_195e65c0","line":83,"range":{"start_line":68,"start_character":0,"end_line":83,"end_character":1},"in_reply_to":"075b06e7_ca220437","updated":"2024-09-13 13:46:31.000000000","message":"Oh! Ok I add ZONE, RECORDSET and moved them to example code","commit_id":"09f2a98757c8eda692e6325b592998801d6c36f3"}],"examples/dns/delete.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ddef delete_zone(conn):"},{"line_number":37,"context_line":"    print(\"Delete Zone:\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"}],"source_content_type":"text/x-python","patch_set":8,"id":"c8b7b23a_63d7eecd","line":36,"updated":"2024-09-12 13:31:59.000000000","message":"whoops","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ddef delete_zone(conn):"},{"line_number":37,"context_line":"    print(\"Delete Zone:\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a45fe88_d39bdcea","line":36,"in_reply_to":"c8b7b23a_63d7eecd","updated":"2024-09-13 13:46:31.000000000","message":"Done","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"ddef delete_zone(conn):"},{"line_number":37,"context_line":"    print(\"Delete Zone:\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    conn.dns.delete_zone(zone_id)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"73dff9c8_21e9fcbe","line":39,"updated":"2024-09-12 13:31:59.000000000","message":"You\u0027re creating a whole object here but only using a single field. Rather than doing this, how about you take a `name_or_id` parameter that users can pass?","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":true,"context_lines":[{"line_number":36,"context_line":"ddef delete_zone(conn):"},{"line_number":37,"context_line":"    print(\"Delete Zone:\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    conn.dns.delete_zone(zone_id)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"910711f3_28473b8b","line":39,"in_reply_to":"73dff9c8_21e9fcbe","updated":"2024-09-13 13:46:31.000000000","message":"Is it okay to modify the code assuming that user enters the factor value without declaring Zone and Recordset separately as before?","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"35e6a316b8fc45292a284124400fd10d45d88214","unresolved":false,"context_lines":[{"line_number":36,"context_line":"ddef delete_zone(conn):"},{"line_number":37,"context_line":"    print(\"Delete Zone:\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    conn.dns.delete_zone(zone_id)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f18409e3_351bdaca","line":39,"in_reply_to":"910711f3_28473b8b","updated":"2024-09-25 13:30:22.000000000","message":"Done","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a59d51642bda88f952c4b8e4635f61cfd38e05a","unresolved":true,"context_lines":[{"line_number":44,"context_line":"def delete_recordset(conn):"},{"line_number":45,"context_line":"    print(\"Deleting Recordset!\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    try:"},{"line_number":50,"context_line":"        conn.dns.delete_recordset(Recordset, zone_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"71e34fc4_9ab2d223","line":47,"updated":"2024-09-12 13:31:59.000000000","message":"ditto (and if other fields)","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"35e6a316b8fc45292a284124400fd10d45d88214","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def delete_recordset(conn):"},{"line_number":45,"context_line":"    print(\"Deleting Recordset!\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    zone_id \u003d conn.dns.find_zone(Zone[\u0027name\u0027]).id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    try:"},{"line_number":50,"context_line":"        conn.dns.delete_recordset(Recordset, zone_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a331992_be54c099","line":47,"in_reply_to":"71e34fc4_9ab2d223","updated":"2024-09-25 13:30:22.000000000","message":"Done","commit_id":"2085073316bdd65382504acc2fb855b4b127bbe7"}],"examples/dns/find.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b137bed2dc3d0af8b1fde17eb4f35c0e2c1cddac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"03e62922_f50378ef","updated":"2024-09-13 09:40:02.000000000","message":"My comments on the previous file also apply here. We don\u0027t need the entire `Recordset` and `Zone` objects. Just allow the user to pass `name_or_id` arguments instead.\n\nThe alternative, if you would prefer to keep things this way, is to do what we\u0027ve done in some services and combine all these examples into two files called e.g. `examples/dns/recordset.py` and `examples/dns/zone.py`. Look at `examples/clustering/profile.py` for an example.","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a0003cf3_91c89739","in_reply_to":"03e62922_f50378ef","updated":"2024-09-13 13:46:31.000000000","message":"Done","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"35e6a316b8fc45292a284124400fd10d45d88214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b3275e2e_87f087aa","in_reply_to":"a0003cf3_91c89739","updated":"2024-09-25 13:30:22.000000000","message":"Done","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"}],"examples/dns/list.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b137bed2dc3d0af8b1fde17eb4f35c0e2c1cddac","unresolved":true,"context_lines":[{"line_number":17,"context_line":"https://docs.openstack.org/openstacksdk/latest/user/guides/dns.html"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Recordset \u003d {"},{"line_number":21,"context_line":"    \"name\": \"test2.com.\","},{"line_number":22,"context_line":"    \"type\": \"A\","},{"line_number":23,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":24,"context_line":"    \"ttl\": 3600,"},{"line_number":25,"context_line":"    \"description\": \"test description\","},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Zone \u003d {"},{"line_number":29,"context_line":"    \"name\": \"test2.com.\","},{"line_number":30,"context_line":"    \"email\": \"test2@example.com\","},{"line_number":31,"context_line":"    \"ttl\": 3600,"},{"line_number":32,"context_line":"    \"description\": \"test description\","},{"line_number":33,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def list_zones(conn):"}],"source_content_type":"text/x-python","patch_set":10,"id":"b5eeada2_e72ae509","line":34,"range":{"start_line":20,"start_character":0,"end_line":34,"end_character":1},"updated":"2024-09-13 09:40:02.000000000","message":"Ditto. Also, `Recordset` is unused here.","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"35e6a316b8fc45292a284124400fd10d45d88214","unresolved":false,"context_lines":[{"line_number":17,"context_line":"https://docs.openstack.org/openstacksdk/latest/user/guides/dns.html"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Recordset \u003d {"},{"line_number":21,"context_line":"    \"name\": \"test2.com.\","},{"line_number":22,"context_line":"    \"type\": \"A\","},{"line_number":23,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":24,"context_line":"    \"ttl\": 3600,"},{"line_number":25,"context_line":"    \"description\": \"test description\","},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Zone \u003d {"},{"line_number":29,"context_line":"    \"name\": \"test2.com.\","},{"line_number":30,"context_line":"    \"email\": \"test2@example.com\","},{"line_number":31,"context_line":"    \"ttl\": 3600,"},{"line_number":32,"context_line":"    \"description\": \"test description\","},{"line_number":33,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def list_zones(conn):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ec5738aa_a1deb1d9","line":34,"range":{"start_line":20,"start_character":0,"end_line":34,"end_character":1},"in_reply_to":"53dac58c_7abb80aa","updated":"2024-09-25 13:30:22.000000000","message":"Done","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"},{"author":{"_account_id":37219,"name":"KyeongNa Park","display_name":"kyeongnapark","email":"nayapark0814@gmail.com","username":"kyeongnapark"},"change_message_id":"af6808e828a72e0a89d4c81345fe7aa7f7b39894","unresolved":true,"context_lines":[{"line_number":17,"context_line":"https://docs.openstack.org/openstacksdk/latest/user/guides/dns.html"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Recordset \u003d {"},{"line_number":21,"context_line":"    \"name\": \"test2.com.\","},{"line_number":22,"context_line":"    \"type\": \"A\","},{"line_number":23,"context_line":"    \"records\": [\"192.168.1.1\"],"},{"line_number":24,"context_line":"    \"ttl\": 3600,"},{"line_number":25,"context_line":"    \"description\": \"test description\","},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Zone \u003d {"},{"line_number":29,"context_line":"    \"name\": \"test2.com.\","},{"line_number":30,"context_line":"    \"email\": \"test2@example.com\","},{"line_number":31,"context_line":"    \"ttl\": 3600,"},{"line_number":32,"context_line":"    \"description\": \"test description\","},{"line_number":33,"context_line":"    \"type\": \"PRIMARY\",  # Default"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def list_zones(conn):"}],"source_content_type":"text/x-python","patch_set":10,"id":"53dac58c_7abb80aa","line":34,"range":{"start_line":20,"start_character":0,"end_line":34,"end_character":1},"in_reply_to":"b5eeada2_e72ae509","updated":"2024-09-13 13:46:31.000000000","message":"Done","commit_id":"f64eb97365067280e92e24e577c7115e9b315ff7"}]}