)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c95296fe565d41da272a51e4baa1a3f61317adfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ddb3106_206b1ee7","updated":"2024-10-09 10:35:48.000000000","message":"I think you forgot something 😅","commit_id":"9013b432de4a1cf526ef330c5c14da0c437ea815"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"f474386e0a97bbcf3a20a29673eb7c5a1d35bf39","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15be1131_03efcf6a","in_reply_to":"0ddb3106_206b1ee7","updated":"2024-10-09 12:09:36.000000000","message":"Arf I forget about the WIP. This first shoot was to ensure openstacksdk-functional-devstack-manila job fails.","commit_id":"9013b432de4a1cf526ef330c5c14da0c437ea815"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"17a0dadece1d9647205853de2a5dced2b1de0071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8303acd2_995d4c9c","in_reply_to":"15be1131_03efcf6a","updated":"2024-10-09 14:59:41.000000000","message":"Done","commit_id":"9013b432de4a1cf526ef330c5c14da0c437ea815"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"467e93bb0c3fbb0698569c1948b6f549d1da7a4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b50a62d0_8d7775c4","updated":"2024-10-09 13:28:22.000000000","message":"Thanks for fixing this issue, Rene! I have one suggestion inline, please take a look :)","commit_id":"336e58afe94846760c1083ecf97dc3ba56d6eba0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a713bbf477bd4d0ff7da813e7a04659758a4535","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53d1875c_2c919a4e","updated":"2024-10-09 16:53:23.000000000","message":"Late +2, lgtm. Thank you, René!","commit_id":"0b592bceb927a7f43264ce642fae7e38d931674f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d939b4fc860085f60446d8a093fa450c311272d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbdd611d_f5ae6d57","updated":"2024-10-09 15:56:27.000000000","message":"Thanks @rene.ribaud@gmail.com","commit_id":"0b592bceb927a7f43264ce642fae7e38d931674f"}],"openstack/tests/functional/shared_file_system/test_share_access_rule.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"467e93bb0c3fbb0698569c1948b6f549d1da7a4e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df794b4f_fe74cf1f","line":112,"range":{"start_line":90,"start_character":8,"end_line":112,"end_character":0},"updated":"2024-10-09 13:28:22.000000000","message":"I believe waiting for the resource deletion as you are doing is the correct way to fix it, but I would suggest reusing some waiters we already have implemented so we can remain consistent with other tests for manila. This is an example of how we do it [1]. You can specify the access rule and the proxy should take care of the rest. With that, you will also be able to drop the import you are currently adding :)\n\n[1] https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/shared_file_system/test_share_network_subnet.py#L50\n\nSo here is a suggestion of how it would look like:\n\n```suggestion\n\n        self.user_cloud.share.delete_access_rule(\n            access_rule[\u0027id\u0027], self.SHARE_ID, unrestrict\u003dTrue\n        )\n\n        self.user_cloud.shared_file_system.wait_for_delete(access_rule)\n\n```","commit_id":"336e58afe94846760c1083ecf97dc3ba56d6eba0"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1fac4edc44dd6e826fd726310184bb3b00219b39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d0c6754_ed8fca50","line":112,"range":{"start_line":90,"start_character":8,"end_line":112,"end_character":0},"in_reply_to":"df794b4f_fe74cf1f","updated":"2024-10-09 13:37:54.000000000","message":"Sure it is cleaner, I did not noticed the waiter.\nThat should be corrected now.","commit_id":"336e58afe94846760c1083ecf97dc3ba56d6eba0"}]}