)]}'
{"id":"openstack%2Fopenstacksdk~936947","triplet_id":"openstack%2Fopenstacksdk~master~I3dd56414b32207a16c6c83971f0494ccb86e07d4","project":"openstack/openstacksdk","branch":"master","topic":"bug/2089821","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2024-12-09 13:24:15.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I3dd56414b32207a16c6c83971f0494ccb86e07d4","subject":"compute: Use security group name or ID","status":"MERGED","created":"2024-12-03 15:22:17.000000000","updated":"2024-12-09 19:36:21.000000000","submitted":"2024-12-09 19:35:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"936947-bug/2089821","meta_rev_id":"c3b7dacfaded4670d5bc0c02413aa9e199693e78","_number":936947,"virtual_id_number":936947,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-12-09 19:35:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2024-12-03 18:54:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-12-09 13:24:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-03 16:39:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-03 18:54:16.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"12dfa53c5192ac949f58349c976ace76e86ea9e4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-12-03 15:22:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c7242b6e092e0bb7f7af09bd2d13c06477174f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-03 16:39:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d237febd038a4a648283b6c60eae8c27\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/7ed21089f0144a4190038b0429db76b3 : SUCCESS in 30m 16s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/9092555787b147e4be8bb5c30c392da2 : SUCCESS in 23m 04s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/626c017dfa554dfd8e1e9f4d009fd80d : SUCCESS in 2m 41s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ea2e2bfb686e4051a45517c24346b05b : SUCCESS in 3m 30s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/d24076bb72664326baed73f6ccdb8ee3 : SUCCESS in 3m 54s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/de3712388fbb4f7f9f6d673a686262ab : SUCCESS in 53m 22s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/712d916185a844bebdf8b6ceccd9936a : SUCCESS in 3m 41s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/c2467bcbf7174f53b5479f02215457d0 : SUCCESS in 4m 25s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/de91f5581da149b8875ca4e150313147 : SUCCESS in 4m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d53662182501419e931217b50cf5b375 : SUCCESS in 8m 19s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/53d1b2b8ca1041a3b9fdd0b6253845d7 : SUCCESS in 47m 54s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/aa0170416da846d2bb19b1ab482ae16f : SUCCESS in 12m 09s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/cae07b0c8d8e4646a659c0dee79b944a : SUCCESS in 30m 29s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/bb0f5b02c4fe4ed888cc819971e221c8 : SUCCESS in 52m 47s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/380801d9eb574fdfae5d199ef9bd5cb4 : SUCCESS in 1h 15m 37s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/bca68ec040004801998332c9ffea2134 : SUCCESS in 1h 03m 16s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/6d29d8214e9c4d5bae873f5dbd325214 : FAILURE in 57m 14s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/c2bf8c1374304cbca9d7654b593615d6 : SUCCESS in 21m 40s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/6d4b2f930e4a4341af39089e510fda2d : POST_FAILURE in 18m 47s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/0c01870f399149cfaa0e9a6a918ce546 : POST_FAILURE in 45m 20s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f04704b8cc164a8b848250f6ebe8180e : SUCCESS in 1h 02m 34s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/02f8bace4c4442c89dd75b31529edfdf : FAILURE in 17m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ffefd9f03ab31f3e56afb8425dd50f266975637f","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-12-03 18:54:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c514a1e6238cff05b34a8efb4d1e5437b9a38ddf","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-12-09 13:24:15.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4e7e67a2055cce47e88cf985d9b0cf3d98fc94e1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-09 13:25:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2a18ea22ef47ce6eac98d92447a81e6405472de6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-09 19:35:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ef90db5978354539ad62c7ce4cf38775\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6e324ea7a447458e89b0acd0a25c2c66 : SUCCESS in 6m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c8b5889d9d57453b8f09557d466ed4c8 : SUCCESS in 3m 50s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/e206325c11ec4e559aeed4a4a70291de : SUCCESS in 3m 04s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c2af4f723d244ed8833c26bbfe774ea5 : SUCCESS in 1h 06m 06s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/ed4792bccd544498a373ad3a03adfc9c : SUCCESS in 4m 11s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/22355c8f011e478b9af8fc30066b8519 : SUCCESS in 5m 13s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/65a44e168ba0499f92530964b500ae13 : SUCCESS in 4m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1742fffdd1514bb5a525e9aaa37c6d61 : SUCCESS in 9m 59s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/0cbbe2d015d24bb98e7e96f5cdb3bcc6 : SUCCESS in 3m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ff84e7ad07e04db7807c5167e490cfdd : SUCCESS in 1h 00m 34s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/129d3ad9357947a0857a2c448ebee01e : SUCCESS in 1h 16m 29s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/079769e37e744095af6f9bbed06f7b29 : SUCCESS in 1h 27m 42s","accounts_in_message":[],"_revision_number":1},{"id":"cc6647b3ab36e53add88eba4968771b629be22c1","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-09 19:35:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"c3b7dacfaded4670d5bc0c02413aa9e199693e78","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-09 19:36:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/998cce4e721444388d513caa0cae906e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee616f8967b44cd784795e3dc2d31a73 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ad6beea71dbeeefbbb84a9ff7fe2433120b459b0","revisions":{"ad6beea71dbeeefbbb84a9ff7fe2433120b459b0":{"kind":"REWORK","_number":1,"created":"2024-12-03 15:22:17.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/47/936947/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/47/936947/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/47/936947/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/47/936947/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/47/936947/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/47/936947/1"}}},"commit":{"parents":[{"commit":"abfd5b86307b7762c266631645fd271bcc5bb909","subject":"Merge \"Replace netifaces library\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/abfd5b86307b7762c266631645fd271bcc5bb909"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-12-03 15:10:11.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-12-03 15:22:02.000000000","tz":0},"subject":"compute: Use security group name or ID","message":"compute: Use security group name or ID\n\nDespite what Nova\u0027s api-ref currently says [1], the \u0027addSecurityGroup\u0027\naction only requires a security group name if using nova-network: it\nwill happily accept either a name or ID if using neutron.\n\nWe are using \u0027Proxy._get_resource\u0027 to allow users to pass either an ID\nor an \u0027openstack.network.v2.security_group.SecurityGroup\u0027 object\n(there\u0027s no implementation of Nova\u0027s deprecated SecurityGroup resource).\nIf given an ID, this help method will only populate the \u0027id\u0027 field of\nthe created resource. Thus, we need to use this if provided.\n\n[1] https://docs.openstack.org/api-ref/compute/#add-security-group-to-a-server-addsecuritygroup-action\n\nChange-Id: I3dd56414b32207a16c6c83971f0494ccb86e07d4\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-bug: #2089821\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ad6beea71dbeeefbbb84a9ff7fe2433120b459b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ad6beea71dbeeefbbb84a9ff7fe2433120b459b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}