)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a94085dff1ebff5e221d950331d9fccec9f54419","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6232962d_ca3390dd","updated":"2025-03-03 12:18:17.000000000","message":"Seems reasonable. I have two nits inline. I\u0027d also like to see a simple unit test to prevent regressions, please. You can place the unit tests into `openstack/tests/unit/config/test_loader.py`.","commit_id":"94e6f81ddf3ee563d00eeb334d75c47c1fd12fc1"}],"openstack/config/loader.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a94085dff1ebff5e221d950331d9fccec9f54419","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from keystoneauth1 import adapter"},{"line_number":28,"context_line":"from keystoneauth1 import loading"},{"line_number":29,"context_line":"from keystoneauth1.exceptions import AuthPluginException"},{"line_number":30,"context_line":"import platformdirs"},{"line_number":31,"context_line":"import yaml"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"138d5ec4_d00b741e","line":29,"in_reply_to":"e0a29de4_d3da3639","updated":"2025-03-03 12:18:17.000000000","message":"Can you fix this. Also, we import modules, not objects, so this should be:\n\n```\nfrom keystoneauth1 import exceptions as ksa_exceptions\n```","commit_id":"94e6f81ddf3ee563d00eeb334d75c47c1fd12fc1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a94085dff1ebff5e221d950331d9fccec9f54419","unresolved":true,"context_lines":[{"line_number":981,"context_line":"                        clouds.append("},{"line_number":982,"context_line":"                            self.get_one(cloud, region_name\u003dregion[\u0027name\u0027])"},{"line_number":983,"context_line":"                        )"},{"line_number":984,"context_line":"                    except AuthPluginException as err:"},{"line_number":985,"context_line":"                        pass"},{"line_number":986,"context_line":"        return clouds"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"be792a63_23fd0e31","line":984,"updated":"2025-03-03 12:18:17.000000000","message":"Can you log a warning here, so people know that the cloud `cloud` has been skipped due to invalid/incomplete configuration?","commit_id":"94e6f81ddf3ee563d00eeb334d75c47c1fd12fc1"}]}