)]}'
{"id":"openstack%2Fopenstacksdk~941272","triplet_id":"openstack%2Fopenstacksdk~master~Icb6b26127d8e200b650687578f450490e71d24c3","project":"openstack/openstacksdk","branch":"master","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2025-02-19 18:42:57.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"Icb6b26127d8e200b650687578f450490e71d24c3","subject":"fields: Tweak _convert_type","status":"MERGED","created":"2025-02-11 17:27:21.000000000","updated":"2025-02-19 22:33:17.000000000","submitted":"2025-02-19 22:30:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"941272-typing","meta_rev_id":"aecc77683f03ee2cbbc465e610b2a831e903c87e","_number":941272,"virtual_id_number":941272,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-19 22:30:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-02-19 18:42:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-02-19 18:42:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-11 19:39:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"179fb6c91dc4d379fa06841b83306cda07ba8856","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-02-11 17:27:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d0d7634a38bb5d6b129913f06b37c8a28ddd23a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-11 19:39:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6cbdbf11b38942408b110af4c9680cc8\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/b6dfa52979d141c18c36b70c1f4fe3c9 : SUCCESS in 58m 42s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/30bd07e6f5bc489dac69797ddb2e475c : SUCCESS in 35m 07s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c75374e7fadf4de192b7bb6acc963d78 : SUCCESS in 4m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e458525ea9874f29b71443424b06473b : SUCCESS in 5m 29s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b64e2c188542403bb5120f6d13f79429 : SUCCESS in 4m 35s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/aaa3aae5549d40c18c7f585eda6091fd : SUCCESS in 1h 15m 03s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/4dd863d94e984c81ab6b5ba7eb00fe85 : SUCCESS in 3m 41s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/a3afb1f873e74ac28a9ef60c8a8a2a87 : SUCCESS in 4m 55s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/995d6a2ed78448eca9d8f01f74182725 : SUCCESS in 7m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f30bdac7de1498f9c05d52674fbd049 : SUCCESS in 11m 22s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/229cae4db65248ce903f03bfb7146f2d : SUCCESS in 9m 56s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/2c0462a86c8243c09ca410f00b30ed43 : FAILURE in 6m 20s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/b50531d8ff854ad1aef22e960e73536c : SKIPPED Skipped due to failed job nodepool-build-image-siblings (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/658483e65dc844c4aadea319f657d0c4 : SUCCESS in 58m 01s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/f86c9a9465f04defae3bf2cd08afa914 : SUCCESS in 1h 24m 23s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/daa69dfb9b674da3a2e94e8bd523861c : SUCCESS in 1h 39m 32s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/270671313bc146c680d0501076ecc01a : FAILURE in 1h 07m 49s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/6be71f8d2e6b4ac785d2843b9abb7aa1 : FAILURE in 38m 56s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/ac4fde05f2c44b82b4ff7bbde57fe20c : SUCCESS in 34m 29s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/1c796064d8274be6aaecaef447a89fc3 : FAILURE in 44m 56s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/da050e2aacbb4e04876985789f765746 : SUCCESS in 1h 14m 01s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/ef89ee08cd264afbac2f1988db69006f : FAILURE in 57m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a7730ce52ba2d23fc0abd37d36f4e3d279b60914","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-02-19 12:50:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"0374622458fd8cf14225e88a855895e0de56b355","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 14:38:23.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/2893cb365dd84ea9a15e7042ad882baf\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/5f228015f00c4c5aae7c84a641312d1a : SUCCESS in 47m 20s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/dc76d416cfb64fcbbcd845646d912b09 : SUCCESS in 35m 47s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9e2e0ac2ef794a8fa7e4d8c1f8634cf7 : SUCCESS in 3m 16s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/63a7208eb41144da90b23a589ef12044 : SUCCESS in 4m 16s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/179e37a486da4ddbb3c621dfce7b44f9 : SUCCESS in 5m 02s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/fdeaa2191c054b69affc0b8fb91b0897 : FAILURE in 1h 06m 30s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/4e07209f60b84ba1ae24a21840c6f605 : SUCCESS in 4m 47s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/a5025848a7f842d7ba3761996e491b8a : SUCCESS in 5m 52s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/a8d3faf7fbb647a78a074335cd367abf : SUCCESS in 7m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a2f3d9c091cf4307ad776df39a0bf72e : SUCCESS in 8m 41s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/81815b88b54141e3a2d7b44f619bcb25 : SUCCESS in 1h 01m 37s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/2c510aefe92143d5bab0a6bc7b3cad93 : SUCCESS in 14m 16s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/b7c5c283ffe64a6c8a72388ab37d1e5b : SUCCESS in 32m 29s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/45b03675a50d40bd88fd9092b2f84b12 : SUCCESS in 1h 07m 48s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/09032721da9a4666a9adf329b7ab38bb : SUCCESS in 1h 38m 31s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/32a6dd8160c44c8b8b5036a91e673f22 : SUCCESS in 1h 32m 03s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/1ae7e1c7ea884a2ca05322c3d50a3746 : FAILURE in 52m 48s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/305a9295845e4df4ac05df7f99dd10e9 : FAILURE in 37m 33s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/0e45ae4f162140abbc98aad3d01b50a8 : SUCCESS in 37m 27s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/fbd7c906d14e40eabb6c6ec596919228 : FAILURE in 41m 19s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b563947bbcd349bb9d4b034ad508236b : SUCCESS in 1h 06m 00s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/b073a80a527f4fc0adbcb7b9c65f5788 : FAILURE in 43m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"200bfdedeeeeb39c244b206b8afcef9b86748061","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-02-19 18:42:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"649bf95038957ee614decce840fc7560bcd112d3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 20:53:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4b3ef4d6cbe74f128e5eeac27c2a1591\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/4fafa47389a84431ad433a55fb4c4477 : SUCCESS in 45m 27s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/086b5368acaf4c578213c5ec1bb16126 : SUCCESS in 24m 29s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44d8dcbf133243a387ff7bad63af38e5 : SUCCESS in 4m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/066f102ade604e1baaca977822407962 : SUCCESS in 4m 10s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/238b7d983c344cb4b1080f0e8f0240fb : SUCCESS in 3m 48s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/dcf024c30ae04bee81dc19d306fca532 : SUCCESS in 1h 08m 45s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/4b262f54c4fa47768c017f4e3dea187c : SUCCESS in 3m 18s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/ac9ef5ed21744b47a278c9866addcf9e : SUCCESS in 4m 53s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/a45e3166f70842e4af4420624653ff9a : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b3af710da0644df2919ca620d94b3996 : SUCCESS in 8m 24s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7af835fb8b174cfc9759d30f2e457f5c : SUCCESS in 1h 21m 25s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/67c2e2fdcb7643f983e70ab6828e282c : SUCCESS in 13m 20s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/870f7f73a3bd48f78e6f136f5004d66b : SUCCESS in 39m 59s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/296e8d8a474b48a2bb3c19991dca86ca : SUCCESS in 54m 29s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/b8cc89a294f94919b40faf6bec4a24a0 : SUCCESS in 1h 43m 39s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/c98ea3b0bfd24356883f8e0b55cf0eb9 : SUCCESS in 1h 59m 55s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/16a17e99a15644c884f01cac739a1fbb : FAILURE in 1h 13m 25s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/7cc101dad94a4495bc2edcbe264432c9 : FAILURE in 41m 39s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/9225b71fde9343ce92d1246ad5b1a3f2 : SUCCESS in 33m 02s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/af24492a985b496f8cf7b0dd802eda84 : FAILURE in 42m 29s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2a6f801d32014bc6a29a3ac50aae8d6a : SUCCESS in 1h 14m 21s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c648c454da0f4a508e691bf80f525ba3 : FAILURE in 51m 53s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0b2a680871c1f6194897cdac28caab2069c46ae9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 20:54:33.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e05f0450d79ec49e9fae2105063f55d8aae834ba","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 22:30:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/045c074dbf5f47eb878353ef0c15ec67\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/233d1d5ba221414cbe14c1688b8b23b6 : SUCCESS in 7m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/537d111ac87049f1aa80a90c9fdf3d17 : SUCCESS in 5m 21s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/7911e038f08c4d0095480fb1a41cd5fd : SUCCESS in 5m 57s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/309c579a69444f0fbc3f60709f0bdf58 : SUCCESS in 1h 05m 27s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/18b6950c6e0a4e02acf4d4f5eb269766 : SUCCESS in 5m 50s\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/bb7eb7929fbe45688fadca83cc78a030 : SUCCESS in 5m 40s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/94a3f8b33b7c4f25909057b09ed5b6e5 : SUCCESS in 6m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c430ba7552b42f4905789e60b7eff60 : SUCCESS in 10m 10s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/9784eb2110834824aca346856e4adbe2 : SUCCESS in 4m 17s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/5363601b3a2646c0af1a31c59c42c9f2 : SUCCESS in 57m 50s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/d9670e92a0074520b17f982ead217feb : SUCCESS in 1h 13m 11s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/ebdda66ac5504a7d8b1ed2f9b5a8a1c8 : SUCCESS in 1h 26m 08s","accounts_in_message":[],"_revision_number":2},{"id":"6c9926cbb65c7495a4aa68c1a049572e3afde780","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 22:30:37.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"aecc77683f03ee2cbbc465e610b2a831e903c87e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-19 22:33:17.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b15ed696d7824b778275ef8cbad1bc39\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92f7ba5ff35a4163b434f6fe41a9ee1b : SUCCESS in 1m 09s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3","revisions":{"e54f4e576fdbfdec23cdfe4776d7e8e9e23e6047":{"kind":"REWORK","_number":1,"created":"2025-02-11 17:27:21.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/72/941272/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/72/941272/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/1"}}},"commit":{"parents":[{"commit":"2dc10e206370e714bbaa06ddc127eaf54df1cd25","subject":"resource: Rework fields","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/2dc10e206370e714bbaa06ddc127eaf54df1cd25"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-25 10:11:49.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-02-11 17:26:10.000000000","tz":0},"subject":"fields: Tweak _convert_type","message":"fields: Tweak _convert_type\n\nWe would like to do a larger rework of this, but for now simply reflow\ninformation somewhat to make that larger rework a little more\nunderstandable.\n\nThe main functional change here is the removal of an \u0027isinstance(value,\ndata_type)\u0027 branch that would skip casting of the value if the value was\nalready of the expected type. This is removed since it provides limited\nvalue (e.g. int(5) \u003d\u003d 5, str(\u0027test\u0027) \u003d\u003d \u0027test\u0027) and would make the\nfuture rework slightly more complex.\n\nWe also add lots of tests to prevent regressions in future changes.\n\nChange-Id: Icb6b26127d8e200b650687578f450490e71d24c3\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e54f4e576fdbfdec23cdfe4776d7e8e9e23e6047"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e54f4e576fdbfdec23cdfe4776d7e8e9e23e6047"}]},"branch":"refs/heads/master"},"bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-02-19 12:50:47.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/72/941272/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/72/941272/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/72/941272/2"}}},"commit":{"parents":[{"commit":"a11df932f671c1d7ad7679c418fb74b126f5851c","subject":"resource: Rework fields","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a11df932f671c1d7ad7679c418fb74b126f5851c"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-25 10:11:49.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-02-19 11:16:56.000000000","tz":0},"subject":"fields: Tweak _convert_type","message":"fields: Tweak _convert_type\n\nWe would like to do a larger rework of this, but for now simply reflow\ninformation somewhat to make that larger rework a little more\nunderstandable.\n\nThe main functional change here is the removal of an \u0027isinstance(value,\ndata_type)\u0027 branch that would skip casting of the value if the value was\nalready of the expected type. This is removed since it provides limited\nvalue (e.g. int(5) \u003d\u003d 5, str(\u0027test\u0027) \u003d\u003d \u0027test\u0027) and would make the\nfuture rework slightly more complex.\n\nWe also add lots of tests to prevent regressions in future changes.\n\nChange-Id: Icb6b26127d8e200b650687578f450490e71d24c3\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/bf1b56e23f1c8cbdd3a2041b09506fb4b7091ed3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}