)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"68a8437f4dad7b2f9a587265fec01e5b0afe45d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b235ecd8_98d00973","updated":"2026-01-21 15:00:43.000000000","message":"LGTM, thanks for the fix Juan!","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"85f4e5a64d59f7ae8800a303a3eafb2fbdb5ec54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e704afd2_aed62f45","updated":"2026-01-22 15:30:23.000000000","message":"Would this be ready for a +w? 😊","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"4adb724c32976f2445349b5f6ad7e82c3832fb62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28a3e14e_baee85ff","updated":"2026-01-21 13:40:52.000000000","message":"recheck","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"c934f42309dcd8e415098dd47aab9da2459dbc6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91acf0c2_286d5e23","updated":"2026-01-21 15:59:48.000000000","message":"recheck","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"9e784815ff4de78b8b098cd197e6c307a9dd67d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6bdbde0_6ce9bf3d","updated":"2026-01-21 15:58:27.000000000","message":"recheck\n\nhitting a retry_limit again","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"24ff789d0974687c99b963a04d184260fa3568d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1132c6b2_5331acfa","updated":"2026-01-27 15:05:45.000000000","message":"recheck","commit_id":"b107b01aacdde4227489cc6433d5c4dfed464468"}],"openstack/shared_file_system/v2/share.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b81901e34943cf36ceacd8dc7cbd10ce3d28002","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \"offset\","},{"line_number":40,"context_line":"        \"sort_key\","},{"line_number":41,"context_line":"        \"sort_dir\","},{"line_number":42,"context_line":"        all_tenants\u003d\"all_tenants\","},{"line_number":43,"context_line":"    )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4c2ecad_05effdaa","line":42,"updated":"2026-01-27 11:28:09.000000000","message":"I was going to leave a comment about using `all_projects` instead of `all_tenants`, but I can\u0027t see where either of them are implemented. I assume I\u0027ve missed something?\n\nhttps://opendev.org/openstack/manila/src/commit/6017d9976e526412e601c677da15d62c6ce73604/manila/api/v2/shares.py#L606-L628\nhttps://opendev.org/openstack/manila/src/commit/6017d9976e526412e601c677da15d62c6ce73604/manila/api/v1/shares.py#L127-L192","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"b55fe7b87352ab5ba8642ce66e9226ff3ed3c593","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \"offset\","},{"line_number":40,"context_line":"        \"sort_key\","},{"line_number":41,"context_line":"        \"sort_dir\","},{"line_number":42,"context_line":"        all_tenants\u003d\"all_tenants\","},{"line_number":43,"context_line":"    )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"e583a2b4_06ee32c0","line":42,"in_reply_to":"8cd1d564_5c28af31","updated":"2026-01-27 13:10:35.000000000","message":"Our answers crossed, sorry, we have reached the same conclusion separatedly. New patch incoming.","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ea056f5450a9b9094dff26fa3dc1b640bf1f7072","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \"offset\","},{"line_number":40,"context_line":"        \"sort_key\","},{"line_number":41,"context_line":"        \"sort_dir\","},{"line_number":42,"context_line":"        all_tenants\u003d\"all_tenants\","},{"line_number":43,"context_line":"    )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cd1d564_5c28af31","line":42,"in_reply_to":"c4c2ecad_05effdaa","updated":"2026-01-27 13:09:41.000000000","message":"Manila implements the all_tenants function on https://opendev.org/openstack/manila/src/commit/6017d9976e526412e601c677da15d62c6ce73604/manila/utils.py#L318.\n\nHowever, your unwritten comment about using all_projects here is 100% reasonable. I came from using openstacksdk to query designate, which supports all_projects\u003d\"all_projects\", so it seemed right, seeing that Manila does not implement all_project, but all_tenants, to implement this as is.\n\nBut if I look at what Nova or Cinder are doing, they all accept all_projects here while the service itself accepts all_tenants, so the appropiate way to implement this to be consistent would be all_projects\u003d\"all_tenants\".\n\nWhat do you think?","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"64b607895e5fdd7f5228b7a6690a73ad4a0f3193","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \"offset\","},{"line_number":40,"context_line":"        \"sort_key\","},{"line_number":41,"context_line":"        \"sort_dir\","},{"line_number":42,"context_line":"        all_tenants\u003d\"all_tenants\","},{"line_number":43,"context_line":"    )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b0aa975_6d7237c9","line":42,"in_reply_to":"c4c2ecad_05effdaa","updated":"2026-01-27 12:49:55.000000000","message":"Okay, the check is here https://opendev.org/openstack/manila/src/commit/6017d9976e526412e601c677da15d62c6ce73604/manila/share/api.py#L2437\n\nCan you change this to\n\n```suggestion\n        all_projects\u003d\"all_tenants\",\n```\n\nto align with other projects. This will create an alias so users can use the project terminology universally, rather than the deprecated tenant terminology.","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29de1019b5e73122fc6fc043a225c6e42abfd4a5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"offset\","},{"line_number":40,"context_line":"        \"sort_key\","},{"line_number":41,"context_line":"        \"sort_dir\","},{"line_number":42,"context_line":"        all_tenants\u003d\"all_tenants\","},{"line_number":43,"context_line":"    )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"90c0861d_9ff0c166","line":42,"in_reply_to":"e583a2b4_06ee32c0","updated":"2026-01-27 15:54:47.000000000","message":"Done","commit_id":"a2a00ecfac1377cc42b7b3f020f4ebba12117bd7"}]}