)]}'
{"id":"openstack%2Fopenstacksdk~984080","triplet_id":"openstack%2Fopenstacksdk~master~I3a872ef0de9485f836e70cfa3d1de70c7bbe2ac5","project":"openstack/openstacksdk","branch":"master","topic":"resource-cleanup","hashtags":[],"change_id":"I3a872ef0de9485f836e70cfa3d1de70c7bbe2ac5","subject":"resource: Drop Resource.commit_jsonpatch","status":"MERGED","created":"2026-04-10 17:05:11.000000000","updated":"2026-04-10 20:34:43.000000000","submitted":"2026-04-10 20:32:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"984080-resource-cleanup","meta_rev_id":"3da624a70ce9e09898567f82e9cf52b8e8d9669c","_number":984080,"virtual_id_number":984080,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-04-10 20:32:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-04-10 18:11:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-04-10 18:11:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-10 18:54:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3c5d98064543e43518fc9c911245438dd62bb5bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-10 17:05:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e257347833223f05b60dc5b609575677129e5d99","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-10 18:11:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"233fe6d3fd52df4bac0ab9d63f2a9193fcca13e4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-10 18:54:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/03d897436c974695b5245770be32f140\n\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/6dd0113e7449404699830b343d13c9f6 : SUCCESS in 25m 15s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a41e0e2fa5394dff8a94081ade4a90d7 : SUCCESS in 5m 12s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b09989c26b5149759a1093590bf323f5 : SUCCESS in 4m 09s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/929026b85bef49c39dd97bc9ab1a3935 : SUCCESS in 4m 27s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/260af302647245d89f326a62028066ab : SUCCESS in 2m 43s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/df8c4f556d5b47878a0803e42685e203 : SUCCESS in 7m 00s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/fe52dedb9411427e8d8d57b72c087e5a : SUCCESS in 53m 53s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/0a289bd62fbe4d7e9dedcc3c58d791a0 : SUCCESS in 6m 36s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/cf53a36edcc64f06b09e69ba730e72c5 : SUCCESS in 5m 49s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/e6bd1ba6139a43c68dcd0f43e9d519ab : SUCCESS in 3m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/689c102018774027b66eaac92b6cc3a9 : SUCCESS in 11m 05s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7df864b346864b29a841877ad4f7fd0c : SUCCESS in 1h 32m 35s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/9e4b5a8f715743388bca7856d03b5396 : SUCCESS in 57m 03s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/c7acb94f9408424eba596a233a8f661a : SUCCESS in 1h 44m 11s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/a6e2810ea45c4f45a3f7cbe0cd22ec2a : FAILURE in 59m 14s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/f83cfbd5949b479390353374fcbc5b23 : SUCCESS in 35m 34s\n- openstacksdk-functional-devstack-compute-manila https://zuul.opendev.org/t/openstack/build/1759d08dde454188a7db17e117cf7b0b : SUCCESS in 22m 21s\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/9e1f3b92b35c475f97b20b5ead236e34 : SUCCESS in 22m 24s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/8b2251684ccf4fb9ae3c573df0012aaf : SUCCESS in 51m 16s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/855f2368762a4b78abe08464c371d4dc : FAILURE in 1h 19m 58s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/0af5e9eac9724d1c8309592ec6607d54 : SUCCESS in 1h 20m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5cde567c19ba7933c69bc1a71328844d333dca2e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-10 18:55:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"323a2a0e01a6b36e98b2e6aec03d2eb4769a4238","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-10 20:32:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a62c8956b3cc431bb6545eb89b7d38f3\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/df484104e2654f5891592bad6c2567ab : SUCCESS in 5m 48s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e969062d02d94e1cbc312b843e4cf468 : SUCCESS in 6m 44s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/487673a23a3f4315be98113b410dcbf9 : SUCCESS in 5m 18s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/78c6c8eaac804054ad8bcfe746096825 : SUCCESS in 1h 09m 58s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/129dec53ea56488c82c6679b4f148bb8 : SUCCESS in 6m 06s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/6f6459c9250049038cb7f526f28bb4f5 : SUCCESS in 6m 14s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/cdf0e5632e01496180848ffd23153a32 : SUCCESS in 5m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7cc973c5f07c46aaab8c4b1815de3e62 : SUCCESS in 11m 50s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/856fb4a4460846a497aaeab87766c3e1 : SUCCESS in 38m 59s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/41573a2973084e1f838a61d3b34b2a33 : SUCCESS in 1h 31m 34s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/2a3ae5beac704fb7837dc732dacf9b8d : SUCCESS in 1h 19m 11s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/cc24c1a1486a4fa295f2e0ffd31264b4 : SUCCESS in 23m 00s","accounts_in_message":[],"_revision_number":1},{"id":"75f96041b30fbdcd2e13b6176b7795acfdbef450","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-10 20:32:33.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"3da624a70ce9e09898567f82e9cf52b8e8d9669c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-10 20:34:43.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/df27d0ac066a402e8fd22b7ff78a3dec\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/60b58a8a143e4321a5d356dca69287de : SUCCESS in 53s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88dc7d126698442b2219e2f694480d274e61d4b0","revisions":{"88dc7d126698442b2219e2f694480d274e61d4b0":{"kind":"REWORK","_number":1,"created":"2026-04-10 17:05:11.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/80/984080/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/80/984080/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/80/984080/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/80/984080/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/80/984080/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/80/984080/1"}}},"commit":{"parents":[{"commit":"3d22b68526b337b17a31c755be0ee339f4f34c9d","subject":"image: Allow Image.patch calls","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/3d22b68526b337b17a31c755be0ee339f4f34c9d"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-10 11:21:24.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-10 16:39:16.000000000","tz":60},"subject":"resource: Drop Resource.commit_jsonpatch","message":"resource: Drop Resource.commit_jsonpatch\n\nThis is wholly unnecessary: if a Resource has allow_patch then we can\ninfer that updates should use both the PATCH method and a JSON Patch\nbody.\n\nBy the same logic, we can also insist that if allow_patch and\nallow_commit are both True, commits should use PATCH.\n\nChange-Id: I3a872ef0de9485f836e70cfa3d1de70c7bbe2ac5\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/88dc7d126698442b2219e2f694480d274e61d4b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/88dc7d126698442b2219e2f694480d274e61d4b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
