)]}'
{"id":"openstack%2Fopenstacksdk~984588","triplet_id":"openstack%2Fopenstacksdk~master~I3d923eeaeb03f1f2bea7b1aeb6c9cc9630cebe42","project":"openstack/openstacksdk","branch":"master","topic":"gate-fix","hashtags":[],"change_id":"I3d923eeaeb03f1f2bea7b1aeb6c9cc9630cebe42","subject":"identity: Fix limit, registered limit update","status":"MERGED","created":"2026-04-14 15:37:10.000000000","updated":"2026-04-14 19:54:37.000000000","submitted":"2026-04-14 19:52:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"984588-gate-fix","meta_rev_id":"b839f19c7504f1c070c396ce0343dc5447c31c9c","_number":984588,"virtual_id_number":984588,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-04-14 19:52:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-04-14 17:36:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-04-14 17:36:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-14 17:21:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"efb4629e286c9d76eae33a2f9030bfabe4dadfe2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-14 15:37:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e21cd4a98b5690868f8acdfd256ca82170c3259b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-14 15:41:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7c6fd3b8203811e6b09a2ac26cd389b8f5336126","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 17:21:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ca5249e26c884f14b34f01d0a957cff2\n\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/0c0601a94fd6457aa7b86e87bf22d2f6 : SUCCESS in 58m 01s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3e55cb4c316147c5861939514ef8fa0e : SUCCESS in 5m 03s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/6b81fb634b0347169b3b977a12b312f2 : SUCCESS in 4m 31s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/a3c34b94cdd347fc93bc15e89b8ea621 : SUCCESS in 4m 41s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3bc67307c39c4a988206a4b3b01c79b9 : SUCCESS in 6m 03s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/18dd16396c464b1a8ba1719a831fcb8c : SUCCESS in 10m 51s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9e7261c8ca5e4cdc9b9e53bd142636c3 : SUCCESS in 1h 29m 39s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/89d76cfe329c4937b2a211eb5ddb8a09 : SUCCESS in 4m 29s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/b10cdbe2ecf44cb7911e10c1b5e27c52 : SUCCESS in 5m 59s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/14f717b72f794c9d98cfff167985377e : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1b37fed061f94c84bd5f32eff7196026 : SUCCESS in 7m 45s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3171276e6a7345159c26236e9f42a875 : SUCCESS in 1h 03m 48s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/e16f1f825a3947b0aeeabf3e90ad99e1 : SUCCESS in 1h 18m 40s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/d413601abc644237b9ed1b80d9858082 : SUCCESS in 1h 35m 35s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/a9eca5ba7db74f99931b307268c427ad : FAILURE in 56m 03s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/0fa7e383617042dd8b9f3a24d481c89d : SUCCESS in 39m 22s\n- openstacksdk-functional-devstack-compute-manila https://zuul.opendev.org/t/openstack/build/6deebd4a078d4e2695be958738e8c0b7 : SUCCESS in 28m 14s\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/99f3411d264f4d9eaafcb63ab4e88bb6 : SUCCESS in 38m 02s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/6463313ba66c4eca8d6701c87106cedc : SUCCESS in 37m 39s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/76e3c667f44b4ad8b5bb40e1464647fd : SUCCESS in 1h 02m 24s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/981ef606c9c64792b42f1a2402248343 : SUCCESS in 1h 28m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2ea6597d61d1fa178eb86fc810e7119807295407","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-14 17:36:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"17b0e417842af4baff45a80278d48bfc1db47977","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 17:36:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"293856b823da8ca5b4b833f1755d3a7fff7d27d4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-04-14 17:37:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1d6fbc8f2bf0b6c6f6b42365cbf5068921fdeda8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 19:52:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e29787f9c84a4ac8b813fc62a7b0fe82\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5efb17eb22294d23927ff06ce188e5ef : SUCCESS in 2m 51s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c85015cb85144e95942a8333d59b6d02 : SUCCESS in 5m 04s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/f1d0734801f04bb1abec0d087ea6b569 : SUCCESS in 4m 34s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/39d6b200b07f4ca2bdc3fe59d2943acc : SUCCESS in 54m 19s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/24221303bcdd4f3abed487472bb7b34c : SUCCESS in 4m 15s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/59a6cafdd31a420ca2d420803d12248b : SUCCESS in 2m 42s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/d478c818519946a78dffcf1735e2c51c : SUCCESS in 5m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0abcf29ddd004519a1f73a125fa6a259 : SUCCESS in 13m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7ddda261b2e040c8bbfca91e93a2ae82 : SUCCESS in 52m 55s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/0026b37d94fa413cad48c91cd04d2275 : SUCCESS in 1h 28m 50s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/652aed5ddedc42eebac505c610eb8dcd : SUCCESS in 1h 20m 35s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/6494d11fc50f476f979569893c8f9037 : SUCCESS in 50m 15s","accounts_in_message":[],"_revision_number":2},{"id":"8f7851880298819b34c404db50c7258874dbe46d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 19:52:06.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"b839f19c7504f1c070c396ce0343dc5447c31c9c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 19:54:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c19773f2c1b7487ca30219167ae16cea\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f08406f321c4095a85964ea0aaf2d35 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e177452b31cb97f5b4b11a0263580ff238b24c7e","revisions":{"a2cbf3a56ecc8e7984ee24f2eae7019c43845931":{"kind":"REWORK","_number":1,"created":"2026-04-14 15:37:10.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/88/984588/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/88/984588/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/1"}}},"commit":{"parents":[{"commit":"0e600262b3768253b5e7579e1afdfa0b6594aad6","subject":"typing: Make config stricter again","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0e600262b3768253b5e7579e1afdfa0b6594aad6"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-14 14:41:04.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-14 15:27:08.000000000","tz":60},"subject":"identity: Fix limit, registered limit update","message":"identity: Fix limit, registered limit update\n\nAs of recent changes [1][2], we dropped the `commit_jsonpatch` attribute\nof the `Resource` class. It turns out, however, that we actually using\nthis (incorrectly) in one case to differentiate between calls to\n`_prepare_request_body` for create requests and for commit requests and\nwe now envelope requests incorrectly for update calls to the\naforementioned resources. This was made worse by the fact that our\nidentity tests have been skipped since change\nI07941d2036a46d5345841f7cbb163e1386494107.\n\nThe previous pattern was incorrect - neither of these resources expect a\nJSON Patch body - so instead we introduce a new helper to do this kind\nof post-generation, pre-submission manipulation. We can roll this out\nmore broadly down the line to help us cut down the amount of\nre-implementations of methods we are currently carrying. Also\ntemporarily disable the skip until we figure out what\u0027s going on.\n\nChange-Id: I3d923eeaeb03f1f2bea7b1aeb6c9cc9630cebe42\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a2cbf3a56ecc8e7984ee24f2eae7019c43845931"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a2cbf3a56ecc8e7984ee24f2eae7019c43845931"}]},"branch":"refs/heads/master"},"e177452b31cb97f5b4b11a0263580ff238b24c7e":{"kind":"REWORK","_number":2,"created":"2026-04-14 15:41:26.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/88/984588/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/88/984588/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/88/984588/2"}}},"commit":{"parents":[{"commit":"0e600262b3768253b5e7579e1afdfa0b6594aad6","subject":"typing: Make config stricter again","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0e600262b3768253b5e7579e1afdfa0b6594aad6"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-14 14:41:04.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-04-14 15:41:13.000000000","tz":60},"subject":"identity: Fix limit, registered limit update","message":"identity: Fix limit, registered limit update\n\nAs of recent changes [1][2], we dropped the `commit_jsonpatch` attribute\nof the `Resource` class. It turns out, however, that we actually using\nthis (incorrectly) in one case to differentiate between calls to\n`_prepare_request_body` for create requests and for commit requests and\nwe now envelope requests incorrectly for update calls to the\naforementioned resources. This was made worse by the fact that our\nidentity tests have been skipped since change\nI07941d2036a46d5345841f7cbb163e1386494107.\n\nThe previous pattern was incorrect - neither of these resources expect a\nJSON Patch body - so instead we introduce a new helper to do this kind\nof post-generation, pre-submission manipulation. We can roll this out\nmore broadly down the line to help us cut down the amount of\nre-implementations of methods we are currently carrying. Also\ntemporarily disable the skip until we figure out what\u0027s going on.\n\nChange-Id: I3d923eeaeb03f1f2bea7b1aeb6c9cc9630cebe42\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e177452b31cb97f5b4b11a0263580ff238b24c7e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e177452b31cb97f5b4b11a0263580ff238b24c7e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}