)]}'
{"id":"openstack%2Fopenstacksdk~989571","triplet_id":"openstack%2Fopenstacksdk~master~I9ab503874952961b56f89e339ac61ee5691d82c7","project":"openstack/openstacksdk","branch":"master","topic":"typing","hashtags":[],"change_id":"I9ab503874952961b56f89e339ac61ee5691d82c7","subject":"Deprecate incorrect get_*_metadata methods","status":"MERGED","created":"2026-05-21 17:08:44.000000000","updated":"2026-05-21 21:10:13.000000000","submitted":"2026-05-21 21:10:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"989571-typing","meta_rev_id":"5e8c54ada036fe4f79b6f07e084fb8fef880f020","_number":989571,"virtual_id_number":989571,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-05-21 21:10:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-05-21 19:14:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-05-21 19:14:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-21 18:49:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4af9a6e7ea8b0a487c9ccda918fbf7d8ca6a76a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-05-21 17:08:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d28b258e4161a96a727d3c40cc5c06390d623b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 18:49:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e8de3ea7eeff4500bef8ff628f1f3758\n\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/81cccebef073463ba1442a1e7642a909 : FAILURE in 6m 47s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71d514936eb24ca7be943e343be8966d : SUCCESS in 2m 47s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/9f58408e6bc44c569556f72ea8c1feb1 : SUCCESS in 3m 24s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/0431ca204f334bdd97b3b0c7a7c872d6 : SUCCESS in 4m 34s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fe067079a3764cae879d4f819b334ce0 : SUCCESS in 5m 00s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/17653c9f789048fe8fae928a9d62be7e : SUCCESS in 6m 57s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/38169e5d25af4b998aac5fdfbeb9b2f8 : SUCCESS in 1h 07m 53s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/df622c14f0b743209c807051b3b6ec55 : SUCCESS in 3m 55s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/1be74d6f23a5439db69b4fe348c9e5fc : SUCCESS in 5m 36s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/caa433edd0aa4c62aa31bd9dcc5bc7ea : SUCCESS in 9m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5d5fbd8b181a48c1b2597a58b8221efd : SUCCESS in 6m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/564142c2c99744999160e491fbeed186 : SUCCESS in 4m 43s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ef90f14f601a4d79bb3e53ab316b5fd3 : SUCCESS in 1h 10m 11s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/4b78cd98ce35471db924c4fc216a7afd : SUCCESS in 1h 28m 34s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/502cad3e125e4f84b40b97c84cb5fda9 : FAILURE in 1h 34m 41s (non-voting)\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/b7ab62560d7f4251afe88ffd3a2b43d1 : FAILURE in 47m 08s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/38fe0c0b66184fe2b953e353d03e6e5b : SUCCESS in 32m 35s\n- openstacksdk-functional-devstack-compute-manila https://zuul.opendev.org/t/openstack/build/cbe67a5fcdba463f9c18de188405c506 : SUCCESS in 38m 57s\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/ad63bc94b05641abbf0575969599bb05 : SUCCESS in 23m 51s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/60f5d8d00c6a49a18068944053b59ed3 : SUCCESS in 48m 42s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c8e94bf85c28409093c0de6e51faa2c5 : SUCCESS in 1h 10m 09s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/ee6ecd90468a426f8badc02b3a4fa744 : SUCCESS in 1h 23m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6c81300c2a9c351788051a917461fa7412b44110","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-05-21 19:14:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"25560da2f558c1b4cd646b93d0d84747d1c0d81a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 19:16:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e231a5f2c1c14355171d8962d9e10b8ea6011312","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 21:10:12.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5cac0bb7b36640d98518c1ba15d1021e\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61ef4b817230425e8ab02257a431213d : SUCCESS in 4m 46s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2441e670f82e4e6e802923e68664c276 : SUCCESS in 3m 32s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/233e0ed6903f40ac9451bbf2249a69d2 : SUCCESS in 4m 22s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c8931363a7224f038ecbb766bbabb764 : SUCCESS in 1h 09m 41s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/883c1423275748d4900797906656b1ab : SUCCESS in 3m 55s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/734f9eac8b9f4c8b988fa5455d8c39f5 : SUCCESS in 5m 00s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/612c0cf64bb94031b7023e558c5f15cd : SUCCESS in 4m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8cb83473dca9429ea26bc92554be50fc : SUCCESS in 9m 19s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bedd7c0565e74dd6ab9afc7200cb36e9 : SUCCESS in 4m 34s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/293202a1a5c94a3d8c1e43ce1beedc2f : SUCCESS in 54m 34s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/212f7cc6fd9d46908f982a9d03b26d13 : SUCCESS in 1h 24m 23s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/5e67ca43a0ac48d3a26955fbeab36159 : SUCCESS in 47m 47s","accounts_in_message":[],"_revision_number":1},{"id":"5e8c54ada036fe4f79b6f07e084fb8fef880f020","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 21:10:13.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f49c00a0343924a8e237e5beef0335d81c6b37e2","revisions":{"f49c00a0343924a8e237e5beef0335d81c6b37e2":{"kind":"REWORK","_number":1,"created":"2026-05-21 17:08:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/71/989571/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/71/989571/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/71/989571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/71/989571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/71/989571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/71/989571/1"}}},"commit":{"parents":[{"commit":"2334f12f3dfed1eb28960006042879b17002e3e4","subject":"typing: Add annotations to all Proxy.get_* methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/2334f12f3dfed1eb28960006042879b17002e3e4"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-05-15 21:28:21.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-05-21 17:08:14.000000000","tz":60},"subject":"Deprecate incorrect get_*_metadata methods","message":"Deprecate incorrect get_*_metadata methods\n\nThese should be called fetch_*_metadata since they modify an existing\nresource.\n\nWe also replace create_share_metadata and update_share_metadata methods\nin the shared file system proxy API with a combined set_share_metadata,\nin line with other proxies, and fix set_aggregate_metadata in the\ncompute proxy API so that it accepts kwargs.\n\nChange-Id: I9ab503874952961b56f89e339ac61ee5691d82c7\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f49c00a0343924a8e237e5beef0335d81c6b37e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f49c00a0343924a8e237e5beef0335d81c6b37e2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}