)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1af17a4725b88ba866ec17bbf02dcb0f46d4d854","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack APIs support fetching only selected fields."},{"line_number":10,"context_line":"To make it possible from SDK also this patch adds the"},{"line_number":11,"context_line":"optional **pparam to these methods to pass extra params"},{"line_number":12,"context_line":"like fields\u003d[\u0027name\u0027, \u0027status\u0027] to retrieve only these fields"},{"line_number":13,"context_line":"from the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8e51c8c_97b1e70f","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":18},"updated":"2026-08-05 10:32:36.000000000","message":"nit\n\n```suggestion\noptional **param to these methods to pass extra params\n```","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5b0010909cb27bcf31a64ed1bf34d797563f9b82","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack APIs support fetching only selected fields."},{"line_number":10,"context_line":"To make it possible from SDK also this patch adds the"},{"line_number":11,"context_line":"optional **pparam to these methods to pass extra params"},{"line_number":12,"context_line":"like fields\u003d[\u0027name\u0027, \u0027status\u0027] to retrieve only these fields"},{"line_number":13,"context_line":"from the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8a71de01_4b56d992","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":18},"in_reply_to":"e8e51c8c_97b1e70f","updated":"2026-08-07 16:01:43.000000000","message":"thanks, I anyway changed it to fields","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2dd316fa5906785c359792e03080d9807104abc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b41bf222_294d8f57","updated":"2026-07-23 09:14:44.000000000","message":"recheck\nThe previous patch already merged.\nthanks for the review","commit_id":"7969d31619bf48f774b70cf5f879f1af4d5cd64b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"21c9cc89df747be6a4e7655e5b52fc83bb18c6ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e900efc1_5b64f18b","updated":"2026-08-05 10:33:01.000000000","message":"I\u0027d really like to avoid doing this if possible","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67c9d756370d24358eeac36071edd6a18bb91be8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33fba37c_39565667","updated":"2026-08-10 10:40:43.000000000","message":"Much better, thanks 🙏 One additional request inline","commit_id":"fec5339c137f2de2ea51b5b386649b12f004fb2b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6aef01e27ace210366f44700e58518042bbdd69c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e00fcf4d_6bdd37a1","updated":"2026-08-08 11:56:06.000000000","message":"ok, I tested now with Nova/tempest (https://review.opendev.org/c/openstack/nova/+/928022) and manually also, and it is now wokrs as expected","commit_id":"fec5339c137f2de2ea51b5b386649b12f004fb2b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e70d6bae218b2d92e1387e8c65018b0a4dccaed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ded3e918_70de253d","updated":"2026-08-10 09:40:34.000000000","message":"recheck\ntest_block_storage_cleanup failure is not related","commit_id":"fec5339c137f2de2ea51b5b386649b12f004fb2b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f5e4e69dc1a0e3c87735ca849e564a40f17f0900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42760fac_b8a53b24","updated":"2026-08-11 09:49:09.000000000","message":"recheck\ndns related quota failures are not related","commit_id":"841a36f4e5f12502aa50ffb9a41c11e07eb91259"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1af17a4725b88ba866ec17bbf02dcb0f46d4d854","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def get_address_group("},{"line_number":335,"context_line":"        self, address_group: str | _address_group.AddressGroup, **params: Any"},{"line_number":336,"context_line":"    ) -\u003e _address_group.AddressGroup:"},{"line_number":337,"context_line":"        \"\"\"Get a single address group"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"54936732_e91ad0eb","line":335,"updated":"2026-08-05 10:32:36.000000000","message":"We\u0027re trying to get away from these random grab bags of attributes, particularly for proxy and cloud methods. If you look around, you\u0027ll notice pretty much no `get_*` proxy method currently accepts kwargs.\n\nIs `fields` the only query parameter supported or are there more? If it\u0027s the only one, can we just specify that like the baremetal proxy does?","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5b0010909cb27bcf31a64ed1bf34d797563f9b82","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def get_address_group("},{"line_number":335,"context_line":"        self, address_group: str | _address_group.AddressGroup, **params: Any"},{"line_number":336,"context_line":"    ) -\u003e _address_group.AddressGroup:"},{"line_number":337,"context_line":"        \"\"\"Get a single address group"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8f806ab5_660f77b2","line":335,"in_reply_to":"54936732_e91ad0eb","updated":"2026-08-07 16:01:43.000000000","message":"thanks I missed Ironic resources when I checked for patterns","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d48d808389418ff65c7d62e58b8d47cc7c2244b7","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def get_address_group("},{"line_number":335,"context_line":"        self, address_group: str | _address_group.AddressGroup, **params: Any"},{"line_number":336,"context_line":"    ) -\u003e _address_group.AddressGroup:"},{"line_number":337,"context_line":"        \"\"\"Get a single address group"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c61b8259_68c525b7","line":335,"in_reply_to":"8f806ab5_660f77b2","updated":"2026-08-10 15:14:13.000000000","message":"Done","commit_id":"974f2787bd0c22c1e9dbfa5fae174517fc2a590e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67c9d756370d24358eeac36071edd6a18bb91be8","unresolved":true,"context_lines":[{"line_number":369,"context_line":"    def get_address_group("},{"line_number":370,"context_line":"        self,"},{"line_number":371,"context_line":"        address_group: str | _address_group.AddressGroup,"},{"line_number":372,"context_line":"        fields: list[str] | None \u003d None,"},{"line_number":373,"context_line":"    ) -\u003e _address_group.AddressGroup:"},{"line_number":374,"context_line":"        \"\"\"Get a single address group"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f955deda_3665c0be","line":372,"updated":"2026-08-10 10:40:43.000000000","message":"Could you make these kwarg-only arguments?\n\n\n\n```suggestion\n        *,\n        fields: list[str] | None \u003d None,\n```","commit_id":"fec5339c137f2de2ea51b5b386649b12f004fb2b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1a18101dee5d0eee9929828f2c541086e5e67eb6","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def get_address_group("},{"line_number":370,"context_line":"        self,"},{"line_number":371,"context_line":"        address_group: str | _address_group.AddressGroup,"},{"line_number":372,"context_line":"        fields: list[str] | None \u003d None,"},{"line_number":373,"context_line":"    ) -\u003e _address_group.AddressGroup:"},{"line_number":374,"context_line":"        \"\"\"Get a single address group"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8376e0fc_b4253bcf","line":372,"in_reply_to":"f955deda_3665c0be","updated":"2026-08-10 14:10:57.000000000","message":"makes sense, I updated the method signatures","commit_id":"fec5339c137f2de2ea51b5b386649b12f004fb2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d48d808389418ff65c7d62e58b8d47cc7c2244b7","unresolved":true,"context_lines":[{"line_number":8979,"context_line":"        *,"},{"line_number":8980,"context_line":"        fields: list[str] | None \u003d None,"},{"line_number":8981,"context_line":"    ) -\u003e _tap_mirror.TapMirror:"},{"line_number":8982,"context_line":"        \"\"\"Get a signle Tap Mirror"},{"line_number":8983,"context_line":""},{"line_number":8984,"context_line":"        :param tap_mirror: The value can be the ID of a tap mirror or a"},{"line_number":8985,"context_line":"            :class:`~openstack.network.v2.tap_mirror.TapMirror` instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"1bbc9123_ebf42f3c","line":8982,"range":{"start_line":8982,"start_character":17,"end_line":8982,"end_character":23},"updated":"2026-08-10 15:14:13.000000000","message":"`s/signle/single/`\n\nbut this was already mispelt so not blocking on it","commit_id":"841a36f4e5f12502aa50ffb9a41c11e07eb91259"}]}