)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3d3721748adc07716fc52f82f7f7682c394b94c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1b8f4d0_193bf543","updated":"2026-08-05 10:12:16.000000000","message":"We don\u0027t really need the new proxy methods, but I\u0027m okay adding them once we make them a little more helpful","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"c95ea30bafa1629363ff9d19b50e919f3cea1ce1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bc7c74f_6bb17ac2","in_reply_to":"b1b8f4d0_193bf543","updated":"2026-08-06 03:26:08.000000000","message":"Thanks for the review! I totally agree with what you mentioned. I dropped both methods and switched to using `update_group` directly, and added a unit test for this.\nI have a question: I added `#:` doc comments to the two new fields, but none of the existing fields on Group have them, so now the new fields would be the only documented attribute on at that resource. I intentionally didn\u0027t touch the existing fields. Should I separate the change, or handle it here?","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1f3c7a09acfeb77da142be77d1a5f0991cded23c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bcfa54b_01f07b3e","updated":"2026-08-19 10:10:45.000000000","message":"recheck","commit_id":"377d8ca330e8c2328573d2642593694723bc1be7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da059f5518a7fb174a63904dd986c2fa9d5f1ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4f4782e_4a9ea3dd","updated":"2026-08-06 12:43:02.000000000","message":"recheck","commit_id":"377d8ca330e8c2328573d2642593694723bc1be7"}],"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3d3721748adc07716fc52f82f7f7682c394b94c","unresolved":true,"context_lines":[{"line_number":2294,"context_line":"    def add_volumes_to_group("},{"line_number":2295,"context_line":"        self,"},{"line_number":2296,"context_line":"        group: str | _group.Group,"},{"line_number":2297,"context_line":"        volumes: list[str],"},{"line_number":2298,"context_line":"    ) -\u003e None:"},{"line_number":2299,"context_line":"        \"\"\"Add volume(s) to a group"},{"line_number":2300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4a77f353_f2fdd6f7","line":2297,"updated":"2026-08-05 10:12:16.000000000","message":"Could/should we also accept `Volume` objects here?\n\n\n```suggestion\n        volumes: Iterable[str | _volume.Volume],\n```\n\nYou\u0027ll need to call `resource.Resource._get_id` on each element then and update the docstring, naturally","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"c95ea30bafa1629363ff9d19b50e919f3cea1ce1","unresolved":false,"context_lines":[{"line_number":2294,"context_line":"    def add_volumes_to_group("},{"line_number":2295,"context_line":"        self,"},{"line_number":2296,"context_line":"        group: str | _group.Group,"},{"line_number":2297,"context_line":"        volumes: list[str],"},{"line_number":2298,"context_line":"    ) -\u003e None:"},{"line_number":2299,"context_line":"        \"\"\"Add volume(s) to a group"},{"line_number":2300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ab3db6e_fce42757","line":2297,"in_reply_to":"4a77f353_f2fdd6f7","updated":"2026-08-06 03:26:08.000000000","message":"Done","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3d3721748adc07716fc52f82f7f7682c394b94c","unresolved":true,"context_lines":[{"line_number":2296,"context_line":"        group: str | _group.Group,"},{"line_number":2297,"context_line":"        volumes: list[str],"},{"line_number":2298,"context_line":"    ) -\u003e None:"},{"line_number":2299,"context_line":"        \"\"\"Add volume(s) to a group"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"        :param group: The :class:`~openstack.block_storage.v3.group.Group` to"},{"line_number":2302,"context_line":"            add volumes to."}],"source_content_type":"text/x-python","patch_set":1,"id":"7fd6ab1a_1bfb7a3a","line":2299,"updated":"2026-08-05 10:12:16.000000000","message":"Its probably worth noting that this is a helper method: users could achieve the exact same thing with e.g.\n\n```\nconn.block_storage.update_group(group, add_volumes\u003d\u0027vol-id-1,vol-id-2\u0027)\n```\n\nright?","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"c95ea30bafa1629363ff9d19b50e919f3cea1ce1","unresolved":false,"context_lines":[{"line_number":2296,"context_line":"        group: str | _group.Group,"},{"line_number":2297,"context_line":"        volumes: list[str],"},{"line_number":2298,"context_line":"    ) -\u003e None:"},{"line_number":2299,"context_line":"        \"\"\"Add volume(s) to a group"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"        :param group: The :class:`~openstack.block_storage.v3.group.Group` to"},{"line_number":2302,"context_line":"            add volumes to."}],"source_content_type":"text/x-python","patch_set":1,"id":"ca7eebc8_5c988fec","line":2299,"in_reply_to":"7fd6ab1a_1bfb7a3a","updated":"2026-08-06 03:26:08.000000000","message":"Done","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3d3721748adc07716fc52f82f7f7682c394b94c","unresolved":true,"context_lines":[{"line_number":2310,"context_line":"    def remove_volumes_from_group("},{"line_number":2311,"context_line":"        self,"},{"line_number":2312,"context_line":"        group: str | _group.Group,"},{"line_number":2313,"context_line":"        volumes: list[str],"},{"line_number":2314,"context_line":"    ) -\u003e None:"},{"line_number":2315,"context_line":"        \"\"\"Remove volume(s) from a group"},{"line_number":2316,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b73824e8_34726c26","line":2313,"updated":"2026-08-05 10:12:16.000000000","message":"As above","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"c95ea30bafa1629363ff9d19b50e919f3cea1ce1","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"    def remove_volumes_from_group("},{"line_number":2311,"context_line":"        self,"},{"line_number":2312,"context_line":"        group: str | _group.Group,"},{"line_number":2313,"context_line":"        volumes: list[str],"},{"line_number":2314,"context_line":"    ) -\u003e None:"},{"line_number":2315,"context_line":"        \"\"\"Remove volume(s) from a group"},{"line_number":2316,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"963ddef8_691bc317","line":2313,"in_reply_to":"b73824e8_34726c26","updated":"2026-08-06 03:26:08.000000000","message":"Done","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"}],"openstack/block_storage/v3/group.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3d3721748adc07716fc52f82f7f7682c394b94c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\")"},{"line_number":58,"context_line":"    volumes \u003d resource.Body(\"volumes\", type\u003dlist)"},{"line_number":59,"context_line":"    volume_types \u003d resource.Body(\"volume_types\", type\u003dlist)"},{"line_number":60,"context_line":"    add_volumes \u003d resource.Body(\"add_volumes\")"},{"line_number":61,"context_line":"    remove_volumes \u003d resource.Body(\"remove_volumes\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    _max_microversion \u003d \"3.38\""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b6f17afa_46a9b153","line":61,"range":{"start_line":60,"start_character":0,"end_line":61,"end_character":52},"updated":"2026-08-05 10:12:16.000000000","message":"Note to self: these are the only essential changes","commit_id":"acaf105b047a850271e1f9698f25db1230e9ad56"}]}