)]}'
{"id":"openstack%2Fos-apply-config~688317","triplet_id":"openstack%2Fos-apply-config~master~I763567667ce5c8d4f30032c9bfde85ee7bda1754","project":"openstack/os-apply-config","branch":"master","hashtags":[],"change_id":"I763567667ce5c8d4f30032c9bfde85ee7bda1754","subject":"Avoid overwriting existing value","status":"ABANDONED","created":"2019-10-14 00:59:07.000000000","updated":"2019-10-17 01:26:11.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"747671c3c4500667bcbf61551664210b4006cb0a","_number":688317,"virtual_id_number":688317,"owner":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-10-15 02:18:25.000000000","_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"date":"2019-10-15 02:20:38.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-10-14 04:01:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-10-14 04:08:57.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"date":"2019-10-14 01:00:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-14 01:00:35.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2019-10-14 04:01:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-14 04:08:57.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-15 02:18:25.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"}],"messages":[{"id":"cb6ef00d610c29cd1a1a2f2221e9c165c6026dfa","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-10-14 00:59:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a68bdbc6205996f6e00404d1e62f8daef1a0099d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 04:01:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7ce353ff6aa740ca96ff7e00707f4f2a : SUCCESS in 3m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c791cb8246546b3b0bc2f0f9c22fc0a : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/50b573d493ce471eac79f3d443fc70df : SUCCESS in 4m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/153d4d76a9f14553bbfaf1bf3953bed3 : SUCCESS in 5m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f70b9afb19fa40df9250631102db343d : SUCCESS in 5m 52s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f8594ef1926f479a979b9bb0fcb77378 : SUCCESS in 5m 00s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/5c4c8782799c43feb4414752c4dfe811 : SUCCESS in 2h 44m 59s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/c6c1e74ab44145259e8a1a26cc82862d : SUCCESS in 2h 02m 36s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/765aee2a94c24c11906c2c6500d2e8c7 : SUCCESS in 2h 09m 30s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/70022262a2d241da80025c18732852f0 : SUCCESS in 2h 07m 01s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/f127cd9f16954e99a52bc8009368e783 : SUCCESS in 2h 08m 53s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/bad0a63d8ea8433189bc61e178416cf7 : FAILURE in 1h 42m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4ec17056ea257a756c52cc85cc16aae5319f3bb6","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-14 04:08:57.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/17/688317/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/de972ab/ : SUCCESS in 3h 08m 37s","accounts_in_message":[],"_revision_number":1},{"id":"d63617f9f0fedef0bb22269f847328214f703033","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-10-15 02:18:25.000000000","message":"Patch Set 1:\n\nThis looks plausible, but I\u0027m not clear enough on what exactly is getting merged here to know whether this is correct and what problem it solves.\n\nClearly this doesn\u0027t leave any way for a later config with an empty value to override an earlier one... but that may be fine.","accounts_in_message":[],"_revision_number":1},{"id":"98f98fa40b86b0330085a77a4f045b5a9aff8d6e","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-10-15 02:20:38.000000000","message":"Patch Set 1:\n\nThanks, Zane. I will add more information later about this.","accounts_in_message":[],"_revision_number":1},{"id":"747671c3c4500667bcbf61551664210b4006cb0a","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-10-17 01:26:11.000000000","message":"Abandoned\n\nAfter chatted with stevebaker, I understand that the current behivour is deliberate. So abandon it now.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"97c0e9a2f13ec135de24c7a632656136e80c4b53","revisions":{"97c0e9a2f13ec135de24c7a632656136e80c4b53":{"kind":"REWORK","_number":1,"created":"2019-10-14 00:59:07.000000000","uploader":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"ref":"refs/changes/17/688317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-apply-config","ref":"refs/changes/17/688317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-apply-config refs/changes/17/688317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-apply-config refs/changes/17/688317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-apply-config refs/changes/17/688317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-apply-config refs/changes/17/688317/1"}}},"commit":{"parents":[{"commit":"45d999508849137c13eeab63bbec269df232758b","subject":"Blacklist sphinx 2.1.0 (autodoc bug)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-apply-config/commit/45d999508849137c13eeab63bbec269df232758b"}]}],"author":{"name":"Feilong Wang","email":"flwang@catalyst.net.nz","date":"2019-10-13 23:27:15.000000000","tz":780},"committer":{"name":"Feilong Wang","email":"flwang@catalyst.net.nz","date":"2019-10-14 00:59:04.000000000","tz":780},"subject":"Avoid overwriting existing value","message":"Avoid overwriting existing value\n\nWhen doing merge configs, we should avoid overwriting existing value,\nif the new value in the new config is empty, such as [].\n\nChange-Id: I763567667ce5c8d4f30032c9bfde85ee7bda1754\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-apply-config/commit/97c0e9a2f13ec135de24c7a632656136e80c4b53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-apply-config/commit/97c0e9a2f13ec135de24c7a632656136e80c4b53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}