)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"8f5f8efb6cbfe73a7bf9b30f738e3ccf4c43cece","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d0bb5c3_88f518e1","updated":"2026-10-02 15:01:01.000000000","message":"I\u0027m wondering if this change could cause the inverse problem whereby an arg that was being swallowed now isn\u0027t swallowed and will break something?","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"6348327161aff4c816d21e290a167659f4cfa2dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00f0604c_7b046bc0","updated":"2026-10-02 16:43:50.000000000","message":"Moving to a neutral review, as my comments are provided.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"f052e5f402004ff5980a87991b7fd435f875069f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f2b46a8_c45725a8","in_reply_to":"3d337521_e376dcf5","updated":"2026-10-02 16:56:30.000000000","message":"Yeah, I think a release note is the solution here.\n\nI\u0027m not sure it requires a major version bump given your searches, but at the very least I think the release note is warranted.  Will +2 once you have it.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"c9fd8ddb5e2321fd313460edc8f7673ecefcbaed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2359c3f6_fe6591f0","in_reply_to":"3f2b46a8_c45725a8","updated":"2026-10-02 17:10:49.000000000","message":"Perfect, ty!","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"0a47ee4e5f68c3afa091280e2e398756992500f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8117caa_c4354494","in_reply_to":"8d0bb5c3_88f518e1","updated":"2026-10-02 15:01:19.000000000","message":"unresolving for visibility.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"22efbc319224f373acd806cd400c84d61479b0cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d337521_e376dcf5","in_reply_to":"95899ced_55da7c50","updated":"2026-10-02 16:50:38.000000000","message":"I am really not concerned that this will happen. Looking at [codesearch.o.o](https://codesearch.opendev.org/?q\u003d%5CbCacheManager%5Cb\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d), I see no users of this functionality in OpenStack. I am also unable to find any [on GitHub](https://github.com/search?q\u003d%22caches.CacheManager%22+language%3APython\u0026type\u003dcode\u0026l\u003dPython) ([alt](https://github.com/search?q\u003d%22from+os_brick+import+caches%22+language%3APython\u0026type\u003dcode), [alt](https://github.com/search?q\u003d%22from+os_brick.caches%22+language%3APython\u0026type\u003dcode)).\n\nHowever, would a major version bump and a release note help? That would signal the break to external users via SemVer.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"daa4ebb45e5faf0cc631ed5548295773ec84b968","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95899ced_55da7c50","in_reply_to":"c4420af6_5147c25c","updated":"2026-10-02 16:41:26.000000000","message":"Right, but I\u0027m worried that this could cause breakage where there was not breakage before.  It\u0027s one thing to have existing breakage that one doesn\u0027t know about because an expected value is not being provided, but it\u0027s a different thing to cause new breakage where a value that was previously being ignored is now not being ignored.\n\nI guess I see the commit message as belonging to the first category, but I\u0027m concerned about the second category.\n\nI\u0027m not opposed to +2 this patch if there\u0027s another core that disagrees with me here, so I\u0027m not looking to force a change or anything.  Just trying to make sure we aren\u0027t causing different problems.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcb031a2a0e406a183faedf71e598d7f4541e71c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4420af6_5147c25c","in_reply_to":"f8117caa_c4354494","updated":"2026-10-02 16:36:13.000000000","message":"This is unlikely (I would wager it will never happen), but I nonetheless called this scenario out in the commit message:\n\n\u003e This meant users could inadvertently pass arguments as *args when they\n\u003e really needed to passed as **kwargs and the args would be silently swallowed.\n\nPut another way, if there were users doing this (which there aren\u0027t) we are doing them a favour by letting them know that e.g the cache option they thought they were enabling is not actually a thing.","commit_id":"9dff35c7e33b24f3eb53e109cb15a68c81584da8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1ef3dcd2c5f866ffd3d6b3b406225781ea4cd22d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81d0b505_c7f84674","updated":"2026-10-02 17:10:30.000000000","message":"LGTM","commit_id":"19ab85a7be1c56675bb45c2e465ecd9a9c86684b"}]}