)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89933fd7_dc6cf2fe","updated":"2026-10-12 13:37:45.000000000","message":"Thanks for starting this. Design-level feedback first, since it affects the naming of the connection-properties contract and the Cinder side:\n\n  * nvme-cli 3.0 (Sep 2026) renamed the protocol to KX-HMAC-CHAP. gen-dhchap-key / check-dhchap-key are now deprecated aliases that warn on stderr and are slated for removal in 4.0. The kernel ABI (dhchap_secret, dhchap_ctrl_secret) and the -S / -C connect options are unchanged. I\u0027d suggest keeping \"dh\" out of the long-lived os-brick API names and not shelling out for key generation at all (details inline).\n  * The secret ends up in plain text in several log lines (inline).\n  * The positional insertion in `Target.init` breaks `TargetTestCase.test_factory` and `test_init`, and the new test class references a fixture that does not exist, so all 16 new tests fail in setUp.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":63,"context_line":"HOST_NQN \u003d \u0027host_nqn\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# DH-HMAC-CHAP authentication parameters"},{"line_number":66,"context_line":"DHCHAP_SECRET \u003d \u0027dhchap_secret\u0027"},{"line_number":67,"context_line":"DHCHAP_CTRL_SECRET \u003d \u0027dhchap_ctrl_secret\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Present in the new new connection info format"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0376145_c3006e39","line":66,"updated":"2026-10-12 13:37:45.000000000","message":"These two constants are never used (the factory relies on kwargs). Either use them or drop them.\n\nOn the names themselves: nvme-cli 3.0 renamed the user-facing protocol to KX-HMAC-CHAP, so \"dhchap\" is already the legacy spelling. These keys become a long-lived contract between Cinder drivers, Nova and os-brick, so I\u0027d prefer a protocol-neutral name, e.g. `auth_host_secret` / `auth_ctrl_secret` (mirrors the iSCSI `auth_*` family). Keep the \"secret\" suffix`.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":315,"context_line":"                volume_nguid: Optional[str] \u003d None,"},{"line_number":316,"context_line":"                ns_id: Optional[str] \u003d None,"},{"line_number":317,"context_line":"                host_nqn: Optional[str] \u003d None,"},{"line_number":318,"context_line":"                dhchap_secret: Optional[str] \u003d None,"},{"line_number":319,"context_line":"                dhchap_ctrl_secret: Optional[str] \u003d None,"},{"line_number":320,"context_line":"                find_controllers\u003dFalse,"},{"line_number":321,"context_line":"                **ignore) -\u003e \u0027Target\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bc9bad8_f7cbaeef","line":318,"updated":"2026-10-12 13:37:45.000000000","message":"Inserting these before find_controllers changes the positional signature. TargetTestCase.test_factory now fails on arity, and test_init passes find_controllers\u003dTrue into dhchap_secret so set_portals_controllers is never called. Please add the new parameters after find_controllers or make them keyword-only, and pass them by keyword from factory.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":337,"context_line":"                 nguid: Optional[str] \u003d None,"},{"line_number":338,"context_line":"                 ns_id: Optional[str] \u003d None,"},{"line_number":339,"context_line":"                 host_nqn\u003dNone,"},{"line_number":340,"context_line":"                 dhchap_secret: Optional[str] \u003d None,"},{"line_number":341,"context_line":"                 dhchap_ctrl_secret: Optional[str] \u003d None,"},{"line_number":342,"context_line":"                 find_controllers\u003dFalse) -\u003e None:"},{"line_number":343,"context_line":"        \"\"\"Initialize instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"c037cb7f_f68566ab","line":340,"updated":"2026-10-12 13:37:45.000000000","message":"same as line 318","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":348,"context_line":"        The find_controllers parameter controls the search of the controller"},{"line_number":349,"context_line":"        names in the system for each of the portals."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        DH-HMAC-CHAP authentication credentials can be provided for secure"},{"line_number":352,"context_line":"        connections."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        self.source_conn_props \u003d source_conn_props"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7a5b765_80178c8d","line":351,"updated":"2026-10-12 13:37:45.000000000","message":"Worth stating the expected format here (DHHC-1:\u003chmac\u003e:\u003cbase64\u003e:) and the minimum requirements (kernel 6.0+ with CONFIG_NVME_HOST_AUTH, nvme-cli 2.1+), since driver developers will read this docstring to know what to put in connection_info.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":947,"context_line":"                       \u0027-l\u0027, \u0027-1\u0027]"},{"line_number":948,"context_line":"                if target.host_nqn:"},{"line_number":949,"context_line":"                    cmd.extend([\u0027-q\u0027, target.host_nqn])"},{"line_number":950,"context_line":"                if target.dhchap_secret:"},{"line_number":951,"context_line":"                    cmd.extend([\u0027-S\u0027, target.dhchap_secret])"},{"line_number":952,"context_line":"                if target.dhchap_ctrl_secret:"},{"line_number":953,"context_line":"                    cmd.extend([\u0027-C\u0027, target.dhchap_ctrl_secret])"},{"line_number":954,"context_line":"                try:"},{"line_number":955,"context_line":"                    self.run_nvme_cli(cmd)"},{"line_number":956,"context_line":"                    connected \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"895bee83_7922a99e","line":953,"range":{"start_line":950,"start_character":0,"end_line":953,"end_character":65},"updated":"2026-10-12 13:37:45.000000000","message":"Two problems with the short options:\n\na) Nothing masks them. With \"-S \u003ckey\u003e\" the DHHC-1 string is printed in plain text by processutils (\"Running cmd (subprocess): ...\") in the privsep log, in the ProcessExecutionError text when connect fails, and by run_nvme_cli\u0027s own debug line.\nb) Readers have to look up what -S means.\n\nSuggest passing them as single tokens: \u0027--dhchap-secret\u003d%s\u0027 and \u0027--dhchap-ctrl-secret\u003d%s\u0027. That spelling is accepted by nvme-cli 2.x and 3.x (3.x hides it from --help but does not warn; --kxchap-secret is 3.x only), and oslo\u0027s \"secret\u003d\" mask pattern then redacts the value in every processutils / privsep log line. Please add a comment explaining the choice so nobody later \"modernises\" it to -S or --kxchap-secret.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":1526,"context_line":"        (out, err) \u003d self._execute(\u0027nvme\u0027, *nvme_command, run_as_root\u003dTrue,"},{"line_number":1527,"context_line":"                                   root_helper\u003dself._root_helper,"},{"line_number":1528,"context_line":"                                   check_exit_code\u003dTrue)"},{"line_number":1529,"context_line":"        msg \u003d (\"nvme %(nvme_command)s: stdout\u003d%(out)s stderr\u003d%(err)s\" %"},{"line_number":1530,"context_line":"               {\u0027nvme_command\u0027: nvme_command, \u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":1531,"context_line":"        LOG.debug(\"[!] %s\", msg)"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"        return out, err"},{"line_number":1534,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4c8171ae_f2577dac","line":1531,"range":{"start_line":1529,"start_character":0,"end_line":1531,"end_character":32},"updated":"2026-10-12 13:37:45.000000000","message":"This logs the raw command list with no masking, so even with the long option the key appears here. Wrap msg in strutils.mask_password(), or log a copy of the command with the secret values replaced.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":1543,"context_line":"    # #######  DH-HMAC-CHAP authentication methods ########"},{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":"    @staticmethod"},{"line_number":1546,"context_line":"    def generate_dhchap_key(hmac: Optional[str] \u003d None,"},{"line_number":1547,"context_line":"                           secret: Optional[str] \u003d None) -\u003e Optional[str]:"},{"line_number":1548,"context_line":"        \"\"\"Generate a DH-HMAC-CHAP host key."},{"line_number":1549,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4d3009b5_e06e47f9","line":1546,"updated":"2026-10-12 13:37:45.000000000","message":"I don\u0027t think os-brick should shell out to nvme-cli for this:\n\n  * \u0027nvme gen-dhchap-key\u0027 is a deprecated alias in nvme-cli 3.0. It prints \"WARNING: ... deprecated and will be removed in the next major version\" on stderr, errors out on builds without the keys plugin, and is gone in 4.0.\n  * On nvme-cli 2.x with a non-zero `--hmac` (the Cinder default) it transforms the secret with the LOCAL `/etc/nvme/hostnqn` and fails if that file is missing. A cinder-volume node is usually not an NVMe host, so this fails exactly where Cinder wants to call it. 3.x dropped the transform, so 2.x and 3.x also give different output for the same inputs.\n  * It runs through privsep as root for no reason.\n  * Key generation is a target-side concern; os-brick is the initiator library, and nothing in os-brick calls this.\n\nThe DHHC-1 format is tiny: \"DHHC-1:%02x:\" + base64(secret || CRC32(secret) little-endian) + \":\" with a 32, 48 or 64 byte secret. If a shared helper is wanted it is a few lines of pure Python (secrets.token_bytes, zlib.crc32, base64). Otherwise generate it in Cinder.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"    @staticmethod"},{"line_number":1546,"context_line":"    def generate_dhchap_key(hmac: Optional[str] \u003d None,"},{"line_number":1547,"context_line":"                           secret: Optional[str] \u003d None) -\u003e Optional[str]:"},{"line_number":1548,"context_line":"        \"\"\"Generate a DH-HMAC-CHAP host key."},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        Uses nvme-cli to generate a DH-HMAC-CHAP key for authentication."},{"line_number":1551,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"61738079_9ca18ba6","line":1548,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":1571,"context_line":"            else:"},{"line_number":1572,"context_line":"                LOG.error(\u0027Failed to generate DH-CHAP key: empty output\u0027)"},{"line_number":1573,"context_line":"                return None"},{"line_number":1574,"context_line":"        except Exception as exc:"},{"line_number":1575,"context_line":"            LOG.error(\u0027Failed to generate DH-CHAP key: %s\u0027, exc)"},{"line_number":1576,"context_line":"            return None"},{"line_number":1577,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"16663b1d_cf9006b2","line":1574,"updated":"2026-10-12 13:37:45.000000000","message":"Swallowing every exception into None hides the real failure (missing binary, deprecated-alias error, missing hostnqn) from the caller, which then raises a generic \"Failed to generate\" in Cinder. If this helper stays, let the exception propagate.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":1576,"context_line":"            return None"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"    @staticmethod"},{"line_number":1579,"context_line":"    def check_dhchap_key(key: str) -\u003e bool:"},{"line_number":1580,"context_line":"        \"\"\"Validate a DH-HMAC-CHAP key."},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"        Uses nvme-cli to validate the format of a DH-CHAP key."}],"source_content_type":"text/x-python","patch_set":1,"id":"8d8201f9_22529d6f","line":1579,"updated":"2026-10-12 13:37:45.000000000","message":"Same points as generate_dhchap_key: deprecated alias on 3.x, root for no reason, and the format check (prefix, hmac id 0..3, base64 decode, 36/52/68 byte payload, CRC32 trailer) is trivial in Python. Also unused within os-brick.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"}],"os_brick/tests/initiator/connectors/test_nvmeof.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            None,  # nguid"},{"line_number":372,"context_line":"            None,  # ns_id"},{"line_number":373,"context_line":"            None,  # host_nqn"},{"line_number":374,"context_line":"            False)  # find_controllers"},{"line_number":375,"context_line":"        self.assertIsInstance(res, nvmeof.Target)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c5abd9f_de430dd5","line":374,"updated":"2026-10-12 13:37:45.000000000","message":"Currently fails: the actual call has two extra positional Nones. Goes away if the new params are placed after find_controllers.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":2222,"context_line":"        self.assertEqual(ana_support, self.connector.supports_multipath())"},{"line_number":2223,"context_line":""},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"class TestNVMeOFConnectorDHCHAP(test_base.TestCase):"},{"line_number":2226,"context_line":"    \"\"\"Test DH-HMAC-CHAP authentication functionality.\"\"\""},{"line_number":2227,"context_line":""},{"line_number":2228,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6eccd21_20de5e7f","line":2225,"updated":"2026-10-12 13:37:45.000000000","message":"All 16 tests here fail in setUp: AttributeError: module \u0027os_brick.tests.initiator.test_connector\u0027 has no attribute \u0027my_execute\u0027. Base the class on test_connector.ConnectorTestCase and use execute\u003dself.fake_execute like NVMeOFConnectorTestCase does. With that change the class passes locally.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b124b5f4af79ee2ea2fd64f51d8d475c716c29eb","unresolved":true,"context_lines":[{"line_number":2250,"context_line":"        \"\"\"Test Target initialization with bi-directional DH-CHAP.\"\"\""},{"line_number":2251,"context_line":"        conn_props \u003d {"},{"line_number":2252,"context_line":"            \u0027target_nqn\u0027: TARGET_NQN,"},{"line_number":2253,"context_line":"            \u0027portals\u0027: [(\u002710.0.0.1\u0027, \u00274420\u0027, \u0027tcp\u0027)],"},{"line_number":2254,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"},{"line_number":2255,"context_line":"            \u0027dhchap_secret\u0027: \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2256,"context_line":"            \u0027dhchap_ctrl_secret\u0027: \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"009f2f4c_8e8c2703","line":2253,"updated":"2026-10-12 13:37:45.000000000","message":"Put the DHHC-1 sample strings in module constants (HOST_KEY, CTRL_KEY next to HOST_NQN) and the lines fit.","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2250,"context_line":"        \"\"\"Test Target initialization with bi-directional DH-CHAP.\"\"\""},{"line_number":2251,"context_line":"        conn_props \u003d {"},{"line_number":2252,"context_line":"            \u0027target_nqn\u0027: TARGET_NQN,"},{"line_number":2253,"context_line":"            \u0027portals\u0027: [(\u002710.0.0.1\u0027, \u00274420\u0027, \u0027tcp\u0027)],"},{"line_number":2254,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"},{"line_number":2255,"context_line":"            \u0027dhchap_secret\u0027: \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2256,"context_line":"            \u0027dhchap_ctrl_secret\u0027: \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"56390365_d3c5e12b","line":2253,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2255,"context_line":"            \u0027dhchap_secret\u0027: \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2256,"context_line":"            \u0027dhchap_ctrl_secret\u0027: \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027,"},{"line_number":2257,"context_line":"        }"},{"line_number":2258,"context_line":"        nvme_conn_props \u003d nvmeof.NVMeOFConnProps(conn_props)"},{"line_number":2259,"context_line":"        target \u003d nvme_conn_props.targets[0]"},{"line_number":2260,"context_line":""},{"line_number":2261,"context_line":"        self.assertEqual(\u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"156b6bf2_f2dc7a63","line":2258,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2265,"context_line":""},{"line_number":2266,"context_line":"    def test_target_factory_with_dhchap(self):"},{"line_number":2267,"context_line":"        \"\"\"Test Target.factory with DH-CHAP parameters.\"\"\""},{"line_number":2268,"context_line":"        conn_props \u003d {"},{"line_number":2269,"context_line":"            \u0027target_nqn\u0027: TARGET_NQN,"},{"line_number":2270,"context_line":"            \u0027portals\u0027: [(\u002710.0.0.1\u0027, \u00274420\u0027, \u0027tcp\u0027)],"},{"line_number":2271,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"950bb6df_7bde8e30","line":2268,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"    def test_target_factory_with_dhchap(self):"},{"line_number":2267,"context_line":"        \"\"\"Test Target.factory with DH-CHAP parameters.\"\"\""},{"line_number":2268,"context_line":"        conn_props \u003d {"},{"line_number":2269,"context_line":"            \u0027target_nqn\u0027: TARGET_NQN,"},{"line_number":2270,"context_line":"            \u0027portals\u0027: [(\u002710.0.0.1\u0027, \u00274420\u0027, \u0027tcp\u0027)],"},{"line_number":2271,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"},{"line_number":2272,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa588e6_f33d3b04","line":2269,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2271,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"},{"line_number":2272,"context_line":"        }"},{"line_number":2273,"context_line":"        nvme_conn_props \u003d nvmeof.NVMeOFConnProps(conn_props)"},{"line_number":2274,"context_line":""},{"line_number":2275,"context_line":"        target \u003d nvmeof.Target.factory("},{"line_number":2276,"context_line":"            source_conn_props\u003dnvme_conn_props,"},{"line_number":2277,"context_line":"            target_nqn\u003dTARGET_NQN,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d404f803_a94cd9c8","line":2274,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"        nvme_conn_props \u003d nvmeof.NVMeOFConnProps(conn_props)"},{"line_number":2274,"context_line":""},{"line_number":2275,"context_line":"        target \u003d nvmeof.Target.factory("},{"line_number":2276,"context_line":"            source_conn_props\u003dnvme_conn_props,"},{"line_number":2277,"context_line":"            target_nqn\u003dTARGET_NQN,"},{"line_number":2278,"context_line":"            portals\u003d[(\u002710.0.0.1\u0027, \u00274420\u0027, \u0027tcp\u0027)],"},{"line_number":2279,"context_line":"            vol_uuid\u003dVOL_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba56bdfd_667fef4a","line":2276,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2290,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027set_portals_controllers\u0027)"},{"line_number":2291,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027run_nvme_cli\u0027)"},{"line_number":2292,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027rescan\u0027)"},{"line_number":2293,"context_line":"    @mock.patch.object(nvmeof.Portal, \u0027state\u0027, new_callable\u003dmock.PropertyMock)"},{"line_number":2294,"context_line":"    def test__connect_target_with_dhchap_secret("},{"line_number":2295,"context_line":"            self, mock_state, mock_rescan, mock_cli, mock_set_ctrls,"},{"line_number":2296,"context_line":"            mock_find_dev):"}],"source_content_type":"text/x-python","patch_set":1,"id":"57814175_e48c6ab1","line":2293,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (88 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2291,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027run_nvme_cli\u0027)"},{"line_number":2292,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027rescan\u0027)"},{"line_number":2293,"context_line":"    @mock.patch.object(nvmeof.Portal, \u0027state\u0027, new_callable\u003dmock.PropertyMock)"},{"line_number":2294,"context_line":"    def test__connect_target_with_dhchap_secret("},{"line_number":2295,"context_line":"            self, mock_state, mock_rescan, mock_cli, mock_set_ctrls,"},{"line_number":2296,"context_line":"            mock_find_dev):"},{"line_number":2297,"context_line":"        \"\"\"Test connect with DH-CHAP host secret.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9e973662_e2effa98","line":2294,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (89 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2294,"context_line":"    def test__connect_target_with_dhchap_secret("},{"line_number":2295,"context_line":"            self, mock_state, mock_rescan, mock_cli, mock_set_ctrls,"},{"line_number":2296,"context_line":"            mock_find_dev):"},{"line_number":2297,"context_line":"        \"\"\"Test connect with DH-CHAP host secret.\"\"\""},{"line_number":2298,"context_line":"        mock_state.side_effect \u003d [None]"},{"line_number":2299,"context_line":"        dev_path \u003d \u0027/dev/nvme0n1\u0027"},{"line_number":2300,"context_line":"        mock_find_dev.return_value \u003d dev_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5d9d590_7539d60d","line":2297,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2296,"context_line":"            mock_find_dev):"},{"line_number":2297,"context_line":"        \"\"\"Test connect with DH-CHAP host secret.\"\"\""},{"line_number":2298,"context_line":"        mock_state.side_effect \u003d [None]"},{"line_number":2299,"context_line":"        dev_path \u003d \u0027/dev/nvme0n1\u0027"},{"line_number":2300,"context_line":"        mock_find_dev.return_value \u003d dev_path"},{"line_number":2301,"context_line":""},{"line_number":2302,"context_line":"        conn_props \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"84de4766_dbe930be","line":2299,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2316,"context_line":"        mock_cli.assert_called_once_with(["},{"line_number":2317,"context_line":"            \u0027connect\u0027, \u0027-a\u0027, portal.address, \u0027-s\u0027, portal.port, \u0027-t\u0027,"},{"line_number":2318,"context_line":"            portal.transport, \u0027-n\u0027, target.nqn, \u0027-Q\u0027, \u0027128\u0027, \u0027-l\u0027, \u0027-1\u0027,"},{"line_number":2319,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027])"},{"line_number":2320,"context_line":""},{"line_number":2321,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027find_device\u0027)"},{"line_number":2322,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027set_portals_controllers\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d057415_54954536","line":2319,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027])"},{"line_number":2320,"context_line":""},{"line_number":2321,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027find_device\u0027)"},{"line_number":2322,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027set_portals_controllers\u0027)"},{"line_number":2323,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027run_nvme_cli\u0027)"},{"line_number":2324,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027rescan\u0027)"},{"line_number":2325,"context_line":"    @mock.patch.object(nvmeof.Portal, \u0027state\u0027, new_callable\u003dmock.PropertyMock)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb40b6fe_25c5a8ee","line":2322,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2329,"context_line":"        \"\"\"Test connect with bi-directional DH-CHAP.\"\"\""},{"line_number":2330,"context_line":"        mock_state.side_effect \u003d [None]"},{"line_number":2331,"context_line":"        dev_path \u003d \u0027/dev/nvme0n1\u0027"},{"line_number":2332,"context_line":"        mock_find_dev.return_value \u003d dev_path"},{"line_number":2333,"context_line":""},{"line_number":2334,"context_line":"        conn_props \u003d {"},{"line_number":2335,"context_line":"            \u0027target_nqn\u0027: TARGET_NQN,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2162dfb1_851b167b","line":2332,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2348,"context_line":"        portal \u003d target.portals[0]"},{"line_number":2349,"context_line":"        mock_cli.assert_called_once_with(["},{"line_number":2350,"context_line":"            \u0027connect\u0027, \u0027-a\u0027, portal.address, \u0027-s\u0027, portal.port, \u0027-t\u0027,"},{"line_number":2351,"context_line":"            portal.transport, \u0027-n\u0027, target.nqn, \u0027-Q\u0027, \u0027128\u0027, \u0027-l\u0027, \u0027-1\u0027,"},{"line_number":2352,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2353,"context_line":"            \u0027-C\u0027, \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027])"},{"line_number":2354,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"03147a3a_1c0854f6","line":2351,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2349,"context_line":"        mock_cli.assert_called_once_with(["},{"line_number":2350,"context_line":"            \u0027connect\u0027, \u0027-a\u0027, portal.address, \u0027-s\u0027, portal.port, \u0027-t\u0027,"},{"line_number":2351,"context_line":"            portal.transport, \u0027-n\u0027, target.nqn, \u0027-Q\u0027, \u0027128\u0027, \u0027-l\u0027, \u0027-1\u0027,"},{"line_number":2352,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2353,"context_line":"            \u0027-C\u0027, \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027])"},{"line_number":2354,"context_line":""},{"line_number":2355,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027find_device\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9157b4a6_0c92eca7","line":2352,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2352,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027,"},{"line_number":2353,"context_line":"            \u0027-C\u0027, \u0027DHHC-1:00:J76xRTrGuh8D6XKdYFrh48EvTaFe7VGaEgr3n7iBb+QI:\u0027])"},{"line_number":2354,"context_line":""},{"line_number":2355,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027find_device\u0027)"},{"line_number":2356,"context_line":"    @mock.patch.object(nvmeof.Target, \u0027set_portals_controllers\u0027)"},{"line_number":2357,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027run_nvme_cli\u0027)"},{"line_number":2358,"context_line":"    @mock.patch.object(nvmeof.NVMeOFConnector, \u0027rescan\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"240d30ad_c332d126","line":2355,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"            mock_find_dev):"},{"line_number":2363,"context_line":"        \"\"\"Test connect with both host NQN and DH-CHAP.\"\"\""},{"line_number":2364,"context_line":"        mock_state.side_effect \u003d [None]"},{"line_number":2365,"context_line":"        dev_path \u003d \u0027/dev/nvme0n1\u0027"},{"line_number":2366,"context_line":"        mock_find_dev.return_value \u003d dev_path"},{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"        conn_props \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcbb093f_d4ad6328","line":2365,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"        mock_cli.assert_called_once_with(["},{"line_number":2384,"context_line":"            \u0027connect\u0027, \u0027-a\u0027, portal.address, \u0027-s\u0027, portal.port, \u0027-t\u0027,"},{"line_number":2385,"context_line":"            portal.transport, \u0027-n\u0027, target.nqn, \u0027-Q\u0027, \u0027128\u0027, \u0027-l\u0027, \u0027-1\u0027,"},{"line_number":2386,"context_line":"            \u0027-q\u0027, HOST_NQN,"},{"line_number":2387,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027])"},{"line_number":2388,"context_line":""},{"line_number":2389,"context_line":"    def test_replicated_volume_with_dhchap(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fea55de3_7e8fbba0","line":2386,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2386,"context_line":"            \u0027-q\u0027, HOST_NQN,"},{"line_number":2387,"context_line":"            \u0027-S\u0027, \u0027DHHC-1:00:ia6zGodOr4SEG0Zzaw398rpY0wqipUWj4jWjUh4HWUz6aQ2n:\u0027])"},{"line_number":2388,"context_line":""},{"line_number":2389,"context_line":"    def test_replicated_volume_with_dhchap(self):"},{"line_number":2390,"context_line":"        \"\"\"Test replicated volume with DH-CHAP authentication.\"\"\""},{"line_number":2391,"context_line":"        conn_props \u003d {"},{"line_number":2392,"context_line":"            \u0027vol_uuid\u0027: VOL_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b5ba055_f7d7df98","line":2389,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"                    \u0027target_nqn\u0027: \u0027fakenqn1\u0027,"},{"line_number":2398,"context_line":"                    \u0027vol_uuid\u0027: VOL_UUID1,"},{"line_number":2399,"context_line":"                    \u0027portals\u0027: [(\u002710.0.0.1\u0027, 4420, \u0027tcp\u0027)],"},{"line_number":2400,"context_line":"                    \u0027dhchap_secret\u0027: \u0027DHHC-1:00:key1:\u0027,"},{"line_number":2401,"context_line":"                },"},{"line_number":2402,"context_line":"                {"},{"line_number":2403,"context_line":"                    \u0027target_nqn\u0027: \u0027fakenqn2\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1578ecdb_45d102cc","line":2400,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2423,"context_line":"        self.assertEqual(\u0027DHHC-1:00:generatedkey:\u0027, key)"},{"line_number":2424,"context_line":"        mock_execute.assert_called_once_with(\u0027nvme\u0027, \u0027gen-dhchap-key\u0027)"},{"line_number":2425,"context_line":""},{"line_number":2426,"context_line":"    @mock.patch.object(priv_rootwrap, \u0027execute\u0027)"},{"line_number":2427,"context_line":"    def test_generate_dhchap_key_with_secret(self, mock_execute):"},{"line_number":2428,"context_line":"        \"\"\"Test generating DH-CHAP key with a secret.\"\"\""},{"line_number":2429,"context_line":"        mock_execute.return_value \u003d (\u0027DHHC-1:00:derivedfromsecret:\\n\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"11402ab8_1c740af3","line":2426,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[{"line_number":2424,"context_line":"        mock_execute.assert_called_once_with(\u0027nvme\u0027, \u0027gen-dhchap-key\u0027)"},{"line_number":2425,"context_line":""},{"line_number":2426,"context_line":"    @mock.patch.object(priv_rootwrap, \u0027execute\u0027)"},{"line_number":2427,"context_line":"    def test_generate_dhchap_key_with_secret(self, mock_execute):"},{"line_number":2428,"context_line":"        \"\"\"Test generating DH-CHAP key with a secret.\"\"\""},{"line_number":2429,"context_line":"        mock_execute.return_value \u003d (\u0027DHHC-1:00:derivedfromsecret:\\n\u0027, \u0027\u0027)"},{"line_number":2430,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3998cd82_17116d1a","line":2427,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3dd8a33b_3f6bf277","line":2523,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19b69672_44255f8c","line":2524,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1789a987_b758cecf","line":2530,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"819fc8d163aa09f04a4c8e812779676e802e0c45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"866ceb4a_06a58d55","line":2532,"updated":"2026-10-12 09:02:40.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"42c1c231327708e5c54e0bf767d97a6d348dc591"}]}
