)]}'
{"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d1c3c31b9f418568e919419677cf8695183c1b39","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027)"},{"line_number":492,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027, return_value\u003dFalse)"},{"line_number":493,"context_line":"    def test_connect_volume_with_not_found_device(self, sleep_mock,"},{"line_number":494,"context_line":"                                                  exists_mock):"},{"line_number":495,"context_line":"        location \u003d \u002710.0.2.15:3260\u0027"},{"line_number":496,"context_line":"        name \u003d \u0027volume-00000001\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_95d175fd","line":493,"updated":"2015-03-19 11:07:38.000000000","message":"Variable names are in wrong order here.","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"987bff33f413b7f9e50cf381556bc49c3c338bcb","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027)"},{"line_number":492,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027, return_value\u003dFalse)"},{"line_number":493,"context_line":"    def test_connect_volume_with_not_found_device(self, sleep_mock,"},{"line_number":494,"context_line":"                                                  exists_mock):"},{"line_number":495,"context_line":"        location \u003d \u002710.0.2.15:3260\u0027"},{"line_number":496,"context_line":"        name \u003d \u0027volume-00000001\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a2a1bdf8","line":493,"in_reply_to":"9a80dd14_95d175fd","updated":"2015-03-19 21:52:14.000000000","message":"Done","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d1c3c31b9f418568e919419677cf8695183c1b39","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                         \u0027iqn.2013-01.ro.com.netapp:node.netapp02\u0027)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(connector.ISCSIConnector,"},{"line_number":549,"context_line":"                       \u0027_get_target_portals_from_iscsiadm_output\u0027)"},{"line_number":550,"context_line":"    @mock.patch.object(connector.ISCSIConnector, \u0027_rescan_iscsi\u0027)"},{"line_number":551,"context_line":"    @mock.patch.object(connector.ISCSIConnector, \u0027_rescan_multipath\u0027)"},{"line_number":552,"context_line":"    @mock.patch.object(host_driver.HostDriver, \u0027get_all_block_devices\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_68118803","line":549,"updated":"2015-03-19 11:07:38.000000000","message":"This mock return_value isn\u0027t set to [[portal, iqn1]] like in previous approach. Is this mock really needed?","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"987bff33f413b7f9e50cf381556bc49c3c338bcb","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                         \u0027iqn.2013-01.ro.com.netapp:node.netapp02\u0027)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(connector.ISCSIConnector,"},{"line_number":549,"context_line":"                       \u0027_get_target_portals_from_iscsiadm_output\u0027)"},{"line_number":550,"context_line":"    @mock.patch.object(connector.ISCSIConnector, \u0027_rescan_iscsi\u0027)"},{"line_number":551,"context_line":"    @mock.patch.object(connector.ISCSIConnector, \u0027_rescan_multipath\u0027)"},{"line_number":552,"context_line":"    @mock.patch.object(host_driver.HostDriver, \u0027get_all_block_devices\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_228ced7f","line":549,"in_reply_to":"9a80dd14_68118803","updated":"2015-03-19 21:52:14.000000000","message":"Yes we need this, as it is used in _discover_iscsi_portals(). Added \"return_value \u003d  [[portal, iqn1]]\"","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d1c3c31b9f418568e919419677cf8695183c1b39","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        multipath_iqn_mock.side_effect \u003d iqns"},{"line_number":573,"context_line":"        get_all_devices_mock.return_value \u003d [dev, \u0027/dev/mapper/md-1\u0027]"},{"line_number":574,"context_line":"        disconnect_mock.side_efect \u003d fake_disconnect_from_iscsi_portal"},{"line_number":575,"context_line":"        fake_property \u003d {\u0027target_portal\u0027: portal,"},{"line_number":576,"context_line":"                         \u0027target_iqn\u0027: iqn1}"},{"line_number":577,"context_line":"        self.connector._disconnect_volume_multipath_iscsi(fake_property,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_08056c79","line":574,"updated":"2015-03-19 11:07:38.000000000","message":"If I understand the logic correctly we can omit that...","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d1c3c31b9f418568e919419677cf8695183c1b39","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        self.connector._disconnect_volume_multipath_iscsi(fake_property,"},{"line_number":578,"context_line":"                                                          \u0027fake/multipath\u0027)"},{"line_number":579,"context_line":"        # Target in use by other mp devices, don\u0027t disconnect"},{"line_number":580,"context_line":"        self.assertEqual([], result)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @mock.patch.object(connector.ISCSIConnector,"},{"line_number":583,"context_line":"                       \u0027_get_target_portals_from_iscsiadm_output\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_88f87c7d","line":580,"updated":"2015-03-19 11:07:38.000000000","message":"... and just call self.assertFalse(disconnect_mock.called) instead of this line.","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"987bff33f413b7f9e50cf381556bc49c3c338bcb","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        self.connector._disconnect_volume_multipath_iscsi(fake_property,"},{"line_number":578,"context_line":"                                                          \u0027fake/multipath\u0027)"},{"line_number":579,"context_line":"        # Target in use by other mp devices, don\u0027t disconnect"},{"line_number":580,"context_line":"        self.assertEqual([], result)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @mock.patch.object(connector.ISCSIConnector,"},{"line_number":583,"context_line":"                       \u0027_get_target_portals_from_iscsiadm_output\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_22e30d35","line":580,"in_reply_to":"9a80dd14_88f87c7d","updated":"2015-03-19 21:52:14.000000000","message":"Thanks, I\u0027ve replaced this with self.assertFalse(disconnect_mock.called).\n\nAnd I\u0027ve also removed other fake_disconnect_from_iscsi_portal\u0027s to disconnect_mock.assert_called_once_with(...).","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d1c3c31b9f418568e919419677cf8695183c1b39","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        disconnect_mock.side_effect \u003d fake_disconnect_from_iscsi_portal"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # Simulate a broken symlink by returning False for os.path.exists(dev)"},{"line_number":637,"context_line":"        exists_mock.return_value \u003d False"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        fake_property \u003d {\u0027target_portal\u0027: portal,"},{"line_number":640,"context_line":"                         \u0027target_iqn\u0027: iqn}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b55bd952","line":637,"updated":"2015-03-19 11:07:38.000000000","message":"This may go to a decorator.","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"987bff33f413b7f9e50cf381556bc49c3c338bcb","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        disconnect_mock.side_effect \u003d fake_disconnect_from_iscsi_portal"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        # Simulate a broken symlink by returning False for os.path.exists(dev)"},{"line_number":637,"context_line":"        exists_mock.return_value \u003d False"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        fake_property \u003d {\u0027target_portal\u0027: portal,"},{"line_number":640,"context_line":"                         \u0027target_iqn\u0027: iqn}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_62d0a553","line":637,"in_reply_to":"9a80dd14_b55bd952","updated":"2015-03-19 21:52:14.000000000","message":"Done","commit_id":"ca3d3af111e7061ddecf6fc9d5708b78b1ef863b"}]}
