)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"40a9328861bb46999561d6a4a2a2671f157d38a7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"driver. Since Nova is moving to use os-brick, I\u0027m including it as"},{"line_number":15,"context_line":"a reference here if needed: https://review.openstack.org/#/c/181941/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"partial-implements blueprint scaleio-cinder-volume-driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bfdb2c015cc0627d341bd6c3e31e2ae27cca3cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_f06457e6","line":17,"updated":"2015-06-19 17:45:37.000000000","message":"Is this the right blueprint, it doesn\u0027t match anything:\n\nhttps://blueprints.launchpad.net/openstack/?searchtext\u003dscaleio-cinder-volume-driver","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fe0e0d144328828383740daf1f613f40c8534b9d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"driver. Since Nova is moving to use os-brick, I\u0027m including it as"},{"line_number":15,"context_line":"a reference here if needed: https://review.openstack.org/#/c/181941/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"partial-implements blueprint scaleio-cinder-volume-driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bfdb2c015cc0627d341bd6c3e31e2ae27cca3cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_1f2bc395","line":17,"in_reply_to":"fa32b979_f06457e6","updated":"2015-06-24 19:16:25.000000000","message":"This is the URL for the blueprint:\n\nhttps://blueprints.launchpad.net/cinder/+spec/scaleio-cinder-volume-driver\n\nBecause the Cinder driver was merged and the blueprint status became implemented, the automated link does\u0027t work any more. I noticed that it happened to other blueprints as well.","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":52,"context_line":"MULTIPATH_ERROR_REGEX \u003d re.compile(\"\\w{3} \\d+ \\d\\d:\\d\\d:\\d\\d \\|.*$\")"},{"line_number":53,"context_line":"OK_STATUS_CODE \u003d 200"},{"line_number":54,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":55,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def _check_multipathd_running(root_helper, enforce_multipath):"},{"line_number":58,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b299ee21","line":55,"updated":"2015-05-27 04:21:05.000000000","message":"If these guys are specific to the ScaleIO connector, they should live in it\u0027s object.","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return True"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_connector_properties(root_helper, my_ip, multipath, enforce_multipath):"},{"line_number":72,"context_line":"    \"\"\"Get the connection properties for all protocols."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_32adfe31","line":70,"updated":"2015-05-27 04:21:05.000000000","message":"I presume you have nothing to fetch for an initiator ?","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":123,"context_line":"                execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":124,"context_line":"                device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":125,"context_line":"                arch\u003dplatform.machine(),"},{"line_number":126,"context_line":"                *args, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Build a Connector object based upon protocol and architecture.\"\"\""},{"line_number":128,"context_line":"        LOG.debug(\"Factory for %(protocol)s on %(arch)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_129322fc","line":125,"updated":"2015-05-27 04:21:05.000000000","message":"Need to add a ScaleIO entry here.","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1286,"context_line":"                                               *args, **kwargs)"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    def find_volume_path(self, volume_id):"},{"line_number":1289,"context_line":"        LOG.info(\"looking for volume %s\" % volume_id)"},{"line_number":1290,"context_line":"        # look for the volume in /dev/disk/by-id directory"},{"line_number":1291,"context_line":"        disk_filename \u003d \"\""},{"line_number":1292,"context_line":"        tries \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d2bb4a74","line":1289,"updated":"2015-05-27 04:21:05.000000000","message":"_LI()","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        # look for the volume in /dev/disk/by-id directory"},{"line_number":1291,"context_line":"        disk_filename \u003d \"\""},{"line_number":1292,"context_line":"        tries \u003d 0"},{"line_number":1293,"context_line":"        while not disk_filename:"},{"line_number":1294,"context_line":"            if (tries \u003e 15):"},{"line_number":1295,"context_line":"                raise exception.NovaException("},{"line_number":1296,"context_line":"                    \"scaleIO volume {0} not found at expected \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f2540622","line":1293,"updated":"2015-05-27 04:21:05.000000000","message":"os_brick has the cinder retries mechanism as well.  You should probably look into using that.  Check out the os_brick.utils file","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                    path \".format(volume_id))"},{"line_number":1298,"context_line":"            by_id_path \u003d \"/dev/disk/by-id\""},{"line_number":1299,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1300,"context_line":"                LOG.warn("},{"line_number":1301,"context_line":"                    \"scaleIO volume {0} not yet found (no directory \\"},{"line_number":1302,"context_line":"                    /dev/disk/by-id yet). Try number: {1} \".format("},{"line_number":1303,"context_line":"                        volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f2a64652","line":1300,"updated":"2015-05-27 04:21:05.000000000","message":"_LW","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1300,"context_line":"                LOG.warn("},{"line_number":1301,"context_line":"                    \"scaleIO volume {0} not yet found (no directory \\"},{"line_number":1302,"context_line":"                    /dev/disk/by-id yet). Try number: {1} \".format("},{"line_number":1303,"context_line":"                        volume_id,"},{"line_number":1304,"context_line":"                        tries))"},{"line_number":1305,"context_line":"                tries \u003d tries + 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_727136e0","line":1302,"updated":"2015-05-27 04:21:05.000000000","message":",","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"                time.sleep(1)"},{"line_number":1307,"context_line":"                continue"},{"line_number":1308,"context_line":"            filenames \u003d os.listdir(by_id_path)"},{"line_number":1309,"context_line":"            LOG.warning("},{"line_number":1310,"context_line":"                \"Files found in {0} path: {1} \".format("},{"line_number":1311,"context_line":"                    by_id_path,"},{"line_number":1312,"context_line":"                    filenames))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_926cb209","line":1309,"updated":"2015-05-27 04:21:05.000000000","message":"_LW","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1329,"context_line":"                    disk_filename,"},{"line_number":1330,"context_line":"                    tries))"},{"line_number":1331,"context_line":"        full_disk_name \u003d by_id_path + \"/\" + disk_filename"},{"line_number":1332,"context_line":"        LOG.warning(\"Full disk name is \" + full_disk_name)"},{"line_number":1333,"context_line":"        return full_disk_name"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"    def _get_client_id(self, server_ip, server_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_923a72e6","line":1332,"updated":"2015-05-27 04:21:05.000000000","message":"_LW","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"                       server_username, server_password, server_token, sdc_ip):"},{"line_number":1337,"context_line":"        request \u003d \"https://\" + server_ip + \":\" + server_port + \\"},{"line_number":1338,"context_line":"            \"/api/types/Client/instances/getByIp::\" + sdc_ip + \"/\""},{"line_number":1339,"context_line":"        LOG.info(\"ScaleIO get client id by ip request: %s\" % request)"},{"line_number":1340,"context_line":"        r \u003d requests.get("},{"line_number":1341,"context_line":"            request,"},{"line_number":1342,"context_line":"            auth\u003d("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_32229eba","line":1339,"updated":"2015-05-27 04:21:05.000000000","message":"_LI and ,","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"                (sdc_ip, sdc_id[\u0027message\u0027]))"},{"line_number":1364,"context_line":"            LOG.error(msg)"},{"line_number":1365,"context_line":"            raise exception.NovaException(data\u003dmsg)"},{"line_number":1366,"context_line":"        LOG.info(\"ScaleIO sdc id is %s\" % sdc_id)"},{"line_number":1367,"context_line":"        return sdc_id"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"    def _get_volume_id(self, server_ip, server_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_92115260","line":1366,"updated":"2015-05-27 04:21:05.000000000","message":"_LI and ,","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"        volname_encoded \u003d urllib.quote(volname, \u0027\u0027)"},{"line_number":1373,"context_line":"        volname_double_encoded \u003d urllib.quote(volname_encoded, \u0027\u0027)"},{"line_number":1374,"context_line":"        LOG.info("},{"line_number":1375,"context_line":"            \"volume name after double encoding is %s \" %"},{"line_number":1376,"context_line":"            volname_double_encoded)"},{"line_number":1377,"context_line":"        request \u003d \"https://\" + server_ip + \":\" + server_port + \\"},{"line_number":1378,"context_line":"            \"/api/types/Volume/instances/getByName::\" + volname_double_encoded"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7216d656","line":1375,"updated":"2015-05-27 04:21:05.000000000","message":"same","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cd5343329c6a18b85653f5e02c9d87de74ef0b98","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"            volname_double_encoded)"},{"line_number":1377,"context_line":"        request \u003d \"https://\" + server_ip + \":\" + server_port + \\"},{"line_number":1378,"context_line":"            \"/api/types/Volume/instances/getByName::\" + volname_double_encoded"},{"line_number":1379,"context_line":"        LOG.info(\"ScaleIO get volume id by name request: %s\" % request)"},{"line_number":1380,"context_line":"        r \u003d requests.get("},{"line_number":1381,"context_line":"            request,"},{"line_number":1382,"context_line":"            auth\u003d("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_12068220","line":1379,"updated":"2015-05-27 04:21:05.000000000","message":"same....etc.","commit_id":"527fe28c2f7c7338c21546edb15f2963b16d7986"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                root_helper\u003droot_helper,"},{"line_number":210,"context_line":"                driver\u003ddriver,"},{"line_number":211,"context_line":"                execute\u003dexecute,"},{"line_number":212,"context_line":"                device_scan_attpempts\u003ddevice_scan_attempts,"},{"line_number":213,"context_line":"                *args, **kwargs"},{"line_number":214,"context_line":"            )"},{"line_number":215,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_40fc9fb7","line":212,"updated":"2015-06-24 19:54:26.000000000","message":"/attpempts/attempts/","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                root_helper\u003droot_helper,"},{"line_number":210,"context_line":"                driver\u003ddriver,"},{"line_number":211,"context_line":"                execute\u003dexecute,"},{"line_number":212,"context_line":"                device_scan_attpempts\u003ddevice_scan_attempts,"},{"line_number":213,"context_line":"                *args, **kwargs"},{"line_number":214,"context_line":"            )"},{"line_number":215,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a9599e5d","line":212,"in_reply_to":"fa32b979_40fc9fb7","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"                raise exception.BrickException(message\u003dmsg)"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_40233f56","line":1528,"updated":"2015-06-24 19:54:26.000000000","message":"LOG.warn is deprecated, please use LOG.warning.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"                raise exception.BrickException(message\u003dmsg)"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2934aef9","line":1528,"in_reply_to":"fa32b979_40233f56","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"},{"line_number":1532,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a0decb3b","line":1529,"updated":"2015-06-24 19:54:26.000000000","message":"Need trailing space at the end so resulting string doesn\u0027t run together.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"            if not os.path.isdir(by_id_path):"},{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"},{"line_number":1532,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c938a2f1","line":1529,"in_reply_to":"fa32b979_a0decb3b","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"},{"line_number":1532,"context_line":"                )"},{"line_number":1533,"context_line":""},{"line_number":1534,"context_line":"                tries +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_60cc4389","line":1531,"updated":"2015-06-24 19:54:26.000000000","message":"Trailing space after {1} not needed.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"                LOG.warn(_LW("},{"line_number":1529,"context_line":"                    \"ScaleIO volume {0} not yet found\""},{"line_number":1530,"context_line":"                    \"(no directory /dev/disk/by-id yet).\""},{"line_number":1531,"context_line":"                    \" Try number: {1} \").format(self.volume_id, tries)"},{"line_number":1532,"context_line":"                )"},{"line_number":1533,"context_line":""},{"line_number":1534,"context_line":"                tries +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_e93d66de","line":1531,"in_reply_to":"fa32b979_60cc4389","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"                continue"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"            filenames \u003d os.listdir(by_id_path)"},{"line_number":1539,"context_line":"            LOG.info(_LI(\"Files found in {0} path: {1} \").format("},{"line_number":1540,"context_line":"                by_id_path, filenames))"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"            for filename in filenames:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c0a3cfb0","line":1539,"updated":"2015-06-24 19:54:26.000000000","message":"Trailing space not needed.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"                continue"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"            filenames \u003d os.listdir(by_id_path)"},{"line_number":1539,"context_line":"            LOG.info(_LI(\"Files found in {0} path: {1} \").format("},{"line_number":1540,"context_line":"                by_id_path, filenames))"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"            for filename in filenames:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_492d72a7","line":1539,"in_reply_to":"fa32b979_c0a3cfb0","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"                    disk_filename \u003d filename"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"            if not disk_filename:"},{"line_number":1548,"context_line":"                LOG.warn("},{"line_number":1549,"context_line":"                    _LW(\"ScaleIO volume {0} not yet found. \""},{"line_number":1550,"context_line":"                        \"Try number: {1}.\").format(self.volume_id, tries)"},{"line_number":1551,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a0ac8b9f","line":1548,"updated":"2015-06-24 19:54:26.000000000","message":"/warn/warning/","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"                    disk_filename \u003d filename"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"            if not disk_filename:"},{"line_number":1548,"context_line":"                LOG.warn("},{"line_number":1549,"context_line":"                    _LW(\"ScaleIO volume {0} not yet found. \""},{"line_number":1550,"context_line":"                        \"Try number: {1}.\").format(self.volume_id, tries)"},{"line_number":1551,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_09168a58","line":1548,"in_reply_to":"fa32b979_a0ac8b9f","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"        volname_encoded \u003d urllib.quote(self.volume_name, \u0027\u0027)"},{"line_number":1601,"context_line":"        volname_double_encoded \u003d urllib.quote(volname_encoded, \u0027\u0027)"},{"line_number":1602,"context_line":"        LOG.info("},{"line_number":1603,"context_line":"            _LI(\"Volume name after double encoding is {} \").format("},{"line_number":1604,"context_line":"                volname_double_encoded"},{"line_number":1605,"context_line":"            )"},{"line_number":1606,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_20be3bae","line":1603,"updated":"2015-06-24 19:54:26.000000000","message":"Trailing space not needed.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"        volname_encoded \u003d urllib.quote(self.volume_name, \u0027\u0027)"},{"line_number":1601,"context_line":"        volname_double_encoded \u003d urllib.quote(volname_encoded, \u0027\u0027)"},{"line_number":1602,"context_line":"        LOG.info("},{"line_number":1603,"context_line":"            _LI(\"Volume name after double encoding is {} \").format("},{"line_number":1604,"context_line":"                volname_double_encoded"},{"line_number":1605,"context_line":"            )"},{"line_number":1606,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c90f4238","line":1603,"in_reply_to":"fa32b979_20be3bae","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5d3188d8c2496979f0cedaeafa3b0278bb90d3d4","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"            \"/getByName::{encoded_volume_name}\""},{"line_number":1611,"context_line":"        ).format(server_ip\u003dself.server_ip,"},{"line_number":1612,"context_line":"                 server_port\u003dself.server_port,"},{"line_number":1613,"context_line":"                 encoded_volume_name\u003dvolname_double_encoded)"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        LOG.info("},{"line_number":1616,"context_line":"            _LI(\"ScaleIO get volume id by name request: {}\").format(request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_d8eadcd7","line":1613,"updated":"2015-06-25 04:24:52.000000000","message":"there is no authentication required to talk to the scaleio array to fetch volume information?!","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"195c9e78f39eee54600e09b1675f12d9bbcbab88","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"            \"/getByName::{encoded_volume_name}\""},{"line_number":1611,"context_line":"        ).format(server_ip\u003dself.server_ip,"},{"line_number":1612,"context_line":"                 server_port\u003dself.server_port,"},{"line_number":1613,"context_line":"                 encoded_volume_name\u003dvolname_double_encoded)"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"        LOG.info("},{"line_number":1616,"context_line":"            _LI(\"ScaleIO get volume id by name request: {}\").format(request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_53d22dd2","line":1613,"in_reply_to":"fa32b979_d8eadcd7","updated":"2015-06-25 05:46:22.000000000","message":"Hi Walt,\n\nThere\u0027s a server_token passed in to \"auth\" on line 1620. So it does authentication. Does this answer your question?","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5d3188d8c2496979f0cedaeafa3b0278bb90d3d4","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"                sdc_ip\u003dself.local_sdc_ip,"},{"line_number":1705,"context_line":"                server_ip\u003dself.server_ip,"},{"line_number":1706,"context_line":"                username\u003dself.server_username,"},{"line_number":1707,"context_line":"                password\u003dself.server_password,"},{"line_number":1708,"context_line":"                iops_limit\u003dself.iops_limit,"},{"line_number":1709,"context_line":"                bandwidth_limit\u003dself.bandwidth_limit"},{"line_number":1710,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_58ac8c9e","line":1707,"updated":"2015-06-25 04:24:52.000000000","message":"are you really sure you want the raw password being logged to a file?","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"                sdc_ip\u003dself.local_sdc_ip,"},{"line_number":1705,"context_line":"                server_ip\u003dself.server_ip,"},{"line_number":1706,"context_line":"                username\u003dself.server_username,"},{"line_number":1707,"context_line":"                password\u003dself.server_password,"},{"line_number":1708,"context_line":"                iops_limit\u003dself.iops_limit,"},{"line_number":1709,"context_line":"                bandwidth_limit\u003dself.bandwidth_limit"},{"line_number":1710,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a9075e1c","line":1707,"in_reply_to":"fa32b979_13002533","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"195c9e78f39eee54600e09b1675f12d9bbcbab88","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"                sdc_ip\u003dself.local_sdc_ip,"},{"line_number":1705,"context_line":"                server_ip\u003dself.server_ip,"},{"line_number":1706,"context_line":"                username\u003dself.server_username,"},{"line_number":1707,"context_line":"                password\u003dself.server_password,"},{"line_number":1708,"context_line":"                iops_limit\u003dself.iops_limit,"},{"line_number":1709,"context_line":"                bandwidth_limit\u003dself.bandwidth_limit"},{"line_number":1710,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_13002533","line":1707,"in_reply_to":"fa32b979_58ac8c9e","updated":"2015-06-25 05:46:22.000000000","message":"Hmm, not a good idea.  The password shouldn\u0027t be logged.  Will remove it.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                                       root_helper\u003dself._root_helper)"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"            LOG.info(_LI(\"map volume {0}: stdout\u003d{1} \""},{"line_number":1721,"context_line":"                         \"stderr\u003d{2}\").format(self.GET_GUID_CMD, out, err))"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":1724,"context_line":"            msg \u003d _(\"Error querying sdc guid: {}\").format(e.stderr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_4057bf57","line":1721,"updated":"2015-06-24 19:54:26.000000000","message":"Format shouldn\u0027t be performed for the log string ahead of time. Instead use %(name)s templating and pass in the format values as parameters to the LOG.info call.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"195c9e78f39eee54600e09b1675f12d9bbcbab88","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                                       root_helper\u003dself._root_helper)"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"            LOG.info(_LI(\"map volume {0}: stdout\u003d{1} \""},{"line_number":1721,"context_line":"                         \"stderr\u003d{2}\").format(self.GET_GUID_CMD, out, err))"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":1724,"context_line":"            msg \u003d _(\"Error querying sdc guid: {}\").format(e.stderr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_33b44980","line":1721,"in_reply_to":"fa32b979_4057bf57","updated":"2015-06-25 05:46:22.000000000","message":"You are right. Will remove formatting. This was actually changed in earlier patch set but got lost some how.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"            raise exception.BrickException(message\u003dmsg)"},{"line_number":1727,"context_line":""},{"line_number":1728,"context_line":"        guid \u003d out"},{"line_number":1729,"context_line":"        LOG.info(_LI(\"Current sdc guid: {}\").format(guid))"},{"line_number":1730,"context_line":"        params \u003d {\u0027guid\u0027: guid, \u0027allowMultipleMappings\u0027: \u0027TRUE\u0027}"},{"line_number":1731,"context_line":"        self.volume_id \u003d self._get_volume_id()"},{"line_number":1732,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c0c98f27","line":1729,"updated":"2015-06-24 19:54:26.000000000","message":"Same.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"            raise exception.BrickException(message\u003dmsg)"},{"line_number":1727,"context_line":""},{"line_number":1728,"context_line":"        guid \u003d out"},{"line_number":1729,"context_line":"        LOG.info(_LI(\"Current sdc guid: {}\").format(guid))"},{"line_number":1730,"context_line":"        params \u003d {\u0027guid\u0027: guid, \u0027allowMultipleMappings\u0027: \u0027TRUE\u0027}"},{"line_number":1731,"context_line":"        self.volume_id \u003d self._get_volume_id()"},{"line_number":1732,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2c027c0a","line":1729,"in_reply_to":"fa32b979_c0c98f27","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"                                                  self.server_port,"},{"line_number":1737,"context_line":"                                                  self.volume_id)"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"        LOG.info(_LI(\"map volume request: {}\").format(request))"},{"line_number":1740,"context_line":"        r \u003d requests.post("},{"line_number":1741,"context_line":"            request,"},{"line_number":1742,"context_line":"            data\u003djson.dumps(params),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a0d24bcf","line":1739,"updated":"2015-06-24 19:54:26.000000000","message":"Same. Looks like several logger calls that format ahead of time.","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"                                                  self.server_port,"},{"line_number":1737,"context_line":"                                                  self.volume_id)"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"        LOG.info(_LI(\"map volume request: {}\").format(request))"},{"line_number":1740,"context_line":"        r \u003d requests.post("},{"line_number":1741,"context_line":"            request,"},{"line_number":1742,"context_line":"            data\u003djson.dumps(params),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_ec0b3423","line":1739,"in_reply_to":"fa32b979_a0d24bcf","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0e2b43ab66598801a43f70b6322eaa86c8d83287","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"        disk_filename \u003d \"\""},{"line_number":1586,"context_line":"        tries \u003d 0"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        while not disk_filename:"},{"line_number":1589,"context_line":"            if tries \u003e self.device_scan_attempts:"},{"line_number":1590,"context_line":"                msg \u003d ("},{"line_number":1591,"context_line":"                    _(\"ScaleIO volume %(volume_id)s not found \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_f76389db","line":1588,"updated":"2015-07-07 22:23:56.000000000","message":"You should probably take a look at the retry mechanism that\u0027s already in utils for managing this.  \n\nhttps://github.com/openstack/os-brick/blob/master/os_brick/utils.py#L25","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4030dc64d31b22ebf63239e7ad7cc315260fe72b","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"        disk_filename \u003d \"\""},{"line_number":1586,"context_line":"        tries \u003d 0"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"        while not disk_filename:"},{"line_number":1589,"context_line":"            if tries \u003e self.device_scan_attempts:"},{"line_number":1590,"context_line":"                msg \u003d ("},{"line_number":1591,"context_line":"                    _(\"ScaleIO volume %(volume_id)s not found \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_dd04387f","line":1588,"in_reply_to":"ba3cc151_f76389db","updated":"2015-07-08 18:04:35.000000000","message":"Done","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f443ee39314dcf949fff81433fb487f3ee9c67a2","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"    def _get_volume_id(self):"},{"line_number":1680,"context_line":"        volname_encoded \u003d urllib.parse.quote(self.volume_name, \u0027\u0027)"},{"line_number":1681,"context_line":"        volname_double_encoded \u003d urllib.parse.quote(volname_encoded, \u0027\u0027)"},{"line_number":1682,"context_line":"        LOG.info(_LI("},{"line_number":1683,"context_line":"            \"Volume name after double encoding is %(volume_name)s.\"),"},{"line_number":1684,"context_line":"            {\u0027volume_name\u0027: volname_double_encoded}"},{"line_number":1685,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_9cfca43f","line":1682,"updated":"2015-07-07 22:16:44.000000000","message":"Seems like this one should probably be a debug level log message. I\u0027m fine if it doesn\u0027t get changed, but consider it if another update is done.","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4030dc64d31b22ebf63239e7ad7cc315260fe72b","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"    def _get_volume_id(self):"},{"line_number":1680,"context_line":"        volname_encoded \u003d urllib.parse.quote(self.volume_name, \u0027\u0027)"},{"line_number":1681,"context_line":"        volname_double_encoded \u003d urllib.parse.quote(volname_encoded, \u0027\u0027)"},{"line_number":1682,"context_line":"        LOG.info(_LI("},{"line_number":1683,"context_line":"            \"Volume name after double encoding is %(volume_name)s.\"),"},{"line_number":1684,"context_line":"            {\u0027volume_name\u0027: volname_double_encoded}"},{"line_number":1685,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_9dfa3076","line":1682,"in_reply_to":"ba3cc151_9cfca43f","updated":"2015-07-08 18:04:35.000000000","message":"Done","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"77d65eca3588b4094512e105e8e19505edda5f64","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        return full_disk_name"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    @utils.retry(exceptions\u003dexception.BrickException,"},{"line_number":1596,"context_line":"                 retries\u003d15,"},{"line_number":1597,"context_line":"                 backoff_rate\u003d1)"},{"line_number":1598,"context_line":"    def _wait_for_volume_path(self, path):"},{"line_number":1599,"context_line":"        if not os.path.isdir(path):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba3cc151_ade81fe3","line":1596,"updated":"2015-07-08 20:46:20.000000000","message":"15 attempts?!  Are you sure you need that many?  That seems a bit excessive ?","commit_id":"d445a016422b308b7f5bb70984bdeb100b765ce1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7ac2ac781d0d8ff678b755e51344cb03ec30f281","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        return full_disk_name"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    @utils.retry(exceptions\u003dexception.BrickException,"},{"line_number":1596,"context_line":"                 retries\u003d15,"},{"line_number":1597,"context_line":"                 backoff_rate\u003d1)"},{"line_number":1598,"context_line":"    def _wait_for_volume_path(self, path):"},{"line_number":1599,"context_line":"        if not os.path.isdir(path):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba3cc151_e595db31","line":1596,"in_reply_to":"ba3cc151_ade81fe3","updated":"2015-07-08 21:59:10.000000000","message":"Added comments in the next patch.  Usually 3 retries is enough.  The max of 15 retries is just to make sure we can find the volume when there are network issues, etc.","commit_id":"d445a016422b308b7f5bb70984bdeb100b765ce1"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fdc368659fabfa70ad9eef17693f9be82f152edf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertEqual(obj.__class__.__name__, \"HuaweiStorHyperConnector\")"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        obj \u003d connector.InitiatorConnector.factory(\"scaleio\", None)"},{"line_number":158,"context_line":"        self.assertEqual(obj.__class__.__name__, \"ScaleIOConnector\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self.assertRaises(ValueError,"},{"line_number":161,"context_line":"                          connector.InitiatorConnector.factory,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c0974fea","line":158,"updated":"2015-06-24 19:54:26.000000000","message":"Existing code this way, but assertEqual parameters should be (expected, actual).","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06c93f7a0e69f76701dd1f8999db46aa862eb6c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertEqual(obj.__class__.__name__, \"HuaweiStorHyperConnector\")"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        obj \u003d connector.InitiatorConnector.factory(\"scaleio\", None)"},{"line_number":158,"context_line":"        self.assertEqual(obj.__class__.__name__, \"ScaleIOConnector\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self.assertRaises(ValueError,"},{"line_number":161,"context_line":"                          connector.InitiatorConnector.factory,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_0948ca89","line":158,"in_reply_to":"fa32b979_c0974fea","updated":"2015-06-25 22:19:52.000000000","message":"Done","commit_id":"9d5aff2ce5018b03db8253331f86f359e8d6a9b9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ffc2c6460a62e92acbce1c09411af21f871ac989","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                         self).text"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"    def fake_execute(self, *cmd, **kwargs):"},{"line_number":1654,"context_line":"        \"\"\"Fakes the rootwrap call\"\"\""},{"line_number":1655,"context_line":"        return self.fake_guid, None"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"    def fake_missing_execute(self, *cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_bd66fb4e","line":1654,"updated":"2015-07-02 14:47:27.000000000","message":"If you do another update, please end the docstring comments with a period.","commit_id":"ad43aeba323c9cf23cca86587aee8e939064a9b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2e068d3eacc62e61c99f1069251cd37b21304b12","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                         self).text"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"    def fake_execute(self, *cmd, **kwargs):"},{"line_number":1654,"context_line":"        \"\"\"Fakes the rootwrap call\"\"\""},{"line_number":1655,"context_line":"        return self.fake_guid, None"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"    def fake_missing_execute(self, *cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6ab88f2a","line":1654,"in_reply_to":"ba3cc151_bd66fb4e","updated":"2015-07-03 01:46:45.000000000","message":"Done","commit_id":"ad43aeba323c9cf23cca86587aee8e939064a9b4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f443ee39314dcf949fff81433fb487f3ee9c67a2","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        self.test_connect_volume()"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    def test_disconnect_volume(self):"},{"line_number":1693,"context_line":"        \"\"\"Successful disconnet from volume\"\"\""},{"line_number":1694,"context_line":"        self.connector.disconnect_volume(self.fake_connection_properties, None)"},{"line_number":1695,"context_line":""},{"line_number":1696,"context_line":"    def test_error_id(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_7c66802a","line":1693,"updated":"2015-07-07 22:16:44.000000000","message":"/disconnet/disconnect/","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4030dc64d31b22ebf63239e7ad7cc315260fe72b","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"        self.test_connect_volume()"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    def test_disconnect_volume(self):"},{"line_number":1693,"context_line":"        \"\"\"Successful disconnet from volume\"\"\""},{"line_number":1694,"context_line":"        self.connector.disconnect_volume(self.fake_connection_properties, None)"},{"line_number":1695,"context_line":""},{"line_number":1696,"context_line":"    def test_error_id(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_1def00b2","line":1693,"in_reply_to":"ba3cc151_7c66802a","updated":"2015-07-08 18:04:35.000000000","message":"Done","commit_id":"c94187c68be123f4a32e52384c7f2cb528f6d5b1"}]}
