)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f2698dd6861f924a73df48cb6ea1d8664cfbe013","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            rbd_handle.seek(original_offset, 0)"},{"line_number":1199,"context_line":"        except Exception as e:"},{"line_number":1200,"context_line":"            LOG.error(_LE(\"Failed to access the device handler: %(error)s\")"},{"line_number":1201,"context_line":"                      % {\"error\": str(e)})"},{"line_number":1202,"context_line":"            return False"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af86dd1_a3e79aab","line":1201,"updated":"2015-06-11 21:29:57.000000000","message":"change the % here to ,\n\n_LE(), {\"error\": \n\nAlso should probably change the str(e) to six.text_type(e)","commit_id":"2ce94db2140cbf69bf0994f4173b6136ce4e1217"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"class RBDConnector(InitiatorConnector):"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":1157,"context_line":"                 execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":1158,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f0c7de95","line":1155,"updated":"2015-06-17 19:11:44.000000000","message":"Please remove these extraneous newlines.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                                           *args, **kwargs)"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"        try:"},{"line_number":1170,"context_line":"            user \u003d connection_properties[\u0027auth_username\u0027]"},{"line_number":1171,"context_line":"            pool, volume \u003d connection_properties[\u0027name\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_90b45235","line":1168,"updated":"2015-06-17 19:11:44.000000000","message":"Please remove these extraneous newlines.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        return {\u0027path\u0027: rbd_handle}"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"    def disconnect_volume(self, connection_properties, device_info):"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        rbd_handle \u003d device_info.get(\u0027path\u0027, None)"},{"line_number":1185,"context_line":"        if rbd_handle is not None:"},{"line_number":1186,"context_line":"            rbd_handle.close()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_50f00afe","line":1183,"updated":"2015-06-17 19:11:44.000000000","message":"Please remove these extraneous newlines.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":1186,"context_line":"            rbd_handle.close()"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    def check_valid_device(self, path, run_as_root\u003dTrue):"},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"        rbd_handle \u003d path"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        if rbd_handle is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_70e50e36","line":1189,"updated":"2015-06-17 19:11:44.000000000","message":"Please remove these extraneous newlines.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bcf524291e5e2ddf99168f658f348ee972b5fe86","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            rbd_handle.read(4096)"},{"line_number":1199,"context_line":"        except Exception as e:"},{"line_number":1200,"context_line":"            LOG.error(_LE(\"Failed to access the device handler: %(error)s\"),"},{"line_number":1201,"context_line":"                      {\"error\": six.text_type(e)})"},{"line_number":1202,"context_line":"            return False"},{"line_number":1203,"context_line":"        finally:"},{"line_number":1204,"context_line":"            rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_49c38e57","line":1201,"updated":"2015-06-17 16:50:12.000000000","message":"six.text_type not needed here, please remove.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"64ec7fce2d17e6829e22c282d39061cd4e5360b0","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            rbd_handle.read(4096)"},{"line_number":1199,"context_line":"        except Exception as e:"},{"line_number":1200,"context_line":"            LOG.error(_LE(\"Failed to access the device handler: %(error)s\"),"},{"line_number":1201,"context_line":"                      {\"error\": six.text_type(e)})"},{"line_number":1202,"context_line":"            return False"},{"line_number":1203,"context_line":"        finally:"},{"line_number":1204,"context_line":"            rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_c93d5ede","line":1201,"in_reply_to":"fa32b979_49c38e57","updated":"2015-06-17 16:52:48.000000000","message":"does _LE do the six.text_type(var) internally before translating it?","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"46ca3b57b23780fcf52d296098be89fb22e03b81","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            rbd_handle.read(4096)"},{"line_number":1199,"context_line":"        except Exception as e:"},{"line_number":1200,"context_line":"            LOG.error(_LE(\"Failed to access the device handler: %(error)s\"),"},{"line_number":1201,"context_line":"                      {\"error\": six.text_type(e)})"},{"line_number":1202,"context_line":"            return False"},{"line_number":1203,"context_line":"        finally:"},{"line_number":1204,"context_line":"            rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_84941b43","line":1201,"in_reply_to":"fa32b979_c93d5ede","updated":"2015-06-17 17:02:21.000000000","message":"No, the translation markers don\u0027t have anything to do with it. The logger will actually take care of it internally.\n\nSo for any logger call that does LOG.blah(FORMAT_STRING % ex) there is an issue because the string formatting is happening first, then being passed in to the logger. In that case you need six.text_type.\n\nBut if it is LOG.blah(FORMAT_STRING, ex) then ex is just passed in as an argument to the logger and the logger can take care of it if and when it needs to.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"}],"os_brick/initiator/linuxrbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4b04d315585e12330806fa82c9f2f95af61ef827","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.rbd \u003d kwargs.get(\u0027rbd\u0027, rbd)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.rbd_conf \u003d kwargs.get(\u0027conffile\u0027, CONFFILE)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.client, self.ioctx \u003d self.connect()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def connect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_e4b91aee","line":48,"updated":"2015-06-04 18:54:40.000000000","message":"I think this will blow up in a messy way if the rados import failed.  Probably need to check that in here and do something sane rather than attempting to call connect().  (Not entirely sure what is sane in this case...)","commit_id":"ba68ee6365766e61ba17057fa48c6662a05128a6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4b04d315585e12330806fa82c9f2f95af61ef827","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            LOG.exception(msg)"},{"line_number":63,"context_line":"            # shutdown cannot raise an exception"},{"line_number":64,"context_line":"            client.shutdown()"},{"line_number":65,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def disconnect(self):"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_842a662b","line":65,"updated":"2015-06-04 18:54:40.000000000","message":"This exception doesn\u0027t exist in os-brick.","commit_id":"ba68ee6365766e61ba17057fa48c6662a05128a6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4b04d315585e12330806fa82c9f2f95af61ef827","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if (offset + length) \u003e total:"},{"line_number":135,"context_line":"            length \u003d total - offset"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self._inc_offset(length)"},{"line_number":138,"context_line":"        return self._rbd_volume.image.read(int(offset), int(length))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def write(self, data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_e487da10","line":137,"updated":"2015-06-04 18:54:40.000000000","message":"If the image.read() fails, your self._offset is now wrong, and very strange things will happen.","commit_id":"ba68ee6365766e61ba17057fa48c6662a05128a6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f08eb89a81492c1eae771eee776137a553043c29","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        if (offset + length) \u003e total:"},{"line_number":142,"context_line":"            length \u003d total - offset"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._inc_offset(length)"},{"line_number":145,"context_line":"        return self._rbd_volume.image.read(int(offset), int(length))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def write(self, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_407a84be","line":144,"updated":"2020-11-23 14:25:37.000000000","message":"If image.read() fails here, self._offset is inconsistent and subsequent seek/read/write operations won\u0027t be done correctly.","commit_id":"2ce94db2140cbf69bf0994f4173b6136ce4e1217"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"10fe643533d4cce19c87d812594775abfe6b0242","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        if (offset + length) \u003e total:"},{"line_number":142,"context_line":"            length \u003d total - offset"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._inc_offset(length)"},{"line_number":145,"context_line":"        return self._rbd_volume.image.read(int(offset), int(length))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def write(self, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a896a6ad_a9447b44","line":144,"in_reply_to":"3afb71cf_407a84be","updated":"2020-11-23 21:59:59.000000000","message":"Good eye.  https://review.opendev.org/c/openstack/os-brick/+/763867","commit_id":"2ce94db2140cbf69bf0994f4173b6136ce4e1217"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"11a0ae7f3e75ba92644419dff915e559b87eb59d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            LOG.exception(msg)"},{"line_number":68,"context_line":"            # shutdown cannot raise an exception"},{"line_number":69,"context_line":"            client.shutdown()"},{"line_number":70,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def disconnect(self):"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af86dd1_36b982ea","line":70,"updated":"2015-06-12 17:22:21.000000000","message":"message\u003dmsg","commit_id":"e737a8dcdd335bbfcb8c94c3ffb270a83409ae78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bcf524291e5e2ddf99168f658f348ee972b5fe86","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONFFILE \u003d \u0027/etc/ceph/ceph.conf\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class RBDClient(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_e9b702d6","line":31,"updated":"2015-06-17 16:50:12.000000000","message":"This is only used in one place. Do we really need a constant for this?","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class RBDClient(object):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, user, pool, *args, **kwargs):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.rbd_user \u003d encodeutils.safe_encode(user)"},{"line_number":39,"context_line":"        self.rbd_pool \u003d encodeutils.safe_encode(pool)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_70bc2e06","line":37,"updated":"2015-06-17 19:11:44.000000000","message":"Please remove these extraneous newlines.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.client, self.ioctx \u003d self.connect()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def connect(self):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        client \u003d self.rados.Rados(rados_id\u003dself.rbd_user,"},{"line_number":59,"context_line":"                                  conffile\u003dself.rbd_conf)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_90b9b217","line":57,"updated":"2015-06-17 19:11:44.000000000","message":"Ditto","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            raise exception.BrickException(message\u003dmsg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def disconnect(self):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # closing an ioctx cannot raise an exception"},{"line_number":75,"context_line":"        self.ioctx.close()"},{"line_number":76,"context_line":"        self.client.shutdown()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3039c6a4","line":73,"updated":"2015-06-17 19:11:44.000000000","message":"Ditto","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fabdf7da8b50517561372ad55dc66056d3a493b3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\"Context manager for dealing with an existing rbd volume.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def __init__(self, client, name, snapshot\u003dNone, read_only\u003dFalse):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if snapshot is not None:"},{"line_number":85,"context_line":"            snapshot \u003d encodeutils.safe_encode(snapshot)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_503eca8c","line":83,"updated":"2015-06-17 19:11:44.000000000","message":"Ditto","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"}],"os_brick/tests/initiator/test_linuxrbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bcf524291e5e2ddf99168f658f348ee972b5fe86","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def test_init(self):"},{"line_number":31,"context_line":"        self.assertEqual(self.mock_volume_wrapper._rbd_volume,"},{"line_number":32,"context_line":"                         self.mock_volume)"},{"line_number":33,"context_line":"        self.assertEqual(self.mock_volume_wrapper._offset, 0)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_inc_offset(self):"},{"line_number":36,"context_line":"        self.mock_volume_wrapper._inc_offset(10)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_29e3aaa5","line":33,"updated":"2015-06-17 16:50:12.000000000","message":"Should be (EXPECTED, ACTUAL).","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bcf524291e5e2ddf99168f658f348ee972b5fe86","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            self.mock_volume_wrapper.flush()"},{"line_number":113,"context_line":"            self.mock_volume.image.flush.assert_called_once_with()"},{"line_number":114,"context_line":"            msg \u003d _(\"flush() not supported in this version of librbd\")"},{"line_number":115,"context_line":"            mock_logger.warning.assert_called_with(msg)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_fileno(self):"},{"line_number":118,"context_line":"        self.assertRaises(IOError, self.mock_volume_wrapper.fileno)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_8988b6c6","line":115,"updated":"2015-06-17 16:50:12.000000000","message":"Please don\u0027t assert on specific log text. OK to validate that a warning log was called, but not the exact text.","commit_id":"19e927ff073a33fc8fb5f66563f0d96f7f46a8f6"}]}
