)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fa905fd02eba5b9b463068f0e4d780ae9c0bc113","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                                   root_helper\u003dself._root_helper,"},{"line_number":470,"context_line":"                                   check_exit_code\u003dcheck_exit_code,"},{"line_number":471,"context_line":"                                   attempts\u003dattempts,"},{"line_number":472,"context_line":"                                   dealy_on_retry\u003ddelay_on_retry)"},{"line_number":473,"context_line":"        msg \u003d (\"iscsiadm %(iscsi_command)s: stdout\u003d%(out)s stderr\u003d%(err)s\","},{"line_number":474,"context_line":"               {\u0027iscsi_command\u0027: iscsi_command, \u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":475,"context_line":"        # don\u0027t let passwords be shown in log output"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_162f8af7","line":472,"updated":"2015-06-02 23:47:06.000000000","message":"s/dealy/delay/","commit_id":"fd96deff9af92167524d2cb5291f4158bb0b867d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c45bb1186da598fb5969f9e14ecc305a43029e9d","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                                   root_helper\u003dself._root_helper,"},{"line_number":470,"context_line":"                                   check_exit_code\u003dcheck_exit_code,"},{"line_number":471,"context_line":"                                   attempts\u003dattempts,"},{"line_number":472,"context_line":"                                   dealy_on_retry\u003ddelay_on_retry)"},{"line_number":473,"context_line":"        msg \u003d (\"iscsiadm %(iscsi_command)s: stdout\u003d%(out)s stderr\u003d%(err)s\","},{"line_number":474,"context_line":"               {\u0027iscsi_command\u0027: iscsi_command, \u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":475,"context_line":"        # don\u0027t let passwords be shown in log output"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_76ffd9aa","line":472,"in_reply_to":"5afe65bd_162f8af7","updated":"2015-06-03 03:16:14.000000000","message":"Well that wont\u0027t work very well :)","commit_id":"fd96deff9af92167524d2cb5291f4158bb0b867d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dffa17ecf39c54759471f63e486cafb15651906b","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    def _run_iscsiadm(self, connection_properties, iscsi_command, **kwargs):"},{"line_number":461,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, 0)"},{"line_number":462,"context_line":"        attempts \u003d kwargs.pop(\u0027attempts\u0027, 1)"},{"line_number":463,"context_line":"        delay_on_retry \u003d kwargs.pop(\u0027delay_on_retry\u0027, 1)"},{"line_number":464,"context_line":"        (out, err) \u003d self._execute(\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027, \u0027-T\u0027,"},{"line_number":465,"context_line":"                                   connection_properties[\u0027target_iqn\u0027],"},{"line_number":466,"context_line":"                                   \u0027-p\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_1e5e7312","line":463,"updated":"2015-06-03 08:43:26.000000000","message":"putils.execute delay_on_retry is a boolean, so I think it would be better to do\n        delay_on_retry \u003d kwargs.pop(\u0027delay_on_retry\u0027, True)\nThe way you have it works, but lends to misinterpretation as the amount of time to delay ...","commit_id":"172d6850c97e03ba8856187bcc9386bcefb8e62c"}]}
