)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":13868,"name":"Danny Wilson","email":"daniel.wilson@purestorage.com","username":"dannywilson"},"change_message_id":"ef4d6286f407477053cec6d6a5bc04ca7269ffe3","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        for ip, iqn in all_ips_iqns:"},{"line_number":521,"context_line":"            ip_iqn \u003d \"%s-iscsi-%s\" % (ip.split(\",\")[0], iqn)"},{"line_number":522,"context_line":"            if ip_iqn not in entries:"},{"line_number":523,"context_line":"                ips_iqns.append([ip, iqn])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        if not devices:"},{"line_number":526,"context_line":"            # disconnect if no other multipath devices"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_629901c4","line":523,"updated":"2015-06-04 17:30:02.000000000","message":"This code looks very different from what is in Nova now.\n\nThis patch added some offset checking for pci-. I don\u0027t see any pci- check here.\nhttps://review.openstack.org/#/c/146233/22/nova/virt/libvirt/volume.py#L539\n\nThere is also an extra check in libvirt before adding to ips_iqns that I don\u0027t see here.\nhttps://review.openstack.org/#/c/146233/22/nova/virt/libvirt/volume.py#L515","commit_id":"531398504fcdcffb37e73a254f5a3da1854ef41e"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"3581cb1581fb4af9253db61b82d47638b8aa4547","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        for ip, iqn in all_ips_iqns:"},{"line_number":521,"context_line":"            ip_iqn \u003d \"%s-iscsi-%s\" % (ip.split(\",\")[0], iqn)"},{"line_number":522,"context_line":"            if ip_iqn not in entries:"},{"line_number":523,"context_line":"                ips_iqns.append([ip, iqn])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        if not devices:"},{"line_number":526,"context_line":"            # disconnect if no other multipath devices"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_644bea2c","line":523,"in_reply_to":"5afe65bd_629901c4","updated":"2015-06-04 18:50:25.000000000","message":"The URLs seems pointing a different patch, but I think you intended to point \nhttps://review.openstack.org/#/c/132490/6/nova/virt/libvirt/volume.py\n\nAs for pci-, because os-brick doesn\u0027t have iscsi_transport support now, I omitted it. This should be added when the patch is merged.\n\nAnd nova code doesn\u0027t work because of the implementation differences between nova and os-brick:\n  - os-brick delete block devices (self._linuxscsi._remove_multipath_device) before calling self._disconnect_volume_multipath_iscsi.\n  - nova delete block devices after disconnection of iscsi sessions (both in _disconnect_volume_multipath_iscsi).\n\nIn os-brick, the multi-path devices are already deleted here, so what only we can \u0026 should do is to check the ips_iqn is included in \"entries\"(all the connected iscsi devices).","commit_id":"531398504fcdcffb37e73a254f5a3da1854ef41e"}]}
