)]}'
{"os_brick/remotefs/remotefs.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dcfbf65509c78923f249e18f448b43b9dcd8fa8c","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        conf_dir \u003d os.path.join(\u0027/etc/pstorage/clusters\u0027, cluster_name)"},{"line_number":158,"context_line":"        if not os.path.exists(conf_dir):"},{"line_number":159,"context_line":"            self._execute(\u0027mkdir\u0027, conf_dir,"},{"line_number":160,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        mds_list_file \u003d os.path.join(conf_dir, \u0027bs_list\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_dc399bd8","line":159,"updated":"2015-06-17 17:54:16.000000000","message":"Cinder\u0027s rootwrap.d/volume.filters doesn\u0027t support mkdir","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dcfbf65509c78923f249e18f448b43b9dcd8fa8c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        mds_list_file \u003d os.path.join(conf_dir, \u0027bs_list\u0027)"},{"line_number":163,"context_line":"        self._execute(\u0027mv\u0027, tmp, mds_list_file,"},{"line_number":164,"context_line":"                      root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _mount_vzstorage(self, vz_share, mount_path, flags):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_9c2f9387","line":163,"updated":"2015-06-17 17:54:16.000000000","message":"Nova\u0027s rootwrap computer.filters doesn\u0027t support mv","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":12661,"name":"Dmitry Guryanov","email":"dmitry.guryanov@gmail.com","username":"dguryanov"},"change_message_id":"b49dd788477bba029e27cded851ab7038452c39f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        mds_list_file \u003d os.path.join(conf_dir, \u0027bs_list\u0027)"},{"line_number":163,"context_line":"        self._execute(\u0027mv\u0027, tmp, mds_list_file,"},{"line_number":164,"context_line":"                      root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _mount_vzstorage(self, vz_share, mount_path, flags):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_0276916f","line":163,"in_reply_to":"fa32b979_9c2f9387","updated":"2015-06-18 13:29:16.000000000","message":"I can use cp command instead of mkdir+mv, it\u0027s in rootwrap filters in both nova and cinder.","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dcfbf65509c78923f249e18f448b43b9dcd8fa8c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._vzstorage_write_mds_list(cluster_name, mdss)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if passwd:"},{"line_number":183,"context_line":"            self._execute(\u0027pstorage\u0027, \u0027-c\u0027, cluster_name, \u0027auth-node\u0027, \u0027-P\u0027,"},{"line_number":184,"context_line":"                          process_input\u003dpasswd,"},{"line_number":185,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_3c84475c","line":183,"updated":"2015-06-17 17:54:16.000000000","message":"Cinder and Nova\u0027s rootwrap filters don\u0027t support the pstorage exec","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":12661,"name":"Dmitry Guryanov","email":"dmitry.guryanov@gmail.com","username":"dguryanov"},"change_message_id":"b49dd788477bba029e27cded851ab7038452c39f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._vzstorage_write_mds_list(cluster_name, mdss)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if passwd:"},{"line_number":183,"context_line":"            self._execute(\u0027pstorage\u0027, \u0027-c\u0027, cluster_name, \u0027auth-node\u0027, \u0027-P\u0027,"},{"line_number":184,"context_line":"                          process_input\u003dpasswd,"},{"line_number":185,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_c2bd0903","line":183,"in_reply_to":"fa32b979_3c84475c","updated":"2015-06-18 13:29:16.000000000","message":"I\u0027m adding pstorage command to rootwrap filters in my cinder patch.","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dcfbf65509c78923f249e18f448b43b9dcd8fa8c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                          process_input\u003dpasswd,"},{"line_number":185,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        mnt_cmd \u003d [\u0027pstorage-mount\u0027, \u0027-c\u0027, cluster_name]"},{"line_number":188,"context_line":"        if flags:"},{"line_number":189,"context_line":"            mnt_cmd.extend(flags)"},{"line_number":190,"context_line":"        mnt_cmd.extend([mount_path])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_1c7f0367","line":187,"updated":"2015-06-17 17:54:16.000000000","message":"same","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":12661,"name":"Dmitry Guryanov","email":"dmitry.guryanov@gmail.com","username":"dguryanov"},"change_message_id":"b49dd788477bba029e27cded851ab7038452c39f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                          process_input\u003dpasswd,"},{"line_number":185,"context_line":"                          root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        mnt_cmd \u003d [\u0027pstorage-mount\u0027, \u0027-c\u0027, cluster_name]"},{"line_number":188,"context_line":"        if flags:"},{"line_number":189,"context_line":"            mnt_cmd.extend(flags)"},{"line_number":190,"context_line":"        mnt_cmd.extend([mount_path])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_a23d6590","line":187,"in_reply_to":"fa32b979_1c7f0367","updated":"2015-06-18 13:29:16.000000000","message":"And this one too.","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9adf7e3c5506bdb7e0660f4aa6d5184d261d34cc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    err\u003d_(\u0027glusterfs_mount_point_base required\u0027))"},{"line_number":57,"context_line":"            self._mount_options \u003d None"},{"line_number":58,"context_line":"        elif mount_type \u003d\u003d \"vzstorage\":"},{"line_number":59,"context_line":"            self._mount_base \u003d kwargs.get(\u0027vzstorage_mount_point_base\u0027, None)"},{"line_number":60,"context_line":"            if not self._mount_base:"},{"line_number":61,"context_line":"                raise exception.InvalidParameterValue("},{"line_number":62,"context_line":"                    err\u003d_(\u0027vzstorage_mount_point_base required\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_d7e93480","line":59,"updated":"2015-06-18 21:29:13.000000000","message":"Could be simplified to:\ntry:\n    self._mount_base \u003d kwargs.get(\u0027vzstorage_mount_point_base\u0027)\nexcept AttributeError:\n     raise exception.InvalidParameterValue(\n                    err\u003d_(\u0027vzstorage_mount_point_base required\u0027)\n\nI understand that you added code like that we already have. So I won\u0027t block patch for it","commit_id":"9f552f93e3649d03ebd451eb19a09bd03f37e8d5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9adf7e3c5506bdb7e0660f4aa6d5184d261d34cc","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self._execute(\u0027chown\u0027, \u0027-R\u0027, \u0027root:root\u0027, conf_dir,"},{"line_number":166,"context_line":"                      root_helper\u003dself.root_helper, run_as_root\u003dTrue)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _mount_vzstorage(self, vz_share, mount_path, flags):"},{"line_number":169,"context_line":"        m \u003d re.search(\"(?:(\\S+):\\/)?([a-zA-Z0-9_-]+)(?::(\\S+))?\", vz_share)"},{"line_number":170,"context_line":"        if not m:"},{"line_number":171,"context_line":"            msg \u003d (_(\"Invalid Virtuozzo Storage share specification: %r.\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_d745b46e","line":168,"updated":"2015-06-18 21:29:13.000000000","message":"I propose to add \u0027flags\u003dNone\u0027 as a default value to make it more explicit.","commit_id":"9f552f93e3649d03ebd451eb19a09bd03f37e8d5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c1b4d80b5ed1acb4b5e5d981a68e9236e2be6c4e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                          \u0027error\u0027: mnt_errors})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _vzstorage_write_mds_list(self, cluster_name, mdss):"},{"line_number":151,"context_line":"        tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":152,"context_line":"        tmp_bs_path \u003d os.path.join(tmp_dir, \u0027bs_list\u0027)"},{"line_number":153,"context_line":"        with open(tmp_bs_path, \u0027w\u0027) as f:"},{"line_number":154,"context_line":"            for mds in mdss:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_84443a1b","line":151,"updated":"2015-07-14 18:42:26.000000000","message":"Please set a prefix or suffix on this so that it\u0027s possible to identify this directory.  (\"vzs\" or similar)","commit_id":"ffc6701e1a8c4caabdbdaddb42f9441d55bc45b2"},{"author":{"_account_id":12661,"name":"Dmitry Guryanov","email":"dmitry.guryanov@gmail.com","username":"dguryanov"},"change_message_id":"4fc6c20dadcf09ea9691df46f6ec14c154a7e876","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                          \u0027error\u0027: mnt_errors})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _vzstorage_write_mds_list(self, cluster_name, mdss):"},{"line_number":151,"context_line":"        tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":152,"context_line":"        tmp_bs_path \u003d os.path.join(tmp_dir, \u0027bs_list\u0027)"},{"line_number":153,"context_line":"        with open(tmp_bs_path, \u0027w\u0027) as f:"},{"line_number":154,"context_line":"            for mds in mdss:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_7ca56002","line":151,"in_reply_to":"9a41bdd9_84443a1b","updated":"2015-07-20 19:04:28.000000000","message":"Done","commit_id":"ffc6701e1a8c4caabdbdaddb42f9441d55bc45b2"}],"os_brick/tests/remotefs/test_remotefs.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dcfbf65509c78923f249e18f448b43b9dcd8fa8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_9ce2332e","line":1,"updated":"2015-06-17 17:54:16.000000000","message":"remove","commit_id":"da8010b2368540d3d8bcea86c2af0828fe080aea"}]}
