)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"eccfc3070e311e0657463a7e7450667bff64cfce","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Allow clients to attach and detach Cinder volumes stored on"},{"line_number":10,"context_line":"a StorPool cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:\t\ttests"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"},{"line_number":15,"context_line":"Implements:\tblueprint brick-add-storpool-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_7179dc2e","line":12,"updated":"2015-08-05 04:41:10.000000000","message":"\"»       »       \"??\n\n•[H101] Include your name with TODOs as in # TODO(yourname). This makes it easier to find out who the author of the comment was.\nhttp://docs.openstack.org/developer/hacking/","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ec9b7947b164af137977e4ec19c4b77a80e61f42","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Allow clients to attach and detach Cinder volumes stored on"},{"line_number":10,"context_line":"a StorPool cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:\t\ttests"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"},{"line_number":15,"context_line":"Implements:\tblueprint brick-add-storpool-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_0b1e0d5f","line":12,"in_reply_to":"1a4dcd0f_7179dc2e","updated":"2015-08-05 13:21:21.000000000","message":"This was actually meant for me to remember to add tests in the next patchset :)  Patchset 1 was never meant to actually go in, just gather some reviews and comments - and thanks for that!\n\nThis line is gone in patchset 2.","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"eccfc3070e311e0657463a7e7450667bff64cfce","unresolved":false,"context_lines":[{"line_number":12,"context_line":"TODO:\t\ttests"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"},{"line_number":15,"context_line":"Implements:\tblueprint brick-add-storpool-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_f193ac4d","line":15,"updated":"2015-08-05 04:41:10.000000000","message":"»       ?","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ec9b7947b164af137977e4ec19c4b77a80e61f42","unresolved":false,"context_lines":[{"line_number":12,"context_line":"TODO:\t\ttests"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"},{"line_number":15,"context_line":"Implements:\tblueprint brick-add-storpool-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_6b7b118d","line":15,"in_reply_to":"1a4dcd0f_f193ac4d","updated":"2015-08-05 13:21:21.000000000","message":"Right, that\u0027s when I was under the impression that os-brick drivers needed a spec; Mike Perez closed the spec review, so this is not relevant any more.\n\nThis line is gone in patchset 2.","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2c7061dd99a3f85a1319fe0867bb6981ee89be00","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow clients to attach and detach Cinder volumes stored on"},{"line_number":10,"context_line":"a StorPool cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_97a8f78e","line":11,"updated":"2015-08-05 15:38:58.000000000","message":"Please reference your blueprint here.","commit_id":"296b8981cd03df951f92ab274e1c4f639bf08f4c"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"83e394474a1f9a4e221dc3c87673274bf83a48e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow clients to attach and detach Cinder volumes stored on"},{"line_number":10,"context_line":"a StorPool cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I33cfd7ab9a1d201f6c49357cacb4a809453b7201"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_57382f3d","line":11,"in_reply_to":"1a4dcd0f_97a8f78e","updated":"2015-08-05 15:42:40.000000000","message":"Done","commit_id":"296b8981cd03df951f92ab274e1c4f639bf08f4c"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"eccfc3070e311e0657463a7e7450667bff64cfce","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"            from storpool import spopenstack"},{"line_number":1350,"context_line":"        except ImportError:"},{"line_number":1351,"context_line":"            raise exception.BrickException(_LE("},{"line_number":1352,"context_line":"                \u0027Could not import the StorPool API bindings\u0027))"},{"line_number":1353,"context_line":"        try:"},{"line_number":1354,"context_line":"            self._attach \u003d spopenstack.AttachDB(log\u003dLOG)"},{"line_number":1355,"context_line":"            self._attach.api().attachmentsList()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f1baccbf","line":1352,"updated":"2015-08-05 04:41:10.000000000","message":"Add \u0027.\u0027 in the end","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ec9b7947b164af137977e4ec19c4b77a80e61f42","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"            from storpool import spopenstack"},{"line_number":1350,"context_line":"        except ImportError:"},{"line_number":1351,"context_line":"            raise exception.BrickException(_LE("},{"line_number":1352,"context_line":"                \u0027Could not import the StorPool API bindings\u0027))"},{"line_number":1353,"context_line":"        try:"},{"line_number":1354,"context_line":"            self._attach \u003d spopenstack.AttachDB(log\u003dLOG)"},{"line_number":1355,"context_line":"            self._attach.api().attachmentsList()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ebae41e5","line":1352,"in_reply_to":"1a4dcd0f_f1baccbf","updated":"2015-08-05 13:21:21.000000000","message":"Done in patchset 2, thanks!","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"eccfc3070e311e0657463a7e7450667bff64cfce","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"            self._attach.api().attachmentsList()"},{"line_number":1356,"context_line":"        except Exception as e:"},{"line_number":1357,"context_line":"            raise exception.BrickException(_LE("},{"line_number":1358,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027) % (e))"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":1361,"context_line":"        client_id \u003d connection_properties.get(\u0027volume\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_31c1142f","line":1358,"updated":"2015-08-05 04:41:10.000000000","message":"Ditto","commit_id":"d635f778aba1406671970dd13eb61528a3396529"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"ec9b7947b164af137977e4ec19c4b77a80e61f42","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"            self._attach.api().attachmentsList()"},{"line_number":1356,"context_line":"        except Exception as e:"},{"line_number":1357,"context_line":"            raise exception.BrickException(_LE("},{"line_number":1358,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027) % (e))"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":1361,"context_line":"        client_id \u003d connection_properties.get(\u0027volume\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_cbdfc567","line":1358,"in_reply_to":"1a4dcd0f_31c1142f","updated":"2015-08-05 13:21:21.000000000","message":"Eh, actually I didn\u0027t add this particular dot in patchset 2, since if exception messages end with a dot, this would make this one end with two :)  I did add dots to the end of the rest of the exception messages all the way down, though, thanks!","commit_id":"d635f778aba1406671970dd13eb61528a3396529"}],"os_brick/initiator/connectors/storpool.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"45b1249a5cb7d5918df3c6313bb2b60211cf2715","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"The StorPool connector properties.\"\"\""},{"line_number":53,"context_line":"        return {}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":56,"context_line":"        \"\"\"Connect to a volume."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :param connection_properties: The dictionary that describes all"}],"source_content_type":"text/x-python","patch_set":13,"id":"df87a7cf_2a90c894","line":55,"updated":"2017-12-11 17:08:25.000000000","message":"I would also suggest adding @utils.trace decorator here and disconnect_volume","commit_id":"6faa0d3d356417438f684473288dc2aae4516b12"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"21d310fa5e3bfc0b688d0fffe4afd07c3464c8e0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        mode \u003d connection_properties.get(\u0027access_mode\u0027, None)"},{"line_number":76,"context_line":"        if mode is None or mode not in (\u0027rw\u0027, \u0027ro\u0027):"},{"line_number":77,"context_line":"            raise exception.BrickException("},{"line_number":78,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":79,"context_line":"        req_id \u003d \u0027brick-%s-%s\u0027 % (client_id, volume_id)"},{"line_number":80,"context_line":"        self._attach.add(req_id, {"},{"line_number":81,"context_line":"            \u0027volume\u0027: volume,"}],"source_content_type":"text/x-python","patch_set":13,"id":"df87a7cf_11704aa5","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":17},"updated":"2017-12-04 15:48:42.000000000","message":"Should use _() translation markers for exception strings. But since os-brick does not currently get translations, I will not down vote on that.","commit_id":"6faa0d3d356417438f684473288dc2aae4516b12"}]}
