)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"7d0391a47ec56c0bea608ca22320eb147a3aca10","unresolved":false,"context_lines":[{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjuction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_674aa2c7","line":10,"updated":"2015-08-04 14:41:35.000000000","message":"S/conjuction/conjunction","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"fbb73013a5678196f8f281e7b5a5ce661d62ef74","unresolved":false,"context_lines":[{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjuction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_7491dc51","line":10,"in_reply_to":"1a4dcd0f_674aa2c7","updated":"2015-08-04 19:37:52.000000000","message":"Done","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"7d0391a47ec56c0bea608ca22320eb147a3aca10","unresolved":false,"context_lines":[{"line_number":10,"context_line":"specify an iscsi iface, which used in conjuction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"Closes-Bug: 1370226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_a7274a11","line":13,"updated":"2015-08-04 14:41:35.000000000","message":"with with?","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"fbb73013a5678196f8f281e7b5a5ce661d62ef74","unresolved":false,"context_lines":[{"line_number":10,"context_line":"specify an iscsi iface, which used in conjuction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"Closes-Bug: 1370226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_14a0989e","line":13,"in_reply_to":"1a4dcd0f_a7274a11","updated":"2015-08-04 19:37:52.000000000","message":"Done","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"62c1850a6385c9e3b8d11be1f14b1e382523b190","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anish Bhatt \u003canish@chelsio.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-05 17:47:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_455d47eb","line":7,"updated":"2015-08-09 05:31:58.000000000","message":"The first line must be limited to 50 characters\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"cf49d31ecd523b3d31659114ee6cda8bcd942bfa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anish Bhatt \u003canish@chelsio.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-05 17:47:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_ee546b22","line":7,"in_reply_to":"1a4dcd0f_455d47eb","updated":"2015-08-09 23:08:57.000000000","message":"There needs to be a hacking rule for this then. Looking at the logs, this does not seem to be enforced at all. Will fix in update.","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"62c1850a6385c9e3b8d11be1f14b1e382523b190","unresolved":false,"context_lines":[{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support for offload transports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_6562c3af","line":10,"updated":"2015-08-09 05:31:58.000000000","message":"S/iscsi/iSCSI","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"cf49d31ecd523b3d31659114ee6cda8bcd942bfa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"os-brick : Add support for --interface option in iscsiadm."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support for offload transports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_8e304709","line":10,"in_reply_to":"1a4dcd0f_6562c3af","updated":"2015-08-09 23:08:57.000000000","message":"Done","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"62c1850a6385c9e3b8d11be1f14b1e382523b190","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support for offload transports."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_05573fcb","line":11,"updated":"2015-08-09 05:31:58.000000000","message":"S/iscsi/iSCSI","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"cf49d31ecd523b3d31659114ee6cda8bcd942bfa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enables use of the libvirt parameter iscsi_iface that can be used to"},{"line_number":10,"context_line":"specify an iscsi iface, which used in conjunction with the"},{"line_number":11,"context_line":"--interface parameter provides offloaded iscsi support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Brings os-brick on par with with nova support for offload transports."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_ae3503f8","line":11,"in_reply_to":"1a4dcd0f_05573fcb","updated":"2015-08-09 23:08:57.000000000","message":"Done","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"8baf30349c557703367877317987459cb8c2fc9f","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            # The rescan isn\u0027t documented as being necessary(?), but it helps"},{"line_number":411,"context_line":"            if self.use_multipath:"},{"line_number":412,"context_line":"                self._rescan_iscsi()"},{"line_number":413,"context_line":"            else:"},{"line_number":414,"context_line":"                self._run_iscsiadm(target_props, (\"--rescan\",))"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            tries \u003d tries + 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_a8adf489","line":413,"updated":"2015-06-29 22:48:33.000000000","message":"Because _get_device_path() is using glob to get host devices, host_devices may return empty list at the first attempt. After the rescan, you may need to rescan for the host_devices here, like:\n\n  host_devices \u003d self._get_device_path(target_props)","commit_id":"17e538afe82913963a165b61eb320576f75164fb"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"dfed0d437c70623befbb17a8da52acaae20f5626","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            # The rescan isn\u0027t documented as being necessary(?), but it helps"},{"line_number":411,"context_line":"            if self.use_multipath:"},{"line_number":412,"context_line":"                self._rescan_iscsi()"},{"line_number":413,"context_line":"            else:"},{"line_number":414,"context_line":"                self._run_iscsiadm(target_props, (\"--rescan\",))"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            tries \u003d tries + 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_acc41392","line":413,"in_reply_to":"ba3cc151_a8adf489","updated":"2015-07-06 22:49:26.000000000","message":"Done","commit_id":"17e538afe82913963a165b61eb320576f75164fb"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"9348b469262449ebbf7e8ced38f645b942d09616","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def _disconnect_volume_iscsi(self, connection_properties):"},{"line_number":492,"context_line":"        # remove the device from the scsi subsystem"},{"line_number":493,"context_line":"        # this eliminates any stale entries until logout"},{"line_number":494,"context_line":"        host_device \u003d self._get_device_path(connection_properties)[0]"},{"line_number":495,"context_line":"        dev_name \u003d self._linuxscsi.get_name_from_path(host_device)"},{"line_number":496,"context_line":"        if dev_name:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_7f0b7dd6","line":493,"updated":"2015-07-15 20:45:37.000000000","message":"Now _get_device_path may return empty list when there is no corresponding device, this results in IndexError exception in a specific situation.\n\nIf iscsi_secondary_ip_addresses is set in LVM driver section in cinder.conf, and the connector is not configured using multipath (alternative path mode), this method is called multiple times for each portal addresses to try removing the all device files. It was excepted to dev_name \u003d None when the secondary device is not connected, but in ISER, _get_device_path returns [] and failed by IndexError.\n\nMy iser backend settings in cinder.conf:\n\n [lvmdriver-2]\n lvm_type \u003d thin\n iscsi_helper \u003d lioadm\n iscsi_ip_address \u003d 172.24.100.1\n iscsi_secondary_ip_addresses \u003d 172.24.100.2\n iscsi_protocol \u003d iser\n ...\n\nThis will fix for the issue:\n\n        host_devices \u003d self._get_device_path(connection_properties)\n        if not host_devices:\n            return\n        host_device \u003d host_devices[0]","commit_id":"2977aff91df061a514bc6ce9e94a9c8399d5432c"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"f850d7320ccd919c919d58d062e17b59bf05d9f7","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def _disconnect_volume_iscsi(self, connection_properties):"},{"line_number":492,"context_line":"        # remove the device from the scsi subsystem"},{"line_number":493,"context_line":"        # this eliminates any stale entries until logout"},{"line_number":494,"context_line":"        host_device \u003d self._get_device_path(connection_properties)[0]"},{"line_number":495,"context_line":"        dev_name \u003d self._linuxscsi.get_name_from_path(host_device)"},{"line_number":496,"context_line":"        if dev_name:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_d2db8e7a","line":493,"in_reply_to":"9a41bdd9_7f0b7dd6","updated":"2015-07-16 04:48:50.000000000","message":"Done","commit_id":"2977aff91df061a514bc6ce9e94a9c8399d5432c"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"7d0391a47ec56c0bea608ca22320eb147a3aca10","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                       \u0027-I\u0027,"},{"line_number":326,"context_line":"                                       transport_iface],"},{"line_number":327,"context_line":"                                      check_exit_code\u003d[0, 2, 6])[0] or \"\""},{"line_number":328,"context_line":"        LOG.debug(\"iscsiadm %(iface)s configuration: stdout\u003d%(out)s\","},{"line_number":329,"context_line":"                  {\u0027iface\u0027: transport_iface, \u0027out\u0027: out})"},{"line_number":330,"context_line":"        for data in [line.split() for line in out.splitlines()]:"},{"line_number":331,"context_line":"            if data[0] \u003d\u003d \u0027iface.transport_name\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_2761fa39","line":328,"updated":"2015-08-04 14:41:35.000000000","message":"Add \u0027.\u0027 in the end","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"fbb73013a5678196f8f281e7b5a5ce661d62ef74","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                       \u0027-I\u0027,"},{"line_number":326,"context_line":"                                       transport_iface],"},{"line_number":327,"context_line":"                                      check_exit_code\u003d[0, 2, 6])[0] or \"\""},{"line_number":328,"context_line":"        LOG.debug(\"iscsiadm %(iface)s configuration: stdout\u003d%(out)s\","},{"line_number":329,"context_line":"                  {\u0027iface\u0027: transport_iface, \u0027out\u0027: out})"},{"line_number":330,"context_line":"        for data in [line.split() for line in out.splitlines()]:"},{"line_number":331,"context_line":"            if data[0] \u003d\u003d \u0027iface.transport_name\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_b4852408","line":328,"in_reply_to":"1a4dcd0f_2761fa39","updated":"2015-08-04 19:37:52.000000000","message":"Done","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"7d0391a47ec56c0bea608ca22320eb147a3aca10","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                    return transport_iface"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        LOG.warn(_LW(\"No useable transport found for iscsi iface %s. \""},{"line_number":336,"context_line":"                     \"Falling back to default transport\"),"},{"line_number":337,"context_line":"                 transport_iface)"},{"line_number":338,"context_line":"        return \u0027default\u0027"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_a7550a51","line":336,"updated":"2015-08-04 14:41:35.000000000","message":"Add \u0027.\u0027 in the end","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"fbb73013a5678196f8f281e7b5a5ce661d62ef74","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                    return transport_iface"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        LOG.warn(_LW(\"No useable transport found for iscsi iface %s. \""},{"line_number":336,"context_line":"                     \"Falling back to default transport\"),"},{"line_number":337,"context_line":"                 transport_iface)"},{"line_number":338,"context_line":"        return \u0027default\u0027"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_547dc01a","line":336,"in_reply_to":"1a4dcd0f_a7550a51","updated":"2015-08-04 19:37:52.000000000","message":"Done","commit_id":"7631d0441ecf2711f18f6e66a0b4844d7275030e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec4c0de62a31c9cbc4f38576a01e9a33ea7941e1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                  execute\u003dexecute,"},{"line_number":161,"context_line":"                                  use_multipath\u003duse_multipath,"},{"line_number":162,"context_line":"                                  device_scan_attempts\u003ddevice_scan_attempts,"},{"line_number":163,"context_line":"                                  transport\u003d\u0027iser\u0027,"},{"line_number":164,"context_line":"                                  *args, **kwargs)"},{"line_number":165,"context_line":"        elif protocol \u003d\u003d \"FIBRE_CHANNEL\":"},{"line_number":166,"context_line":"            if arch in (S390, S390X):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_97d22a5b","line":163,"updated":"2015-08-05 20:00:43.000000000","message":"The devstack job is failing because with this change you now have multiple transport kwargs going into the constructor:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/volume.py#L276","commit_id":"e274407498a40e64152de513cf0ccd2199e0f2af"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"197c4bc751e99ed56ea2d97b6203e0c74b609626","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        return (\"/dev/disk/by-path/ip-%s-iser-%s-lun-%s\" %"},{"line_number":807,"context_line":"                (iser_properties[\u0027target_portal\u0027],"},{"line_number":808,"context_line":"                 iser_properties[\u0027target_iqn\u0027],"},{"line_number":809,"context_line":"                 iser_properties.get(\u0027target_lun\u0027, 0)))"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"class FibreChannelConnector(InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a4dcd0f_4eebf1dc","side":"PARENT","line":809,"updated":"2015-08-15 16:37:50.000000000","message":"Looks like removing this won\u0027t break nova as it it is today.","commit_id":"a347cd7fa770746df9cc6c15d4416876d97a2eef"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6b2b13f4aff564495cbea99e2ff1175eaa5d5e69","unresolved":false,"context_lines":[{"line_number":292,"context_line":"class ISCSIConnector(InitiatorConnector):"},{"line_number":293,"context_line":"    \"\"\"Connector class to attach/detach iSCSI volumes.\"\"\""},{"line_number":294,"context_line":"    supported_transports \u003d [\u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027,"},{"line_number":295,"context_line":"                            \u0027cxgb4i\u0027, \u0027qla4xxx\u0027, \u0027ocs\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":298,"context_line":"                 execute\u003dputils.execute, use_multipath\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"da20952f_017a65bd","line":295,"updated":"2015-08-28 22:26:09.000000000","message":"iser isn\u0027t in the list of supported transports.","commit_id":"d02a58575af1444351e13facb5b8ace247feadcc"}],"os_brick/tests/initiator/test_linuxscsi.py":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"62c1850a6385c9e3b8d11be1f14b1e382523b190","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/ip-10.10.220.253:3260-\""},{"line_number":51,"context_line":"                     \"iscsi-iqn.2000-05.com.3pardata:21810002ac00383d-lun-0\")"},{"line_number":52,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":53,"context_line":"        self.assertEqual(name, device_name)"},{"line_number":54,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/pci-0000:00:00.0-ip-10.9.8.7:3260-\""},{"line_number":55,"context_line":"                     \"iscsi-iqn.2000-05.com.openstack:2180002ac00383d-lun-0\")"},{"line_number":56,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_c5715779","line":53,"updated":"2015-08-09 05:31:58.000000000","message":"self.assertEqual(device_name, name)","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"cf49d31ecd523b3d31659114ee6cda8bcd942bfa","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/ip-10.10.220.253:3260-\""},{"line_number":51,"context_line":"                     \"iscsi-iqn.2000-05.com.3pardata:21810002ac00383d-lun-0\")"},{"line_number":52,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":53,"context_line":"        self.assertEqual(name, device_name)"},{"line_number":54,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/pci-0000:00:00.0-ip-10.9.8.7:3260-\""},{"line_number":55,"context_line":"                     \"iscsi-iqn.2000-05.com.openstack:2180002ac00383d-lun-0\")"},{"line_number":56,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_ee7d4bb2","line":53,"in_reply_to":"1a4dcd0f_c5715779","updated":"2015-08-09 23:08:57.000000000","message":"That is prexisting code, but will fix.","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"62c1850a6385c9e3b8d11be1f14b1e382523b190","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/pci-0000:00:00.0-ip-10.9.8.7:3260-\""},{"line_number":55,"context_line":"                     \"iscsi-iqn.2000-05.com.openstack:2180002ac00383d-lun-0\")"},{"line_number":56,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":57,"context_line":"        self.assertEqual(name, device_name)"},{"line_number":58,"context_line":"        realpath_mock.return_value \u003d \"bogus\""},{"line_number":59,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":60,"context_line":"        self.assertIsNone(name)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_255cbbec","line":57,"updated":"2015-08-09 05:31:58.000000000","message":"self.assertEqual(device_name, name)","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"cf49d31ecd523b3d31659114ee6cda8bcd942bfa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        disk_path \u003d (\"/dev/disk/by-path/pci-0000:00:00.0-ip-10.9.8.7:3260-\""},{"line_number":55,"context_line":"                     \"iscsi-iqn.2000-05.com.openstack:2180002ac00383d-lun-0\")"},{"line_number":56,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":57,"context_line":"        self.assertEqual(name, device_name)"},{"line_number":58,"context_line":"        realpath_mock.return_value \u003d \"bogus\""},{"line_number":59,"context_line":"        name \u003d self.linuxscsi.get_name_from_path(disk_path)"},{"line_number":60,"context_line":"        self.assertIsNone(name)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_ce572f25","line":57,"in_reply_to":"1a4dcd0f_255cbbec","updated":"2015-08-09 23:08:57.000000000","message":"Done","commit_id":"aed07dbf48ee1918346685e92d9f56ff8a130082"}]}