)]}'
{"os_brick/exception.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e7d22af0f925d82dc5ada017a13682c4bb952b48","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if isinstance(v, Exception):"},{"line_number":50,"context_line":"                self.kwargs[k] \u003d six.text_type(v)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if self._should_format():"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                message \u003d self.message % kwargs"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_1d52ebdd","line":52,"updated":"2015-06-30 20:43:05.000000000","message":"Why do you need these changes? Maybe we need an unit test if there was a bug?","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3c7bef463f5762214ffe47a1cb55f0f696a9a746","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if isinstance(v, Exception):"},{"line_number":50,"context_line":"                self.kwargs[k] \u003d six.text_type(v)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if self._should_format():"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                message \u003d self.message % kwargs"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bb9f44b3","line":52,"in_reply_to":"ba3cc151_1d52ebdd","updated":"2015-06-30 22:17:53.000000000","message":"one of the tests was failing.","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"31cc925616dd81dd7f71deb53dfa6c3b32bd1b7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            if isinstance(v, Exception):"},{"line_number":50,"context_line":"                self.kwargs[k] \u003d six.text_type(v)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if self._should_format():"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                message \u003d self.message % kwargs"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b0f2efd0","line":52,"in_reply_to":"ba3cc151_bb9f44b3","updated":"2015-07-01 08:22:55.000000000","message":"Which one? tox -e py34 pass with my patch and I didn\u0027t have to write such complex code. I only replaced .iteritems() with .items():\n\nhttps://review.openstack.org/#/c/197062/1/os_brick/exception.py","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2e29f4c8c01768587515079c696f0214316581ef","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        # As discovery result may contain other targets\u0027 iqns, extract targets"},{"line_number":557,"context_line":"        # to be disconnected whose block devices are already deleted here."},{"line_number":558,"context_line":"        ips_iqns \u003d []"},{"line_number":559,"context_line":"        entries \u003d list(map(lambda x: x.lstrip(\u0027ip-\u0027).split(\u0027-lun-\u0027)[0],"},{"line_number":560,"context_line":"                       self._get_iscsi_devices()))"},{"line_number":561,"context_line":"        for ip, iqn in all_ips_iqns:"},{"line_number":562,"context_line":"            ip_iqn \u003d \"%s-iscsi-%s\" % (ip.split(\",\")[0], iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_20030d0f","line":559,"updated":"2015-06-30 18:40:01.000000000","message":"I missed this in previous patch, so if for some reason you need to submit another patch you can remove the map:\n\n entries \u003d [device.lstrip(\u0027ip-\u0027).split(\u0027-lun-\u0027)[0]\n            for device in self._get_iscsi_devices()]","commit_id":"25f5fa921684ef6c0b1356d046d103301ba34dfb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"fad7ba47bfe91debc946b056341e0892a6081758","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        # As discovery result may contain other targets\u0027 iqns, extract targets"},{"line_number":557,"context_line":"        # to be disconnected whose block devices are already deleted here."},{"line_number":558,"context_line":"        ips_iqns \u003d []"},{"line_number":559,"context_line":"        entries \u003d list(map(lambda x: x.lstrip(\u0027ip-\u0027).split(\u0027-lun-\u0027)[0],"},{"line_number":560,"context_line":"                       self._get_iscsi_devices()))"},{"line_number":561,"context_line":"        for ip, iqn in all_ips_iqns:"},{"line_number":562,"context_line":"            ip_iqn \u003d \"%s-iscsi-%s\" % (ip.split(\",\")[0], iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_806e992d","line":559,"in_reply_to":"ba3cc151_20030d0f","updated":"2015-06-30 18:52:11.000000000","message":"Done","commit_id":"25f5fa921684ef6c0b1356d046d103301ba34dfb"}],"os_brick/tests/base.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97936e63c12b78300c3076a8e3f9c178c184856e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestCase(testtools.TestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\"Test case base class for all unit tests.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_5a48792d","line":31,"updated":"2015-06-30 20:35:05.000000000","message":"Why not using oslotest.base.BaseTestCase here?","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"31cc925616dd81dd7f71deb53dfa6c3b32bd1b7a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestCase(testtools.TestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\"Test case base class for all unit tests.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_50b843e5","line":31,"in_reply_to":"ba3cc151_3b6574e0","updated":"2015-07-01 08:22:55.000000000","message":"Ah cool, I see that you reverted this change ;-)","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3c7bef463f5762214ffe47a1cb55f0f696a9a746","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestCase(testtools.TestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\"Test case base class for all unit tests.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3b6574e0","line":31,"in_reply_to":"ba3cc151_5a48792d","updated":"2015-06-30 22:17:53.000000000","message":"I had a problem getting the tests to run properly when I first started on this patch.   I\u0027ll revert it and retest.","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5c068f6ddef3b614d1c314beec5b04ba50163b30","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        iqn \u003d \u0027iqn.2010-10.org.openstack:%s\u0027 % name"},{"line_number":266,"context_line":"        vol \u003d {\u0027id\u0027: 1, \u0027name\u0027: name}"},{"line_number":267,"context_line":"        connection_info \u003d self.iscsi_connection(vol, location, iqn)"},{"line_number":268,"context_line":"        for key, value in list(extra_props.items()):"},{"line_number":269,"context_line":"            connection_info[\u0027data\u0027][key] \u003d value"},{"line_number":270,"context_line":"        device \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":271,"context_line":"        dev_str \u003d \u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-1\u0027 % (location, iqn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8a8a3abe","line":268,"updated":"2015-06-30 18:15:12.000000000","message":"No need to convert it to a list, changing iteritems to items should be enough","commit_id":"84556e1897a7b408f1252e38b1aa5ae687b598b2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a88adb30bffcdc898c38449e8692d798fb765080","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        iqn \u003d \u0027iqn.2010-10.org.openstack:%s\u0027 % name"},{"line_number":266,"context_line":"        vol \u003d {\u0027id\u0027: 1, \u0027name\u0027: name}"},{"line_number":267,"context_line":"        connection_info \u003d self.iscsi_connection(vol, location, iqn)"},{"line_number":268,"context_line":"        for key, value in list(extra_props.items()):"},{"line_number":269,"context_line":"            connection_info[\u0027data\u0027][key] \u003d value"},{"line_number":270,"context_line":"        device \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":271,"context_line":"        dev_str \u003d \u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-1\u0027 % (location, iqn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8596ab4a","line":268,"in_reply_to":"ba3cc151_8a8a3abe","updated":"2015-06-30 18:27:04.000000000","message":"Done","commit_id":"84556e1897a7b408f1252e38b1aa5ae687b598b2"}],"tox.ini":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5c068f6ddef3b614d1c314beec5b04ba50163b30","unresolved":false,"context_lines":[{"line_number":29,"context_line":"commands \u003d python setup.py build_sphinx"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:py34]"},{"line_number":32,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":33,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":34,"context_line":"commands \u003d"},{"line_number":35,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ba3cc151_aa929e9d","line":32,"updated":"2015-06-30 18:15:12.000000000","message":"This is already defined in [testenv], there\u0027s no need to redefine it here.","commit_id":"84556e1897a7b408f1252e38b1aa5ae687b598b2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a88adb30bffcdc898c38449e8692d798fb765080","unresolved":false,"context_lines":[{"line_number":29,"context_line":"commands \u003d python setup.py build_sphinx"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:py34]"},{"line_number":32,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":33,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":34,"context_line":"commands \u003d"},{"line_number":35,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ba3cc151_65c4c75e","line":32,"in_reply_to":"ba3cc151_aa929e9d","updated":"2015-06-30 18:27:04.000000000","message":"thanks.  I copied this from nova\u0027s tox.ini and they had test-requirements-34.txt, which is probably why they needed it.\n\nI\u0027ll remove.","commit_id":"84556e1897a7b408f1252e38b1aa5ae687b598b2"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97936e63c12b78300c3076a8e3f9c178c184856e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    os_brick.tests.initiator.test_connector \\"},{"line_number":39,"context_line":"    os_brick.tests.initiator.test_linuxfc \\"},{"line_number":40,"context_line":"    os_brick.tests.initiator.test_linuxrbd \\"},{"line_number":41,"context_line":"    os_brick.tests.initiator.test_linuxscsi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ba3cc151_fa214dfc","line":41,"updated":"2015-06-30 20:35:05.000000000","message":"You can remove this change: it looks like all tests pass on Python 3.4 with your change.","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"31cc925616dd81dd7f71deb53dfa6c3b32bd1b7a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    os_brick.tests.initiator.test_connector \\"},{"line_number":39,"context_line":"    os_brick.tests.initiator.test_linuxfc \\"},{"line_number":40,"context_line":"    os_brick.tests.initiator.test_linuxrbd \\"},{"line_number":41,"context_line":"    os_brick.tests.initiator.test_linuxscsi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ba3cc151_7006a7cf","line":41,"in_reply_to":"ba3cc151_3b9334a5","updated":"2015-07-01 08:22:55.000000000","message":"\"tox -epy34 fails w/o this section. (...) db type could not be determined error: testr failed (3)\"\n\nAh, it\u0027s a common bug in testr. It\u0027s a shame that it was not fixed in testrepository yet :-(\n\nYou must run tox -e py34 and *then* tox -e py27. So it\u0027s better to write \"envlist \u003d py34,py27,pep8\" above. Otherwise, tox -e py27 creates a .testrepository directory but Python 3 is unable to use it.\n\nThe workaround is: rm -rf .testrepository.\n\nJenkins doesn\u0027t have this issue: it always start with a fresh checkout (without .testrepository nor .tox).","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1e4f3dfa851a5405cdf8e37d59e51b5db069fffc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    os_brick.tests.initiator.test_connector \\"},{"line_number":39,"context_line":"    os_brick.tests.initiator.test_linuxfc \\"},{"line_number":40,"context_line":"    os_brick.tests.initiator.test_linuxrbd \\"},{"line_number":41,"context_line":"    os_brick.tests.initiator.test_linuxscsi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ba3cc151_230a1b22","line":41,"in_reply_to":"ba3cc151_7006a7cf","updated":"2015-07-01 08:37:13.000000000","message":"I\u0027ve encountered that problem before, so I\u0027m fine leaving this as it is or just changing envlist order and leaving a comment in the file on how to fix this when the issue happens.","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3c7bef463f5762214ffe47a1cb55f0f696a9a746","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    os_brick.tests.initiator.test_connector \\"},{"line_number":39,"context_line":"    os_brick.tests.initiator.test_linuxfc \\"},{"line_number":40,"context_line":"    os_brick.tests.initiator.test_linuxrbd \\"},{"line_number":41,"context_line":"    os_brick.tests.initiator.test_linuxscsi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ba3cc151_3b9334a5","line":41,"in_reply_to":"ba3cc151_fa214dfc","updated":"2015-06-30 22:17:53.000000000","message":"tox -epy34 fails w/o this section.\n\npy34 develop-inst-nodeps: /home/vagrant/os-brick\npy34 runtests: PYTHONHASHSEED\u003d\u00273796310218\u0027\npy34 runtests: commands[0] | python setup.py testr --slowest --testr-args\u003d\nrunning testr\nrunning\u003dOS_STDOUT_CAPTURE\u003d${OS_STDOUT_CAPTURE:-1} \\\nOS_STDERR_CAPTURE\u003d${OS_STDERR_CAPTURE:-1} \\\nOS_TEST_TIMEOUT\u003d${OS_TEST_TIMEOUT:-60} \\\n${PYTHON:-python} -m subunit.run discover -t ./ . --list \ndb type could not be determined\nerror: testr failed (3)\nERROR: InvocationError: \u0027/home/vagrant/os-brick/.tox/py34/bin/python setup.py testr --slowest --testr-args\u003d\u0027\n__________________________________________________________ summary __________________________________________________________\nERROR:   py34: commands failed","commit_id":"475b1cc65bc4ae507a3035069e9862b72a950945"}]}
