)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"97c5da8b0938ac701102d7cc54e45b59531de526","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Updated the setup.cfg to install the os-brick.filters file into"},{"line_number":16,"context_line":"/usr/local/etc/os-brick/rootwrap.d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1479842"},{"line_number":19,"context_line":"UpgradeImpact:  Need to place the os-brick.filters file in service\u0027s"},{"line_number":20,"context_line":"                rootwrap.d directory to enable filters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_327b7f2b","line":17,"updated":"2015-07-31 01:45:01.000000000","message":"Call out the devstack change I9d77783c4cc8d8db7fff21543526fd4060f8b12b so reviewers can check the results there.","commit_id":"3398a9cb715008db8f91527fe8565e2d74b98a46"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a1fe751a75c5056d91f42e0d69c6833aaf247273","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Updated the setup.cfg to install the os-brick.filters file into"},{"line_number":16,"context_line":"/usr/local/etc/os-brick/rootwrap.d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1479842"},{"line_number":19,"context_line":"UpgradeImpact:  Need to place the os-brick.filters file in service\u0027s"},{"line_number":20,"context_line":"                rootwrap.d directory to enable filters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_723ec32a","line":17,"in_reply_to":"3a50d1a3_327b7f2b","updated":"2015-07-31 16:34:35.000000000","message":"Done","commit_id":"3398a9cb715008db8f91527fe8565e2d74b98a46"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"f3724a66d451e1bc6c4ac7a1388a5f7d5ecb30d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"UpgradeImpact:  Need to place the os-brick.filters file in service\u0027s"},{"line_number":19,"context_line":"                rootwrap.d directory to enable filters."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"},{"line_number":22,"context_line":"Change-Id: I2b1e657b87c7b27548200a20b991f34c3413c24b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa1b9901_8bf9e4ca","line":21,"updated":"2015-08-24 21:33:53.000000000","message":"This shouldn\u0027t be specified. Instead, \u0027Depends-On \u003cthis patch\u0027s change-id\u003e \u0027 should be specified in the devstack change.","commit_id":"f2fbf8b50039675c64f266be280d2184b364c12b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3873cd57a3bc1bbaa94293fef57367bdc493f79a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"UpgradeImpact:  Need to place the os-brick.filters file in service\u0027s"},{"line_number":19,"context_line":"                rootwrap.d directory to enable filters."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"},{"line_number":22,"context_line":"Change-Id: I2b1e657b87c7b27548200a20b991f34c3413c24b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa1b9901_9fd326d5","line":21,"in_reply_to":"fa1b9901_8bf9e4ca","updated":"2015-08-25 21:33:26.000000000","message":"No, that\u0027s what was originally tried, but the dsvm-tempest jobs don\u0027t pull in changes from libraries, they only pull in released pips on pypi.  The only dsvm jobs for libraries that pull in source are the src jobs, and if you want to make depends-on work for libs you\u0027d have to update devstack to pull from source for all libraries, which no one has done (or probably wants to do).\n\nSo I think you\u0027d have to merge this and release it in os-brick, then merge the devstack change.","commit_id":"f2fbf8b50039675c64f266be280d2184b364c12b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b0f6f6a09a97d9ac7fc539aa402d34caf2d9be40","unresolved":false,"context_lines":[{"line_number":18,"context_line":"UpgradeImpact:  Need to place the os-brick.filters file in service\u0027s"},{"line_number":19,"context_line":"                rootwrap.d directory to enable filters."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"},{"line_number":22,"context_line":"Change-Id: I2b1e657b87c7b27548200a20b991f34c3413c24b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa1b9901_bfef0a86","line":21,"in_reply_to":"fa1b9901_9fd326d5","updated":"2015-08-25 21:34:16.000000000","message":"However, the depends-on here is blocking this from merging, since the devstack change won\u0027t merge.","commit_id":"f2fbf8b50039675c64f266be280d2184b364c12b"}],"etc/os-brick/rootwrap.d/os-brick.filters":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2b43a4db533def99f57f71798018372f7c029c32","unresolved":false,"context_lines":[{"line_number":53,"context_line":"cp: CommandFilter, cp, root"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# initiator/connector.py:"},{"line_number":56,"context_line":"drv_cfg: CommandFilter, /opt/emc/scaleio/sdc/bin/drv_cfg, --query_guid, root"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# initiator/connector.py"},{"line_number":59,"context_line":"sds_cli: CommandFilter, /usr/local/bin/sds/sds_cli, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_0df43485","line":56,"updated":"2015-08-14 12:49:56.000000000","message":"In our new CI setup, the above line is causing an error\n\"Unauthorized command: drv_cfg --query_guid (no filter matched)\". \n\nIt should be changed to the following:\n\ndrv_cfg: CommandFilter, /opt/emc/scaleio/sdc/bin/drv_cfg, root, /opt/emc/scaleio/sdc/bin/drv_cfg, --query_guid","commit_id":"ef2ccb7ac601576a2661c2f345ebd5e1abcc90c6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f61689b5acd81c880b65df4815b4792a67562ee7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"cp: CommandFilter, cp, root"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# initiator/connector.py:"},{"line_number":56,"context_line":"drv_cfg: CommandFilter, /opt/emc/scaleio/sdc/bin/drv_cfg, --query_guid, root"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# initiator/connector.py"},{"line_number":59,"context_line":"sds_cli: CommandFilter, /usr/local/bin/sds/sds_cli, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1a4dcd0f_6d1cc16a","line":56,"in_reply_to":"1a4dcd0f_0df43485","updated":"2015-08-14 20:33:09.000000000","message":"Done","commit_id":"ef2ccb7ac601576a2661c2f345ebd5e1abcc90c6"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"1f53673bee0f578837a55a838dfbfa50af6fb7cf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"mkdir: CommandFilter, mkdir, root"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# remotefs/remotefs.py: \u0027chown\u0027, \u0027-R\u0027, \u0027root\u0027"},{"line_number":18,"context_line":"chown: CommandFilter, chown, root"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# initiator/connector.py: \u0027ip\u0027, \u0027addr\u0027, \u0027list\u0027"},{"line_number":21,"context_line":"ip: CommandFilter, ip, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa1b9901_6c7d9ce6","line":18,"updated":"2015-08-18 16:02:14.000000000","message":"Can we be more specific for the arguments here and for other commands using RegExpFilters?\n\nI got a review comment in glance_store that these filters are too permissive (https://security.openstack.org/guidelines/dg_use-oslo-rootwrap-securely.html).\n\nhttps://review.openstack.org/#/c/166414/14/etc/rootwrap.d/cinder_store.filters","commit_id":"08e1a613496bc800d73b25073816f706aab2618e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e8de37b80e8a296dc5ef89f711eb9bfdcb576225","unresolved":false,"context_lines":[{"line_number":15,"context_line":"mkdir: CommandFilter, mkdir, root"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# remotefs/remotefs.py: \u0027chown\u0027, \u0027-R\u0027, \u0027root\u0027"},{"line_number":18,"context_line":"chown: CommandFilter, chown, root"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# initiator/connector.py: \u0027ip\u0027, \u0027addr\u0027, \u0027list\u0027"},{"line_number":21,"context_line":"ip: CommandFilter, ip, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa1b9901_ec5081d6","line":18,"in_reply_to":"fa1b9901_6c7d9ce6","updated":"2015-08-19 21:33:05.000000000","message":"Done","commit_id":"08e1a613496bc800d73b25073816f706aab2618e"}]}
