)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ec97dafaf7d964b3ddfb9f9083c98c7497651fd2","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                        connection_properties"},{"line_number":358,"context_line":"                    )"},{"line_number":359,"context_line":"                else:"},{"line_number":360,"context_line":"                    raise"},{"line_number":361,"context_line":"            out \u003d self._run_iscsiadm_bare("},{"line_number":362,"context_line":"                [\u0027-m\u0027, \u0027discoverydb\u0027,"},{"line_number":363,"context_line":"                 \u0027-t\u0027, \u0027sendtargets\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c437344c","line":360,"updated":"2015-08-13 17:07:55.000000000","message":"We should log an error here, since this is new behavior.   The current code doesn\u0027t expect an exception to come from _discover_iscsi_portals","commit_id":"fb0561aa5fbc6d34b6dec63e63854fb499ad627b"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ec97dafaf7d964b3ddfb9f9083c98c7497651fd2","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027}"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        if self.use_multipath:"},{"line_number":406,"context_line":"            # Multipath installed, discovering other targets if available"},{"line_number":407,"context_line":"            ips_iqns \u003d self._discover_iscsi_portals(connection_properties)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            if not connection_properties.get(\u0027target_iqns\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c45c1480","line":406,"updated":"2015-08-13 17:07:55.000000000","message":"should also wrap this in a try block and raise a Brick based exception complaining about the inability to discover the portals, due to the new exception raised inside of _discover_iscsi_portals","commit_id":"fb0561aa5fbc6d34b6dec63e63854fb499ad627b"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ec97dafaf7d964b3ddfb9f9083c98c7497651fd2","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            location,"},{"line_number":484,"context_line":"            \u0027iscsiadm -m discoverydb -t sendtargets -p %s --discover\u0027 %"},{"line_number":485,"context_line":"            location]"},{"line_number":486,"context_line":"        self.assertEqual(expected_cmds, self.cmds)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027, return_value\u003dTrue)"},{"line_number":489,"context_line":"    @mock.patch.object(host_driver.HostDriver, \u0027get_all_block_devices\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_84d60cc2","line":486,"updated":"2015-08-13 17:07:55.000000000","message":"should also add a new test for the new exception being raised, being translated into a Brick exception.","commit_id":"fb0561aa5fbc6d34b6dec63e63854fb499ad627b"}]}
