)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8b573a37d652dcceca7e48fe636129ba8b025738","unresolved":false,"context_lines":[{"line_number":34,"context_line":"     sde -\u003e ... (snip) .../13:0:0:2/block/sde"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  3. associate the multipath device with the iSCSI devices"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Partial-Bug: 1487169"},{"line_number":39,"context_line":"Change-Id: I70cf5e1990cc5baffb3ef5150b9ed673e3504d6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_d376d105","line":37,"updated":"2015-10-02 16:08:22.000000000","message":"I do agree that we need to update the iSCSI code to find the multipath devices.  But I think we should be using the same mechanism that we are using for FC, and share the code between the 2.  Please take a close look at this patchset and reuse as much of it as possible:\n\nhttps://review.openstack.org/#/c/213389/\n\nThe logic of the different paths and retries should be the same between iSCSI and FC paths.  We really don\u0027t want to try and discover mpath devices differently for each connector type.","commit_id":"b04ecd2ca33fa67aedb6e4d74bb83bf6eacebaa7"},{"author":{"_account_id":13847,"name":"Keiichi KII","email":"k-keiichi@bx.jp.nec.com","username":"kii"},"change_message_id":"0abab45cf73020adffc1494ec135621ad02e5d0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"     sde -\u003e ... (snip) .../13:0:0:2/block/sde"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  3. associate the multipath device with the iSCSI devices"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Partial-Bug: 1487169"},{"line_number":39,"context_line":"Change-Id: I70cf5e1990cc5baffb3ef5150b9ed673e3504d6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_52d4b1bb","line":37,"in_reply_to":"9a1a9d01_d376d105","updated":"2015-10-08 09:15:02.000000000","message":"Thank you for the reference and your comment.\nAnd I agree with sharing the logic of the discovering mpath devices betwee iSCSI and FC connector.\nI\u0027ll fix my patch in the next version.","commit_id":"b04ecd2ca33fa67aedb6e4d74bb83bf6eacebaa7"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bdea441cf69927826f237ca5e2f5e09b62981196","unresolved":false,"context_lines":[{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    def _get_multipath_device_name(self, single_path_device):"},{"line_number":816,"context_line":"        device \u003d os.path.realpath(single_path_device)"},{"line_number":817,"context_line":"        mpath_map \u003d self._get_multipath_device_map(device)"},{"line_number":818,"context_line":"        mpdev \u003d mpath_map.get(device)"},{"line_number":819,"context_line":"        if mpdev:"},{"line_number":820,"context_line":"            return mpdev"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_93bb7975","line":817,"updated":"2015-10-02 16:10:46.000000000","message":"please use the linuxscsi.find_multipath_device_path(wwn) \nto discover the path instead of this custom code.  We need to share the same code, so we don\u0027t create a maintenance nightmare between the different connector objects.","commit_id":"b04ecd2ca33fa67aedb6e4d74bb83bf6eacebaa7"},{"author":{"_account_id":13847,"name":"Keiichi KII","email":"k-keiichi@bx.jp.nec.com","username":"kii"},"change_message_id":"0abab45cf73020adffc1494ec135621ad02e5d0b","unresolved":false,"context_lines":[{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    def _get_multipath_device_name(self, single_path_device):"},{"line_number":816,"context_line":"        device \u003d os.path.realpath(single_path_device)"},{"line_number":817,"context_line":"        mpath_map \u003d self._get_multipath_device_map(device)"},{"line_number":818,"context_line":"        mpdev \u003d mpath_map.get(device)"},{"line_number":819,"context_line":"        if mpdev:"},{"line_number":820,"context_line":"            return mpdev"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_527111a7","line":817,"in_reply_to":"9a1a9d01_93bb7975","updated":"2015-10-08 09:15:02.000000000","message":"Thank you for your comment.I\u0027ll replace the custom code with find_multipath_device_path().\nAnd I agree with sharing the same code between the connector objects.","commit_id":"b04ecd2ca33fa67aedb6e4d74bb83bf6eacebaa7"}]}