)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"af42d7a07b6d40dc7e66c1db4efe64a1828dd35d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove brackets from portal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case IPv6 address is present in location os_brick would fail to"},{"line_number":10,"context_line":"get correct path as brackets are forbiden chars in udev and are removed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1449492"},{"line_number":13,"context_line":"Change-Id: I965ce7bb9bc2b2c3fdd240d998441f8b06b36934"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a2ca52d_e9688b89","line":10,"updated":"2015-10-15 12:41:06.000000000","message":"s/forbiden/forbidden","commit_id":"2aa11b1e070187a0336a167cb1ded986dc9e1656"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d5f76953fc67d7ff480205837ac29643cbe96cc","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        if not devices:"},{"line_number":611,"context_line":"            self._disconnect_from_iscsi_portal(connection_properties)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _munge_path(self, path):"},{"line_number":614,"context_line":"        \"\"\"Remove brackets from path."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_13c69567","line":613,"updated":"2015-10-14 09:53:32.000000000","message":"-1: You are not munging a path, but the portal:\n\n def _munge_portal(self, target)","commit_id":"cbb13fad62368ddeb5627a0a9e2f2fb5d7c57d57"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d5f76953fc67d7ff480205837ac29643cbe96cc","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            self._disconnect_from_iscsi_portal(connection_properties)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _munge_path(self, path):"},{"line_number":614,"context_line":"        \"\"\"Remove brackets from path."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path"},{"line_number":617,"context_line":"        would not contain any brackets. Udev code specificaly forbids that."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_d38d7d32","line":614,"updated":"2015-10-14 09:53:32.000000000","message":"nit: s/path/target\u0027s portal","commit_id":"cbb13fad62368ddeb5627a0a9e2f2fb5d7c57d57"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d5f76953fc67d7ff480205837ac29643cbe96cc","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \"\"\"Remove brackets from path."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path"},{"line_number":617,"context_line":"        would not contain any brackets. Udev code specificaly forbids that."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        return (path[0].replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027), path[1], path[2])"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_d3949d38","line":617,"updated":"2015-10-14 09:53:32.000000000","message":"nit: s/would/must","commit_id":"cbb13fad62368ddeb5627a0a9e2f2fb5d7c57d57"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d5f76953fc67d7ff480205837ac29643cbe96cc","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path"},{"line_number":617,"context_line":"        would not contain any brackets. Udev code specificaly forbids that."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        return (path[0].replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027), path[1], path[2])"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    def _get_device_path(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_533ded29","line":618,"updated":"2015-10-14 09:53:32.000000000","message":"nit: It would be good to specify what the argument is (a tuple with Portal, IQN and LUN) so we can understand why 619 is accessing each of those","commit_id":"cbb13fad62368ddeb5627a0a9e2f2fb5d7c57d57"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d5f76953fc67d7ff480205837ac29643cbe96cc","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        In case IPv6 address was used the udev path"},{"line_number":617,"context_line":"        would not contain any brackets. Udev code specificaly forbids that."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        return (path[0].replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027), path[1], path[2])"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    def _get_device_path(self, connection_properties):"},{"line_number":622,"context_line":"        if self._get_transport() \u003d\u003d \"default\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_d3f33d72","line":619,"updated":"2015-10-14 09:53:32.000000000","message":"nit: Since we only expect brackets at the beginning and the end we can use `path[0].strip(\u0027[]\u0027)` instead.","commit_id":"cbb13fad62368ddeb5627a0a9e2f2fb5d7c57d57"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"af42d7a07b6d40dc7e66c1db4efe64a1828dd35d","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \"\"\"Remove brackets from portal."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path would not contain any"},{"line_number":617,"context_line":"        brackets. Udev code specificaly forbids that."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        portal, iqn, lun \u003d target"},{"line_number":620,"context_line":"        return (portal.replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027), iqn, lun)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_a93b739b","line":617,"updated":"2015-10-15 12:41:06.000000000","message":"s/specificaly/specifically","commit_id":"2aa11b1e070187a0336a167cb1ded986dc9e1656"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"ee784c82fa6e43e4f601065ea09b2b641b50f6d8","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    def _munge_portal(self, target):"},{"line_number":614,"context_line":"        \"\"\"Remove brackets from portal."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        In case IPv6 address was used the udev path would not contain any"},{"line_number":617,"context_line":"        brackets. Udev code specifically forbids that."},{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        portal, iqn, lun \u003d target"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_b4e09e97","line":616,"updated":"2015-10-15 16:35:09.000000000","message":"would -\u003e should","commit_id":"0d76f8d369790bc942265dc05be086722db4592c"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0e87d397bf083b3d778bca9e6d048690b05a131b","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        connection_info[\u0027data\u0027][\u0027target_portals\u0027] \u003d [location, location2]"},{"line_number":434,"context_line":"        connection_info[\u0027data\u0027][\u0027target_iqns\u0027] \u003d [iqn, iqn2]"},{"line_number":435,"context_line":"        connection_info[\u0027data\u0027][\u0027target_luns\u0027] \u003d [1, 2]"},{"line_number":436,"context_line":"        dev_str2 \u003d \u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-2\u0027 % (location2, iqn2)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        def fake_run_iscsiadm(iscsi_properties, iscsi_command, **kwargs):"},{"line_number":439,"context_line":"            if iscsi_properties[\u0027target_portal\u0027] \u003d\u003d location:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_3397bb3b","line":436,"updated":"2015-10-15 20:20:28.000000000","message":"This is now an invalid device path.","commit_id":"0d76f8d369790bc942265dc05be086722db4592c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0e87d397bf083b3d778bca9e6d048690b05a131b","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        connection_properties \u003d self.iscsi_connection_multipath("},{"line_number":570,"context_line":"            vol, [location1, location2], [iqn1, iqn2], [1, 2])"},{"line_number":571,"context_line":"        devs \u003d [\u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-1\u0027 % (location1, iqn1),"},{"line_number":572,"context_line":"                \u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-2\u0027 % (location2, iqn2)]"},{"line_number":573,"context_line":"        mock_devices.return_value \u003d devs"},{"line_number":574,"context_line":"        mock_iscsi_devices.return_value \u003d devs"},{"line_number":575,"context_line":"        mock_device_name.return_value \u003d fake_multipath_dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_539cb75c","line":572,"updated":"2015-10-15 20:20:28.000000000","message":"Ditto","commit_id":"0d76f8d369790bc942265dc05be086722db4592c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0e87d397bf083b3d778bca9e6d048690b05a131b","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        vol \u003d {\u0027id\u0027: 1, \u0027name\u0027: name1}"},{"line_number":689,"context_line":"        connection_properties \u003d self.iscsi_connection(vol, location1, iqn1)"},{"line_number":690,"context_line":"        devs \u003d [\u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-1\u0027 % (location1, iqn1),"},{"line_number":691,"context_line":"                \u0027/dev/disk/by-path/ip-%s-iscsi-%s-lun-2\u0027 % (location2, iqn2)]"},{"line_number":692,"context_line":"        mock_devices.return_value \u003d devs"},{"line_number":693,"context_line":"        mock_iscsi_devices.return_value \u003d devs"},{"line_number":694,"context_line":"        mock_device_name.return_value \u003d fake_multipath_dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_f3a5c3a1","line":691,"updated":"2015-10-15 20:20:28.000000000","message":"Ditto","commit_id":"0d76f8d369790bc942265dc05be086722db4592c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d03a1a1d96946a642958ecf6f93940d54565077f","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            mock_rescan_multipath, mock_iscsi_devices,"},{"line_number":561,"context_line":"            mock_get_device_map, mock_devices, mock_exists):"},{"line_number":562,"context_line":"        location1 \u003d \u002710.0.2.15:3260\u0027"},{"line_number":563,"context_line":"        location2 \u003d \u0027[2001:db8::1]:3260\u0027"},{"line_number":564,"context_line":"        dev_loc2 \u003d \u00272001:db8::1:3260\u0027 # udev location2"},{"line_number":565,"context_line":"        name1 \u003d \u0027volume-00000001-1\u0027"},{"line_number":566,"context_line":"        name2 \u003d \u0027volume-00000001-2\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_79f72859","line":563,"updated":"2015-10-16 16:37:48.000000000","message":"Any reason to not just use munge_portal here (same for 614, 684)?  Especially since we\u0027re not flexing munge_portal\u0027s muscle in any tests currently..","commit_id":"514db93854c774859f4635c0a0b6c5b0885ea61b"}]}
