)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6d430c87d31536a136624d92d7a56a311c8bd428","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance FC multipath support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch proposes to enhance FC multipath by adding target_luns"},{"line_number":10,"context_line":"to FibreChannelConnector."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Only target_luns is added because FCConnector has already treated"},{"line_number":13,"context_line":"multiple wwn information in target_wwn."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a26ad4f_9bde336c","line":10,"updated":"2015-10-29 02:13:48.000000000","message":"Can you please explain why we are adding a new option coming in the connection properties?   What benefit to a user of os-brick is there for this?  What changes are required in cinder to make use of this if any.  Why would a cinder driver pass in target_lun vs. target_luns, and can they do both and why?","commit_id":"5a772aa4740e2404ab23db8933d612b7da5b835e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76de41e39ca45e14372e4be729b411f06fd1217f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"multiple wwn information in target_wwn."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"target_luns differs among lun-masking tables (lun id tables)"},{"line_number":16,"context_line":"in the following conditions."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"1)"},{"line_number":19,"context_line":"Storage/Driver manages lun-masking tables for each FC ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a26ad4f_041fbb6c","line":16,"updated":"2015-11-02 19:12:26.000000000","message":"I\u0027m not sure what you mean by lun masking tables and how it\u0027s relevant to the FC brick connector.\n\nI don\u0027t really understand this commit message and how it relates to the code.","commit_id":"d7f4cd179ae8bedcbc6c05ddb13bbbb1ecee888e"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"7d53987318db0c1a07b28349d92683eedfbf994e","unresolved":false,"context_lines":[{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    def _get_host_devices(self, possible_devs):"},{"line_number":1063,"context_line":"        host_devices \u003d []"},{"line_number":1064,"context_line":"        for pci_num, target_wwn, lun in possible_devs:"},{"line_number":1065,"context_line":"            host_device \u003d \"/dev/disk/by-path/pci-%s-fc-%s-lun-%s\" % ("},{"line_number":1066,"context_line":"                pci_num,"},{"line_number":1067,"context_line":"                target_wwn,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_3562b8ae","line":1064,"updated":"2015-10-24 12:03:37.000000000","message":"Better to change \u0027lun\u0027 to \u0027lun_number\u0027. It will be easy to understand.","commit_id":"24aeecf14755e3f1404942bd112c19a59ed499f0"},{"author":{"_account_id":10674,"name":"Yusuke Hayashi","email":"yusuke.hayashi.710@gmail.com","username":"YusukeHayashi"},"change_message_id":"509b8c166ee23ca90d1b0d1fab08b29d716d08cf","unresolved":false,"context_lines":[{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    def _get_host_devices(self, possible_devs):"},{"line_number":1063,"context_line":"        host_devices \u003d []"},{"line_number":1064,"context_line":"        for pci_num, target_wwn, lun in possible_devs:"},{"line_number":1065,"context_line":"            host_device \u003d \"/dev/disk/by-path/pci-%s-fc-%s-lun-%s\" % ("},{"line_number":1066,"context_line":"                pci_num,"},{"line_number":1067,"context_line":"                target_wwn,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_d510245c","line":1064,"in_reply_to":"3a29b11f_3562b8ae","updated":"2015-10-24 14:51:14.000000000","message":"Since \u0027lun\u0027 means Logical Unit Number, I think it no problem.\nMaybe, following argument \u0027lunumbers\u0027 in _get_possible_devices confuses you...  I\u0027ll fix later argument name, thanks.","commit_id":"24aeecf14755e3f1404942bd112c19a59ed499f0"}]}
