)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"cf2fedc0843168edfd516377c1596d4a5fa02aa7","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        This method will attempt to update the local hosts\u0027s"},{"line_number":303,"context_line":"        volume after the volume has been extended on the remote"},{"line_number":304,"context_line":"        system."},{"line_number":305,"context_line":"        \"\"\""},{"line_number":306,"context_line":"        pass"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def get_all_available_volumes(self, connection_properties\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_2b71c744","line":305,"updated":"2015-11-15 12:18:25.000000000","message":"It would be useful to document the return value here - it appears returning None means failure?","commit_id":"a5423437fbfaaee5f93fd371993adb536f9375b3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"05117ef34fdefd49beabc95caac968adc92b2b6a","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        This method will attempt to update the local hosts\u0027s"},{"line_number":303,"context_line":"        volume after the volume has been extended on the remote"},{"line_number":304,"context_line":"        system."},{"line_number":305,"context_line":"        \"\"\""},{"line_number":306,"context_line":"        pass"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def get_all_available_volumes(self, connection_properties\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_ac174eec","line":305,"in_reply_to":"da85f559_2b71c744","updated":"2015-11-16 16:44:48.000000000","message":"ok will do.  I\u0027ll document this a tad bit better.\nThanks for the suggestion.","commit_id":"a5423437fbfaaee5f93fd371993adb536f9375b3"}],"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"cf2fedc0843168edfd516377c1596d4a5fa02aa7","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":387,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":388,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":389,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":390,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":391,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":392,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_4ba3eb9e","line":389,"updated":"2015-11-15 12:18:25.000000000","message":"_LE I think?","commit_id":"a5423437fbfaaee5f93fd371993adb536f9375b3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"05117ef34fdefd49beabc95caac968adc92b2b6a","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":387,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":388,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":389,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":390,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":391,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":392,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_ccf972ca","line":389,"in_reply_to":"da85f559_4ba3eb9e","updated":"2015-11-16 16:44:48.000000000","message":"the markers are only used when the string is inside the LOG.XXX call.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"a5423437fbfaaee5f93fd371993adb536f9375b3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a3ae996e2fa98abf7d04ce5d25e4d44ef80abd53","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        rescan_path \u003d \"%(scsi_path)s/rescan\" % {\u0027scsi_path\u0027: scsi_path}"},{"line_number":385,"context_line":"        self.echo_scsi_command(rescan_path, \"1\")"},{"line_number":386,"context_line":"        new_size \u003d self.get_device_size(volume_path)"},{"line_number":387,"context_line":"        LOG.debug(_LI(\"volume size after scsi device rescan %s\"), new_size)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        scsi_wwn \u003d self.get_scsi_wwn(volume_path)"},{"line_number":390,"context_line":"        mpath_device \u003d self.find_multipath_device_path(scsi_wwn)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_47285a86","line":387,"updated":"2016-01-05 19:58:59.000000000","message":"Debug should not have _LI marker.","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7b66a7e4638168f05d4b6a54b0c2d6e35cf3cff2","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        rescan_path \u003d \"%(scsi_path)s/rescan\" % {\u0027scsi_path\u0027: scsi_path}"},{"line_number":385,"context_line":"        self.echo_scsi_command(rescan_path, \"1\")"},{"line_number":386,"context_line":"        new_size \u003d self.get_device_size(volume_path)"},{"line_number":387,"context_line":"        LOG.debug(_LI(\"volume size after scsi device rescan %s\"), new_size)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        scsi_wwn \u003d self.get_scsi_wwn(volume_path)"},{"line_number":390,"context_line":"        mpath_device \u003d self.find_multipath_device_path(scsi_wwn)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_ab3c7cc8","line":387,"in_reply_to":"fa69d971_47285a86","updated":"2016-01-05 23:14:27.000000000","message":"Done","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a3ae996e2fa98abf7d04ce5d25e4d44ef80abd53","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_8732d2f0","line":400,"updated":"2016-01-05 19:58:59.000000000","message":"Needs to be _LE for LOG.error level.\n\nAlso, formatting values should be passed in to logger (LOG.error(msg, {...}) rather than performing string formatting ahead of time here.","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"003f1576be2b55848388724cff84b24b8b18fbf2","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_abc6bc97","line":400,"in_reply_to":"fa69d971_2b764ca4","updated":"2016-01-05 23:17:03.000000000","message":"That actually states that it should only be used when used for logging. Whether the string is first assigned to a variable and then passed in to the logger, or if it is just used as a literal within the logger call does not matter.","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7b66a7e4638168f05d4b6a54b0c2d6e35cf3cff2","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_2b764ca4","line":400,"in_reply_to":"fa69d971_8732d2f0","updated":"2016-01-05 23:14:27.000000000","message":"according to the guidelines you use the markers when you are passing the string inline, not as a variable.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ff298a28bd85108109ab5c9b9ace61993a52db2d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_6b53e4e2","line":400,"range":{"start_line":400,"start_character":24,"end_line":400,"end_character":26},"updated":"2016-01-05 23:18:12.000000000","message":"s/_/_LI/","commit_id":"fe340db85885664e22b59d865644dd88bff18b29"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7418aeca4dd62e5d1bf33909740a41b0d3b57f47","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_7a3dd0db","line":400,"range":{"start_line":400,"start_character":24,"end_line":400,"end_character":26},"in_reply_to":"fa69d971_6b53e4e2","updated":"2016-01-06 16:09:16.000000000","message":"not according to the guidelines.  You shouldn\u0027t be using the markers when assigning the string to a var.  You should only be using the markers inside the actual LOG call.\n\n\"The log marker functions (_LI(), _LW(), _LE(), and _LC()) must only be used when the message is only sent directly to the log. Anytime that the message will be passed outside of the current context (for example as part of an exception) the _() marker function must be used.\"\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"fe340db85885664e22b59d865644dd88bff18b29"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7a3ed6e0bb4f112c0615954bd486d7a36e58bb60","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                     {\u0027device\u0027: mpath_device, \u0027size\u0027: size})"},{"line_number":398,"context_line":"            result \u003d self.multipath_resize_map(scsi_wwn)"},{"line_number":399,"context_line":"            if \u0027fail\u0027 in result:"},{"line_number":400,"context_line":"                msg \u003d (_(\"Multipathd failed to update the size mapping of \""},{"line_number":401,"context_line":"                         \"multipath device %(scsi_wwn)s volume %(volume)s\") %"},{"line_number":402,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_path})"},{"line_number":403,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_e494ba8b","line":400,"range":{"start_line":400,"start_character":24,"end_line":400,"end_character":26},"in_reply_to":"fa69d971_7a3dd0db","updated":"2016-01-06 19:29:13.000000000","message":"my bad.  you are right. fixing...","commit_id":"fe340db85885664e22b59d865644dd88bff18b29"}],"os_brick/tests/initiator/test_linuxscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a3ae996e2fa98abf7d04ce5d25e4d44ef80abd53","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        mock_mpath_resize_map.return_value \u003d \u0027fail\u0027"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        ret_size \u003d self.linuxscsi.extend_volume(\u0027/dev/fake\u0027)"},{"line_number":618,"context_line":"        self.assertEqual(None, ret_size)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        # because we don\u0027t mock out the echo_scsi_command"},{"line_number":621,"context_line":"        expected_cmds \u003d [\u0027tee -a /sys/bus/scsi/drivers/sd/0:0:0:1/rescan\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_c798cac2","line":618,"updated":"2016-01-05 19:58:59.000000000","message":"Should be self.assertIsNone(ret_size)","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7b66a7e4638168f05d4b6a54b0c2d6e35cf3cff2","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        mock_mpath_resize_map.return_value \u003d \u0027fail\u0027"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        ret_size \u003d self.linuxscsi.extend_volume(\u0027/dev/fake\u0027)"},{"line_number":618,"context_line":"        self.assertEqual(None, ret_size)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        # because we don\u0027t mock out the echo_scsi_command"},{"line_number":621,"context_line":"        expected_cmds \u003d [\u0027tee -a /sys/bus/scsi/drivers/sd/0:0:0:1/rescan\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_2b9decbb","line":618,"in_reply_to":"fa69d971_c798cac2","updated":"2016-01-05 23:14:27.000000000","message":"Done","commit_id":"88ade4e4d7e1fc05f0a8eefa5fc73cef7c0098f3"}]}