)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"02dd14d3ba6f079100402acfab2d75928b008ddc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  a. If we use multipath, there may be multiple volume paths"},{"line_number":12,"context_line":"     expected, in this case, we should ensure each of the volume"},{"line_number":13,"context_line":"     path exists. Otherwise, the multipath will not switch between"},{"line_number":14,"context_line":"     multiple links when one of them is disconnected."},{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_68b07f8c","line":14,"updated":"2015-12-03 16:23:05.000000000","message":"I don\u0027t think this should be enforced 100% of the time.   When the system is loaded with a lot of volumes already, the time it takes to find all of the paths goes up exponentially.   This will cause all sorts of failures.","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"},{"author":{"_account_id":18967,"name":"zhangsong","email":"zhangsong@cmss.chinamobile.com","username":"zhangsong"},"change_message_id":"15b382ba667737fc565764c5613f1b97104221d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  a. If we use multipath, there may be multiple volume paths"},{"line_number":12,"context_line":"     expected, in this case, we should ensure each of the volume"},{"line_number":13,"context_line":"     path exists. Otherwise, the multipath will not switch between"},{"line_number":14,"context_line":"     multiple links when one of them is disconnected."},{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_5b999a6d","line":14,"in_reply_to":"7a740942_68b07f8c","updated":"2015-12-04 14:23:30.000000000","message":"It use os.path.exists(volume_path) to find the device, and the potential_volume_paths which have been got before have a fixed number. So I don\u0027t think the time it takes will goes up exponentially when the system is loaded with a lot of volumes already. I have tested this case with almost 40 volumes in one system, and I didn\u0027t find it takes more time.\n\nOn the other hand, if we don\u0027t enforce 100% of the time, how can we ensure all of the device path will be created?","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"02dd14d3ba6f079100402acfab2d75928b008ddc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"},{"line_number":18,"context_line":"     /dev/mapper/XXXX multipath device will not be created."},{"line_number":19,"context_line":"  So, the right way is to try-delay until each of the path is"},{"line_number":20,"context_line":"  showed up."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_08f3fb74","line":18,"updated":"2015-12-03 16:23:05.000000000","message":"But as the man page notes on find_multipaths \u003d yes, it will create a multipath device is more than 1 device path with the same wwn is created.   You don\u0027t have to wait for all of them to show up.","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"},{"author":{"_account_id":18967,"name":"zhangsong","email":"zhangsong@cmss.chinamobile.com","username":"zhangsong"},"change_message_id":"01a67498016f70c8c2cbd1eedb52fae07e32a5d2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"},{"line_number":18,"context_line":"     /dev/mapper/XXXX multipath device will not be created."},{"line_number":19,"context_line":"  So, the right way is to try-delay until each of the path is"},{"line_number":20,"context_line":"  showed up."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_6625f2a9","line":18,"in_reply_to":"7a740942_08f3fb74","updated":"2015-12-04 02:49:37.000000000","message":"Yes, it need more than 1 device path with same wwn to create a multipath device. But the current code only ensure one of them is show up, this can\u0027t ensure multipath device will be created.","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"},{"author":{"_account_id":18967,"name":"zhangsong","email":"zhangsong@cmss.chinamobile.com","username":"zhangsong"},"change_message_id":"15b382ba667737fc565764c5613f1b97104221d1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"},{"line_number":18,"context_line":"     /dev/mapper/XXXX multipath device will not be created."},{"line_number":19,"context_line":"  So, the right way is to try-delay until each of the path is"},{"line_number":20,"context_line":"  showed up."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_9b7942ff","line":18,"in_reply_to":"7a740942_6625f2a9","updated":"2015-12-04 14:23:30.000000000","message":"If only one device path is show up, the multipath device will not be created. It will provide original host_device for instance if multipath_device is none. So the code here is not reliable.","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"da30e6eba687904ca3e23979a1ef33989723821a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  b. On redhat7.1(which I has tested), the \u0027find_multipaths\u0027"},{"line_number":16,"context_line":"     parameter is set to \u0027yes\u0027 in mulitpath.conf by default. In"},{"line_number":17,"context_line":"     this case, if only one path is showed up, the"},{"line_number":18,"context_line":"     /dev/mapper/XXXX multipath device will not be created."},{"line_number":19,"context_line":"  So, the right way is to try-delay until each of the path is"},{"line_number":20,"context_line":"  showed up."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5aef4532_c5e9d380","line":18,"in_reply_to":"7a740942_9b7942ff","updated":"2016-03-11 03:44:09.000000000","message":"According to my personal practice, multipath device would still be created regardless of the number of path for specific LUN.\nThat\u0027s say, if one LUN has only one path, multipath device still appears\n\nThanks\nPeter","commit_id":"544275ef09289e99e5f6dfceb0708dd73927f332"}]}
