)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"f04393a33d75619e8948538406201774356e434d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-10 14:04:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD connector class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_c3bfd1fa","line":8,"updated":"2015-12-10 13:56:24.000000000","message":"Add more information about this review.","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-10 14:04:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD connector class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_155881f9","line":8,"in_reply_to":"7a740942_9b07cd80","updated":"2015-12-11 08:33:36.000000000","message":"Done","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c2b9c85d9c10c2454ce386111e0a389906b63897","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-10 14:04:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD connector class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_9b07cd80","line":8,"in_reply_to":"7a740942_c3bfd1fa","updated":"2015-12-11 03:39:23.000000000","message":"Can you please reference your blueprint here?","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-10 14:04:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD connector class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_7561c5a7","line":8,"in_reply_to":"7a740942_c3bfd1fa","updated":"2015-12-11 08:33:36.000000000","message":"Done","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"}],"etc/os-brick/rootwrap.d/os-brick.filters":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"sds_cli: CommandFilter, /usr/local/bin/sds/sds_cli, root"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# initiator/connector.py"},{"line_number":62,"context_line":"drbdadm: CommandFilter, drbdadm, root"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# initiator/connector.py: \u0027vgc-cluster\u0027, \u0027domain-list\u0027, \u0027-l\u0027"},{"line_number":65,"context_line":"# initiator/connector.py: \u0027vgc-cluster\u0027, \u0027space-set-apphosts\u0027, \u0027-n\u0027..."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a710552_88a48fa6","line":62,"updated":"2015-12-15 16:33:04.000000000","message":"Just a note here.  Since Nova and Cinder aren\u0027t using this rootwrap filters file, you\u0027ll have to make the same change in nova and cinder\u0027s rootwrap filter file for drbdadm to work.","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":59,"context_line":"sds_cli: CommandFilter, /usr/local/bin/sds/sds_cli, root"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# initiator/connector.py"},{"line_number":62,"context_line":"drbdadm: CommandFilter, drbdadm, root"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# initiator/connector.py: \u0027vgc-cluster\u0027, \u0027domain-list\u0027, \u0027-l\u0027"},{"line_number":65,"context_line":"# initiator/connector.py: \u0027vgc-cluster\u0027, \u0027space-set-apphosts\u0027, \u0027-n\u0027..."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a710552_324daa3e","line":62,"in_reply_to":"5a710552_88a48fa6","updated":"2015-12-16 09:57:42.000000000","message":"Ah, thanks a lot! That\u0027s a interesting note.\n\nI wondered about that already (and asked on #openstack-cinder), but never got a reply.","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c2b9c85d9c10c2454ce386111e0a389906b63897","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"                                       data_dict[\u0027name\u0027],"},{"line_number":1542,"context_line":"                                       run_as_root\u003dTrue,"},{"line_number":1543,"context_line":"                                       root_helper\u003dself._root_helper,"},{"line_number":1544,"context_line":"                                       # fixme: want that here?"},{"line_number":1545,"context_line":"                                       check_exit_code\u003d0)"},{"line_number":1546,"context_line":"        finally:"},{"line_number":1547,"context_line":"            os.unlink(tmp.name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fb8931cb","line":1544,"updated":"2015-12-11 03:39:23.000000000","message":"What are you planning to do with this comment?  Remove \"check_exit_code\u003d0\"?","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"                                       data_dict[\u0027name\u0027],"},{"line_number":1542,"context_line":"                                       run_as_root\u003dTrue,"},{"line_number":1543,"context_line":"                                       root_helper\u003dself._root_helper,"},{"line_number":1544,"context_line":"                                       # fixme: want that here?"},{"line_number":1545,"context_line":"                                       check_exit_code\u003d0)"},{"line_number":1546,"context_line":"        finally:"},{"line_number":1547,"context_line":"            os.unlink(tmp.name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_b5fe4dac","line":1544,"in_reply_to":"7a740942_fb8931cb","updated":"2015-12-11 08:33:36.000000000","message":"Done","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c2b9c85d9c10c2454ce386111e0a389906b63897","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"    def disconnect_volume(self, conn_prop, device_info):"},{"line_number":1569,"context_line":"        \"\"\"Detach the volume.\"\"\""},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"        # TODO(PM): reference counting for consistency groups, ie."},{"line_number":1572,"context_line":"        # multiple devices in one resource"},{"line_number":1573,"context_line":"        self._drbdadm_command(\"down\", conn_prop,"},{"line_number":1574,"context_line":"                              conn_prop[\u0027provider_auth\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_5b3e45db","line":1571,"updated":"2015-12-11 03:39:23.000000000","message":"Why do you need reference counting for consistency groups?  Do you mean attaching all volumes in a CG to a VM so you want to know at detach time if there\u0027s still a volume attached?\n\nCurrently you can only attach one volume at a time.  We don\u0027t have a group attach command if that is what you meant.\n\nCan you attach one volume in a CG to a VM?","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"    def disconnect_volume(self, conn_prop, device_info):"},{"line_number":1569,"context_line":"        \"\"\"Detach the volume.\"\"\""},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"        # TODO(PM): reference counting for consistency groups, ie."},{"line_number":1572,"context_line":"        # multiple devices in one resource"},{"line_number":1573,"context_line":"        self._drbdadm_command(\"down\", conn_prop,"},{"line_number":1574,"context_line":"                              conn_prop[\u0027provider_auth\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1582c100","line":1571,"in_reply_to":"7a740942_5b3e45db","updated":"2015-12-11 08:33:36.000000000","message":"Well, we will provide all block devices in a CG to the hypervisor (as /dev/drbd* device nodes); whether QEMU then opens these or not won\u0027t matter.\n\nYes, for detaching individual volumes in a CG we would need to know whether all volumes are detached before \"detaching\" the CG on the hypervisor.","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c2b9c85d9c10c2454ce386111e0a389906b63897","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"        # DRBDmanage normally returns /dev/drbdX names (to not depend on udev)."},{"line_number":1583,"context_line":"        # Should we just"},{"line_number":1584,"context_line":"        #   return \u0027/dev/\u0027"},{"line_number":1585,"context_line":"        # return \u0027/dev/drbd/by-res\u0027"},{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"class HuaweiStorHyperConnector(InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fb0cd143","line":1585,"updated":"2015-12-11 03:39:23.000000000","message":"Sounds like you need to figure this out so that you can return a real search path instead of [ ]?","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"        # DRBDmanage normally returns /dev/drbdX names (to not depend on udev)."},{"line_number":1583,"context_line":"        # Should we just"},{"line_number":1584,"context_line":"        #   return \u0027/dev/\u0027"},{"line_number":1585,"context_line":"        # return \u0027/dev/drbd/by-res\u0027"},{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"class HuaweiStorHyperConnector(InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1599616e","line":1585,"in_reply_to":"7a740942_fb0cd143","updated":"2015-12-11 08:33:36.000000000","message":"For now, I\u0027ll return None - like eg. the RBDConnector.","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c2b9c85d9c10c2454ce386111e0a389906b63897","unresolved":false,"context_lines":[{"line_number":1584,"context_line":"        #   return \u0027/dev/\u0027"},{"line_number":1585,"context_line":"        # return \u0027/dev/drbd/by-res\u0027"},{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"class HuaweiStorHyperConnector(InitiatorConnector):"},{"line_number":1589,"context_line":"    \"\"\"\"Connector class to attach/detach SDSHypervisor volumes.\"\"\""},{"line_number":1590,"context_line":"    attached_success_code \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1e366be7","line":1587,"updated":"2015-12-11 03:39:23.000000000","message":"If get_search_path is empty, get_all_available_volumes() will also return [ ].","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6a98a0788562197a5f09db04dc25f2c914b2dba4","unresolved":false,"context_lines":[{"line_number":1584,"context_line":"        #   return \u0027/dev/\u0027"},{"line_number":1585,"context_line":"        # return \u0027/dev/drbd/by-res\u0027"},{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"class HuaweiStorHyperConnector(InitiatorConnector):"},{"line_number":1589,"context_line":"    \"\"\"\"Connector class to attach/detach SDSHypervisor volumes.\"\"\""},{"line_number":1590,"context_line":"    attached_success_code \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_55b609dd","line":1587,"in_reply_to":"7a740942_1e366be7","updated":"2015-12-11 08:33:36.000000000","message":"I don\u0027t know the implications - is that a problem?\n\nWell, we\u0027re returning \"None\" now anyway.","commit_id":"5a6d9b5557684712a3e2587392161b2a4e18cf2f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"        try:"},{"line_number":1534,"context_line":"            kv \u003d {\u0027shared-secret\u0027: sh_secret}"},{"line_number":1535,"context_line":"            tmp.write(data_dict[\u0027config\u0027] % kv)"},{"line_number":1536,"context_line":"            tmp.close()"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"            (out, err) \u003d self._execute(\u0027drbdadm\u0027, cmd,"},{"line_number":1539,"context_line":"                                       \"-c\", tmp.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_480467bf","line":1536,"updated":"2015-12-15 16:33:04.000000000","message":"so we are saving a secret in a temp file ?  Is there no other way to do this?","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"        try:"},{"line_number":1534,"context_line":"            kv \u003d {\u0027shared-secret\u0027: sh_secret}"},{"line_number":1535,"context_line":"            tmp.write(data_dict[\u0027config\u0027] % kv)"},{"line_number":1536,"context_line":"            tmp.close()"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"            (out, err) \u003d self._execute(\u0027drbdadm\u0027, cmd,"},{"line_number":1539,"context_line":"                                       \"-c\", tmp.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_92eb3eb0","line":1536,"in_reply_to":"5a710552_480467bf","updated":"2015-12-16 09:57:42.000000000","message":"Well, we could spool the data in from STDIN, too.\n\nHow about explicitly making the file 0700, and/or in /dev/shm (if that exists)?\n\nWell, other services (samba mounts, pppd, etc.), they\u0027ve got their secrets in some config file, too.","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        return (out, err)"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"    def connect_volume(self, conn_prop):"},{"line_number":1549,"context_line":"        \"\"\"Attach the volume.\"\"\""},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        self._drbdadm_command(\"adjust\", conn_prop, conn_prop[\u0027provider_auth\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_a508962e","line":1548,"updated":"2015-12-15 16:33:04.000000000","message":"can you use the same name as the rest of the connectors?\nconn_prop -\u003e connection_properties","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        return (out, err)"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"    def connect_volume(self, conn_prop):"},{"line_number":1549,"context_line":"        \"\"\"Attach the volume.\"\"\""},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        self._drbdadm_command(\"adjust\", conn_prop, conn_prop[\u0027provider_auth\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_52ce365b","line":1548,"in_reply_to":"5a710552_a508962e","updated":"2015-12-16 09:57:42.000000000","message":"Done... although it makes the lines longer ;)","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"        device_info \u003d {"},{"line_number":1554,"context_line":"            \u0027type\u0027: \u0027block\u0027,"},{"line_number":1555,"context_line":"            \u0027path\u0027: conn_prop[\u0027device\u0027],"},{"line_number":1556,"context_line":"        }"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"        return device_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_4891c798","line":1555,"updated":"2015-12-15 16:33:04.000000000","message":"do drbd volumes have a WWN ?\n\nI\u0027ve been adding the scsi_wwn attribute as a return value here\n\ntake a look here:\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L804-L806\n\nand here:\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L1323-L1325","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"        device_info \u003d {"},{"line_number":1554,"context_line":"            \u0027type\u0027: \u0027block\u0027,"},{"line_number":1555,"context_line":"            \u0027path\u0027: conn_prop[\u0027device\u0027],"},{"line_number":1556,"context_line":"        }"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"        return device_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_d264664a","line":1555,"in_reply_to":"5a710552_4891c798","updated":"2015-12-16 09:57:42.000000000","message":"No, they don\u0027t.\n\nThe ID is IP:Port, with the shared-secret being used to avoid mistakes.","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"        return device_info"},{"line_number":1559,"context_line":""},{"line_number":1560,"context_line":"    def disconnect_volume(self, conn_prop, device_info):"},{"line_number":1561,"context_line":"        \"\"\"Detach the volume.\"\"\""},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        self._drbdadm_command(\"down\", conn_prop,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_e80c333d","line":1560,"updated":"2015-12-15 16:33:04.000000000","message":"same here.\n\nconn_prop -\u003e connection_properties","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"        return device_info"},{"line_number":1559,"context_line":""},{"line_number":1560,"context_line":"    def disconnect_volume(self, conn_prop, device_info):"},{"line_number":1561,"context_line":"        \"\"\"Detach the volume.\"\"\""},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        self._drbdadm_command(\"down\", conn_prop,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_725b3288","line":1560,"in_reply_to":"5a710552_e80c333d","updated":"2015-12-16 09:57:42.000000000","message":"Done","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"885a4c7b0010fbc06e852c1be16f166de06d8ca9","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        return [path]"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"    def get_search_path(self):"},{"line_number":1571,"context_line":"        # TODO(linbit): is it allowed to return \"/dev\", or is that too broad?"},{"line_number":1572,"context_line":"        return None"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_2567c626","line":1571,"updated":"2015-12-15 16:33:04.000000000","message":"/dev probably isn\u0027t a good path.   Take a look at get_all_available_volumes() in the base class.  It will use get_search_path() to find all of the available volumes for the connector based off of that path. \n\nSo, if you want to use /dev, then you probably should also override get_all_available_volumes() to only return the drbd based /dev/\u003cdevice\u003e devices.","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"f2b535386eca5856f2ece77bedffa2a32b805611","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        return [path]"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"    def get_search_path(self):"},{"line_number":1571,"context_line":"        # TODO(linbit): is it allowed to return \"/dev\", or is that too broad?"},{"line_number":1572,"context_line":"        return None"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_031cde10","line":1571,"in_reply_to":"5a710552_2567c626","updated":"2015-12-16 09:57:42.000000000","message":"Like that?","commit_id":"1bc190a112f224cee1be5af4d959d07761d0ff64"}]}
