)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"62a4a691adcb8d406c49228489a9735976f25e67","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Copy Image to Volume"},{"line_number":17,"context_line":"* Copy Volume to Image"},{"line_number":18,"context_line":"* Clone Volume"},{"line_number":19,"context_line":"* Extend volume"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This commit also include the connector unit test."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_88a3e4b1","line":19,"updated":"2015-12-18 16:17:56.000000000","message":"This commit message is good for Cinder.  But since this is an os-brick patch, you should change the message to be specific to this patch.","commit_id":"eb29807f073726e0f6e3d80f2b3d2dbcf0218985"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"62a4a691adcb8d406c49228489a9735976f25e67","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This commit also include the connector unit test."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The cinder driver itself has not been commited in cinder. I first commit this connector,"},{"line_number":24,"context_line":"then the part in nova then finally I will commit the connector in cinder"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I81036a58ab334a7e047f7fa5486c11fd19d24b8f"},{"line_number":27,"context_line":"Implements: blueprint disco-driver-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_c8748c37","line":24,"updated":"2015-12-18 16:17:56.000000000","message":"ok we can work on getting this in, but we need to verify the CI for the cinder driver.  Can you also add CI for the os-brick connector?","commit_id":"eb29807f073726e0f6e3d80f2b3d2dbcf0218985"},{"author":{"_account_id":19151,"name":"Thelo Gaultier","email":"thelo.gaultier@gmail.com","username":"Thelo"},"change_message_id":"4a8f7bb02f9618861e8c69d20f3016e4dc927bc0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This commit also include the connector unit test."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The cinder driver itself has not been commited in cinder. I first commit this connector,"},{"line_number":24,"context_line":"then the part in nova then finally I will commit the connector in cinder"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I81036a58ab334a7e047f7fa5486c11fd19d24b8f"},{"line_number":27,"context_line":"Implements: blueprint disco-driver-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_867982ca","line":24,"in_reply_to":"3a7e1126_c8748c37","updated":"2015-12-19 07:49:47.000000000","message":"Thanks for the review, I am working on the CI for the disco driver so I will add the os-brick connector at the same time. However I thought that I still have until January 19th to do this and the patch could be accepted in the meantime, am I wrong?","commit_id":"eb29807f073726e0f6e3d80f2b3d2dbcf0218985"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c014bd930e6cd5b56b20587e8eda07fac821ddc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Connector for ITRI DISCO cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the os+brick connector for the"},{"line_number":10,"context_line":"ITRI DISCO cinder driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit also includes the ITRI DISCO connector unit test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_a1e30fd8","line":9,"updated":"2015-12-21 19:51:44.000000000","message":"os-brick","commit_id":"8a9345fb6cea7e095374367297074846e4c52060"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c014bd930e6cd5b56b20587e8eda07fac821ddc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"( review : https://review.openstack.org/#/c/253356/ )"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"I first commit this connector, then the part in nova"},{"line_number":18,"context_line":"finally I committed the connector in cinder"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note that the patch for nova requires this commit to be merged to pass the unit test."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_812e13f9","line":18,"updated":"2015-12-21 19:51:44.000000000","message":"It might be useful to list the nova patch here as well as a reference.","commit_id":"8a9345fb6cea7e095374367297074846e4c52060"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35722d34a4fb90d4532b2a8ec30e4c43c1821cc0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"( ref : https://review.openstack.org/#/c/253353/ )"},{"line_number":19,"context_line":"finally I committed the connector in cinder"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the patch for nova requires this commit to be merged to pass the unit test."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I81036a58ab334a7e047f7fa5486c11fd19d24b8f"},{"line_number":24,"context_line":"Implements: blueprint disco-driver-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa69d971_876ad27f","line":21,"updated":"2016-01-05 20:07:29.000000000","message":"Minor nit: if you need to do another update, please add a newline here to keep the line \u003c 72 characters.","commit_id":"d0e2c3ba7760b22170ea0fbd670ff8e23fe2cb3e"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2d223fbbff2c305b04e8d44fd93a28724cdd9e12","unresolved":false,"context_lines":[{"line_number":2664,"context_line":""},{"line_number":2665,"context_line":"    def get_config(self, connection_properties):"},{"line_number":2666,"context_line":"        \"\"\"Get config for DISCO volume driver.\"\"\""},{"line_number":2667,"context_line":"        self.server_port \u003d str(connection_properties[\u0027conf\u0027][\u0027server_port\u0027])"},{"line_number":2668,"context_line":"        self.server_ip \u003d str(connection_properties[\u0027conf\u0027][\u0027server_ip\u0027])"},{"line_number":2669,"context_line":""},{"line_number":2670,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_b7b0bf44","line":2667,"updated":"2015-12-04 19:47:43.000000000","message":"str() -\u003e six.text_type()","commit_id":"ed9160e63df3647335d5919321ba4dd5de20d4c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2d223fbbff2c305b04e8d44fd93a28724cdd9e12","unresolved":false,"context_lines":[{"line_number":2665,"context_line":"    def get_config(self, connection_properties):"},{"line_number":2666,"context_line":"        \"\"\"Get config for DISCO volume driver.\"\"\""},{"line_number":2667,"context_line":"        self.server_port \u003d str(connection_properties[\u0027conf\u0027][\u0027server_port\u0027])"},{"line_number":2668,"context_line":"        self.server_ip \u003d str(connection_properties[\u0027conf\u0027][\u0027server_ip\u0027])"},{"line_number":2669,"context_line":""},{"line_number":2670,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"},{"line_number":2671,"context_line":"        disco_dev \u003d \u0027/dev/dms%s\u0027 % (disco_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_77ba5725","line":2668,"updated":"2015-12-04 19:47:43.000000000","message":"Same","commit_id":"ed9160e63df3647335d5919321ba4dd5de20d4c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2d223fbbff2c305b04e8d44fd93a28724cdd9e12","unresolved":false,"context_lines":[{"line_number":2681,"context_line":""},{"line_number":2682,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"},{"line_number":2683,"context_line":"        disco_dev \u003d \u0027/dev/dms%s\u0027 % (disco_id)"},{"line_number":2684,"context_line":"        LOG.debug(\"Attaching %s\", format(disco_dev))"},{"line_number":2685,"context_line":"        source_path \u003d disco_dev"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"        self._mount_disco_volume(source_path, disco_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_57863b66","line":2684,"updated":"2015-12-04 19:47:43.000000000","message":"Please use six.text_type() instead of format().","commit_id":"ed9160e63df3647335d5919321ba4dd5de20d4c8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c014bd930e6cd5b56b20587e8eda07fac821ddc","unresolved":false,"context_lines":[{"line_number":2648,"context_line":""},{"line_number":2649,"context_line":"    def get_search_path(self):"},{"line_number":2650,"context_line":"        \"\"\"Get directory path where to get DISCO volumes.\"\"\""},{"line_number":2651,"context_line":"        return \"/dev\""},{"line_number":2652,"context_line":""},{"line_number":2653,"context_line":"    def get_volume_paths(self, connection_properties):"},{"line_number":2654,"context_line":"        \"\"\"Get config for DISCO volume driver.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_5270f7a3","line":2651,"updated":"2015-12-21 19:51:44.000000000","message":"If you are returning /dev here, then you are going to need to override the base class\u0027s get_all_available_volumes().  If you don\u0027t then it will return every single /dev/* entry for the DISCO connector.\n\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L379\n\nThe idea behind the get_all_available_volumes() is to show all of the specific connector\u0027s volumes on the host.  Int this case it should only show all of the DISCO based volumes.","commit_id":"8a9345fb6cea7e095374367297074846e4c52060"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c014bd930e6cd5b56b20587e8eda07fac821ddc","unresolved":false,"context_lines":[{"line_number":2674,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027,"},{"line_number":2675,"context_line":"                       \u0027path\u0027: disco_dev}"},{"line_number":2676,"context_line":"        return device_info"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":2679,"context_line":"        \"\"\"Connect the volume. Returns xml for libvirt.\"\"\""},{"line_number":2680,"context_line":"        device_info \u003d self.get_config(connection_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_5211d702","line":2677,"updated":"2015-12-21 19:51:44.000000000","message":"You probably want to put a local lock here to prevent multiple connect attempts at the same time, like the other connectors do.","commit_id":"8a9345fb6cea7e095374367297074846e4c52060"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7c014bd930e6cd5b56b20587e8eda07fac821ddc","unresolved":false,"context_lines":[{"line_number":2726,"context_line":"            LOG.info(_LI(\"Volume already attached to host\"))"},{"line_number":2727,"context_line":""},{"line_number":2728,"context_line":"    @staticmethod"},{"line_number":2729,"context_line":"    def _path_exists(path):"},{"line_number":2730,"context_line":"        \"\"\"Check path.\"\"\""},{"line_number":2731,"context_line":"        exist \u003d False"},{"line_number":2732,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_52b6b7f9","line":2729,"updated":"2015-12-21 19:51:44.000000000","message":"why are you expecting IOError when checking if a path exists?","commit_id":"8a9345fb6cea7e095374367297074846e4c52060"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35722d34a4fb90d4532b2a8ec30e4c43c1821cc0","unresolved":false,"context_lines":[{"line_number":2691,"context_line":"    @synchronized(\u0027connect_volume\u0027)"},{"line_number":2692,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":2693,"context_line":"        \"\"\"Connect the volume. Returns xml for libvirt.\"\"\""},{"line_number":2694,"context_line":"        LOG.info(_LI(\"Enter in DISCO connect volume\"))"},{"line_number":2695,"context_line":"        device_info \u003d self.get_config(connection_properties)"},{"line_number":2696,"context_line":"        LOG.debug(\"device info : %s.\" % device_info)"},{"line_number":2697,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_67da3e4e","line":2694,"updated":"2016-01-05 20:07:29.000000000","message":"Please remove this or change it to debug level.","commit_id":"d0e2c3ba7760b22170ea0fbd670ff8e23fe2cb3e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35722d34a4fb90d4532b2a8ec30e4c43c1821cc0","unresolved":false,"context_lines":[{"line_number":2693,"context_line":"        \"\"\"Connect the volume. Returns xml for libvirt.\"\"\""},{"line_number":2694,"context_line":"        LOG.info(_LI(\"Enter in DISCO connect volume\"))"},{"line_number":2695,"context_line":"        device_info \u003d self.get_config(connection_properties)"},{"line_number":2696,"context_line":"        LOG.debug(\"device info : %s.\" % device_info)"},{"line_number":2697,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"},{"line_number":2698,"context_line":"        disco_dev \u003d \u0027/dev/dms%s\u0027 % (disco_id)"},{"line_number":2699,"context_line":"        LOG.debug(\"Attaching %s\", six.text_type(disco_dev))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_a7ecb6f3","line":2696,"updated":"2016-01-05 20:07:29.000000000","message":"Change % to , so the logger does the string formatting.","commit_id":"d0e2c3ba7760b22170ea0fbd670ff8e23fe2cb3e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35722d34a4fb90d4532b2a8ec30e4c43c1821cc0","unresolved":false,"context_lines":[{"line_number":2696,"context_line":"        LOG.debug(\"device info : %s.\" % device_info)"},{"line_number":2697,"context_line":"        disco_id \u003d connection_properties[\u0027disco_id\u0027]"},{"line_number":2698,"context_line":"        disco_dev \u003d \u0027/dev/dms%s\u0027 % (disco_id)"},{"line_number":2699,"context_line":"        LOG.debug(\"Attaching %s\", six.text_type(disco_dev))"},{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"        self._mount_disco_volume(disco_dev, disco_id)"},{"line_number":2702,"context_line":"        return device_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_87c65266","line":2699,"updated":"2016-01-05 20:07:29.000000000","message":"Remove six.text_type. The logger will convert as needed.","commit_id":"d0e2c3ba7760b22170ea0fbd670ff8e23fe2cb3e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35722d34a4fb90d4532b2a8ec30e4c43c1821cc0","unresolved":false,"context_lines":[{"line_number":2786,"context_line":"            LOG.debug(\"Received ret len\u003d%(lenR)d, ret\u003d%(ret)s\","},{"line_number":2787,"context_line":"                      {\u0027lenR\u0027: len(repr(ret)), \u0027ret\u0027: repr(ret)})"},{"line_number":2788,"context_line":""},{"line_number":2789,"context_line":"            ret_val \u003d str(\"\".join(\"%02x\" % ord(c) for c in ret))"},{"line_number":2790,"context_line":""},{"line_number":2791,"context_line":"            if ret_val !\u003d \u002700000000\u0027:"},{"line_number":2792,"context_line":"                return \u0027ERROR\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_87741236","line":2789,"updated":"2016-01-05 20:07:29.000000000","message":"str() not needed here.","commit_id":"d0e2c3ba7760b22170ea0fbd670ff8e23fe2cb3e"}]}
