)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"593d2864c02ebb6b7eb7db3d1b038d8165073bb8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems a number of ISCSIConnectorTestCase tests are never run in the"},{"line_number":10,"context_line":"gate, thanks to @testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027)),"},{"line_number":11,"context_line":"which is exciting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I believe the offending change was introduced in"},{"line_number":14,"context_line":"Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_1eb83974","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":17},"updated":"2015-12-21 21:42:53.000000000","message":"exciting-\u003e exiting?","commit_id":"fa18062cc715d19dcd0823171fc8cfde957deed5"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"20bb8b58019ddb0e3d0068c4edad53d0ed0c09e2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems a number of ISCSIConnectorTestCase tests are never run in the"},{"line_number":10,"context_line":"gate, thanks to @testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027)),"},{"line_number":11,"context_line":"which is exciting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I believe the offending change was introduced in"},{"line_number":14,"context_line":"Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_1653643a","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":17},"in_reply_to":"3a7e1126_1eb83974","updated":"2016-01-06 07:40:28.000000000","message":"No, I meant \"exciting\" as written - I was just trying to point out that having tests that aren\u0027t run in the gate environment is a situation that will lead to hidden surprises (like this one).  Perhaps it was an odd choice of word by me - I\u0027ll change it to something else if I need to update the patch for some reason.","commit_id":"fa18062cc715d19dcd0823171fc8cfde957deed5"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"593d2864c02ebb6b7eb7db3d1b038d8165073bb8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"which is exciting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I believe the offending change was introduced in"},{"line_number":14,"context_line":"Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change continues Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75 by"},{"line_number":17,"context_line":"also mocking get_scsi_wwn in the test cases that are only run when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_de5cf14c","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":42},"updated":"2015-12-21 21:42:53.000000000","message":"Can you elaborate here a bit about what this change did? And why that particular code that skips the tests was added?","commit_id":"fa18062cc715d19dcd0823171fc8cfde957deed5"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7e82d749de035506e26b0c1b5c5d2216e163ee79","unresolved":false,"context_lines":[{"line_number":11,"context_line":"which is exciting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I believe the offending change was introduced in"},{"line_number":14,"context_line":"Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change continues Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75 by"},{"line_number":17,"context_line":"also mocking get_scsi_wwn in the test cases that are only run when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_dadf7567","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":42},"in_reply_to":"3a7e1126_de5cf14c","updated":"2016-01-04 21:33:01.000000000","message":"Nothing in that patch adds skips to tests.  This needs to be changed and/or removed.","commit_id":"fa18062cc715d19dcd0823171fc8cfde957deed5"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"20bb8b58019ddb0e3d0068c4edad53d0ed0c09e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"which is exciting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I believe the offending change was introduced in"},{"line_number":14,"context_line":"Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change continues Ic98cdd700bc9fa3467e8c7f3cdaa70c12414ad75 by"},{"line_number":17,"context_line":"also mocking get_scsi_wwn in the test cases that are only run when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_5139e6d5","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":42},"in_reply_to":"fa69d971_dadf7567","updated":"2016-01-06 07:40:28.000000000","message":"My understanding is that patch introduced some changes which broke these tests (a new command was introduced so the \"expected\" set of commands no longer matches).  The breakage wasn\u0027t noticed because the tests *already had* skips and obviously doesn\u0027t get run on the gate nor your environment or else you\u0027d (presumably) have noticed and included it in your original change.\n\nHave I misdiagnosed something about the history here?  I still think the existing description correctly describes the situation...  I can obviously remove the reference to your change if you wish, but then I feel I\u0027m missing valuable information about when the change that prompted this one was introduced.","commit_id":"fa18062cc715d19dcd0823171fc8cfde957deed5"}]}