)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"07d61d1a432d1c2325264cb8699d03cab25fb328","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            driver \u003d host_driver.HostDriver()"},{"line_number":154,"context_line":"        self.set_driver(driver)"},{"line_number":155,"context_line":"        self.device_scan_attempts \u003d device_scan_attempts"},{"line_number":156,"context_line":"        self._linuxscsi \u003d linuxscsi.LinuxSCSI(root_helper, execute)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def set_driver(self, driver):"},{"line_number":159,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3f01df6a","line":156,"updated":"2016-01-13 21:54:09.000000000","message":"....LinuxSCSI(root_helper, execute\u003dexecute)","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5b68ee3244c0e67cbeb1a3530571a9f5eb1f520d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            driver \u003d host_driver.HostDriver()"},{"line_number":154,"context_line":"        self.set_driver(driver)"},{"line_number":155,"context_line":"        self.device_scan_attempts \u003d device_scan_attempts"},{"line_number":156,"context_line":"        self._linuxscsi \u003d linuxscsi.LinuxSCSI(root_helper, execute)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def set_driver(self, driver):"},{"line_number":159,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_a26054d0","line":156,"in_reply_to":"da6ed579_3f01df6a","updated":"2016-01-14 16:01:30.000000000","message":"Done","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f531df58c271884aaaf546299102e4d7d82321a4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            LOG.debug(\"Multipath device path discovered %(device)s\","},{"line_number":296,"context_line":"                      {\u0027device\u0027: path})"},{"line_number":297,"context_line":"            # for temporary backwards compatibility"},{"line_number":298,"context_line":"            device_info[\u0027multipath_id\u0027] \u003d device_wwn"},{"line_number":299,"context_line":"        else:"},{"line_number":300,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":301,"context_line":"                self.device_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_5fc93325","line":298,"updated":"2016-01-13 21:56:48.000000000","message":"so it seems that the only reason device_info is passed in here is to set this value.\n\nIt might be worthwhile, to not pass it in, and do the test outside ?\n\ndef connect_volume...:\n\n...\npath \u003d self._discover_mpath_device(wwn, connection_properties)\nif path:\n  device_info[\u0027multipath_id\u0027] \u003d wwn\n...","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5b68ee3244c0e67cbeb1a3530571a9f5eb1f520d","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            LOG.debug(\"Multipath device path discovered %(device)s\","},{"line_number":296,"context_line":"                      {\u0027device\u0027: path})"},{"line_number":297,"context_line":"            # for temporary backwards compatibility"},{"line_number":298,"context_line":"            device_info[\u0027multipath_id\u0027] \u003d device_wwn"},{"line_number":299,"context_line":"        else:"},{"line_number":300,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":301,"context_line":"                self.device_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4c971dec","line":298,"in_reply_to":"da6ed579_5fc93325","updated":"2016-01-14 16:01:30.000000000","message":"Done.","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c964297d1357f1a73a9403084dd17fbc722c4a78","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            else:"},{"line_number":307,"context_line":"                # we didn\u0027t find a multipath device."},{"line_number":308,"context_line":"                # so we assume the kernel only sees 1 device"},{"line_number":309,"context_line":"                device_path \u003d self.host_device"},{"line_number":310,"context_line":"                LOG.debug(\"Unable to find multipath device name for \""},{"line_number":311,"context_line":"                          \"volume. Using path %(device)s for volume.\","},{"line_number":312,"context_line":"                          {\u0027device\u0027: self.host_device})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_5f97f3eb","line":309,"updated":"2016-01-13 21:58:50.000000000","message":"since the purpose of this method now is to try and find a mpath device, we probably should return None from this method and let the caller decide what to do?","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5b68ee3244c0e67cbeb1a3530571a9f5eb1f520d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            else:"},{"line_number":307,"context_line":"                # we didn\u0027t find a multipath device."},{"line_number":308,"context_line":"                # so we assume the kernel only sees 1 device"},{"line_number":309,"context_line":"                device_path \u003d self.host_device"},{"line_number":310,"context_line":"                LOG.debug(\"Unable to find multipath device name for \""},{"line_number":311,"context_line":"                          \"volume. Using path %(device)s for volume.\","},{"line_number":312,"context_line":"                          {\u0027device\u0027: self.host_device})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_f706de1a","line":309,"in_reply_to":"da6ed579_5f97f3eb","updated":"2016-01-14 16:01:30.000000000","message":"So I did this, but I think I am missing something because I\u0027m confused by returning none and then saving the results of the function into the path variable when it would be None..","commit_id":"fc12fb4d6ddc0a971d70e121c18b2416de4d73c2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cc9919faaf88ca9cf9bd35d315f5cd2a6293727d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            except exception.BlockDeviceReadOnly:"},{"line_number":312,"context_line":"                LOG.warning(_LW(\u0027Block device %s is still read-only. \u0027"},{"line_number":313,"context_line":"                                \u0027Continuing anyway.\u0027), device_path)"},{"line_number":314,"context_line":"        return None"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    @abc.abstractmethod"},{"line_number":317,"context_line":"    def connect_volume(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_82bf19a9","line":314,"updated":"2016-01-14 17:36:43.000000000","message":"This method only returns None ?","commit_id":"ade30b1101b13cd970693eb2d681c582e6cefbb8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"94ae19df78ed68cb1b7cd2a37e45f98134df51da","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return True"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _discover_mpath_device(self, device_wwn,"},{"line_number":291,"context_line":"                               connection_properties):"},{"line_number":292,"context_line":"        path \u003d self._linuxscsi.find_multipath_device_path(device_wwn)"},{"line_number":293,"context_line":"        device_path \u003d None"},{"line_number":294,"context_line":"        multipath_id \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_acfe3636","line":291,"updated":"2016-01-20 00:49:56.000000000","message":"might be a good idea to document the purpose of this function.","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"934fc946fa0c89b5ac7a90d447f81befb3e077cc","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return True"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _discover_mpath_device(self, device_wwn,"},{"line_number":291,"context_line":"                               connection_properties):"},{"line_number":292,"context_line":"        path \u003d self._linuxscsi.find_multipath_device_path(device_wwn)"},{"line_number":293,"context_line":"        device_path \u003d None"},{"line_number":294,"context_line":"        multipath_id \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_685f0d0f","line":291,"in_reply_to":"ba63e191_acfe3636","updated":"2016-01-20 17:42:20.000000000","message":"Done","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"beefb2633d9f54087ee5a9dcb690f0c54712edfa","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        enabled device if there is one."},{"line_number":295,"context_line":"        \"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        path \u003d self._linuxscsi.find_multipath_device_path(device_wwn)"},{"line_number":298,"context_line":"        device_path \u003d None"},{"line_number":299,"context_line":"        multipath_id \u003d None"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_ff304303","line":297,"updated":"2016-01-21 23:02:41.000000000","message":"what happens when path is not None here.  This function will return None, None","commit_id":"18a4213655ed82cbc5745a1b2b64a346a484e73a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"50fc32dc63bf7aa5d24e322629165bebe5191b03","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        device_info[\u0027scsi_wwn\u0027] \u003d device_wwn"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if self.use_multipath:"},{"line_number":844,"context_line":"            (host_device, device_info[\u0027multipath_id\u0027]) \u003d ("},{"line_number":845,"context_line":"                super(ISCSIConnector, self). _discover_mpath_device("},{"line_number":846,"context_line":"                    device_wwn, connection_properties))"},{"line_number":847,"context_line":"        device_info[\u0027path\u0027] \u003d host_device"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_a65b71f5","line":844,"updated":"2016-01-22 20:09:37.000000000","message":"so _discover_mpath_device can return None, None in the case it can\u0027t find a multipath device.  We shouldn\u0027t be setting the multipath_id if we can\u0027t find it.\n\n(host_device, multipath_id) \u003d ....\n\n  if multipath_id:\n      device_info[\u0027multipath_id\u0027] \u003d multipath_id","commit_id":"fbfecc3218a1003fbfcf745e32d5ae2c2b362995"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"50fc32dc63bf7aa5d24e322629165bebe5191b03","unresolved":false,"context_lines":[{"line_number":846,"context_line":"                    device_wwn, connection_properties))"},{"line_number":847,"context_line":"        device_info[\u0027path\u0027] \u003d host_device"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        if host_device and device_info[\u0027multipath_id\u0027]:"},{"line_number":850,"context_line":"            device_info[\u0027multipath_id\u0027] \u003d device_wwn"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        LOG.debug(\"connect_volume returning %s\", device_info)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_066b5d86","line":849,"updated":"2016-01-22 20:09:37.000000000","message":"this will fail if multipath isn\u0027t running and/or if it\u0027s disabled in CONF.\n\nYou shouldn\u0027t be doing this here, but inside the if.use_multipath: block...","commit_id":"fbfecc3218a1003fbfcf745e32d5ae2c2b362995"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"71162e34c270371daebc4b1f6a14c70f66797eec","unresolved":false,"context_lines":[{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if self.use_multipath:"},{"line_number":844,"context_line":"            device_info[\u0027multipath_id\u0027] \u003d None"},{"line_number":845,"context_line":"            (host_device, device_info[\u0027multipath_id\u0027]) \u003d ("},{"line_number":846,"context_line":"                super(ISCSIConnector, self). _discover_mpath_device("},{"line_number":847,"context_line":"                    device_wwn, connection_properties))"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_06027db4","line":845,"updated":"2016-01-22 20:10:34.000000000","message":"host_device, multipath_id \u003d \n\nif multipath_id:\n   device_info[\u0027multipath_id\u0027] \u003d multipath_id","commit_id":"1fb0cde93a58939b17a3b706a5b7d3298cd7e457"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"399d8252be5a0463b2779c1a94755afa2e9d2536","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                device_info[\u0027multipath_id\u0027] \u003d multipath_id"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"            if host_device and device_info[\u0027multipath_id\u0027]:"},{"line_number":852,"context_line":"                device_info[\u0027multipath_id\u0027] \u003d device_wwn"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        device_info[\u0027path\u0027] \u003d host_device"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_bc2dbeff","line":852,"updated":"2016-01-22 21:11:40.000000000","message":"remove this.  you are already setting it on 849.","commit_id":"0f9ffa6c8dbc05712e6563600e03bc18ab7912b4"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5786581577b126bc10225e8d690441f9583c10f0","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        device_info[\u0027scsi_wwn\u0027] \u003d device_wwn"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if self.use_multipath:"},{"line_number":844,"context_line":"            device_info[\u0027multipath_id\u0027] \u003d None"},{"line_number":845,"context_line":"            (host_device, multipath_id) \u003d (super("},{"line_number":846,"context_line":"                ISCSIConnector, self)._discover_mpath_device("},{"line_number":847,"context_line":"                device_wwn, connection_properties))"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_bcc93e28","line":844,"updated":"2016-01-22 21:15:28.000000000","message":"we don\u0027t want to set this to None.  looking at the older code, if we don\u0027t have a multipath path, we don\u0027t set the multipath_id.","commit_id":"ec2baa07fea1352072b13ffc9e1931e773d717e9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"782126979b4487c3baef6204b13b8fbbe4fdb1ca","unresolved":false,"context_lines":[{"line_number":839,"context_line":"            for dev in host_devices:"},{"line_number":840,"context_line":"                if os.path.exists(dev):"},{"line_number":841,"context_line":"                    host_device \u003d dev"},{"line_number":842,"context_line":"                    multipath_device \u003d self._get_multipath_device_name(dev)"},{"line_number":843,"context_line":"                    if multipath_device:"},{"line_number":844,"context_line":"                        break"},{"line_number":845,"context_line":"            if not host_device:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a57f1b5_6cbfe8fb","side":"PARENT","line":842,"updated":"2016-02-10 21:12:47.000000000","message":"so, we should probably look at removing this call here as well, because it makes a multipath -l call as well.  I can post a follow up patch I presume, so we can get this patch to land.","commit_id":"46740682804904c3c9c04d90df1a28e567ba4337"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"23795c22087982e36fb2ba14f23daa8940afc608","unresolved":false,"context_lines":[{"line_number":839,"context_line":"            for dev in host_devices:"},{"line_number":840,"context_line":"                if os.path.exists(dev):"},{"line_number":841,"context_line":"                    host_device \u003d dev"},{"line_number":842,"context_line":"                    multipath_device \u003d self._get_multipath_device_name(dev)"},{"line_number":843,"context_line":"                    if multipath_device:"},{"line_number":844,"context_line":"                        break"},{"line_number":845,"context_line":"            if not host_device:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a57f1b5_6d6efb97","side":"PARENT","line":842,"in_reply_to":"3a57f1b5_246340de","updated":"2016-02-11 00:53:56.000000000","message":"Good point.","commit_id":"46740682804904c3c9c04d90df1a28e567ba4337"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"52adff9e50acccf4914038c49db60a65d7a82b70","unresolved":false,"context_lines":[{"line_number":839,"context_line":"            for dev in host_devices:"},{"line_number":840,"context_line":"                if os.path.exists(dev):"},{"line_number":841,"context_line":"                    host_device \u003d dev"},{"line_number":842,"context_line":"                    multipath_device \u003d self._get_multipath_device_name(dev)"},{"line_number":843,"context_line":"                    if multipath_device:"},{"line_number":844,"context_line":"                        break"},{"line_number":845,"context_line":"            if not host_device:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a57f1b5_246340de","side":"PARENT","line":842,"in_reply_to":"3a57f1b5_6cbfe8fb","updated":"2016-02-10 23:35:49.000000000","message":"+1, i\u0027m a fan of doing this in baby steps. helps avoid any regressions.","commit_id":"46740682804904c3c9c04d90df1a28e567ba4337"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"94ae19df78ed68cb1b7cd2a37e45f98134df51da","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        mock_devices.return_value \u003d devs"},{"line_number":614,"context_line":"        mock_iscsi_devices.return_value \u003d devs"},{"line_number":615,"context_line":"        mock_get_iqn.return_value \u003d [iqn1, iqn2]"},{"line_number":616,"context_line":"        mock_discover_mpath_device.return_value \u003d (fake_multipath_dev, FAKE_SCSI_WWN)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        result \u003d self.connector_with_multipath.connect_volume("},{"line_number":619,"context_line":"            connection_properties[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_3f6346de","line":616,"updated":"2016-01-20 00:49:56.000000000","message":"this line looks too long?","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"934fc946fa0c89b5ac7a90d447f81befb3e077cc","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        mock_devices.return_value \u003d devs"},{"line_number":614,"context_line":"        mock_iscsi_devices.return_value \u003d devs"},{"line_number":615,"context_line":"        mock_get_iqn.return_value \u003d [iqn1, iqn2]"},{"line_number":616,"context_line":"        mock_discover_mpath_device.return_value \u003d (fake_multipath_dev, FAKE_SCSI_WWN)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        result \u003d self.connector_with_multipath.connect_volume("},{"line_number":619,"context_line":"            connection_properties[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_c8c959ae","line":616,"in_reply_to":"ba63e191_3f6346de","updated":"2016-01-20 17:42:20.000000000","message":"Done","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"94ae19df78ed68cb1b7cd2a37e45f98134df51da","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":627,"context_line":"        for command in expected_commands:"},{"line_number":628,"context_line":"            self.assertIn(command, self.cmds)"},{"line_number":629,"context_line":"        mock_discover_mpath_device.assert_called_once_with(devs[0])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        self.cmds \u003d []"},{"line_number":632,"context_line":"        self.connector_with_multipath.disconnect_volume("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_5fe39a33","line":629,"updated":"2016-01-20 00:49:56.000000000","message":"the params to _discover_mpath_device are not the same as the function previously on this line.","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"934fc946fa0c89b5ac7a90d447f81befb3e077cc","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":627,"context_line":"        for command in expected_commands:"},{"line_number":628,"context_line":"            self.assertIn(command, self.cmds)"},{"line_number":629,"context_line":"        mock_discover_mpath_device.assert_called_once_with(devs[0])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        self.cmds \u003d []"},{"line_number":632,"context_line":"        self.connector_with_multipath.disconnect_volume("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_68170dee","line":629,"in_reply_to":"ba63e191_5fe39a33","updated":"2016-01-20 17:42:20.000000000","message":"Oops. Fixed now.","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"94ae19df78ed68cb1b7cd2a37e45f98134df51da","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                           \u0027path\u0027: fake_multipath_dev, \u0027type\u0027: \u0027block\u0027,"},{"line_number":691,"context_line":"                           \u0027scsi_wwn\u0027: FAKE_SCSI_WWN}"},{"line_number":692,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":693,"context_line":"        mock_device_name.assert_called_once_with(dev2)"},{"line_number":694,"context_line":"        props[\u0027target_portal\u0027] \u003d location1"},{"line_number":695,"context_line":"        props[\u0027target_iqn\u0027] \u003d iqn1"},{"line_number":696,"context_line":"        mock_iscsiadm.assert_any_call(props, (\u0027--login\u0027,),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_5f307ae8","line":693,"updated":"2016-01-20 00:49:56.000000000","message":"This call was removed from your new code.  that\u0027s why this one is failing.","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"934fc946fa0c89b5ac7a90d447f81befb3e077cc","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                           \u0027path\u0027: fake_multipath_dev, \u0027type\u0027: \u0027block\u0027,"},{"line_number":691,"context_line":"                           \u0027scsi_wwn\u0027: FAKE_SCSI_WWN}"},{"line_number":692,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":693,"context_line":"        mock_device_name.assert_called_once_with(dev2)"},{"line_number":694,"context_line":"        props[\u0027target_portal\u0027] \u003d location1"},{"line_number":695,"context_line":"        props[\u0027target_iqn\u0027] \u003d iqn1"},{"line_number":696,"context_line":"        mock_iscsiadm.assert_any_call(props, (\u0027--login\u0027,),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_28bb55c6","line":693,"in_reply_to":"ba63e191_5f307ae8","updated":"2016-01-20 17:42:20.000000000","message":"Done","commit_id":"1072c084b7829f10bcfe306587e70bd9afce2b76"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"beefb2633d9f54087ee5a9dcb690f0c54712edfa","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                   connection_properties[\u0027data\u0027]))"},{"line_number":356,"context_line":"        result \u003d (result_path, result_mpath_id)"},{"line_number":357,"context_line":"        expected_result \u003d {\u0027multipath_id\u0027: FAKE_SCSI_WWN,"},{"line_number":358,"context_line":"                           \u0027path\u0027: fake_multipath_dev}"},{"line_number":359,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_3f0edb3b","line":358,"updated":"2016-01-21 23:02:41.000000000","message":"_discover_mpath_device doesn\u0027t return a dict.","commit_id":"18a4213655ed82cbc5745a1b2b64a346a484e73a"}]}
