)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f32282826848b4e4d5a614e2cd42e70ebaa6ebaa","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                         host\u003dhost,"},{"line_number":163,"context_line":"                                         multipath\u003dmultipath,"},{"line_number":164,"context_line":"                                         enforce_multipath\u003denforce_multipath))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    return props"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_f303fa0b","side":"PARENT","line":165,"updated":"2016-02-09 19:08:03.000000000","message":"unnecessary change.","commit_id":"d390a0dc8e877f694bc9807656ba5a1f53599455"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"0a7b355d763f76a6ca7e19a91e60a78cda88c4e3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                         host\u003dhost,"},{"line_number":163,"context_line":"                                         multipath\u003dmultipath,"},{"line_number":164,"context_line":"                                         enforce_multipath\u003denforce_multipath))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    return props"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_1111d252","side":"PARENT","line":165,"in_reply_to":"3a57f1b5_f303fa0b","updated":"2016-02-10 09:32:54.000000000","message":"Done","commit_id":"d390a0dc8e877f694bc9807656ba5a1f53599455"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"1fa176e44d350ed66bb0d1f482c0554deed8dba4","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"class BaseISCSIConnector(InitiatorConnector):"},{"line_number":564,"context_line":"    def _iterate_all_targets(self, connection_properties):"},{"line_number":565,"context_line":"        for ip, iqn, lun in self._get_all_targets(connection_properties):"},{"line_number":566,"context_line":"            props \u003d copy.deepcopy(connection_properties)"},{"line_number":567,"context_line":"            props[\u0027target_portal\u0027] \u003d ip"},{"line_number":568,"context_line":"            props[\u0027target_iqn\u0027] \u003d iqn"}],"source_content_type":"text/x-python","patch_set":29,"id":"3aaa91ec_91886824","line":565,"updated":"2016-06-22 12:44:20.000000000","message":"because of the merge conflict, this is changed to:\n\n    for portal, iqn, lun in self._get_all_targets(connection_properties):","commit_id":"1436fab281c7ca1fb5879127e91e3387be2ab2e2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8657c28a2c7384ec708b9aaabec880b038e421e6","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        return [(connection_properties[\u0027target_portal\u0027],"},{"line_number":583,"context_line":"                 connection_properties[\u0027target_iqn\u0027],"},{"line_number":584,"context_line":"                 connection_properties.get(\u0027target_lun\u0027, 0))]"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class ISCSIConnector(BaseLinuxConnector, BaseISCSIConnector):"}],"source_content_type":"text/x-python","patch_set":29,"id":"7aa08908_89e29cd3","line":584,"updated":"2016-06-17 17:39:12.000000000","message":"Now that we are moving more code into the BaseISCSIConnector, I think we should break out the unit tests and ensure that there are unit tests specifically against the BaseISCSIConnector.","commit_id":"1436fab281c7ca1fb5879127e91e3387be2ab2e2"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"1fa176e44d350ed66bb0d1f482c0554deed8dba4","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        return [(connection_properties[\u0027target_portal\u0027],"},{"line_number":583,"context_line":"                 connection_properties[\u0027target_iqn\u0027],"},{"line_number":584,"context_line":"                 connection_properties.get(\u0027target_lun\u0027, 0))]"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class ISCSIConnector(BaseLinuxConnector, BaseISCSIConnector):"}],"source_content_type":"text/x-python","patch_set":29,"id":"3aaa91ec_91a188ac","line":584,"in_reply_to":"7aa08908_89e29cd3","updated":"2016-06-22 12:44:20.000000000","message":"Done, there weren\u0027t any (direct) unit tests for these anyways.","commit_id":"1436fab281c7ca1fb5879127e91e3387be2ab2e2"}],"os_brick/initiator/windows/iscsi.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"cda3a33cd4d2ea0a3c9528a99bc5470643eb0231","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if not self.initiator_list:"},{"line_number":42,"context_line":"            LOG.info(_LI(\"No iSCSI initiator was explicitly requested. \""},{"line_number":43,"context_line":"                         \"The Microsoft iSCSI initiator will choose the \""},{"line_number":44,"context_line":"                         \"initiator when estabilishing sessions.\"))"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            available_initiators \u003d self._iscsi_utils.get_iscsi_initiators()"},{"line_number":47,"context_line":"            for initiator in self.initiator_list:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9abb7d3a_a6d029ca","line":44,"updated":"2016-06-01 16:36:40.000000000","message":"this case is not covered.","commit_id":"bdfb28ee1e61ee7c31349610934ed9963bc4a206"}],"os_brick/initiator/windows/windows_connector.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f32282826848b4e4d5a614e2cd42e70ebaa6ebaa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        connector.FIBRE_CHANNEL: FibreChannelConnector,"},{"line_number":35,"context_line":"        connector.SMBFS: SMBFSConnector,"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"    return connector_dict"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_connector(protocol, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_33bbd210","line":37,"updated":"2016-02-09 19:08:03.000000000","message":"If I\u0027m not mistaken, this dictionary isn\u0027t changed. So, you can just make it a constant.","commit_id":"69d38496479ee4216cf037aaf97ec26f1896f6eb"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a0f05c9eea2bba19fa4341713e6ae5b486d71939","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        connector.FIBRE_CHANNEL: FibreChannelConnector,"},{"line_number":35,"context_line":"        connector.SMBFS: SMBFSConnector,"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"    return connector_dict"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_connector(protocol, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_f2cbd170","line":37,"in_reply_to":"3a57f1b5_33bbd210","updated":"2016-02-10 11:27:44.000000000","message":"Actually, it wouldn\u0027t work that way, unless I put it at the end of the module. Otherwise, you\u0027d get an \u0027undefined\u0027 error.","commit_id":"69d38496479ee4216cf037aaf97ec26f1896f6eb"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"0a7b355d763f76a6ca7e19a91e60a78cda88c4e3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        connector.FIBRE_CHANNEL: FibreChannelConnector,"},{"line_number":35,"context_line":"        connector.SMBFS: SMBFSConnector,"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"    return connector_dict"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_connector(protocol, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_712606bc","line":37,"in_reply_to":"3a57f1b5_33bbd210","updated":"2016-02-10 09:32:54.000000000","message":"Done","commit_id":"69d38496479ee4216cf037aaf97ec26f1896f6eb"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f32282826848b4e4d5a614e2cd42e70ebaa6ebaa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                    \"properly configured, thus not claiming the device \""},{"line_number":121,"context_line":"                    \"paths. This issue must be addressed urgently as \""},{"line_number":122,"context_line":"                    \"it can lead to data corruption.\"),"},{"line_number":123,"context_line":"                device_paths)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def extend_volume(self, connection_properties):"},{"line_number":126,"context_line":"        volume_paths \u003d self.get_volume_paths(connection_properties)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_53f8ce7c","line":123,"updated":"2016-02-09 19:08:03.000000000","message":"sounds like a more serious problem. are we sure that only logging an error is enough in this case? when it comes to data corruption, I think raising an exception would be a safer alternative.","commit_id":"69d38496479ee4216cf037aaf97ec26f1896f6eb"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"0a7b355d763f76a6ca7e19a91e60a78cda88c4e3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                    \"properly configured, thus not claiming the device \""},{"line_number":121,"context_line":"                    \"paths. This issue must be addressed urgently as \""},{"line_number":122,"context_line":"                    \"it can lead to data corruption.\"),"},{"line_number":123,"context_line":"                device_paths)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def extend_volume(self, connection_properties):"},{"line_number":126,"context_line":"        volume_paths \u003d self.get_volume_paths(connection_properties)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_113f92b5","line":123,"in_reply_to":"3a57f1b5_53f8ce7c","updated":"2016-02-10 09:32:54.000000000","message":"Makes sense, I\u0027ll raise an exception instead.","commit_id":"69d38496479ee4216cf037aaf97ec26f1896f6eb"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            with open(path, \u0027r\u0027) as dev:"},{"line_number":103,"context_line":"                dev.read(1)"},{"line_number":104,"context_line":"        except Exception as exc:"},{"line_number":105,"context_line":"            LOG.error(_LE(\"Failed to access the device on the path \""},{"line_number":106,"context_line":"                          \"%(path)s: %(exc)s.\"),"},{"line_number":107,"context_line":"                      {\"path\": path,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_49e2ba30","line":104,"updated":"2016-02-12 12:59:30.000000000","message":"Should we handle more specific exception here?","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            with open(path, \u0027r\u0027) as dev:"},{"line_number":103,"context_line":"                dev.read(1)"},{"line_number":104,"context_line":"        except Exception as exc:"},{"line_number":105,"context_line":"            LOG.error(_LE(\"Failed to access the device on the path \""},{"line_number":106,"context_line":"                          \"%(path)s: %(exc)s.\"),"},{"line_number":107,"context_line":"                      {\"path\": path,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_c4ea0f74","line":104,"in_reply_to":"3a57f1b5_49e2ba30","updated":"2016-02-12 13:32:30.000000000","message":"I guess we can just go for IOError.","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            with open(path, \u0027r\u0027) as dev:"},{"line_number":103,"context_line":"                dev.read(1)"},{"line_number":104,"context_line":"        except Exception as exc:"},{"line_number":105,"context_line":"            LOG.error(_LE(\"Failed to access the device on the path \""},{"line_number":106,"context_line":"                          \"%(path)s: %(exc)s.\"),"},{"line_number":107,"context_line":"                      {\"path\": path,"},{"line_number":108,"context_line":"                       \"exc\": exc})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_49b95a14","line":105,"updated":"2016-02-12 12:59:30.000000000","message":"LOG.error \u003d\u003e LOG.exception","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            with open(path, \u0027r\u0027) as dev:"},{"line_number":103,"context_line":"                dev.read(1)"},{"line_number":104,"context_line":"        except Exception as exc:"},{"line_number":105,"context_line":"            LOG.error(_LE(\"Failed to access the device on the path \""},{"line_number":106,"context_line":"                          \"%(path)s: %(exc)s.\"),"},{"line_number":107,"context_line":"                      {\"path\": path,"},{"line_number":108,"context_line":"                       \"exc\": exc})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_64047b49","line":105,"in_reply_to":"3a57f1b5_49b95a14","updated":"2016-02-12 13:32:30.000000000","message":"Done","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        return None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ISCSIConnector(BaseWindowsConnector, connector.BaseISCSIConnector):"},{"line_number":141,"context_line":"    _DEFAULT_INITIATOR_LIST \u003d [None]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_29017eaf","line":140,"updated":"2016-02-12 12:59:30.000000000","message":"May be add \u0027Windows\u0027 prefix to connectors is a good idea to get unique name of classes","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        return None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class ISCSIConnector(BaseWindowsConnector, connector.BaseISCSIConnector):"},{"line_number":141,"context_line":"    _DEFAULT_INITIATOR_LIST \u003d [None]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_648b1bc4","line":140,"in_reply_to":"3a57f1b5_29017eaf","updated":"2016-02-12 13:32:30.000000000","message":"Makes sense.","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                if not self.use_multipath:"},{"line_number":220,"context_line":"                    break"},{"line_number":221,"context_line":"            except os_win_exc.OSWinException as ex:"},{"line_number":222,"context_line":"                LOG.exception(ex)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        if not volume_connected:"},{"line_number":225,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_89cd1287","line":222,"updated":"2016-02-12 12:59:30.000000000","message":"No need to pass exception instance for LOG.exception method. Please, add error message instead of it","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                if not self.use_multipath:"},{"line_number":220,"context_line":"                    break"},{"line_number":221,"context_line":"            except os_win_exc.OSWinException as ex:"},{"line_number":222,"context_line":"                LOG.exception(ex)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        if not volume_connected:"},{"line_number":225,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_0a6cb1ce","line":222,"in_reply_to":"3a57f1b5_89cd1287","updated":"2016-02-12 13:32:30.000000000","message":"Well, I wanted the full trace to be logged, even if just one of the sessions could not be estabilished and the volume was properly connected, so that the admin can take proper actions.\n\nAlso, the exceptions raised by os_win would be really meaningful, explaining what failed. So I think it\u0027s safe to leave it this way.","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def get_connector_properties(*args, **kwargs):"},{"line_number":274,"context_line":"        return {}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":277,"context_line":"        self.ensure_share_mounted(connection_properties)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_697e961a","line":274,"updated":"2016-02-12 12:59:30.000000000","message":"Please, add a comment if we really want to return empty dictionary here","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def get_connector_properties(*args, **kwargs):"},{"line_number":274,"context_line":"        return {}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":277,"context_line":"        self.ensure_share_mounted(connection_properties)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_cab1b948","line":274,"in_reply_to":"3a57f1b5_697e961a","updated":"2016-02-12 13:32:30.000000000","message":"Done","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aec4431a6e3b1b04a83f87b4131a9435fad44fad","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                if not self.use_multipath:"},{"line_number":220,"context_line":"                    break"},{"line_number":221,"context_line":"            except os_win_exc.OSWinException as ex:"},{"line_number":222,"context_line":"                LOG.exception(ex)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        if not volume_connected:"},{"line_number":225,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_4980e846","line":222,"updated":"2016-04-18 13:02:40.000000000","message":"This is not correct. ex should not be passed in to LOG.exception. Change to some sort of message for the exception logging.","commit_id":"3797786874ae4851e3aad890bb12f827cd9d5270"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"6fb4d376ef6f08495a77c6f3bfb571bef3172a21","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                if not self.use_multipath:"},{"line_number":220,"context_line":"                    break"},{"line_number":221,"context_line":"            except os_win_exc.OSWinException as ex:"},{"line_number":222,"context_line":"                LOG.exception(ex)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        if not volume_connected:"},{"line_number":225,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_89cde05f","line":222,"in_reply_to":"1a122d0e_4980e846","updated":"2016-04-18 13:10:33.000000000","message":"Good point, I\u0027ve missed that out. Thanks!","commit_id":"3797786874ae4851e3aad890bb12f827cd9d5270"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        volume_paths \u003d self.get_volume_paths(connection_properties)"},{"line_number":126,"context_line":"        if not volume_paths:"},{"line_number":127,"context_line":"            err_msg \u003d _(\"Could not find the disk. Extend failed.\")"},{"line_number":128,"context_line":"            raise exception.BrickException(err_msg)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        device_path \u003d volume_paths[0]"},{"line_number":131,"context_line":"        device_number \u003d self._diskutils.get_device_number_from_device_name("}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_283e58da","line":128,"updated":"2016-05-25 02:37:03.000000000","message":"untested code path.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        volume_paths \u003d self.get_volume_paths(connection_properties)"},{"line_number":126,"context_line":"        if not volume_paths:"},{"line_number":127,"context_line":"            err_msg \u003d _(\"Could not find the disk. Extend failed.\")"},{"line_number":128,"context_line":"            raise exception.BrickException(err_msg)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        device_path \u003d volume_paths[0]"},{"line_number":131,"context_line":"        device_number \u003d self._diskutils.get_device_number_from_device_name("}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_dc360e50","line":128,"in_reply_to":"bab6814e_283e58da","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                if not self.use_multipath:"},{"line_number":218,"context_line":"                    break"},{"line_number":219,"context_line":"            except os_win_exc.OSWinException:"},{"line_number":220,"context_line":"                LOG.exception(_LE(\"Could not estabilish the iSCSI session.\"))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if not volume_connected:"},{"line_number":223,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_233799b1","line":220,"updated":"2016-05-25 02:37:03.000000000","message":"ust a curiosity, can you add some extra info about what volume session couldn\u0027t be established? might be useful for debbuing.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                if not self.use_multipath:"},{"line_number":218,"context_line":"                    break"},{"line_number":219,"context_line":"            except os_win_exc.OSWinException:"},{"line_number":220,"context_line":"                LOG.exception(_LE(\"Could not estabilish the iSCSI session.\"))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if not volume_connected:"},{"line_number":223,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_94ae162c","line":220,"in_reply_to":"bab6814e_233799b1","updated":"2016-05-26 16:23:19.000000000","message":"I\u0027m already logging this kind of information when attempting to establish the session, I guess that\u0027s enough. You can easily match those messages by the request id.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                LOG.exception(_LE(\"Could not estabilish the iSCSI session.\"))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if not volume_connected:"},{"line_number":223,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        scsi_wwn \u003d self._get_scsi_wwn(device_number)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_83bf65fb","line":223,"updated":"2016-05-25 02:37:03.000000000","message":"just a curiosity, can you add some extra info about what volume couldn\u0027t be connected? it would be useful for debugging.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                LOG.exception(_LE(\"Could not estabilish the iSCSI session.\"))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if not volume_connected:"},{"line_number":223,"context_line":"            raise exception.BrickException(_(\"Could not connect volume.\"))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        scsi_wwn \u003d self._get_scsi_wwn(device_number)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_d774279d","line":223,"in_reply_to":"bab6814e_83bf65fb","updated":"2016-05-26 16:23:19.000000000","message":"We can rely on the message I\u0027ve previously mentioned or I can just log the connection properties, but that may be considered sensitive data.\n\nAs an alternative, we may log just the volume id, but that is not guaranteed to be present in the connection properties.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"728556e8859feba8ac37b64787695f7f184f41a4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return connector_dict"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_connector(protocol, *args, **kwargs):"},{"line_number":41,"context_line":"    LOG.debug(\"Retrieving connector for protocol: %s.\", protocol)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    conn_cls \u003d _get_connectors().get(protocol.upper())"}],"source_content_type":"text/x-python","patch_set":23,"id":"bab6814e_8996f849","line":40,"updated":"2016-05-26 19:06:25.000000000","message":"can we rename this to factory, just to be consistent with the other factory?\n\nAlso, \n   one of the issues we have with the current connector.py is that it has grown to be so large is hard to manage.   I\u0027d like to avoid this in the windows_connector.py and split out each individual connector into it\u0027s own file.\n\nso something like\nwindows/iscsi.py\nwindows/smbfs.py\nwindows/fibre_channel.py\n\nWe are actively working on trying to split out the linux connectors into their own files as well, but we have a circular dependency issue.","commit_id":"f6abfdf706737788d2ab49785e116f7c2a042cbd"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"7436382c6b10a01cf5d931a890305037da584c69","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return connector_dict"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def get_connector(protocol, *args, **kwargs):"},{"line_number":41,"context_line":"    LOG.debug(\"Retrieving connector for protocol: %s.\", protocol)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    conn_cls \u003d _get_connectors().get(protocol.upper())"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_df7139aa","line":40,"in_reply_to":"bab6814e_8996f849","updated":"2016-05-30 10:33:15.000000000","message":"Good point, I have addressed this in the latest patch set.","commit_id":"f6abfdf706737788d2ab49785e116f7c2a042cbd"}],"os_brick/tests/remotefs/test_windows_remotefs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def test_create_new_mount_point(self):"},{"line_number":89,"context_line":"        self._test_create_mount_point()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_mount_point_existing_symlink(self):"},{"line_number":92,"context_line":"        self._test_create_mount_point(path_exists\u003dTrue, is_symlink\u003dTrue)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_mount_point_existing_not_symlink(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_091922d7","line":91,"updated":"2016-02-12 12:59:30.000000000","message":"Please, use ddt library instead of calling self._test_create_mount_point with different params","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def test_create_new_mount_point(self):"},{"line_number":89,"context_line":"        self._test_create_mount_point()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_mount_point_existing_symlink(self):"},{"line_number":92,"context_line":"        self._test_create_mount_point(path_exists\u003dTrue, is_symlink\u003dTrue)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_mount_point_existing_not_symlink(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_ea1fd505","line":91,"in_reply_to":"3a57f1b5_091922d7","updated":"2016-02-12 13:32:30.000000000","message":"I thought about using it, but it was not in the test-requirements, nor was it used by any of the os-brick tests.\n\nCan I just add ddt to test-requirements in this change or do I need a new patch for this?","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"}],"os_brick/tests/windows/test_factory.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2090495d1a6bc1419c544e3c854cc7ed0372ce60","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @ddt.unpack"},{"line_number":36,"context_line":"    @mock.patch.object(windows_remotefs, \u0027WindowsRemoteFsClient\u0027)"},{"line_number":37,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)"},{"line_number":38,"context_line":"    def test_factory(self, mock_remotefs, proto, expected_cls):"},{"line_number":39,"context_line":"        obj \u003d connector.InitiatorConnector.factory(proto, None)"},{"line_number":40,"context_line":"        self.assertIsInstance(obj, expected_cls)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9abb7d3a_e93fe284","line":38,"updated":"2016-05-31 16:08:13.000000000","message":"this looks wrong.\n\nyou have self, 2 mocks, 2 other arguments. you\u0027re missing a mock.","commit_id":"5f8123ada789fa62cc7f0e95ebec8811a1ae34fc"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"07b6731ee5ca1e4c36fcca8e3900561876019074","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @ddt.unpack"},{"line_number":36,"context_line":"    @mock.patch.object(windows_remotefs, \u0027WindowsRemoteFsClient\u0027)"},{"line_number":37,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)"},{"line_number":38,"context_line":"    def test_factory(self, mock_remotefs, proto, expected_cls):"},{"line_number":39,"context_line":"        obj \u003d connector.InitiatorConnector.factory(proto, None)"},{"line_number":40,"context_line":"        self.assertIsInstance(obj, expected_cls)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9abb7d3a_d6741f37","line":38,"in_reply_to":"9abb7d3a_e93fe284","updated":"2016-06-01 05:39:09.000000000","message":"Nope, I guess this causes the confusion:\n@mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)\n\nsys.platform is the patched object, \u0027win32\u0027 is the new value. If you explicitly pass the new value when using a mock decorator, it will not be among the decorated method arguments anymore.","commit_id":"5f8123ada789fa62cc7f0e95ebec8811a1ae34fc"}],"os_brick/tests/windows/test_windows_connector.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @mock.patch.object(windows_connector, \u0027utilsfactory\u0027)"},{"line_number":32,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)"},{"line_number":33,"context_line":"    def test_factory(self, mock_utilsfactory, mock_remotefs):"},{"line_number":34,"context_line":"        obj \u003d connector.InitiatorConnector.factory(connector.ISCSI, None)"},{"line_number":35,"context_line":"        self.assertIsInstance(obj, windows_connector.ISCSIConnector)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        obj \u003d connector.InitiatorConnector.factory(connector.FIBRE_CHANNEL,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_e97a86f0","line":34,"updated":"2016-02-12 12:59:30.000000000","message":"This tests is a good candidate to use ddt library","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d89d19252410f4f1bfb4a9cc12273098865c5ea5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @mock.patch.object(windows_connector, \u0027utilsfactory\u0027)"},{"line_number":32,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)"},{"line_number":33,"context_line":"    def test_factory(self, mock_utilsfactory, mock_remotefs):"},{"line_number":34,"context_line":"        obj \u003d connector.InitiatorConnector.factory(connector.ISCSI, None)"},{"line_number":35,"context_line":"        self.assertIsInstance(obj, windows_connector.ISCSIConnector)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        obj \u003d connector.InitiatorConnector.factory(connector.FIBRE_CHANNEL,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_0adb5150","line":34,"in_reply_to":"3a57f1b5_e97a86f0","updated":"2016-02-12 13:32:30.000000000","message":"Indeed.","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a837b3e996356fec614ea98e8578fcacdde2c82","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            mock_hostutils.FEATURE_MPIO)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_check_multipath_support_available(self):"},{"line_number":68,"context_line":"        self._test_check_multipath_support()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_check_multipath_support_unavailable(self):"},{"line_number":71,"context_line":"        self._test_check_multipath_support(feature_available\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_8925120a","line":68,"updated":"2016-02-12 12:59:30.000000000","message":"Please use ddt library","commit_id":"21307d10a3aa50dc16473f4cf61c44bd779925e6"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @mock.patch.object(win_conn.BaseWindowsConnector,"},{"line_number":74,"context_line":"                       \u0027check_multipath_support\u0027)"},{"line_number":75,"context_line":"    @ddt.unpack"},{"line_number":76,"context_line":"    def test_get_connector_properties(self, mock_check_mpio,"},{"line_number":77,"context_line":"                                      mpio_requested\u003dTrue,"},{"line_number":78,"context_line":"                                      mpio_available\u003dTrue):"},{"line_number":79,"context_line":"        mock_check_mpio.return_value \u003d mpio_available"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_68686022","line":76,"updated":"2016-05-25 02:37:03.000000000","message":"there\u0027s an inconsistentcy here. \n\nSo, either move this test to WindowsConnectorUtilsTestCase, or move the test_check_multipath_support here. Both tested methods belong to BaseWindowsConnector, I\u0027d have both tests here.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @mock.patch.object(win_conn.BaseWindowsConnector,"},{"line_number":74,"context_line":"                       \u0027check_multipath_support\u0027)"},{"line_number":75,"context_line":"    @ddt.unpack"},{"line_number":76,"context_line":"    def test_get_connector_properties(self, mock_check_mpio,"},{"line_number":77,"context_line":"                                      mpio_requested\u003dTrue,"},{"line_number":78,"context_line":"                                      mpio_available\u003dTrue):"},{"line_number":79,"context_line":"        mock_check_mpio.return_value \u003d mpio_available"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_f70deb8f","line":76,"in_reply_to":"bab6814e_68686022","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self._connector._diskutils \u003d self._diskutils"},{"line_number":103,"context_line":"        self._connector._iscsi_utils \u003d self._iscsi_utils"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_get_scsi_wwn(self):"},{"line_number":106,"context_line":"        mock_get_uid_and_type \u003d self._diskutils.get_disk_uid_and_uid_type"},{"line_number":107,"context_line":"        mock_get_uid_and_type.return_value \u003d (mock.sentinel.disk_uid,"},{"line_number":108,"context_line":"                                              mock.sentinel.uid_type)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_28a2d84b","line":105,"updated":"2016-05-25 02:37:03.000000000","message":"method is defined in BaseWindowsConnector, I\u0027d move this test to BaseWindowsConnectorTestCase.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self._connector._diskutils \u003d self._diskutils"},{"line_number":103,"context_line":"        self._connector._iscsi_utils \u003d self._iscsi_utils"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_get_scsi_wwn(self):"},{"line_number":106,"context_line":"        mock_get_uid_and_type \u003d self._diskutils.get_disk_uid_and_uid_type"},{"line_number":107,"context_line":"        mock_get_uid_and_type.return_value \u003d (mock.sentinel.disk_uid,"},{"line_number":108,"context_line":"                                              mock.sentinel.uid_type)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_b7652346","line":105,"in_reply_to":"bab6814e_28a2d84b","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @ddt.data(None, IOError)"},{"line_number":117,"context_line":"    @mock.patch.object(six.moves.builtins, \u0027open\u0027)"},{"line_number":118,"context_line":"    def test_check_valid_device(self, exc, mock_open):"},{"line_number":119,"context_line":"        mock_open.side_effect \u003d exc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        valid_device \u003d self._connector.check_valid_device("}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_68ab401f","line":118,"updated":"2016-05-25 02:37:03.000000000","message":"ditto.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @ddt.data(None, IOError)"},{"line_number":117,"context_line":"    @mock.patch.object(six.moves.builtins, \u0027open\u0027)"},{"line_number":118,"context_line":"    def test_check_valid_device(self, exc, mock_open):"},{"line_number":119,"context_line":"        mock_open.side_effect \u003d exc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        valid_device \u003d self._connector.check_valid_device("}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_f75b2b84","line":118,"in_reply_to":"bab6814e_68ab401f","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if not exc:"},{"line_number":128,"context_line":"            mock_read.assert_called_once_with(1)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_check_device_paths(self):"},{"line_number":131,"context_line":"        # We expect an exception to be raised if the same volume"},{"line_number":132,"context_line":"        # can be accessed through multiple paths."},{"line_number":133,"context_line":"        device_paths \u003d [mock.sentinel.dev_path_0,"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_a87c08b6","line":130,"updated":"2016-05-25 02:37:03.000000000","message":"ditto.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if not exc:"},{"line_number":128,"context_line":"            mock_read.assert_called_once_with(1)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_check_device_paths(self):"},{"line_number":131,"context_line":"        # We expect an exception to be raised if the same volume"},{"line_number":132,"context_line":"        # can be accessed through multiple paths."},{"line_number":133,"context_line":"        device_paths \u003d [mock.sentinel.dev_path_0,"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_5755d74d","line":130,"in_reply_to":"bab6814e_a87c08b6","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f1c86a2ea8f96c932a9543314b0e05380307ce16","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          device_paths)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(win_conn.WindowsISCSIConnector, \u0027get_volume_paths\u0027)"},{"line_number":140,"context_line":"    def test_extend_volume(self, mock_get_vol_paths):"},{"line_number":141,"context_line":"        mock_vol_paths \u003d [mock.sentinel.dev_path]"},{"line_number":142,"context_line":"        mock_get_vol_paths.return_value \u003d mock_vol_paths"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_48447c73","line":140,"updated":"2016-05-25 02:37:03.000000000","message":"ditto.","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8a9a1fc26e616b884c168c529372ee849e771673","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          device_paths)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(win_conn.WindowsISCSIConnector, \u0027get_volume_paths\u0027)"},{"line_number":140,"context_line":"    def test_extend_volume(self, mock_get_vol_paths):"},{"line_number":141,"context_line":"        mock_vol_paths \u003d [mock.sentinel.dev_path]"},{"line_number":142,"context_line":"        mock_get_vol_paths.return_value \u003d mock_vol_paths"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_3752d367","line":140,"in_reply_to":"bab6814e_48447c73","updated":"2016-05-26 16:23:19.000000000","message":"Done","commit_id":"0fdd502f5eb14e25feb2970a28dcccf9ea51fb18"}]}
