)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"faf6a3efa8f4ded096d685097feacf970f410766","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a WIP Patch"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch changes how the get_connector_properties works.  It migrates"},{"line_number":12,"context_line":"the code for each specific connector type\u0027s cinnector_properties (initiator)"},{"line_number":13,"context_line":"into the connector itself.   It also only calls each connector that matches"},{"line_number":14,"context_line":"the platform and the os type.  This will allow us to add Windows based"},{"line_number":15,"context_line":"connectors in the future.  So, when os-brick is running on windows, it won\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_74e684b5","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":64},"updated":"2016-02-15 17:43:49.000000000","message":"cinnector_properties -\u003e connector_properties","commit_id":"d390a0dc8e877f694bc9807656ba5a1f53599455"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"55055e02ae930d4f57bbd11195f194310d81d8b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os-brick refactor get_connector_properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes how the get_connector_properties works.  It migrates"},{"line_number":10,"context_line":"the code for each specific connector type\u0027s cinnector_properties (initiator)"},{"line_number":11,"context_line":"into the connector itself.   It also only calls each connector that matches"},{"line_number":12,"context_line":"the platform and the os type.  This will allow us to add Windows based"},{"line_number":13,"context_line":"connectors in the future.  So, when os-brick is running on windows, it won\u0027t"},{"line_number":14,"context_line":"call any of the linux based connectors to fetch the initiator information, as"},{"line_number":15,"context_line":"they won\u0027t work."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"I\u0027m not sure it\u0027s necessary to filter by platform as well, but it seemed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_0b874313","line":14,"range":{"start_line":9,"start_character":71,"end_line":14,"end_character":77},"updated":"2016-04-21 16:49:21.000000000","message":"Lines should get wrapped at 72 characters, but not that big a deal.","commit_id":"3203708f54a331a876a6ef8d7623c200bd82f2f8"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"6feb2f042138b3fe8e37cabaefdd49ddac643521","unresolved":false,"context_lines":[{"line_number":67,"context_line":"PLATFORM_S390 \u003d \u0027S390\u0027"},{"line_number":68,"context_line":"OS_TYPE_ALL \u003d \u0027ALL\u0027"},{"line_number":69,"context_line":"OS_TYPE_LINUX \u003d \u0027LINUX\u0027"},{"line_number":70,"context_line":"OS_TYPE_WINDOWS \u003d \u0027WINDOWS\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"S390X \u003d \"s390x\""},{"line_number":73,"context_line":"S390 \u003d \"s390\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_195dc046","line":70,"updated":"2016-02-08 12:45:31.000000000","message":"I guess this should be \"WIN32\" or \"WIN\", considering the way the os type is checked and the fact that on Windows, sys.platform will always be \u0027win32\u0027.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"610afe23cd62b7634fdca7394d75c97c1750808e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"PLATFORM_S390 \u003d \u0027S390\u0027"},{"line_number":68,"context_line":"OS_TYPE_ALL \u003d \u0027ALL\u0027"},{"line_number":69,"context_line":"OS_TYPE_LINUX \u003d \u0027LINUX\u0027"},{"line_number":70,"context_line":"OS_TYPE_WINDOWS \u003d \u0027WINDOWS\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"S390X \u003d \"s390x\""},{"line_number":73,"context_line":"S390 \u003d \"s390\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_04777ea0","line":70,"in_reply_to":"5a5ae5dd_195dc046","updated":"2016-02-08 19:26:07.000000000","message":"ok thanks I\u0027ll change this to WIN32 ?","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"2c2ac6310ca3c9b0b8573a53c4a12d16cd4d553d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":175,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":178,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_950c9e95","line":175,"updated":"2016-02-04 10:37:47.000000000","message":"I guess this should be OS_TYPE_ALL","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8a8fb7a10b50dab163d7065bc3ddee17ab16c9c1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":175,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":178,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8b4e9a94","line":175,"in_reply_to":"5a5ae5dd_950c9e95","updated":"2016-02-04 21:55:12.000000000","message":"It should be, but can\u0027t just yet, because of the call to _check_multipathd_running() inside of get_connector_properties.  It\u0027s linux specific right now.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"56365c0d42617de60381d3228a732d432b83165b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""},{"line_number":190,"context_line":"        self.driver \u003d driver"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @staticmethod"},{"line_number":193,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":194,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":195,"context_line":"        multipath \u003d kwargs[\u0027multipath\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_30844a09","line":192,"updated":"2016-02-08 14:15:29.000000000","message":"Can we make this a regular method instead? The connector may need some resources that are set up in init.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1e4876d44a92c115d9da4adf4ae3564803193779","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""},{"line_number":190,"context_line":"        self.driver \u003d driver"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @staticmethod"},{"line_number":193,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":194,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":195,"context_line":"        multipath \u003d kwargs[\u0027multipath\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_bb433bae","line":192,"in_reply_to":"5a5ae5dd_30844a09","updated":"2016-02-08 14:38:02.000000000","message":"I think I get it now, you actually instantiate the connector in the inherited method because the connector constructor signatures are different in some cases (e.g. RemoteFS), so it\u0027s easier to loop over the connectors this way.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"3c05a9ec17e49f8c2ef2f3c236c1c6a6c3b522b1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        enforce_multipath \u003d kwargs[\u0027enforce_multipath\u0027]"},{"line_number":197,"context_line":"        props \u003d {}"},{"line_number":198,"context_line":"        # TODO(walter-boring) move this into platform specific lib"},{"line_number":199,"context_line":"        props[\u0027multipath\u0027] \u003d (multipath and"},{"line_number":200,"context_line":"                              _check_multipathd_running(root_helper,"},{"line_number":201,"context_line":"                                                        enforce_multipath))"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_b9f02cca","line":199,"updated":"2016-02-08 12:37:31.000000000","message":"To make this easier, we could have a generic method called \"check_multipath_support\" which we can then override in a platform specific connector.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"610afe23cd62b7634fdca7394d75c97c1750808e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        enforce_multipath \u003d kwargs[\u0027enforce_multipath\u0027]"},{"line_number":197,"context_line":"        props \u003d {}"},{"line_number":198,"context_line":"        # TODO(walter-boring) move this into platform specific lib"},{"line_number":199,"context_line":"        props[\u0027multipath\u0027] \u003d (multipath and"},{"line_number":200,"context_line":"                              _check_multipathd_running(root_helper,"},{"line_number":201,"context_line":"                                                        enforce_multipath))"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_04853e58","line":199,"in_reply_to":"5a5ae5dd_b9f02cca","updated":"2016-02-08 19:26:07.000000000","message":"yah I think that\u0027s what should happen as well, but it should exist in the linuxscsi.py and the windows connector can have windowsscsi.py that has the same method.","commit_id":"8bd128df8d576d5867dc017575593a699afa963e"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"19fde83e80fac6faadb006904b47e5be116c9d17","unresolved":false,"context_lines":[{"line_number":91,"context_line":"VZSTORAGE \u003d \"VZSTORAGE\""},{"line_number":92,"context_line":"SHEEPDOG \u003d \"SHEEPDOG\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"connector_map \u003d ["},{"line_number":95,"context_line":"    \u0027os_brick.initiator.connector.InitiatorConnector\u0027,"},{"line_number":96,"context_line":"    \u0027os_brick.initiator.connector.ISCSIConnector\u0027,"},{"line_number":97,"context_line":"    \u0027os_brick.initiator.connector.FibreChannelConnector\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_206167a9","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":13},"updated":"2016-05-02 21:23:12.000000000","message":"shouldn\u0027t we call it list or something if it isn\u0027t a map?","commit_id":"85cc1d4b16ab73e731e01b31e3852ef2c98a78df"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f278a2eb125c1bf83f24d7839a6d7dfe0fa96654","unresolved":false,"context_lines":[{"line_number":91,"context_line":"VZSTORAGE \u003d \"VZSTORAGE\""},{"line_number":92,"context_line":"SHEEPDOG \u003d \"SHEEPDOG\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"connector_map \u003d ["},{"line_number":95,"context_line":"    \u0027os_brick.initiator.connector.InitiatorConnector\u0027,"},{"line_number":96,"context_line":"    \u0027os_brick.initiator.connector.ISCSIConnector\u0027,"},{"line_number":97,"context_line":"    \u0027os_brick.initiator.connector.FibreChannelConnector\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_49c4875e","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":13},"in_reply_to":"1a122d0e_206167a9","updated":"2016-05-03 04:18:10.000000000","message":"sure that\u0027s easy enough","commit_id":"85cc1d4b16ab73e731e01b31e3852ef2c98a78df"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"19fde83e80fac6faadb006904b47e5be116c9d17","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""},{"line_number":180,"context_line":"        self.driver \u003d driver"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"},{"line_number":183,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":185,"context_line":"        multipath \u003d kwargs[\u0027multipath\u0027]"},{"line_number":186,"context_line":"        enforce_multipath \u003d kwargs[\u0027enforce_multipath\u0027]"},{"line_number":187,"context_line":"        props \u003d {}"},{"line_number":188,"context_line":"        # TODO(walter-boring) move this into platform specific lib"},{"line_number":189,"context_line":"        props[\u0027multipath\u0027] \u003d (multipath and"},{"line_number":190,"context_line":"                              linuxscsi.LinuxSCSI.is_multipath_running("},{"line_number":191,"context_line":"                                  enforce_multipath, root_helper))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return props"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @staticmethod"},{"line_number":196,"context_line":"    def factory(protocol, root_helper, driver\u003dNone,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_e0bf6fa8","line":193,"range":{"start_line":182,"start_character":4,"end_line":193,"end_character":20},"updated":"2016-05-02 21:23:12.000000000","message":"Maybe I\u0027m missing something, but for like the iSCSI and FC connectors they override this and don\u0027t call super() to pick up the multipath info, and there were a bunch of others that just override it and return {}. Maybe we should move this mpath stuff into a helper that can be called by the connectors that support it, and the base connector class just does the {}?","commit_id":"85cc1d4b16ab73e731e01b31e3852ef2c98a78df"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f278a2eb125c1bf83f24d7839a6d7dfe0fa96654","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""},{"line_number":180,"context_line":"        self.driver \u003d driver"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"},{"line_number":183,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":185,"context_line":"        multipath \u003d kwargs[\u0027multipath\u0027]"},{"line_number":186,"context_line":"        enforce_multipath \u003d kwargs[\u0027enforce_multipath\u0027]"},{"line_number":187,"context_line":"        props \u003d {}"},{"line_number":188,"context_line":"        # TODO(walter-boring) move this into platform specific lib"},{"line_number":189,"context_line":"        props[\u0027multipath\u0027] \u003d (multipath and"},{"line_number":190,"context_line":"                              linuxscsi.LinuxSCSI.is_multipath_running("},{"line_number":191,"context_line":"                                  enforce_multipath, root_helper))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return props"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @staticmethod"},{"line_number":196,"context_line":"    def factory(protocol, root_helper, driver\u003dNone,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_898b3f1e","line":193,"range":{"start_line":182,"start_character":4,"end_line":193,"end_character":20},"in_reply_to":"1a122d0e_e0bf6fa8","updated":"2016-05-03 04:18:10.000000000","message":"So there is no super call at all because 1) it\u0027s a static\nand 2) the helper function calls every connector and adds the results to the dictionary returned.   So this one is called, and then iSCSI is called to collect only the iSCSI properties, and FC is called to collect only the FC related properties.  multipath is a system wide capability that isn\u0027t necesarrily tied to either iSCSI or FC.","commit_id":"85cc1d4b16ab73e731e01b31e3852ef2c98a78df"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"PLATFORM_S390 \u003d \u0027S390\u0027"},{"line_number":69,"context_line":"OS_TYPE_ALL \u003d \u0027ALL\u0027"},{"line_number":70,"context_line":"OS_TYPE_LINUX \u003d \u0027LINUX\u0027"},{"line_number":71,"context_line":"OS_TYPE_WINDOWS \u003d \u0027WINDOWS\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"S390X \u003d \"s390x\""},{"line_number":74,"context_line":"S390 \u003d \"s390\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_f5d43020","line":71,"updated":"2016-05-03 16:58:59.000000000","message":"Since in the current code, we are only using OS_TYPE_LINUX.  Can you add a note saying this type is for future connector for Windows?","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":68,"context_line":"PLATFORM_S390 \u003d \u0027S390\u0027"},{"line_number":69,"context_line":"OS_TYPE_ALL \u003d \u0027ALL\u0027"},{"line_number":70,"context_line":"OS_TYPE_LINUX \u003d \u0027LINUX\u0027"},{"line_number":71,"context_line":"OS_TYPE_WINDOWS \u003d \u0027WINDOWS\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"S390X \u003d \"s390x\""},{"line_number":74,"context_line":"S390 \u003d \"s390\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_537097a4","line":71,"in_reply_to":"1a122d0e_f5d43020","updated":"2016-05-03 21:42:24.000000000","message":"Sure, or I can simply remove it.   The windows connector patch actually changes the value.  So, I can just nuke it here and their patch can add it.\n\nhttps://review.openstack.org/232595","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e3dee7c92131d1deb853524a1cda8e12d644b140","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":164,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":167,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_044c2475","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":27},"updated":"2016-05-03 15:55:01.000000000","message":"Should this be OS_TYPE_ANY then based on the comment and since it\u0027s in the generic/base class?","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":164,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":167,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_956cdc37","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":27},"in_reply_to":"1a122d0e_044c2475","updated":"2016-05-03 16:58:59.000000000","message":"+1.\n\nAlso this line looks exactly the same in every derived connector class.  Can we just have it here and not to repeat the exact same line in the derived connector classes?","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"09e5c6b1852a142da20115e052a24847e997f304","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":164,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":167,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6d004f03","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":27},"in_reply_to":"1a122d0e_044c2475","updated":"2016-05-03 21:53:48.000000000","message":"Taking a closer look at the current state of this class, there are other functions that are relying on the self._linuxscsi member existing.  I think a small refactor as a follow up patch is warranted to migrate some of those methods into a InitiatorLinuxConnector class.  This will remove all linux specific calls from the InitiatorConnector class.\n\nEither that, or a follow patch that creates a windowsscsi.py and a factory for building the correct \u003cplatform\u003escsi.py class.","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"09e5c6b1852a142da20115e052a24847e997f304","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            driver \u003d host_driver.HostDriver()"},{"line_number":174,"context_line":"        self.set_driver(driver)"},{"line_number":175,"context_line":"        self.device_scan_attempts \u003d device_scan_attempts"},{"line_number":176,"context_line":"        self._linuxscsi \u003d linuxscsi.LinuxSCSI(root_helper, execute\u003dexecute)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def set_driver(self, driver):"},{"line_number":179,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ed13bf63","line":176,"updated":"2016-05-03 21:53:48.000000000","message":"This is currently specific to the linux platform.","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e3dee7c92131d1deb853524a1cda8e12d644b140","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        multipath \u003d kwargs[\u0027multipath\u0027]"},{"line_number":186,"context_line":"        enforce_multipath \u003d kwargs[\u0027enforce_multipath\u0027]"},{"line_number":187,"context_line":"        props \u003d {}"},{"line_number":188,"context_line":"        # TODO(walter-boring) move this into platform specific lib"},{"line_number":189,"context_line":"        props[\u0027multipath\u0027] \u003d (multipath and"},{"line_number":190,"context_line":"                              linuxscsi.LinuxSCSI.is_multipath_running("},{"line_number":191,"context_line":"                                  enforce_multipath, root_helper))"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_4498dc6a","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":66},"updated":"2016-05-03 15:55:01.000000000","message":"yeah, seems like this doesn\u0027t belong here at all.  Any reason not to just move it in a tied dep or something before we forget?","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"09e5c6b1852a142da20115e052a24847e997f304","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        enabled device if there is one."},{"line_number":329,"context_line":"        \"\"\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        path \u003d self._linuxscsi.find_multipath_device_path(device_wwn)"},{"line_number":332,"context_line":"        device_path \u003d None"},{"line_number":333,"context_line":"        multipath_id \u003d None"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_8d05eb15","line":331,"updated":"2016-05-03 21:53:48.000000000","message":"Also specific to linux here.","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    @staticmethod"},{"line_number":547,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":548,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":549,"context_line":"        props \u003d {}"},{"line_number":550,"context_line":"        iscsi \u003d ISCSIConnector(root_helper\u003droot_helper)"},{"line_number":551,"context_line":"        initiator \u003d iscsi.get_initiator()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ca199324","line":548,"updated":"2016-05-03 16:58:59.000000000","message":"Should this be \"iSCSI\" instead of generic?","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    @staticmethod"},{"line_number":547,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":548,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":549,"context_line":"        props \u003d {}"},{"line_number":550,"context_line":"        iscsi \u003d ISCSIConnector(root_helper\u003droot_helper)"},{"line_number":551,"context_line":"        initiator \u003d iscsi.get_initiator()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_2dcbf74b","line":548,"in_reply_to":"1a122d0e_ca199324","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"    @staticmethod"},{"line_number":1358,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1359,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1360,"context_line":"        props \u003d {}"},{"line_number":1361,"context_line":"        fc \u003d linuxfc.LinuxFibreChannel(root_helper)"},{"line_number":1362,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_8adafbe7","line":1359,"updated":"2016-05-03 16:58:59.000000000","message":"s/generic/FC","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"    @staticmethod"},{"line_number":1358,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1359,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1360,"context_line":"        props \u003d {}"},{"line_number":1361,"context_line":"        fc \u003d linuxfc.LinuxFibreChannel(root_helper)"},{"line_number":1362,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6dd5efe3","line":1359,"in_reply_to":"1a122d0e_8adafbe7","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    @staticmethod"},{"line_number":1682,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1683,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1684,"context_line":"        return {}"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_0a942be6","line":1683,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e AoE","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    @staticmethod"},{"line_number":1682,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1683,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1684,"context_line":"        return {}"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_cd024372","line":1683,"in_reply_to":"1a122d0e_0a942be6","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":1850,"context_line":""},{"line_number":1851,"context_line":"    @staticmethod"},{"line_number":1852,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1853,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1854,"context_line":"        return {}"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    def set_execute(self, execute):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_8a883bc8","line":1853,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e RemoteFs","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":1850,"context_line":""},{"line_number":1851,"context_line":"    @staticmethod"},{"line_number":1852,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1853,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1854,"context_line":"        return {}"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    def set_execute(self, execute):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ad05477a","line":1853,"in_reply_to":"1a122d0e_8a883bc8","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":1924,"context_line":""},{"line_number":1925,"context_line":"    @staticmethod"},{"line_number":1926,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1927,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1928,"context_line":"        return {}"},{"line_number":1929,"context_line":""},{"line_number":1930,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_caa99326","line":1927,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e RBD","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":1924,"context_line":""},{"line_number":1925,"context_line":"    @staticmethod"},{"line_number":1926,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":1927,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":1928,"context_line":"        return {}"},{"line_number":1929,"context_line":""},{"line_number":1930,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_0dfd5b6e","line":1927,"in_reply_to":"1a122d0e_caa99326","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"    @staticmethod"},{"line_number":2019,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2020,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2021,"context_line":"        return {}"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6a715fde","line":2020,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e local","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"    @staticmethod"},{"line_number":2019,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2020,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2021,"context_line":"        return {}"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_edff3f64","line":2020,"in_reply_to":"1a122d0e_6a715fde","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"    @staticmethod"},{"line_number":2084,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2085,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2086,"context_line":"        return {}"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"    def check_valid_device(self, path, run_as_root\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ea4baf84","line":2085,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e DRBD","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"    @staticmethod"},{"line_number":2084,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2085,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2086,"context_line":"        return {}"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"    def check_valid_device(self, path, run_as_root\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_4df7538c","line":2085,"in_reply_to":"1a122d0e_ea4baf84","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2183,"context_line":""},{"line_number":2184,"context_line":"    @staticmethod"},{"line_number":2185,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2186,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2187,"context_line":"        return {}"},{"line_number":2188,"context_line":""},{"line_number":2189,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ea328f0e","line":2186,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e HuaweiStorHyper","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2183,"context_line":""},{"line_number":2184,"context_line":"    @staticmethod"},{"line_number":2185,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2186,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2187,"context_line":"        return {}"},{"line_number":2188,"context_line":""},{"line_number":2189,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_2df2d79b","line":2186,"in_reply_to":"1a122d0e_ea328f0e","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2338,"context_line":""},{"line_number":2339,"context_line":"    @staticmethod"},{"line_number":2340,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2341,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2342,"context_line":"        return {}"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"    def _log_cli_err(self, err):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6a1f9f70","line":2341,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e HGST","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2338,"context_line":""},{"line_number":2339,"context_line":"    @staticmethod"},{"line_number":2340,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2341,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2342,"context_line":"        return {}"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"    def _log_cli_err(self, err):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_8df16b98","line":2341,"in_reply_to":"1a122d0e_6a1f9f70","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2509,"context_line":""},{"line_number":2510,"context_line":"    @staticmethod"},{"line_number":2511,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2512,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2513,"context_line":"        return {}"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6a067f22","line":2512,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e ScaleIO","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2509,"context_line":""},{"line_number":2510,"context_line":"    @staticmethod"},{"line_number":2511,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2512,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2513,"context_line":"        return {}"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_6deccfbb","line":2512,"in_reply_to":"1a122d0e_6a067f22","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":2956,"context_line":""},{"line_number":2957,"context_line":"    @staticmethod"},{"line_number":2958,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2959,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2960,"context_line":"        return {}"},{"line_number":2961,"context_line":""},{"line_number":2962,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_f52710b3","line":2959,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e DISCO","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":2956,"context_line":""},{"line_number":2957,"context_line":"    @staticmethod"},{"line_number":2958,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":2959,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":2960,"context_line":"        return {}"},{"line_number":2961,"context_line":""},{"line_number":2962,"context_line":"    def get_search_path(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_cd29a3f4","line":2959,"in_reply_to":"1a122d0e_f52710b3","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":3108,"context_line":""},{"line_number":3109,"context_line":""},{"line_number":3110,"context_line":"class SheepdogConnector(InitiatorConnector):"},{"line_number":3111,"context_line":"    \"\"\"\"Connector class to attach/detach sheepdog volumes.\"\"\""},{"line_number":3112,"context_line":""},{"line_number":3113,"context_line":"    def __init__(self, root_helper, driver\u003dNone, use_multipath\u003dFalse,"},{"line_number":3114,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_152bac34","line":3111,"updated":"2016-05-03 16:58:59.000000000","message":"Do you need the following here?\n\n    platform \u003d PLATFORM_ALL\n    os_type \u003d OS_TYPE_LINUX","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":3108,"context_line":""},{"line_number":3109,"context_line":""},{"line_number":3110,"context_line":"class SheepdogConnector(InitiatorConnector):"},{"line_number":3111,"context_line":"    \"\"\"\"Connector class to attach/detach sheepdog volumes.\"\"\""},{"line_number":3112,"context_line":""},{"line_number":3113,"context_line":"    def __init__(self, root_helper, driver\u003dNone, use_multipath\u003dFalse,"},{"line_number":3114,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_ed361f50","line":3111,"in_reply_to":"1a122d0e_152bac34","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b9fbfda126dbe0142f958d4620b0f62c4ca462bc","unresolved":false,"context_lines":[{"line_number":3121,"context_line":""},{"line_number":3122,"context_line":"    @staticmethod"},{"line_number":3123,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":3124,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":3125,"context_line":"        return {}"},{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_154c4c75","line":3124,"updated":"2016-05-03 16:58:59.000000000","message":"generic -\u003e Sheepdog","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2cc43704a2e7136af59673439f784e41c660713","unresolved":false,"context_lines":[{"line_number":3121,"context_line":""},{"line_number":3122,"context_line":"    @staticmethod"},{"line_number":3123,"context_line":"    def get_connector_properties(root_helper, *args, **kwargs):"},{"line_number":3124,"context_line":"        \"\"\"The generic connector properties.\"\"\""},{"line_number":3125,"context_line":"        return {}"},{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"    def get_volume_paths(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_4d3e332a","line":3124,"in_reply_to":"1a122d0e_154c4c75","updated":"2016-05-03 21:42:24.000000000","message":"Done","commit_id":"b90842619229b313125602c88adbfb57a145f89d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5879c1b8b0d536a6f2c594a0ce7de1cab36fa652","unresolved":false,"context_lines":[{"line_number":90,"context_line":"VZSTORAGE \u003d \"VZSTORAGE\""},{"line_number":91,"context_line":"SHEEPDOG \u003d \"SHEEPDOG\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"connector_list \u003d ["},{"line_number":94,"context_line":"    \u0027os_brick.initiator.connector.InitiatorConnector\u0027,"},{"line_number":95,"context_line":"    \u0027os_brick.initiator.connector.ISCSIConnector\u0027,"},{"line_number":96,"context_line":"    \u0027os_brick.initiator.connector.FibreChannelConnector\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_4771ec76","line":93,"updated":"2016-05-04 02:09:13.000000000","message":"nit: you could just build this list dynamically from the classes that are of type InitiatorConnector in here.\n\nI guess that wouldn\u0027t work for the following dependent change though that adds the windows connectors.","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3e7b0f9f743de613a6fe6e35fdfd32d6ab3f247f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"VZSTORAGE \u003d \"VZSTORAGE\""},{"line_number":91,"context_line":"SHEEPDOG \u003d \"SHEEPDOG\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"connector_list \u003d ["},{"line_number":94,"context_line":"    \u0027os_brick.initiator.connector.InitiatorConnector\u0027,"},{"line_number":95,"context_line":"    \u0027os_brick.initiator.connector.ISCSIConnector\u0027,"},{"line_number":96,"context_line":"    \u0027os_brick.initiator.connector.FibreChannelConnector\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_27aaf01a","line":93,"in_reply_to":"1a122d0e_4771ec76","updated":"2016-05-04 02:51:58.000000000","message":"I had thought of that, but then the FakeConnector would also be included.  It sucks to have a manual list, I get that.  It can be changed later if we want to clean this up.","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5879c1b8b0d536a6f2c594a0ce7de1cab36fa652","unresolved":false,"context_lines":[{"line_number":157,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    # This object can be used on any platform (x86, S390)"},{"line_number":160,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":163,"context_line":"    os_type \u003d OS_TYPE_LINUX"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_0725345b","line":160,"updated":"2016-05-04 02:09:13.000000000","message":"Since these are required attributes in an ABC, rather than relying on defining them in each class with the attribute, you could add a getter method that is an abstractmethod, like:\n\n  @abstractmethod\n  def get_plaform(self):\n      return PLATFORM_ALL\n\nBut that\u0027s just a suggestion. It will fail either way when you get the connector if you don\u0027t have these defined.","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3e7b0f9f743de613a6fe6e35fdfd32d6ab3f247f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    # This object can be used on any platform (x86, S390)"},{"line_number":160,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":163,"context_line":"    os_type \u003d OS_TYPE_LINUX"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_62b85612","line":160,"in_reply_to":"1a122d0e_0725345b","updated":"2016-05-04 02:51:58.000000000","message":"The only disadvantage is that I would have to instantiate the object to call this, unless I made it static.  If you feel strongly about this I can change it.","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"559cf4e40d9ba044a30f53922b7d979a55ab6938","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    # This object can be used on any platform (x86, S390)"},{"line_number":160,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":163,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":166,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_b3648621","line":163,"range":{"start_line":162,"start_character":4,"end_line":163,"end_character":27},"updated":"2016-05-03 23:07:03.000000000","message":"Should we have the comment say just linux for now and add windows/all in the follow on patches that allow for it?","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3e7b0f9f743de613a6fe6e35fdfd32d6ab3f247f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    # This object can be used on any platform (x86, S390)"},{"line_number":160,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":163,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":166,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_47da8cea","line":163,"range":{"start_line":162,"start_character":4,"end_line":163,"end_character":27},"in_reply_to":"1a122d0e_b3648621","updated":"2016-05-04 02:51:58.000000000","message":"yah I will add that comment.","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5879c1b8b0d536a6f2c594a0ce7de1cab36fa652","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"class ISCSIConnector(InitiatorConnector):"},{"line_number":525,"context_line":"    \"\"\"Connector class to attach/detach iSCSI volumes.\"\"\""},{"line_number":526,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":527,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":528,"context_line":"    supported_transports \u003d [\u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027, \u0027default\u0027,"},{"line_number":529,"context_line":"                            \u0027cxgb4i\u0027, \u0027qla4xxx\u0027, \u0027ocs\u0027, \u0027iser\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_471f2c09","line":526,"updated":"2016-05-04 02:09:13.000000000","message":"Why redefine these if they are in the base class?","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3e7b0f9f743de613a6fe6e35fdfd32d6ab3f247f","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"class ISCSIConnector(InitiatorConnector):"},{"line_number":525,"context_line":"    \"\"\"Connector class to attach/detach iSCSI volumes.\"\"\""},{"line_number":526,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":527,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":528,"context_line":"    supported_transports \u003d [\u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027, \u0027default\u0027,"},{"line_number":529,"context_line":"                            \u0027cxgb4i\u0027, \u0027qla4xxx\u0027, \u0027ocs\u0027, \u0027iser\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a122d0e_c2ce8ab6","line":526,"in_reply_to":"1a122d0e_471f2c09","updated":"2016-05-04 02:51:58.000000000","message":"Done","commit_id":"e54d67206e500d8709f308f4ff7036602ec317af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fe625b98fc0d9d26c8d548e7031568ace9e18c66","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    platform \u003d PLATFORM_ALL"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any os type (linux, windows)"},{"line_number":163,"context_line":"    # TODO(walter-boring) This class stil has a reliance on"},{"line_number":164,"context_line":"    # linuxscsi object, making it specific to linux.  Need to fix that."},{"line_number":165,"context_line":"    os_type \u003d OS_TYPE_LINUX"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a122d0e_f7da4ae8","line":163,"range":{"start_line":163,"start_character":37,"end_line":163,"end_character":41},"updated":"2016-05-04 15:06:50.000000000","message":"still","commit_id":"80703d3e2070c16a745d75d497dedc5ec1b9e714"}]}
