)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"9767cfbb6910fd8bac3225a0da311179aeea9f20","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":151,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":152,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":153,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":154,"context_line":"                 *args, **kwargs):"},{"line_number":155,"context_line":"        super(InitiatorConnector, self).__init__(root_helper, execute\u003dexecute,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_dfa6d2bf","line":152,"updated":"2016-03-19 21:00:57.000000000","message":"I see what you are doing by setting execute to None. It is a bit confusing as you need to look at Executor to understand that an exception isn\u0027t thrown if it is left as None. Is there not a better default to use or do you plan for this to change in a later release?  Same for the other methods that use None as a default for execute.","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"f3a239578bb159d8e60c8fe7238923fc0d34c7b0","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":151,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":152,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":153,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":154,"context_line":"                 *args, **kwargs):"},{"line_number":155,"context_line":"        super(InitiatorConnector, self).__init__(root_helper, execute\u003dexecute,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_416f6192","line":152,"in_reply_to":"1af94dfe_dfa6d2bf","updated":"2016-03-21 06:30:58.000000000","message":"I need a value for \"I don\u0027t care, you should use the default executor\".  In this change, I was using None for that default, I could equally as easily change it to an explicit DEFAULT_EXECUTOR sentinel object if you\u0027d prefer.  The whole \"dependency injection\" thing feels a bit java-ish, since afaics the usual python pattern would be to just monkey-patch the executor during tests and drop the explicit execute\u003d argument entirely.\n\nIn practice, I actually treat putils.execute as \"I want the default\" and _don\u0027t_ use putils.execute as the executor, since I found execute\u003dputils.execute was *everywhere* all over this code and (more importantly) the calling code in nova and cinder.  So the whole point is a bit silly.  I can revert out the execute\u003dNone changes in os-brick and just rely on my execute\u003dputils.execute-means-default hack if you\u0027d prefer - but I feel that\u0027s just deferring a real fix.","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"4aa80f987b940e7785b7a316125b3b556e49e82f","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":151,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":152,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":153,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":154,"context_line":"                 *args, **kwargs):"},{"line_number":155,"context_line":"        super(InitiatorConnector, self).__init__(root_helper, execute\u003dexecute,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_fad1ccfc","line":152,"in_reply_to":"fa0719c6_07f712d4","updated":"2016-03-22 04:40:08.000000000","message":"I _believe_ I have already removed all(*) the places where an explicit execute\u003d was unnecessary.  The remaining cases, like this one, are where `execute` is also used explicitly elsewhere in the function (see line 161 below).\n\n(*) Except I see a new case in SheepdogConnector.__init__ crept in with the last rebase - fixed.\n\n\nLet me know what you\u0027d like me to do in the remaining cases - I figure I can stick with execute\u003dNone, go back to execute\u003dputils.execute, introduce a new execute\u003dDEFAULT_EXECUTOR, or massively rewrite everything :P","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"4fc5f8b5151c4836f2a961694ffce71e3f9b4a00","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":151,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":152,"context_line":"    def __init__(self, root_helper, driver\u003dNone, execute\u003dNone,"},{"line_number":153,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":154,"context_line":"                 *args, **kwargs):"},{"line_number":155,"context_line":"        super(InitiatorConnector, self).__init__(root_helper, execute\u003dexecute,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_07f712d4","line":152,"in_reply_to":"fa0719c6_416f6192","updated":"2016-03-21 18:35:02.000000000","message":"Well monkey-patching could also be considered java-ish as AOP functionally does the same thing. :)\n\nI do like the fact that you are getting rid of \"execute\u003d\" everywhere though. I think you can take it further and get rid of \"execute\u003d\" from the other classes in this file that inherit from InitiatorConnector (i.e. like you did with LocalConnector, RBDConnector, etc...). Explicitly setting execute\u003dNone doesn\u0027t really provide any value and is a bit misleading as it is updated in a super class. Allowing it to be passed as a kwarg seems fine.","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0181b7a1f5c1eedbfff5f02061b514537c0d265b","unresolved":false,"context_lines":[{"line_number":2360,"context_line":"    OK_STATUS_CODE \u003d 200"},{"line_number":2361,"context_line":"    VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":2362,"context_line":"    VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":2363,"context_line":"    GET_GUID_CMD \u003d [\u0027/opt/emc/scaleio/sdc/bin/drv_cfg\u0027, \u0027--query_guid\u0027]"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":2366,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_508b1168","line":2363,"updated":"2016-04-20 02:18:15.000000000","message":"Everyone\u0027s cool with hard coded paths like this?","commit_id":"dbf77fba1061cb4e93b3db5f8117d6ccc689f702"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"012a2a19d6c05dc17587061588cfe87eef307747","unresolved":false,"context_lines":[{"line_number":2360,"context_line":"    OK_STATUS_CODE \u003d 200"},{"line_number":2361,"context_line":"    VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":2362,"context_line":"    VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":2363,"context_line":"    GET_GUID_CMD \u003d [\u0027/opt/emc/scaleio/sdc/bin/drv_cfg\u0027, \u0027--query_guid\u0027]"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":2366,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_847f2baa","line":2363,"in_reply_to":"1a122d0e_508b1168","updated":"2016-04-20 05:09:19.000000000","message":"A good question to raise.  Previously the path was hardcoded in the rootwrap filters (although of course they\u0027re \"ok\" for a deployer to change, unlike the same string here).\n\nWith privsep, we need to either add an oslo.config option for this command and/or assume the deployer has set up $PATH appropriately.  (Every other command assumes the latter fwiw)\n\nI felt this was maybe ok for this particular command, since it looks like the /opt/emc path contains proprietary tools and the vendor might strongly encourage this installation location.  I don\u0027t have any experience with emc however, so this is purely conjecture based on the fact the same path was previously hardcoded in rootwrap filters without comment.","commit_id":"dbf77fba1061cb4e93b3db5f8117d6ccc689f702"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1ec04fbc21111179898e86c7bf1db4897ef3457b","unresolved":false,"context_lines":[{"line_number":2360,"context_line":"    OK_STATUS_CODE \u003d 200"},{"line_number":2361,"context_line":"    VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":2362,"context_line":"    VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":2363,"context_line":"    GET_GUID_CMD \u003d [\u0027/opt/emc/scaleio/sdc/bin/drv_cfg\u0027, \u0027--query_guid\u0027]"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":2366,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_c323b454","line":2363,"in_reply_to":"1a122d0e_847f2baa","updated":"2016-04-20 16:02:42.000000000","message":"This is a documented install location for ScaleIO so it should be okay.  We\u0027ll look into other options raised by the reviewers.  Thanks.","commit_id":"dbf77fba1061cb4e93b3db5f8117d6ccc689f702"}],"os_brick/privileged/rootwrap.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"44adda733291a8a0238ee24cd373c7155d2f5673","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        sanitized_cmd \u003d strutils.mask_password(\u0027 \u0027.join(cmd))"},{"line_number":72,"context_line":"        raise putils.ProcessExecutionError("},{"line_number":73,"context_line":"            cmd\u003dsanitized_cmd, description\u003dstr(e))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# See comment on `execute`"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_a1a4a307","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":49},"updated":"2016-03-18 19:10:55.000000000","message":"Use six.text_type to handle unicode?","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"f3a239578bb159d8e60c8fe7238923fc0d34c7b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        sanitized_cmd \u003d strutils.mask_password(\u0027 \u0027.join(cmd))"},{"line_number":72,"context_line":"        raise putils.ProcessExecutionError("},{"line_number":73,"context_line":"            cmd\u003dsanitized_cmd, description\u003dstr(e))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# See comment on `execute`"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_e15dd5ed","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":49},"in_reply_to":"1af94dfe_a1a4a307","updated":"2016-03-21 06:30:58.000000000","message":"Done","commit_id":"296b48ac29074ed9a357efd7ab68a7657abf6e0a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"fdd87e1498b99283e66a2cee9b174e22b1c09edc","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    try:"},{"line_number":56,"context_line":"        if run_as_root:"},{"line_number":57,"context_line":"            return execute_root(*cmd, **kwargs)"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            return putils.execute(*cmd, **kwargs)"},{"line_number":60,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_19f93581","line":57,"updated":"2016-03-21 20:45:54.000000000","message":"I dumped out the result of execute_root and it\u0027s one big long string, instead of a list, which should contain\n(stdout, stderr) as the result.","commit_id":"9cb98f84308ae5d619c330bc5a08cc6ff7cd04de"}],"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2899c5afa83d81b6b0d6768686269dfed41dc686","unresolved":false,"context_lines":[{"line_number":9,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.serialization\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.i18n\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.privsep\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":13,"context_line":"oslo.service\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.utils\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":15,"context_line":"requests!\u003d2.9.0,\u003e\u003d2.8.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":25,"id":"1a122d0e_cbe54ba9","line":12,"updated":"2016-04-15 15:25:10.000000000","message":"This should be \u003e\u003d1.5.0 given the dependency on the privsep change https://review.openstack.org/#/c/295083/ went into the 1.5.0 release.","commit_id":"227ef000e6064d77cba0d51de9bb698a9c020f83"}]}
