)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0bdf00fab108aab771a2914e88d2e7e4fcdf4312","unresolved":false,"context_lines":[{"line_number":3049,"context_line":"        \"\"\""},{"line_number":3050,"context_line":""},{"line_number":3051,"context_line":"        sheepdog_handle \u003d self._get_sheepdog_handle(connection_properties)"},{"line_number":3052,"context_line":"        return {\u0027path\u0027: sheepdog_handle}"},{"line_number":3053,"context_line":""},{"line_number":3054,"context_line":"    def disconnect_volume(self, connection_properties, device_info):"},{"line_number":3055,"context_line":"        \"\"\"Disconnect a volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_64ff24ab","line":3052,"updated":"2016-02-19 00:06:44.000000000","message":"I think we should add a type here to be explicit.  The rbd connector does something similar in the respect that it returns a python object that is used for IO, instead of an actual filesystem device path that can be used to mount, format and do IO against.   \n\nOr I suppose I can do a follow that adds a new global \u0027type\u0027: \u0027handle\u0027  and update both the RBD and sheepdog connectors.","commit_id":"f3a857c8be20fae2e8b8ae328950f295c7f77ca8"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"46acd4b40f577ff565421f8fb79aee3091fcd1d9","unresolved":false,"context_lines":[{"line_number":3049,"context_line":"        \"\"\""},{"line_number":3050,"context_line":""},{"line_number":3051,"context_line":"        sheepdog_handle \u003d self._get_sheepdog_handle(connection_properties)"},{"line_number":3052,"context_line":"        return {\u0027path\u0027: sheepdog_handle}"},{"line_number":3053,"context_line":""},{"line_number":3054,"context_line":"    def disconnect_volume(self, connection_properties, device_info):"},{"line_number":3055,"context_line":"        \"\"\"Disconnect a volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_b515d89c","line":3052,"in_reply_to":"dae33548_64ff24ab","updated":"2016-02-19 05:02:29.000000000","message":"Hi Walter,\n\nsheepdog_handle is a linuxsheepdog.SheepdogIOWrapper object. Both RBDVolumeIOWrapper and SheepdogIOwraper are derived from io.RawIOBase.\n\nI don\u0027t understand why adds new type for handle? :)","commit_id":"f3a857c8be20fae2e8b8ae328950f295c7f77ca8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5263807ac2e94a93dc733736bf1eb473bb41d8dc","unresolved":false,"context_lines":[{"line_number":3049,"context_line":"        \"\"\""},{"line_number":3050,"context_line":""},{"line_number":3051,"context_line":"        sheepdog_handle \u003d self._get_sheepdog_handle(connection_properties)"},{"line_number":3052,"context_line":"        return {\u0027path\u0027: sheepdog_handle}"},{"line_number":3053,"context_line":""},{"line_number":3054,"context_line":"    def disconnect_volume(self, connection_properties, device_info):"},{"line_number":3055,"context_line":"        \"\"\"Disconnect a volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_fcfc4240","line":3052,"in_reply_to":"dae33548_b515d89c","updated":"2016-02-19 22:07:43.000000000","message":"I will make a follow up patch that adds a new type value for connectors like this.","commit_id":"f3a857c8be20fae2e8b8ae328950f295c7f77ca8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0bdf00fab108aab771a2914e88d2e7e4fcdf4312","unresolved":false,"context_lines":[{"line_number":3061,"context_line":"        :type device_info: dict"},{"line_number":3062,"context_line":"        \"\"\""},{"line_number":3063,"context_line":"        if device_info:"},{"line_number":3064,"context_line":"            sheepdog_handle \u003d device_info.get(\u0027path\u0027, None)"},{"line_number":3065,"context_line":"            if sheepdog_handle is not None:"},{"line_number":3066,"context_line":"                sheepdog_handle.close()"},{"line_number":3067,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_24e35c07","line":3064,"updated":"2016-02-19 00:06:44.000000000","message":"this worries me a bit, because in the normal nova -\u003e cinder detach, the disconnect_volume is called with the connection_properties that comes back from cinder\u0027s initialize_connection.  Obviously the path string isn\u0027t going to be a callable object at that point.\n\nCan we also make sure the sheepdog_handle is an object of the required type?  If not, we log a message and/or fail?","commit_id":"f3a857c8be20fae2e8b8ae328950f295c7f77ca8"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"46acd4b40f577ff565421f8fb79aee3091fcd1d9","unresolved":false,"context_lines":[{"line_number":3061,"context_line":"        :type device_info: dict"},{"line_number":3062,"context_line":"        \"\"\""},{"line_number":3063,"context_line":"        if device_info:"},{"line_number":3064,"context_line":"            sheepdog_handle \u003d device_info.get(\u0027path\u0027, None)"},{"line_number":3065,"context_line":"            if sheepdog_handle is not None:"},{"line_number":3066,"context_line":"                sheepdog_handle.close()"},{"line_number":3067,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_35fee838","line":3064,"in_reply_to":"dae33548_24e35c07","updated":"2016-02-19 05:02:29.000000000","message":"Will do it.","commit_id":"f3a857c8be20fae2e8b8ae328950f295c7f77ca8"}]}
