)]}'
{"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5686999584bacd81e188cf9c5be9414b255e2156","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        return processed"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"},{"line_number":424,"context_line":"        if not isinstance(lun_id, int):"},{"line_number":425,"context_line":"            msg \u003d _(\u0027Invalid input type, lun_id must be int\u0027)"},{"line_number":426,"context_line":"            raise ValueError(msg)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if lun_id \u003c 256:"},{"line_number":429,"context_line":"                return lun_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_0031cda2","line":426,"range":{"start_line":424,"start_character":7,"end_line":426,"end_character":33},"updated":"2016-03-15 19:05:16.000000000","message":"This part needs a test case to cover it.","commit_id":"9168ab88de658d9fcee0537765e65f0246937495"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"2f64cfd6bb93a56f09b53860d17b3dd207fe24e1","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        return processed"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"},{"line_number":424,"context_line":"        if not isinstance(lun_id, int):"},{"line_number":425,"context_line":"            msg \u003d _(\u0027Invalid input type, lun_id must be int\u0027)"},{"line_number":426,"context_line":"            raise ValueError(msg)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if lun_id \u003c 256:"},{"line_number":429,"context_line":"                return lun_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_b7264ab8","line":426,"range":{"start_line":424,"start_character":7,"end_line":426,"end_character":33},"in_reply_to":"1af94dfe_0031cda2","updated":"2016-03-16 05:47:11.000000000","message":"Done","commit_id":"9168ab88de658d9fcee0537765e65f0246937495"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f9aacd416e1a13c6ae83729bd26ebec53a97bff3","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"},{"line_number":424,"context_line":"        if not isinstance(lun_id, int):"},{"line_number":425,"context_line":"            msg \u003d _(\u0027Invalid input type, lun_id must be int\u0027)"},{"line_number":426,"context_line":"            raise ValueError(msg)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if lun_id \u003c 256:"},{"line_number":429,"context_line":"                return lun_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_f261e9a9","line":426,"updated":"2016-03-16 14:03:36.000000000","message":"I don\u0027t think you should do this check and raise a ValueError for a private method.\n\nIt is sufficient to just ensure that it isn\u0027t called incorrectly since this isn\u0027t called externally.","commit_id":"dc9e556a5a2347d1a0ace887a0f6bbdc21cf0e04"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bdf06092688be9e05a5a4a2f330f245257e30914","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                x \u003d self._format_lun_id(int(x))"},{"line_number":418,"context_line":"                processed.append(x)"},{"line_number":419,"context_line":"        else:"},{"line_number":420,"context_line":"            processed \u003d self._format_lun_id(int(lun_ids))"},{"line_number":421,"context_line":"        return processed"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_6feed1ed","line":420,"updated":"2016-03-20 21:34:28.000000000","message":"This is going to result in a TypeError. I think you will need to do something like:\n\n    [int(x) for x in lun_ids]","commit_id":"72c04344b5f3a1cbfaf419471ab9dc124fe54764"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71e7324a0e0be6adbe84591311752748285f36cd","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                x \u003d self._format_lun_id(int(x))"},{"line_number":418,"context_line":"                processed.append(x)"},{"line_number":419,"context_line":"        else:"},{"line_number":420,"context_line":"            processed \u003d self._format_lun_id(int(lun_ids))"},{"line_number":421,"context_line":"        return processed"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_b9a01f92","line":420,"in_reply_to":"fa0719c6_563710b0","updated":"2016-03-21 13:52:54.000000000","message":"Yeah... that\u0027s probably the better answer.","commit_id":"72c04344b5f3a1cbfaf419471ab9dc124fe54764"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2a194f520c65b174792f83762cfced435e039b71","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                x \u003d self._format_lun_id(int(x))"},{"line_number":418,"context_line":"                processed.append(x)"},{"line_number":419,"context_line":"        else:"},{"line_number":420,"context_line":"            processed \u003d self._format_lun_id(int(lun_ids))"},{"line_number":421,"context_line":"        return processed"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _format_lun_id(self, lun_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_563710b0","line":420,"in_reply_to":"fa0719c6_6feed1ed","updated":"2016-03-21 13:32:11.000000000","message":"Honestly this code should be refactored to not try to handle both list and int inputs...","commit_id":"72c04344b5f3a1cbfaf419471ab9dc124fe54764"}],"os_brick/tests/initiator/test_linuxscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bdf06092688be9e05a5a4a2f330f245257e30914","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        result \u003d self.linuxscsi.process_lun_id(lun_id)"},{"line_number":664,"context_line":"        expected \u003d 13"},{"line_number":665,"context_line":"        self.assertEqual(expected, result)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def test_process_lun_id_single_string_var_return(self):"},{"line_number":668,"context_line":"        self.assertRaises(ValueError, self.linuxscsi.process_lun_id, \u0027one\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_cfb9ddee","line":666,"updated":"2016-03-20 21:34:28.000000000","message":"Would be good to add a test passing in a list of lun_ids.","commit_id":"72c04344b5f3a1cbfaf419471ab9dc124fe54764"}]}
