)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d93ae776da337aa7a31f48895f27ae4a755cfa51","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"        # stream, and only grab actual ip / iqn lines."},{"line_number":1071,"context_line":"        targets \u003d []"},{"line_number":1072,"context_line":"        for data in [line.split() for line in output.splitlines()]:"},{"line_number":1073,"context_line":"            if len(data) \u003d\u003d 2 and data[1].startswith(\u0027iqn.\u0027) \\"},{"line_number":1074,"context_line":"               and data[1] \u003d\u003d iqn:"},{"line_number":1075,"context_line":"                targets.append(data)"},{"line_number":1076,"context_line":"        return targets"},{"line_number":1077,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_80300a03","line":1074,"range":{"start_line":1073,"start_character":15,"end_line":1074,"end_character":33},"updated":"2016-04-05 14:49:23.000000000","message":"If you put parentheses around this you can get rid of the \u0027\\\u0027","commit_id":"915f9cfd91c7e60e9c6c2742886b24a974aa8d65"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"2b88ef0b38801523d6c3c431eed1b2c9e0d8e12e","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"        # stream, and only grab actual ip / iqn lines."},{"line_number":1071,"context_line":"        targets \u003d []"},{"line_number":1072,"context_line":"        for data in [line.split() for line in output.splitlines()]:"},{"line_number":1073,"context_line":"            if len(data) \u003d\u003d 2 and data[1].startswith(\u0027iqn.\u0027) \\"},{"line_number":1074,"context_line":"               and data[1] \u003d\u003d iqn:"},{"line_number":1075,"context_line":"                targets.append(data)"},{"line_number":1076,"context_line":"        return targets"},{"line_number":1077,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_896a97b1","line":1074,"range":{"start_line":1073,"start_character":15,"end_line":1074,"end_character":33},"in_reply_to":"9a061dce_80300a03","updated":"2016-04-07 03:23:59.000000000","message":"Thank you for the comments.\nI found out that this modify is unnecessary, so delete it.\nI\u0027m going to commit new one later.","commit_id":"915f9cfd91c7e60e9c6c2742886b24a974aa8d65"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05a5fa22ec5e8d77767409b5c1159ede2f21e250","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                                     if iqn \u003d\u003d main_iqn])"},{"line_number":647,"context_line":"                if len(all_portals) \u003d\u003d len(match_portals):"},{"line_number":648,"context_line":"                    ips_iqns \u003d zip(all_portals, [main_iqn] * len(all_portals))"},{"line_number":649,"context_line":"                if len(match_portals) \u003d\u003d 2:"},{"line_number":650,"context_line":"                    # This type shares the same iqn between multiple portals,"},{"line_number":651,"context_line":"                    # so use the supplied iqn. No need to connect to all of the"},{"line_number":652,"context_line":"                    # targets which discovered."}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_4ee6ef15","line":649,"updated":"2016-07-06 14:01:50.000000000","message":"Maybe I\u0027m just having a hard time at the moment tracing through this code, but what is the significance of 2 for the number of match_portals?","commit_id":"b26ede6b2f160e3c70224e30abf8a73c1bc813b3"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d93ae776da337aa7a31f48895f27ae4a755cfa51","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"%s %s"},{"line_number":1062,"context_line":"\"\"\" % (discovered_targets[0][0], discovered_targets[0][1],"},{"line_number":1063,"context_line":"            discovered_targets[1][0], discovered_targets[1][1])"},{"line_number":1064,"context_line":"        out \u003d self.connector.\\"},{"line_number":1065,"context_line":"            _get_target_portals_from_iscsiadm_output(sample_input,"},{"line_number":1066,"context_line":"                                                     iqn)"},{"line_number":1067,"context_line":"        self.assertEqual(out, targets)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def test_sanitize_log_run_iscsiadm(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_eb23a7a5","line":1066,"range":{"start_line":1064,"start_character":14,"end_line":1066,"end_character":57},"updated":"2016-04-05 14:49:23.000000000","message":"Same comment here. You should be able to get rid of the \u0027\\\u0027 if you use parentheses.","commit_id":"915f9cfd91c7e60e9c6c2742886b24a974aa8d65"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"2b88ef0b38801523d6c3c431eed1b2c9e0d8e12e","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"%s %s"},{"line_number":1062,"context_line":"\"\"\" % (discovered_targets[0][0], discovered_targets[0][1],"},{"line_number":1063,"context_line":"            discovered_targets[1][0], discovered_targets[1][1])"},{"line_number":1064,"context_line":"        out \u003d self.connector.\\"},{"line_number":1065,"context_line":"            _get_target_portals_from_iscsiadm_output(sample_input,"},{"line_number":1066,"context_line":"                                                     iqn)"},{"line_number":1067,"context_line":"        self.assertEqual(out, targets)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def test_sanitize_log_run_iscsiadm(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_69ae23e7","line":1066,"range":{"start_line":1064,"start_character":14,"end_line":1066,"end_character":57},"in_reply_to":"9a061dce_eb23a7a5","updated":"2016-04-07 03:23:59.000000000","message":"I found out that this modify is unnecessary too.\nI\u0027m going to commit new one later.","commit_id":"915f9cfd91c7e60e9c6c2742886b24a974aa8d65"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05a5fa22ec5e8d77767409b5c1159ede2f21e250","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        connection_properties \u003d {\u0027target_iqn\u0027: iqn}"},{"line_number":876,"context_line":"        devs, targets \u003d self.connector._get_potential_volume_paths("},{"line_number":877,"context_line":"            connection_properties, use_rescan\u003dFalse)"},{"line_number":878,"context_line":"        self.assertEqual(connect_to_iscsi_mock.call_count, 2)"},{"line_number":879,"context_line":"        connect_to_iscsi_mock.call_count \u003d 0"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # Test for the type use different iqns on different portals."}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_0eaea797","line":878,"updated":"2016-07-06 14:01:50.000000000","message":"See comment below.","commit_id":"b26ede6b2f160e3c70224e30abf8a73c1bc813b3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05a5fa22ec5e8d77767409b5c1159ede2f21e250","unresolved":false,"context_lines":[{"line_number":889,"context_line":"        connection_properties \u003d {\u0027target_iqn\u0027: iqn}"},{"line_number":890,"context_line":"        devs, targets \u003d self.connector._get_potential_volume_paths("},{"line_number":891,"context_line":"            connection_properties, use_rescan\u003dFalse)"},{"line_number":892,"context_line":"        self.assertEqual(connect_to_iscsi_mock.call_count, 4)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def test_get_target_portals_from_iscsiadm_output(self):"},{"line_number":895,"context_line":"        connector \u003d self.connector"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ae0153b1","line":892,"updated":"2016-07-06 14:01:50.000000000","message":"Please change assertEqual argument order to (expected, actual) to stay consistent.","commit_id":"b26ede6b2f160e3c70224e30abf8a73c1bc813b3"}]}
