)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"1a47d948849c326db8edf65782c598a6d2cf5c67","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Split out factory method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to clear up circular dependencies and clean up the connector.py file."},{"line_number":10,"context_line":"This is the first of many step steps in a larger effort to reduce the"},{"line_number":11,"context_line":"overall complexity of the connector.py file."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_6dea78dc","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":78},"updated":"2016-04-07 19:27:13.000000000","message":"Lines should be wrapped at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Split out factory method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to clear up circular dependencies and clean up the connector.py file."},{"line_number":10,"context_line":"This is the first of many step steps in a larger effort to reduce the"},{"line_number":11,"context_line":"overall complexity of the connector.py file."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a18252c_15c77446","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":78},"in_reply_to":"9a061dce_6dea78dc","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ca8aac01c1649cb9b65577fc1bbbfb877ffd1138","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Split out factory method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to clear up circular dependencies and clean up the connector.py file."},{"line_number":10,"context_line":"This is the first of many step steps in a larger effort to reduce the"},{"line_number":11,"context_line":"overall complexity of the connector.py file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc1384fddd70fd5802135365fd8a5f3729cb4ea4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_65abf175","line":10,"updated":"2016-04-06 21:28:57.000000000","message":"Taking many steps is hard enough for some of us.  Having to\ndo step steps every time is doubly hard.  DuncanT wouldn\u0027t\nhave a problem though.","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Split out factory method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to clear up circular dependencies and clean up the connector.py file."},{"line_number":10,"context_line":"This is the first of many step steps in a larger effort to reduce the"},{"line_number":11,"context_line":"overall complexity of the connector.py file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc1384fddd70fd5802135365fd8a5f3729cb4ea4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a18252c_95e1c4d3","line":10,"in_reply_to":"9a061dce_65abf175","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"c869b176c023979989b10626c068df39de7e0892"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"865412cf2f15d35920b7fbc4676dcefc0ec49d79","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":171,"context_line":"                device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":172,"context_line":"                arch\u003dNone,"},{"line_number":173,"context_line":"                *args, **kwargs):"},{"line_number":174,"context_line":"        \"\"\"Build a Connector object based upon protocol and architecture.\"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # We do this instead of assigning it in the definition"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_5aa44e56","side":"PARENT","line":173,"updated":"2016-04-11 16:24:12.000000000","message":"The problem with removing this entirely, is that it will instantly break Nova and Cinder.  The both rely on this method existing to create the correct connector object.\nWe will need to have a shim in place until we release a new version of os-brick that has the new factory location.  Then we\u0027ll have to put Nova and Cinder patches in place to use the new location.","commit_id":"1d392b1fc9c68eb541896870d16e6f8ecbaf99c5"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":171,"context_line":"                device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":172,"context_line":"                arch\u003dNone,"},{"line_number":173,"context_line":"                *args, **kwargs):"},{"line_number":174,"context_line":"        \"\"\"Build a Connector object based upon protocol and architecture.\"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # We do this instead of assigning it in the definition"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_15093432","side":"PARENT","line":173,"in_reply_to":"7a1b2928_5aa44e56","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"1d392b1fc9c68eb541896870d16e6f8ecbaf99c5"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b3a2b5d6a4636e5e7bcc78ff0e511adab0b3f7d7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        utils.connector_factory("},{"line_number":174,"context_line":"            protocol, root_helper, driver\u003dNone,"},{"line_number":175,"context_line":"            execute \u003d putils.execute, use_multipath\u003dFalse,"},{"line_number":176,"context_line":"            device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":177,"context_line":"            arch\u003dNone, *args, **kwargs)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def check_valid_device(self, path, run_as_root\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_7f62a3ae","line":176,"updated":"2016-04-18 18:15:16.000000000","message":"this should be\ndevice_scan_attempts\u003ddevice_scan_attempts as it\u0027s passed in.\nSame with the other defaults.\n\ndriver\u003ddriver,\nexecute\u003dexecute,\nuse_multipath\u003duse_multipath,\narch\u003darch\n\nYou also might want to do a \u0027return\u0027 here as well :)","commit_id":"8282ae7efb27b69812327eb8206a6107a2b342eb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a1a625355a83ce7e51996f5135bbcdd150e3dc54","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.driver \u003d driver"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @staticmethod"},{"line_number":169,"context_line":"    def factory(protocol, root_helper, driver\u003dNone, execute \u003d putils.execute,"},{"line_number":170,"context_line":"                use_multipath\u003dFalse,"},{"line_number":171,"context_line":"                device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT, arch\u003dNone,"},{"line_number":172,"context_line":"                *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_288bd3c4","line":169,"updated":"2016-04-18 19:56:56.000000000","message":"need to remove the white space around execute \u003d putils.execute","commit_id":"dbbfd27f67ca93886f1d75adad66742de5861d59"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"96650924a34d5040bfdecebf1d3748942f1f4b77","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"from os_brick import exception"},{"line_number":49,"context_line":"from os_brick import executor"},{"line_number":50,"context_line":"from os_brick import utils"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"from os_brick.initiator import host_driver"},{"line_number":53,"context_line":"from os_brick.initiator import linuxfc"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_a4244bc6","line":50,"updated":"2016-05-03 18:00:58.000000000","message":"you need to import the initiator/utils.py as well here.","commit_id":"fe9d69e5c8ef2a57eaf29210b071cdfc94f8ddab"}],"os_brick/initiator/utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"393b2bd7126327a0b1efcf6d76f51240ceccce3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_f7b901cd","line":1,"updated":"2016-04-08 15:49:38.000000000","message":"New files should not have the Foundation copyright unless they are created by someone working for the Foundation.","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_b5496091","line":1,"in_reply_to":"9a061dce_f7b901cd","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"393b2bd7126327a0b1efcf6d76f51240ceccce3a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from connector import AoEConnector"},{"line_number":22,"context_line":"from connector import DISCOConnector"},{"line_number":23,"context_line":"from connector import DRBDConnector"},{"line_number":24,"context_line":"from connector import FibreChannelConnector"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_7778512c","line":21,"updated":"2016-04-08 15:49:38.000000000","message":"Except in rare cases we want to import only modules, not specific classes. I think these should just be:\n\nfrom os_brick.initiator import connector\n\nThen below for each object creation do connector.FibreChannelConnector(), etc.","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from connector import AoEConnector"},{"line_number":22,"context_line":"from connector import DISCOConnector"},{"line_number":23,"context_line":"from connector import DRBDConnector"},{"line_number":24,"context_line":"from connector import FibreChannelConnector"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_b517a053","line":21,"in_reply_to":"9a061dce_7778512c","updated":"2016-04-11 21:34:34.000000000","message":"I can give it a try, but the reason I was importing this way was to try to avoid cyclic dependencies..if that thought process makes sense.","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"393b2bd7126327a0b1efcf6d76f51240ceccce3a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":63,"context_line":"            execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":64,"context_line":"            device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":65,"context_line":"            arch\u003dNone, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_77acd135","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":11},"updated":"2016-04-08 15:49:38.000000000","message":"Instead of calling this \"factory\" how about something more semantically meaning full like get_connector. I think the usage would be more readable and obvious by then being able to do utils.get_connector(\u0027blah\u0027,...)","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":59,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":63,"context_line":"            execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":64,"context_line":"            device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":65,"context_line":"            arch\u003dNone, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_355ef045","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":11},"in_reply_to":"7a1b2928_9a09c634","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"332f0756a22aed7d1a3f6a4c88b5ea185c3e26af","unresolved":false,"context_lines":[{"line_number":59,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":63,"context_line":"            execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":64,"context_line":"            device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":65,"context_line":"            arch\u003dNone, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_155bf455","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":11},"in_reply_to":"9a061dce_77acd135","updated":"2016-04-11 21:34:34.000000000","message":"Done","commit_id":"c869b176c023979989b10626c068df39de7e0892"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"865412cf2f15d35920b7fbc4676dcefc0ec49d79","unresolved":false,"context_lines":[{"line_number":59,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":63,"context_line":"            execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":64,"context_line":"            device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":65,"context_line":"            arch\u003dNone, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_9a09c634","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":11},"in_reply_to":"9a061dce_77acd135","updated":"2016-04-11 16:24:12.000000000","message":"connector_factory, since this is a factory function.","commit_id":"c869b176c023979989b10626c068df39de7e0892"}]}
