)]}'
{"os_brick/initiator/AoEConnector.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f4865c477d4379db07e4c47d05664b44c057fc69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_d4c8c3aa","line":1,"updated":"2016-04-19 18:59:05.000000000","message":"This line is part of the copyright notice and not the license.  Please remove it here and just stick w/ the Apache license text.  (In all of these files.)","commit_id":"91dad9b5dbb8285484494d33aa0483017c0f0a57"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d0a549c79edcc142eb4a23a14548825b09641b04","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class AoEConnector(InitiatorConnector):"},{"line_number":32,"context_line":"    \"\"\"Connector class to attach/detach AoE volumes.\"\"\""},{"line_number":33,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":34,"context_line":"                 execute\u003dputils.execute,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_3e5887fa","line":31,"updated":"2016-06-21 20:40:59.000000000","message":"this should be\nclass AoEConnector(InitiatorConnector.InitiatorConnector):","commit_id":"f7dba75b26e8c2b8c3ce067900c1b965878469c7"}],"os_brick/initiator/__init__.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"511d03a552c40e6c8bed5aed59700cd8f61af472","unresolved":false,"context_lines":[{"line_number":38,"context_line":"S390X \u003d \"s390x\""},{"line_number":39,"context_line":"S390 \u003d \"s390\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":42,"context_line":"ISER \u003d \"ISER\""},{"line_number":43,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":44,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_53e275d6","line":41,"updated":"2016-07-28 12:53:40.000000000","message":"Moving these constants to initiator module looks logically right, but it changes current os_brick.initiator.connector API.\n\nI don\u0027t know who uses this constants except me [1] but I\u0027m voting to keep backward compatibity for the APIs and follow deprecation policy [2]\n\n[1] https://review.openstack.org/#/c/263744/21/brick_cinderclient_ext/volume_actions.py\n[2] https://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html","commit_id":"27d0f0e009e053e60f4874e948e17a259ecd3aed"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"27608543393259b663e61a2774257b116740601a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"S390X \u003d \"s390x\""},{"line_number":39,"context_line":"S390 \u003d \"s390\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":42,"context_line":"ISER \u003d \"ISER\""},{"line_number":43,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":44,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_a4d0edf8","line":41,"in_reply_to":"bacf61ea_53e275d6","updated":"2016-08-02 18:28:33.000000000","message":"So Nova and Cinder don\u0027t use the constants in connector.py currently except the cinder disco volume driver.   \n\nThe problem with keeping them in connector.py is a circular dependency problem, which has to be overcome.   I can\u0027t have any of the individual connector files require importing connector.py, because connector.py imports the individual files.....\n\nSo, the constants have to get moved out of connector.py in order for this refactor to work at all....or we have duplicates in both connector.py and __init__.py  \n\nsadness.....","commit_id":"27d0f0e009e053e60f4874e948e17a259ecd3aed"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a5b64fdd423790a5ee4570820855ad6913b80399","unresolved":false,"context_lines":[{"line_number":38,"context_line":"S390X \u003d \"s390x\""},{"line_number":39,"context_line":"S390 \u003d \"s390\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":42,"context_line":"ISER \u003d \"ISER\""},{"line_number":43,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":44,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_90f4ed87","line":41,"in_reply_to":"bacf61ea_a4d0edf8","updated":"2016-08-03 07:20:44.000000000","message":"Got it, thank for the detailed explanation! I\u0027ll update my code once os-brick with this patch will be released","commit_id":"27d0f0e009e053e60f4874e948e17a259ecd3aed"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b2edcf4d2b80fd01bbeee828696a3a2891ea5ce2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from os_brick.initiator import RBDConnector"},{"line_number":55,"context_line":"from os_brick.initiator import RemoteFsConnector"},{"line_number":56,"context_line":"from os_brick.initiator import ScaleIOConnector"},{"line_number":57,"context_line":"from os_brick.initiator import SheepdogConnector"},{"line_number":58,"context_line":"from os_brick.i18n import _, _LE, _LW"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1e57fa58","line":57,"updated":"2016-04-19 18:25:22.000000000","message":"why are these guys in here?  Shouldn\u0027t this patch be a child of your factory refactor patch?","commit_id":"885c555a41d73bff3d6fb6ff0ef13006dae52fa4"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2fd3bc87cf09a70ca90237f4d833039ad591b273","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":160,"context_line":"class InitiatorConnector(executor.Executor):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # This object can be used on any platform (x86, S390)"},{"line_number":163,"context_line":"    platform \u003d PLATFORM_ALL"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_fd160854","side":"PARENT","line":160,"updated":"2016-06-21 20:15:16.000000000","message":"we still need a backwards compatible InitiatorConnector::factory in this file, so we don\u0027t break existing deployments.","commit_id":"0fbaad573060a56c5f9998b0182bcda8c3e7fe3e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"806138bf769369a0d6fe27a015d1be8d00bfda72","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027os_brick.initiator.HuaweiStorHyperConnector\u0027,"},{"line_number":61,"context_line":"    \u0027os_brick.initiator.HGSTConnector\u0027,"},{"line_number":62,"context_line":"    \u0027os_brick.initiator.ScaleIOConnector\u0027,"},{"line_number":63,"context_line":"    \u0027os_brick.initiator.DISCOConnector\u0027,"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_feb9dfed","line":63,"updated":"2016-06-21 20:43:59.000000000","message":"Because you named the files the same as the class, this list is no longer valid.\n\nshould be\nos_brick.initiator.ISCSIConnector.ISCSIConnector,\nos_brick.initiator.FibreChannelConnector.FibreChannelConnector,\n\netc.\n\nYet another reason to not use camel case filenames.","commit_id":"f7dba75b26e8c2b8c3ce067900c1b965878469c7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b8adcf28003718494870bc2048102c9ab26af2aa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027os_brick.initiator.HuaweiStorHyperConnector\u0027,"},{"line_number":61,"context_line":"    \u0027os_brick.initiator.HGSTConnector\u0027,"},{"line_number":62,"context_line":"    \u0027os_brick.initiator.ScaleIOConnector\u0027,"},{"line_number":63,"context_line":"    \u0027os_brick.initiator.DISCOConnector\u0027,"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_86caf79f","line":63,"in_reply_to":"3aaa91ec_feb9dfed","updated":"2016-06-22 09:36:00.000000000","message":"+1","commit_id":"f7dba75b26e8c2b8c3ce067900c1b965878469c7"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"24f5becc7512b0a5ceccfddfdeb89d7404d279fc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# These constants are being deprecated and moving to the init file."},{"line_number":41,"context_line":"# Please use the constants there instead."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"DEVICE_SCAN_ATTEMPTS_DEFAULT \u003d 3"},{"line_number":44,"context_line":"MULTIPATH_ERROR_REGEX \u003d re.compile(\"\\w{3} \\d+ \\d\\d:\\d\\d:\\d\\d \\|.*$\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_06629916","line":41,"updated":"2016-08-02 21:16:00.000000000","message":"# TODO(kendall) Remove these constants once everyone has \n# migrated to using them in __init__.py  \n# \n# DO NOT USE THESE HERE","commit_id":"c5e3d8affbdd76120fd1b2952a75d7581f26fdaf"}],"os_brick/initiator/connectors/base_iscsi.py":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_brick.initiator import initiator_connector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_376ce19c","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":62},"updated":"2016-07-15 09:02:20.000000000","message":"Not use.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"436ea86ffbc54d88f1c8a6d2203872993aef6778","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_brick.initiator import initiator_connector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_829f4cb3","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":62},"in_reply_to":"1aa78d24_376ce19c","updated":"2016-07-19 17:33:35.000000000","message":"Done","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class BaseISCSIConnector(initiator_connector.InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_170e05e5","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":33},"updated":"2016-07-15 09:02:20.000000000","message":"Not use.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"436ea86ffbc54d88f1c8a6d2203872993aef6778","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class BaseISCSIConnector(initiator_connector.InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_c2a944e1","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"1aa78d24_170e05e5","updated":"2016-07-19 17:33:35.000000000","message":"Done","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            return zip(connection_properties[\u0027target_portals\u0027],"},{"line_number":291,"context_line":"                       connection_properties[\u0027target_iqns\u0027])"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        out \u003d None"},{"line_number":294,"context_line":"        if connection_properties.get(\u0027discovery_auth_method\u0027):"},{"line_number":295,"context_line":"            try:"},{"line_number":296,"context_line":"                self._run_iscsiadm_update_discoverydb(connection_properties)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_949e7361","line":293,"range":{"start_line":293,"start_character":7,"end_line":293,"end_character":18},"updated":"2016-07-15 09:02:20.000000000","message":"Not used and could remove.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            if self.use_multipath:"},{"line_number":404,"context_line":"                self._rescan_iscsi()"},{"line_number":405,"context_line":"            else:"},{"line_number":406,"context_line":"                if (tries):"},{"line_number":407,"context_line":"                    host_devices \u003d self._get_device_path(target_props)"},{"line_number":408,"context_line":"                self._run_iscsiadm(target_props, (\"--rescan\",))"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_f459b7fe","line":406,"range":{"start_line":406,"start_character":19,"end_line":406,"end_character":26},"updated":"2016-07-15 09:02:20.000000000","message":"Remove redundant parentheses.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        # don\u0027t let passwords be shown in log output"},{"line_number":581,"context_line":"        LOG.debug(strutils.mask_password(msg))"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        return (out, err)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    def _iscsiadm_update(self, connection_properties, property_key,"},{"line_number":586,"context_line":"                         property_value, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_54c9ab59","line":583,"range":{"start_line":583,"start_character":15,"end_line":583,"end_character":25},"updated":"2016-07-15 09:02:20.000000000","message":"Remove redundant parentheses.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"436ea86ffbc54d88f1c8a6d2203872993aef6778","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        # don\u0027t let passwords be shown in log output"},{"line_number":581,"context_line":"        LOG.debug(strutils.mask_password(msg))"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        return (out, err)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    def _iscsiadm_update(self, connection_properties, property_key,"},{"line_number":586,"context_line":"                         property_value, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_a23890a1","line":583,"range":{"start_line":583,"start_character":15,"end_line":583,"end_character":25},"in_reply_to":"1aa78d24_54c9ab59","updated":"2016-07-19 17:33:35.000000000","message":"This exists in the current code.   This patch is about splitting out the existing code into separate files so we can maintain it easier.   This kind of fix can be done in a follow up patch.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":740,"context_line":"                           attempts\u003d5,"},{"line_number":741,"context_line":"                           delay_on_retry\u003dTrue)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def _get_iscsi_devices(self):"},{"line_number":744,"context_line":"        try:"},{"line_number":745,"context_line":"            devices \u003d list(os.walk(\u0027/dev/disk/by-path\u0027))[0][-1]"},{"line_number":746,"context_line":"        except IndexError:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_f46ed7fe","line":743,"range":{"start_line":743,"start_character":7,"end_line":743,"end_character":26},"updated":"2016-07-15 09:02:20.000000000","message":"Could move _get_iscsi_devices() to linuxscsi.py","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                iqns.append(entry.split(\"iscsi-\")[1].split(\"-lun\")[0])"},{"line_number":772,"context_line":"        return iqns"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def _get_multipath_device_map(self):"},{"line_number":775,"context_line":"        out \u003d self._run_multipath([\u0027-ll\u0027], check_exit_code\u003d[0, 1])[0]"},{"line_number":776,"context_line":"        mpath_line \u003d [line for line in out.splitlines()"},{"line_number":777,"context_line":"                      if not re.match(initiator.MULTIPATH_ERROR_REGEX, line)]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_14b5637d","line":774,"range":{"start_line":774,"start_character":3,"end_line":774,"end_character":40},"updated":"2016-07-15 09:02:20.000000000","message":"Could move _get_multipath_device_map() to linuxscsi.py?","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                                             check_exit_code\u003d[0, 1, 21, 255])"},{"line_number":797,"context_line":"        LOG.debug(\"iscsi session list stdout\u003d%(out)s stderr\u003d%(err)s\","},{"line_number":798,"context_line":"                  {\u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":799,"context_line":"        return (out, err)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _run_iscsiadm_bare(self, iscsi_command, **kwargs):"},{"line_number":802,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_14344348","line":799,"range":{"start_line":799,"start_character":15,"end_line":799,"end_character":25},"updated":"2016-07-15 09:02:20.000000000","message":"Remove redundant parentheses.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1edca93d096f550694bb44356fc6bd1840ec1e20","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                  \"stdout\u003d%(out)s stderr\u003d%(err)s\","},{"line_number":821,"context_line":"                  {\u0027multipath_command\u0027: multipath_command,"},{"line_number":822,"context_line":"                   \u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":823,"context_line":"        return (out, err)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def _rescan_iscsi(self):"},{"line_number":826,"context_line":"        self._run_iscsiadm_bare((\u0027-m\u0027, \u0027node\u0027, \u0027--rescan\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_b413afb6","line":823,"range":{"start_line":823,"start_character":15,"end_line":823,"end_character":25},"updated":"2016-07-15 09:02:20.000000000","message":"Remove redundant parentheses.","commit_id":"4b2d647a0f5d996c003a0f938adb7453cb750785"}],"os_brick/initiator/utils.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"918c8c28ac85dbd30f8ef896df139102891b2ca3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"S390X \u003d \"s390x\""},{"line_number":38,"context_line":"S390 \u003d \"s390\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":41,"context_line":"ISER \u003d \"ISER\""},{"line_number":42,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":43,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_23b6abdc","line":40,"updated":"2016-05-27 15:18:13.000000000","message":"I think it would be a good idea to have a separate module for those constants. It could save us from some circular imports.","commit_id":"cea75f682c781811e304194903ce23ec8494307d"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"b38837fb65b9a2282e567da1b4e9920325386bcf","unresolved":false,"context_lines":[{"line_number":37,"context_line":"S390X \u003d \"s390x\""},{"line_number":38,"context_line":"S390 \u003d \"s390\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":41,"context_line":"ISER \u003d \"ISER\""},{"line_number":42,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":43,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_b5670de9","line":40,"in_reply_to":"7aa08908_be59c537","updated":"2016-06-17 06:21:10.000000000","message":"Yep, I was thinking about having something like constants.py so that those may be easily used from outside this module.","commit_id":"cea75f682c781811e304194903ce23ec8494307d"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d571822077e4f036bbabf42bf638a4a5b9f8d05b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"S390X \u003d \"s390x\""},{"line_number":38,"context_line":"S390 \u003d \"s390\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"ISCSI \u003d \"ISCSI\""},{"line_number":41,"context_line":"ISER \u003d \"ISER\""},{"line_number":42,"context_line":"FIBRE_CHANNEL \u003d \"FIBRE_CHANNEL\""},{"line_number":43,"context_line":"AOE \u003d \"AOE\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_be59c537","line":40,"in_reply_to":"9abb7d3a_23b6abdc","updated":"2016-06-16 18:36:10.000000000","message":"What do you mean? like moving them to a different file or directory? If you could elaborate that would be wonderful :)","commit_id":"cea75f682c781811e304194903ce23ec8494307d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e58d2844385afc946d90e4e243bdee8e117fab27","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    LOG.debug(\"Factory for %(protocol)s on %(arch)s\","},{"line_number":73,"context_line":"              {\u0027protocol\u0027: protocol, \u0027arch\u0027: arch})"},{"line_number":74,"context_line":"    protocol \u003d protocol.upper()"},{"line_number":75,"context_line":"    if protocol in [ISCSI, ISER]:"},{"line_number":76,"context_line":"        # override transport kwarg for requests not comming"},{"line_number":77,"context_line":"        # from the nova LibvirtISERVolumeDriver"},{"line_number":78,"context_line":"        if protocol \u003d\u003d ISER:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_86fde93d","line":75,"updated":"2016-06-15 14:53:15.000000000","message":"Just an idea how we can implement this fabric: http://paste.openstack.org/show/516041/ - early PoC","commit_id":"cea75f682c781811e304194903ce23ec8494307d"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d571822077e4f036bbabf42bf638a4a5b9f8d05b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    LOG.debug(\"Factory for %(protocol)s on %(arch)s\","},{"line_number":73,"context_line":"              {\u0027protocol\u0027: protocol, \u0027arch\u0027: arch})"},{"line_number":74,"context_line":"    protocol \u003d protocol.upper()"},{"line_number":75,"context_line":"    if protocol in [ISCSI, ISER]:"},{"line_number":76,"context_line":"        # override transport kwarg for requests not comming"},{"line_number":77,"context_line":"        # from the nova LibvirtISERVolumeDriver"},{"line_number":78,"context_line":"        if protocol \u003d\u003d ISER:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_dea49109","line":75,"in_reply_to":"7aa08908_86fde93d","updated":"2016-06-16 18:36:10.000000000","message":"Thanks! Yeah I will get this addressed in my next patchset.","commit_id":"cea75f682c781811e304194903ce23ec8494307d"}]}
