)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                    use_multipath\u003duse_multipath,"},{"line_number":224,"context_line":"                    device_scan_attempts\u003ddevice_scan_attempts,"},{"line_number":225,"context_line":"                    *args, **kwargs)"},{"line_number":226,"context_line":"        elif protocol \u003d\u003d \"FIBRE_CHANNEL_ECKD\":"},{"line_number":227,"context_line":"                return FibreChannelECKDConnector("},{"line_number":228,"context_line":"                    root_helper\u003droot_helper,"},{"line_number":229,"context_line":"                    driver\u003ddriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_491a74c7","line":226,"updated":"2016-06-17 18:01:54.000000000","message":"isn\u0027t this also architecture and/or platform specific ?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                    use_multipath\u003duse_multipath,"},{"line_number":224,"context_line":"                    device_scan_attempts\u003ddevice_scan_attempts,"},{"line_number":225,"context_line":"                    *args, **kwargs)"},{"line_number":226,"context_line":"        elif protocol \u003d\u003d \"FIBRE_CHANNEL_ECKD\":"},{"line_number":227,"context_line":"                return FibreChannelECKDConnector("},{"line_number":228,"context_line":"                    root_helper\u003droot_helper,"},{"line_number":229,"context_line":"                    driver\u003ddriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_84ce8558","line":226,"in_reply_to":"7aa08908_491a74c7","updated":"2016-06-20 11:57:38.000000000","message":"yes.. true. Will change","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"class FibreChannelECKDConnector(FibreChannelConnector):"},{"line_number":1702,"context_line":"    \"\"\"Connector class to attach/detach ECKD volumes on S390X arch.\"\"\""},{"line_number":1703,"context_line":"    platform \u003d PLATFORM_S390"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":1706,"context_line":"                 execute\u003dNone, use_multipath\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2903a843","line":1703,"updated":"2016-06-17 18:01:54.000000000","message":"do you need a get_connector_properties that are specific to ECKD?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"class FibreChannelECKDConnector(FibreChannelConnector):"},{"line_number":1702,"context_line":"    \"\"\"Connector class to attach/detach ECKD volumes on S390X arch.\"\"\""},{"line_number":1703,"context_line":"    platform \u003d PLATFORM_S390"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":1706,"context_line":"                 execute\u003dNone, use_multipath\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_c446cdbe","line":1703,"in_reply_to":"7aa08908_2903a843","updated":"2016-06-20 11:57:38.000000000","message":"as far as I can see no","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                      \"(after %(tries)s rescans)\","},{"line_number":1790,"context_line":"                      {\u0027name\u0027: self.device_name, \u0027tries\u0027: tries})"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        device_path \u003d self.host_device"},{"line_number":1793,"context_line":"        device_name \u003d self.device_name"},{"line_number":1794,"context_line":"        dev_info \u003d {\u0027device\u0027: device_name, \u0027host\u0027: None,"},{"line_number":1795,"context_line":"                    \u0027channel\u0027: None, \u0027id\u0027: None, \u0027lun\u0027: None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_09aeac2d","line":1792,"updated":"2016-06-17 18:01:54.000000000","message":"you don\u0027t support multipath ?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                      \"(after %(tries)s rescans)\","},{"line_number":1790,"context_line":"                      {\u0027name\u0027: self.device_name, \u0027tries\u0027: tries})"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        device_path \u003d self.host_device"},{"line_number":1793,"context_line":"        device_name \u003d self.device_name"},{"line_number":1794,"context_line":"        dev_info \u003d {\u0027device\u0027: device_name, \u0027host\u0027: None,"},{"line_number":1795,"context_line":"                    \u0027channel\u0027: None, \u0027id\u0027: None, \u0027lun\u0027: None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_84516565","line":1792,"in_reply_to":"7aa08908_09aeac2d","updated":"2016-06-20 11:57:38.000000000","message":"multipath is handled / managed below the operating system (in our firmware / I/O subsystem). The operating system only sees a volume. The fact that multiple paths exist to a volume is transparent to the Operating System","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c65488f4c13929c79055a1aa5429cec40c00c3e","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"        device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":1744,"context_line":"        device_path \u003d \"/dev/disk/by-path/ccw-%s\" % device_identifier"},{"line_number":1745,"context_line":""},{"line_number":1746,"context_line":"        LOG.debug(\"connect ECKD volume: cula %s unit_address %s device %s\","},{"line_number":1747,"context_line":"                  cula, unit_address, device_number)"},{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        self._linuxfc.configure_eckd_device(device_number)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_4869c2bd","line":1746,"updated":"2016-07-12 10:32:14.000000000","message":"Please, start log messages with upper-case symbols","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"f74894b4ddd312c8d6f97fda8d1e88b5db70622a","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"        device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":1744,"context_line":"        device_path \u003d \"/dev/disk/by-path/ccw-%s\" % device_identifier"},{"line_number":1745,"context_line":""},{"line_number":1746,"context_line":"        LOG.debug(\"connect ECKD volume: cula %s unit_address %s device %s\","},{"line_number":1747,"context_line":"                  cula, unit_address, device_number)"},{"line_number":1748,"context_line":""},{"line_number":1749,"context_line":"        self._linuxfc.configure_eckd_device(device_number)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_c744f81c","line":1746,"in_reply_to":"1aa78d24_4869c2bd","updated":"2016-07-14 14:55:45.000000000","message":"Done","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"}],"os_brick/initiator/linuxeckd.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :param device: device id\r"},{"line_number":44,"context_line":"        \"\"\"\r"},{"line_number":45,"context_line":"        ## cat /sys/bus/ccw/devices/0.0.5171/online\r"},{"line_number":46,"context_line":"        if os.access(\u0027/sys/bus/ccw/devices/%s/online\u0027 % device, os.R_OK):\r"},{"line_number":47,"context_line":"            (out, _err) \u003d self._execute(\u0027cat\u0027,\r"},{"line_number":48,"context_line":"                                        \u0027/sys/bus/ccw/devices/%s/online\u0027\r"},{"line_number":49,"context_line":"                                        % device,\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_4cfd62b0","line":46,"updated":"2016-06-17 18:01:54.000000000","message":"so, this is going to test the read permissions using the user that is running the app (nova/cinder).  \n\nThe _execute() call will/may run as a different user (root)\n\nSo, this os.access may fail, and yet the cat would work.","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :param device: device id\r"},{"line_number":44,"context_line":"        \"\"\"\r"},{"line_number":45,"context_line":"        ## cat /sys/bus/ccw/devices/0.0.5171/online\r"},{"line_number":46,"context_line":"        if os.access(\u0027/sys/bus/ccw/devices/%s/online\u0027 % device, os.R_OK):\r"},{"line_number":47,"context_line":"            (out, _err) \u003d self._execute(\u0027cat\u0027,\r"},{"line_number":48,"context_line":"                                        \u0027/sys/bus/ccw/devices/%s/online\u0027\r"},{"line_number":49,"context_line":"                                        % device,\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_38b532cd","line":46,"in_reply_to":"7aa08908_4cfd62b0","updated":"2016-06-20 11:57:38.000000000","message":"I changed it to have it just check if the file exists","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        :param device: device id\r"},{"line_number":60,"context_line":"        \"\"\"\r"},{"line_number":61,"context_line":"        ## cat /sys/bus/ccw/devices/0.0.5171/status\r"},{"line_number":62,"context_line":"        if os.access(\u0027/sys/bus/ccw/devices/%s/status\u0027 % device, os.R_OK):\r"},{"line_number":63,"context_line":"            (out, _err) \u003d self._execute(\u0027cat\u0027,\r"},{"line_number":64,"context_line":"                                        \u0027/sys/bus/ccw/devices/%s/status\u0027\r"},{"line_number":65,"context_line":"                                        % device,\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2c21f64d","line":62,"updated":"2016-06-17 18:01:54.000000000","message":"same","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        :param device: device id\r"},{"line_number":60,"context_line":"        \"\"\"\r"},{"line_number":61,"context_line":"        ## cat /sys/bus/ccw/devices/0.0.5171/status\r"},{"line_number":62,"context_line":"        if os.access(\u0027/sys/bus/ccw/devices/%s/status\u0027 % device, os.R_OK):\r"},{"line_number":63,"context_line":"            (out, _err) \u003d self._execute(\u0027cat\u0027,\r"},{"line_number":64,"context_line":"                                        \u0027/sys/bus/ccw/devices/%s/status\u0027\r"},{"line_number":65,"context_line":"                                        % device,\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_d8c4ee41","line":62,"in_reply_to":"7aa08908_2c21f64d","updated":"2016-06-20 11:57:38.000000000","message":"Done","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        else:\r"},{"line_number":85,"context_line":"            return False\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"    def get_name_from_path(self, path):\r"},{"line_number":88,"context_line":"        \"\"\"Translates /dev/disk/by-path/ entry to /dev/dasdX.\"\"\"\r"},{"line_number":89,"context_line":"\r"},{"line_number":90,"context_line":"        name \u003d os.path.realpath(path)\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_ac8fa621","line":87,"updated":"2016-06-17 18:01:54.000000000","message":"Why are you duplicating this?  It already exists in linuxscsi, which your new connector already uses.","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        else:\r"},{"line_number":85,"context_line":"            return False\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"    def get_name_from_path(self, path):\r"},{"line_number":88,"context_line":"        \"\"\"Translates /dev/disk/by-path/ entry to /dev/dasdX.\"\"\"\r"},{"line_number":89,"context_line":"\r"},{"line_number":90,"context_line":"        name \u003d os.path.realpath(path)\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_98d1c6fe","line":87,"in_reply_to":"7aa08908_ac8fa621","updated":"2016-06-20 11:57:38.000000000","message":"ok... will remove","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        else:\r"},{"line_number":94,"context_line":"            return None\r"},{"line_number":95,"context_line":"\r"},{"line_number":96,"context_line":"    def flush_device_io(self, device):\r"},{"line_number":97,"context_line":"        \"\"\"This is used to flush any remaining IO in the buffers.\"\"\"\r"},{"line_number":98,"context_line":"        try:\r"},{"line_number":99,"context_line":"            LOG.debug(\"Flushing IO for ECKD volume %s\", device)\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_ec7ece19","line":96,"updated":"2016-06-17 18:01:54.000000000","message":"Why are you duplicating this?  It already exists in linuxscsi, which your new connector already uses.","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        else:\r"},{"line_number":94,"context_line":"            return None\r"},{"line_number":95,"context_line":"\r"},{"line_number":96,"context_line":"    def flush_device_io(self, device):\r"},{"line_number":97,"context_line":"        \"\"\"This is used to flush any remaining IO in the buffers.\"\"\"\r"},{"line_number":98,"context_line":"        try:\r"},{"line_number":99,"context_line":"            LOG.debug(\"Flushing IO for ECKD volume %s\", device)\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_78ce9a5b","line":96,"in_reply_to":"7aa08908_ec7ece19","updated":"2016-06-20 11:57:38.000000000","message":"ok, will remove it","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"26cabc9424cc4ea9fb5a37d4a30c28ee28507a4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_7f24b3ae","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":62},"updated":"2016-07-22 18:12:59.000000000","message":"Uh.. Might want this to be IBM?","commit_id":"a50c80a1fff1cd7248aad6717204f40d54fb8349"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"867f7c1cdf298340416208a6fb5e4a86db34c0c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_51533f17","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":62},"in_reply_to":"dada55a8_7f24b3ae","updated":"2016-07-26 08:45:43.000000000","message":"Yes :-)","commit_id":"a50c80a1fff1cd7248aad6717204f40d54fb8349"}],"os_brick/initiator/linuxfc.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":229,"context_line":"        eckd_device_command \u003d (\u0027cio_ignore\u0027, \u0027-r\u0027, \u0027%(dev_id)s\u0027"},{"line_number":230,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":231,"context_line":"        LOG.debug(\"issue cio_ignore for s390: %s\", eckd_device_command)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        out, info \u003d None, None"},{"line_number":234,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_6c693e8c","line":231,"updated":"2016-06-17 18:01:54.000000000","message":"Why are you building the command here just to print it out, and then rebuilding it again inside the try block?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":229,"context_line":"        eckd_device_command \u003d (\u0027cio_ignore\u0027, \u0027-r\u0027, \u0027%(dev_id)s\u0027"},{"line_number":230,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":231,"context_line":"        LOG.debug(\"issue cio_ignore for s390: %s\", eckd_device_command)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        out, info \u003d None, None"},{"line_number":234,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_d8f22e9a","line":231,"in_reply_to":"7aa08908_6c693e8c","updated":"2016-06-20 11:57:38.000000000","message":"I changed the trace statement","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-e\u0027, \u0027%(dev_id)s\u0027"},{"line_number":245,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":246,"context_line":"        LOG.debug(\"add ECKD command for s390: %s\", eckd_device_command)"},{"line_number":247,"context_line":"        out, info \u003d None, None"},{"line_number":248,"context_line":"        try:"},{"line_number":249,"context_line":"            out, info \u003d self._execute(\u0027chccwdev\u0027, \u0027-e\u0027, \u0027%(dev_id)s\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2cfa96bd","line":246,"updated":"2016-06-17 18:01:54.000000000","message":"Why are you building the command here just to print it out, and then rebuilding it again inside the try block?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-e\u0027, \u0027%(dev_id)s\u0027"},{"line_number":245,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":246,"context_line":"        LOG.debug(\"add ECKD command for s390: %s\", eckd_device_command)"},{"line_number":247,"context_line":"        out, info \u003d None, None"},{"line_number":248,"context_line":"        try:"},{"line_number":249,"context_line":"            out, info \u003d self._execute(\u0027chccwdev\u0027, \u0027-e\u0027, \u0027%(dev_id)s\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_f82f2af4","line":246,"in_reply_to":"7aa08908_2cfa96bd","updated":"2016-06-20 11:57:38.000000000","message":"same here","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        LOG.debug(\"Deconfigure ECKD volume: device_number\u003d%(device_num)s \","},{"line_number":262,"context_line":"                  {\u0027device_num\u0027: device_number})"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"#        eckd_device_command \u003d (\"chccwdev -d %s\" % (device_number))"},{"line_number":265,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":266,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-d\u0027, \u0027%(dev_id)s\u0027"},{"line_number":267,"context_line":"                               % {\"dev_id\": full_device_identifier})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_89361c01","line":264,"updated":"2016-06-17 18:01:54.000000000","message":"remove commented out lines","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        LOG.debug(\"Deconfigure ECKD volume: device_number\u003d%(device_num)s \","},{"line_number":262,"context_line":"                  {\u0027device_num\u0027: device_number})"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"#        eckd_device_command \u003d (\"chccwdev -d %s\" % (device_number))"},{"line_number":265,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":266,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-d\u0027, \u0027%(dev_id)s\u0027"},{"line_number":267,"context_line":"                               % {\"dev_id\": full_device_identifier})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_58359e44","line":264,"in_reply_to":"7aa08908_89361c01","updated":"2016-06-20 11:57:38.000000000","message":"Done","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ea22da8de1b1874956cce4918411e7f8d9f85133","unresolved":false,"context_lines":[{"line_number":264,"context_line":"#        eckd_device_command \u003d (\"chccwdev -d %s\" % (device_number))"},{"line_number":265,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":266,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-d\u0027, \u0027%(dev_id)s\u0027"},{"line_number":267,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":268,"context_line":"        LOG.debug(\"remove ECKD command for s390: %s\", eckd_device_command)"},{"line_number":269,"context_line":"        out, info \u003d None, None"},{"line_number":270,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2c4c5641","line":267,"updated":"2016-06-17 18:01:54.000000000","message":"why are you building this here just to print it out, then to build it again inside the try block?","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"345951b364e41fe1813ac537fb2b956895b1cb72","unresolved":false,"context_lines":[{"line_number":264,"context_line":"#        eckd_device_command \u003d (\"chccwdev -d %s\" % (device_number))"},{"line_number":265,"context_line":"        full_device_identifier \u003d \"0.0.%04x\" % device_number"},{"line_number":266,"context_line":"        eckd_device_command \u003d (\u0027chccwdev\u0027, \u0027-d\u0027, \u0027%(dev_id)s\u0027"},{"line_number":267,"context_line":"                               % {\"dev_id\": full_device_identifier})"},{"line_number":268,"context_line":"        LOG.debug(\"remove ECKD command for s390: %s\", eckd_device_command)"},{"line_number":269,"context_line":"        out, info \u003d None, None"},{"line_number":270,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_783cda2f","line":267,"in_reply_to":"7aa08908_2c4c5641","updated":"2016-06-20 11:57:38.000000000","message":"same here. I changed the trace","commit_id":"a6b1d5eec5a3d227d50c5931e35d459c0354bbca"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c65488f4c13929c79055a1aa5429cec40c00c3e","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"        super(FibreChannelECKDConnectorTestCase, self).setUp()"},{"line_number":1637,"context_line":"        self.connector \u003d connector.FibreChannelECKDConnector("},{"line_number":1638,"context_line":"            None, execute\u003dself.fake_execute, use_multipath\u003dFalse)"},{"line_number":1639,"context_line":"        self.assertIsNotNone(self.connector)"},{"line_number":1640,"context_line":"        self.assertIsNotNone(self.connector._linuxfc)"},{"line_number":1641,"context_line":"        self.assertEqual(self.connector._linuxfc.__class__.__name__,"},{"line_number":1642,"context_line":"                         \"LinuxFibreChannelECKD\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_28c27685","line":1639,"updated":"2016-07-12 10:32:14.000000000","message":"Please, remove asserts from the setUp method","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"f74894b4ddd312c8d6f97fda8d1e88b5db70622a","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"        super(FibreChannelECKDConnectorTestCase, self).setUp()"},{"line_number":1637,"context_line":"        self.connector \u003d connector.FibreChannelECKDConnector("},{"line_number":1638,"context_line":"            None, execute\u003dself.fake_execute, use_multipath\u003dFalse)"},{"line_number":1639,"context_line":"        self.assertIsNotNone(self.connector)"},{"line_number":1640,"context_line":"        self.assertIsNotNone(self.connector._linuxfc)"},{"line_number":1641,"context_line":"        self.assertEqual(self.connector._linuxfc.__class__.__name__,"},{"line_number":1642,"context_line":"                         \"LinuxFibreChannelECKD\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_473008e9","line":1639,"in_reply_to":"1aa78d24_28c27685","updated":"2016-07-14 14:55:45.000000000","message":"Done","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c65488f4c13929c79055a1aa5429cec40c00c3e","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"                             \u0027chccwdev -d 0.0.a173\u0027]"},{"line_number":1684,"context_line":"        self.assertEqual(expected_commands, self.cmds)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"#    @mock.patch.object(connector.FibreChannelConnectorS390X,"},{"line_number":1687,"context_line":"#                       \u0027_get_possible_devices\u0027, return_value\u003d[(3, 5), ])"},{"line_number":1688,"context_line":"#    @mock.patch.object(linuxfc.LinuxFibreChannelS390X, \u0027get_fc_hbas_info\u0027,"},{"line_number":1689,"context_line":"#                       return_value\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_c83772ae","line":1686,"updated":"2016-07-12 10:32:14.000000000","message":"Please, remove commented code","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"f74894b4ddd312c8d6f97fda8d1e88b5db70622a","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"                             \u0027chccwdev -d 0.0.a173\u0027]"},{"line_number":1684,"context_line":"        self.assertEqual(expected_commands, self.cmds)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"#    @mock.patch.object(connector.FibreChannelConnectorS390X,"},{"line_number":1687,"context_line":"#                       \u0027_get_possible_devices\u0027, return_value\u003d[(3, 5), ])"},{"line_number":1688,"context_line":"#    @mock.patch.object(linuxfc.LinuxFibreChannelS390X, \u0027get_fc_hbas_info\u0027,"},{"line_number":1689,"context_line":"#                       return_value\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_8750300c","line":1686,"in_reply_to":"1aa78d24_c83772ae","updated":"2016-07-14 14:55:45.000000000","message":"Done","commit_id":"c6a1f8f7921467d0f9246a50e367ea1249679c24"}],"os_brick/tests/initiator/test_linuxeckd.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"26cabc9424cc4ea9fb5a37d4a30c28ee28507a4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_7ff793f5","line":1,"updated":"2016-07-22 18:12:59.000000000","message":"Same comment here. Think this should be IBM?","commit_id":"a50c80a1fff1cd7248aad6717204f40d54fb8349"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"867f7c1cdf298340416208a6fb5e4a86db34c0c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_517a1f89","line":1,"in_reply_to":"dada55a8_7ff793f5","updated":"2016-07-26 08:45:43.000000000","message":"Yes :-)","commit_id":"a50c80a1fff1cd7248aad6717204f40d54fb8349"}]}