)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"7b263a8683cc1b12e4195f2381eb8759d7ee036e","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_04c318ee","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"updated":"2016-06-08 08:48:02.000000000","message":"The device_name is already /dev/sdX device, so I think it needn\u0027t to add the code.https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L1474","commit_id":"ae8a378c02a224a325dc3179257c86c3ac055498"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8189fa344cce1d9af43b1ebfc5062f31c5ef31ac","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_040cb8eb","line":497,"range":{"start_line":497,"start_character":11,"end_line":497,"end_character":59},"updated":"2016-06-08 08:40:48.000000000","message":"better to use: self._linuxscsi.get_name_from_path()","commit_id":"ae8a378c02a224a325dc3179257c86c3ac055498"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"2aa505b23bb039171da58ac20ce5b3b16be2f7fe","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_49ebb078","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_04c318ee","updated":"2016-06-12 10:07:33.000000000","message":"Seems you were referring to connect_volume in FibreChannelConnector, whereas I was trying to fix the iscsi multipath issue.\n\nI will update my commite message to avoid this kind of confusion.","commit_id":"ae8a378c02a224a325dc3179257c86c3ac055498"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"1c4ab66e990ca0b40927de51f0db12d67cfb67e9","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d8de456c","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"updated":"2016-06-13 00:50:11.000000000","message":"The connect_volume also calls _discover_mpath_device, so I think that should be changed in the disconnect_volume.","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e5ba7906ed03cfb051978d172fcc44b5faac364e","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_7f02740d","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_231b581e","updated":"2016-06-18 03:44:35.000000000","message":"That needs to change every function which calls _discover_mpath_device.\n\nMaking change in _discover_mpath_device can avoid similar mis-use of _discover_mpath_device in the future.\n\nThanks\nPeter","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"9936b424876daaad3e226222fd34908e3a292429","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_231b581e","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_45d31704","updated":"2016-06-15 09:35:04.000000000","message":"Hi, Peter,\nI know what you\u0027re trying to do and I think fix it in disconnect_volume would be better.","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"91a9002627245e23881de6340923d1da3514751f","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_45d31704","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_92a8a721","updated":"2016-06-15 02:54:46.000000000","message":"I changed the _discover_mpath_device for ISCSIConnector, so this fix also benefit disconnect_volume.\n\nThanks\nPeter","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"d691d25baf2c26507c9785a73cb0e43363bdbcb8","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_92a8a721","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_b23b239b","updated":"2016-06-15 02:07:29.000000000","message":"Yes, \nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L996\n\ndevice_wwn \u003d self._linuxscsi.get_scsi_wwn(dev)\ndevice_name \u003d self._linuxscsi.get_name_from_path(dev)\n(multipath_device, multipath_id) \u003d (super(\n    ISCSIConnector, self)._discover_mpath_device(\n        device_wwn, connection_properties, device_name))","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"205995e5e50273dcbed972fdff526c39e637e286","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if path is None:"},{"line_number":496,"context_line":"            # find_multipath_device only accept realpath not symbolic path"},{"line_number":497,"context_line":"            device_realpath \u003d os.path.realpath(device_name)"},{"line_number":498,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":499,"context_line":"                device_realpath)"},{"line_number":500,"context_line":"            if mpath_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_b23b239b","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":59},"in_reply_to":"7aa08908_d8de456c","updated":"2016-06-15 01:47:52.000000000","message":"Hi Yuyafei\nDo you mean i should also fix this in disconnect_volume?","commit_id":"1bc0db6be87ff027d6ee577af1b0e09bd9d0b5af"}]}