)]}'
{"os_brick/encryptors/cryptsetup.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0179891bd8fba9f8712911716d8823c77fe73d16","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # a unique name for the volume -- e.g., the iSCSI participant name"},{"line_number":60,"context_line":"        self.dev_name \u003d \u0027crypt-%s\u0027 % self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # NOTE(lixiaoy1): This is to import fix for 1439869 from Nova."},{"line_number":63,"context_line":"        # NOTE(tsekiyama): In older version of nova, dev_name was the same"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0d3e8dc0","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":69},"updated":"2016-07-07 01:24:43.000000000","message":"os.path.basename rather than split?","commit_id":"07f5f521defb3a1125dbc908078a66add6c5ea0a"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"27d39970b892620ffb86e26adfb00396a2c70013","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # a unique name for the volume -- e.g., the iSCSI participant name"},{"line_number":60,"context_line":"        self.dev_name \u003d \u0027crypt-%s\u0027 % self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # NOTE(lixiaoy1): This is to import fix for 1439869 from Nova."},{"line_number":63,"context_line":"        # NOTE(tsekiyama): In older version of nova, dev_name was the same"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c65c5f7f","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":69},"in_reply_to":"1aa78d24_0d3e8dc0","updated":"2016-07-07 06:59:05.000000000","message":"This is just to get the last file name in the symlink_path. Which is used to generate new decrypted device /dev/mapper/[self.dev_name]","commit_id":"07f5f521defb3a1125dbc908078a66add6c5ea0a"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"be458becef42652b18dced3183c28c80e2757abc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # a unique name for the volume -- e.g., the iSCSI participant name"},{"line_number":60,"context_line":"        self.dev_name \u003d \u0027crypt-%s\u0027 % self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # NOTE(lixiaoy1): This is to import fix for 1439869 from Nova."},{"line_number":63,"context_line":"        # NOTE(tsekiyama): In older version of nova, dev_name was the same"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e1e7c5a9","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":69},"in_reply_to":"1aa78d24_c65c5f7f","updated":"2016-07-07 07:19:20.000000000","message":"Oh, misunderstood. Updated.","commit_id":"07f5f521defb3a1125dbc908078a66add6c5ea0a"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0179891bd8fba9f8712911716d8823c77fe73d16","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # as the symlink name. Now it has \u0027crypt-\u0027 prefix to avoid conflict"},{"line_number":65,"context_line":"        # with multipath device symlink. To enable rolling update, we use the"},{"line_number":66,"context_line":"        # old name when the encrypted volume already exists."},{"line_number":67,"context_line":"        old_dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":68,"context_line":"        wwn \u003d data.get(\u0027multipath_id\u0027)"},{"line_number":69,"context_line":"        if self._is_crypt_device_available(old_dev_name):"},{"line_number":70,"context_line":"            self.dev_name \u003d old_dev_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_cd1f6559","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":55},"updated":"2016-07-07 01:24:43.000000000","message":"os.path.basename rather than a split?","commit_id":"07f5f521defb3a1125dbc908078a66add6c5ea0a"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"27d39970b892620ffb86e26adfb00396a2c70013","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # as the symlink name. Now it has \u0027crypt-\u0027 prefix to avoid conflict"},{"line_number":65,"context_line":"        # with multipath device symlink. To enable rolling update, we use the"},{"line_number":66,"context_line":"        # old name when the encrypted volume already exists."},{"line_number":67,"context_line":"        old_dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":68,"context_line":"        wwn \u003d data.get(\u0027multipath_id\u0027)"},{"line_number":69,"context_line":"        if self._is_crypt_device_available(old_dev_name):"},{"line_number":70,"context_line":"            self.dev_name \u003d old_dev_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e6d07bcb","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":55},"in_reply_to":"1aa78d24_cd1f6559","updated":"2016-07-07 06:59:05.000000000","message":"Please see above.","commit_id":"07f5f521defb3a1125dbc908078a66add6c5ea0a"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"f97c989307893d757c6a33aa19a3ce3e0223bf67","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # a unique name for the volume -- e.g., the iSCSI participant name"},{"line_number":60,"context_line":"        self.dev_name \u003d \u0027crypt-%s\u0027 % os.path.basename(self.symlink_path)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # NOTE(lixiaoy1): This is to import fix for 1439869 from Nova."},{"line_number":63,"context_line":"        # NOTE(tsekiyama): In older version of nova, dev_name was the same"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c7756fcb","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":13},"updated":"2016-07-07 11:04:08.000000000","message":"This could be moved to after line 68 so that it can be\n\n     self.dev_name \u003d \u0027crypt-%s\u0027 % old_dev_name\n\ninstead of repeating basename, as commented by Jay in the original patch.","commit_id":"9d2bb5e15de92c72cc50bac2ee5d0b3b2704ed1e"}]}
